neobytes-project/neobytes
neobytes-project/neobytes
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity
ebc2591e4b
neobytes/src/rpcmasternode-budget.cpp

635 lines
26 KiB
C++
Raw Normal View History

Stable budget implementation - All budgeting code seems to be rather stable now. Serialization/caching is working rather well. - Fixed some ambiguous variable names within the budgeting system that were causing the file caching to not work all of the time
2015-05-27 18:28:55 +02:00
// Copyright (c) 2014-2015 The Dash Developers
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
// Distributed under the MIT/X11 software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include "main.h"
#include "db.h"
#include "init.h"
#include "activemasternode.h"
#include "masternodeman.h"
#include "masternode-payments.h"
#include "masternode-budget.h"
#include "masternodeconfig.h"
#include "rpcserver.h"
#include "utilmoneystr.h"
#include <fstream>
using namespace json_spirit;
using namespace std;
Value mnbudget(const Array& params, bool fHelp)
{
string strCommand;
if (params.size() >= 1)
strCommand = params[0].get_str();
if (fHelp ||
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
(strCommand != "vote-many" && strCommand != "prepare" && strCommand != "submit" && strCommand != "vote" && strCommand != "getvotes" && strCommand != "getinfo" && strCommand != "show" && strCommand != "projection" && strCommand != "check"))
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
throw runtime_error(
"mnbudget \"command\"... ( \"passphrase\" )\n"
"Vote or show current budgets\n"
"\nAvailable commands:\n"
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
" prepare - Prepare proposal for network by signing and creating tx\n"
" submit - Submit proposal for network\n"
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
" vote-many - Vote on a Dash initiative\n"
" vote-alias - Vote on a Dash initiative\n"
" vote - Vote on a Dash initiative/budget\n"
" getvotes - Show current masternode budgets\n"
" getinfo - Show current masternode budgets\n"
" show - Show all budgets\n"
Added mnbudget projection and changed "show" - Show now shows every proposal that is known, which seems to be the general expected behavior of the users - Added "projection" for showing what will end up in the budget if it was finalized currently
2015-07-03 19:54:10 +02:00
" projection - Show the projection of which proposals will be paid the next cycle\n"
Clear expired proposals / added mnbudget check
2015-07-06 22:23:09 +02:00
" check - Scan proposals and remove invalid\n"
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
);
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
if(strCommand == "prepare")
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
{
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
int nBlockMin = 0;
CBlockIndex* pindexPrev = chainActive.Tip();
draft
2015-05-04 11:31:31 +02:00
std::vector<CMasternodeConfig::CMasternodeEntry> mnEntries;
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
mnEntries = masternodeConfig.getEntries();
removed vote from prepare/submit and fixed some help strings
2015-07-12 17:09:06 +02:00
if (params.size() != 7 && params.size() != 8)
Change variable naming for rpc commands - Added MonthlyPayment and TotalPayment
2015-07-18 17:46:44 +02:00
throw runtime_error("Correct usage is 'mnbudget prepare proposal-name url payment_count block_start dash_address monthly_payment_dash [use_ix(true|false)]'");
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
std::string strProposalName = params[1].get_str();
if(strProposalName.size() > 20)
return "Invalid proposal name, limit of 20 characters.";
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
std::string strURL = params[2].get_str();
if(strURL.size() > 64)
return "Invalid url, limit of 64 characters.";
int nPaymentCount = params[3].get_int();
if(nPaymentCount < 1)
return "Invalid payment count, must be more than zero.";
//set block min
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
if(pindexPrev != NULL) nBlockMin = pindexPrev->nHeight - GetBudgetPaymentCycleBlocks() * (nPaymentCount + 1);
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
int nBlockStart = params[4].get_int();
Budget stability fixes - Proposals must start on a budget block now - Finalized budgets now enforce proposal start and end periods - Other misc fixes
2015-06-16 19:04:35 +02:00
if(nBlockStart % GetBudgetPaymentCycleBlocks() != 0){
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
int nNext = pindexPrev->nHeight - pindexPrev->nHeight % GetBudgetPaymentCycleBlocks() + GetBudgetPaymentCycleBlocks();
return strprintf("Invalid block start - must be a budget cycle block. Next valid block: %d", nNext);
Budget stability fixes - Proposals must start on a budget block now - Finalized budgets now enforce proposal start and end periods - Other misc fixes
2015-06-16 19:04:35 +02:00
}
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
int nBlockEnd = nBlockStart + GetBudgetPaymentCycleBlocks() * nPaymentCount;
Budget stability fixes - Proposals must start on a budget block now - Finalized budgets now enforce proposal start and end periods - Other misc fixes
2015-06-16 19:04:35 +02:00
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
if(nBlockStart < nBlockMin)
small fixes for rpc
2015-07-23 04:11:39 +02:00
return "Invalid block start, must be more than current height.";
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
Budget stability fixes - Proposals must start on a budget block now - Finalized budgets now enforce proposal start and end periods - Other misc fixes
2015-06-16 19:04:35 +02:00
if(nBlockEnd < pindexPrev->nHeight)
return "Invalid ending block, starting block + (payment_cycle*payments) must be more than current height.";
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
CBitcoinAddress address(params[5].get_str());
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
if (!address.IsValid())
throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Invalid Dash address");
draft
2015-05-04 11:31:31 +02:00
// Parse Dash address
CScript scriptPubKey = GetScriptForDestination(address.Get());
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
CAmount nAmount = AmountFromValue(params[6]);
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
//*************************************************************************
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
Fixed proposal nTime calculation and usage
2015-07-28 17:55:11 +02:00
// create transaction 15 minutes into the future, to allow for confirmation time
Proposal nTime based on fee transaction block
2015-07-30 03:26:21 +02:00
CBudgetProposalBroadcast budgetProposalBroadcast(strProposalName, strURL, nPaymentCount, scriptPubKey, nAmount, nBlockStart, 0);
Check IsValid when preparing fee
2015-07-14 16:05:33 +02:00
std::string strError = "";
Fixed prepare -- shouldn't check collateral
2015-07-16 00:56:40 +02:00
if(!budgetProposalBroadcast.IsValid(strError, false))
Check IsValid when preparing fee
2015-07-14 16:05:33 +02:00
return "Proposal is not valid - " + budgetProposalBroadcast.GetHash().ToString() + " - " + strError;
Few fixes for mnbudget rpc - do not ask for vote on prepare and submit - fix bug found by @thelazier - fix command descriptions to avoid confusions - tiny refactoring for tx/ix
2015-07-12 08:09:51 +02:00
bool useIX = true;
small fixes for rpc
2015-07-23 04:11:39 +02:00
if (params.size() > 7) {
if(params[7].get_str() != "false" && params[7].get_str() != "true")
return "Invalid use_ix, must be true or false";
useIX = params[7].get_str() == "true" ? true : false;
}
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
CWalletTx wtx;
fixed issues with rpc commands
2015-07-12 16:45:58 +02:00
pwalletMain->GetBudgetSystemCollateralTX(wtx, budgetProposalBroadcast.GetHash(), useIX);
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
// make our change address
CReserveKey reservekey(pwalletMain);
//send the tx to the network
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
pwalletMain->CommitTransaction(wtx, reservekey, useIX ? "ix" : "tx");
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
Proposal nTime based on fee transaction block
2015-07-30 03:26:21 +02:00
return wtx.GetHash().ToString();
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
}
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
if(strCommand == "submit")
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
{
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
int nBlockMin = 0;
CBlockIndex* pindexPrev = chainActive.Tip();
draft
2015-05-04 11:31:31 +02:00
std::vector<CMasternodeConfig::CMasternodeEntry> mnEntries;
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
mnEntries = masternodeConfig.getEntries();
Proposal nTime based on fee transaction block
2015-07-30 03:26:21 +02:00
if (params.size() != 8)
throw runtime_error("Correct usage is 'mnbudget submit proposal-name url payment_count block_start dash_address monthly_payment_dash fee_tx'");
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
// Check these inputs the same way we check the vote commands:
// **********************************************************
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
std::string strProposalName = params[1].get_str();
if(strProposalName.size() > 20)
return "Invalid proposal name, limit of 20 characters.";
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
std::string strURL = params[2].get_str();
if(strURL.size() > 64)
return "Invalid url, limit of 64 characters.";
int nPaymentCount = params[3].get_int();
if(nPaymentCount < 1)
return "Invalid payment count, must be more than zero.";
//set block min
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
if(pindexPrev != NULL) nBlockMin = pindexPrev->nHeight - GetBudgetPaymentCycleBlocks() * (nPaymentCount + 1);
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
int nBlockStart = params[4].get_int();
Budget stability fixes - Proposals must start on a budget block now - Finalized budgets now enforce proposal start and end periods - Other misc fixes
2015-06-16 19:04:35 +02:00
if(nBlockStart % GetBudgetPaymentCycleBlocks() != 0){
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
int nNext = pindexPrev->nHeight - pindexPrev->nHeight % GetBudgetPaymentCycleBlocks() + GetBudgetPaymentCycleBlocks();
return strprintf("Invalid block start - must be a budget cycle block. Next valid block: %d", nNext);
Budget stability fixes - Proposals must start on a budget block now - Finalized budgets now enforce proposal start and end periods - Other misc fixes
2015-06-16 19:04:35 +02:00
}
int nBlockEnd = nBlockStart + (GetBudgetPaymentCycleBlocks()*nPaymentCount);
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
if(nBlockStart < nBlockMin)
return "Invalid payment count, must be more than current height.";
Budget stability fixes - Proposals must start on a budget block now - Finalized budgets now enforce proposal start and end periods - Other misc fixes
2015-06-16 19:04:35 +02:00
if(nBlockEnd < pindexPrev->nHeight)
return "Invalid ending block, starting block + (payment_cycle*payments) must be more than current height.";
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
CBitcoinAddress address(params[5].get_str());
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
if (!address.IsValid())
throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Invalid Dash address");
draft
2015-05-04 11:31:31 +02:00
// Parse Dash address
CScript scriptPubKey = GetScriptForDestination(address.Get());
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
CAmount nAmount = AmountFromValue(params[6]);
removed vote from prepare/submit and fixed some help strings
2015-07-12 17:09:06 +02:00
uint256 hash = ParseHashV(params[7], "parameter 1");
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
//create the proposal incase we're the first to make it
Proposal nTime based on fee transaction block
2015-07-30 03:26:21 +02:00
CBudgetProposalBroadcast budgetProposalBroadcast(strProposalName, strURL, nPaymentCount, scriptPubKey, nAmount, nBlockStart, hash);
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
std::string strError = "";
Proposal nTime based on fee transaction block
2015-07-30 03:26:21 +02:00
if(!IsBudgetCollateralValid(hash, budgetProposalBroadcast.GetHash(), strError, budgetProposalBroadcast.nTime)){
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
return "Proposal FeeTX is not valid - " + hash.ToString() + " - " + strError;
}
if(!budgetProposalBroadcast.IsValid(strError)){
return "Proposal is not valid - " + budgetProposalBroadcast.GetHash().ToString() + " - " + strError;
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
}
Fixed budget syncing issues / forking issues / syncing issues - Budgets now store the seen objects locally so they're not overwritten when saving/loading to check validity of budget.dat - Added safer sync "failure" mode, that will retry an hour later if the sync fails for some reason. This will stop the client from thinking it has budget data and rejecting blocks when they're valid. - protocol bump - version bump
2015-07-25 18:29:29 +02:00
budget.mapSeenMasternodeBudgetProposals.insert(make_pair(budgetProposalBroadcast.GetHash(), budgetProposalBroadcast));
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
budgetProposalBroadcast.Relay();
Various fixes - Proposal submitting now works properly - Syncing proposals now works properly - Finalized budgets are now created correctly
2015-07-12 19:34:21 +02:00
budget.AddProposal(budgetProposalBroadcast);
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
return budgetProposalBroadcast.GetHash().ToString();
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
}
if(strCommand == "vote-many")
{
std::vector<CMasternodeConfig::CMasternodeEntry> mnEntries;
mnEntries = masternodeConfig.getEntries();
if (params.size() != 3)
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
throw runtime_error("Correct usage is 'mnbudget vote-many proposal-hash yes|no'");
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
uint256 hash = ParseHashV(params[1], "parameter 1");
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
std::string strVote = params[2].get_str();
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
if(strVote != "yes" && strVote != "no") return "You can only vote 'yes' or 'no'";
int nVote = VOTE_ABSTAIN;
if(strVote == "yes") nVote = VOTE_YES;
if(strVote == "no") nVote = VOTE_NO;
int success = 0;
int failed = 0;
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
Object resultsObj;
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
BOOST_FOREACH(CMasternodeConfig::CMasternodeEntry mne, masternodeConfig.getEntries()) {
std::string errorMessage;
std::vector<unsigned char> vchMasterNodeSignature;
std::string strMasterNodeSignMessage;
CPubKey pubKeyCollateralAddress;
CKey keyCollateralAddress;
CPubKey pubKeyMasternode;
CKey keyMasternode;
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
Object statusObj;
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
if(!darkSendSigner.SetKey(mne.getPrivKey(), errorMessage, keyMasternode, pubKeyMasternode)){
failed++;
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
statusObj.push_back(Pair("result", "failed"));
statusObj.push_back(Pair("errorMessage", "Masternode signing error, could not set key correctly: " + errorMessage));
resultsObj.push_back(Pair(mne.getAlias(), statusObj));
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
continue;
}
CMasternode* pmn = mnodeman.Find(pubKeyMasternode);
if(pmn == NULL)
{
failed++;
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
statusObj.push_back(Pair("result", "failed"));
statusObj.push_back(Pair("errorMessage", "Can't find masternode by pubkey"));
resultsObj.push_back(Pair(mne.getAlias(), statusObj));
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
continue;
}
CBudgetVote vote(pmn->vin, hash, nVote);
if(!vote.Sign(keyMasternode, pubKeyMasternode)){
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
failed++;
statusObj.push_back(Pair("result", "failed"));
statusObj.push_back(Pair("errorMessage", "Failure to sign."));
resultsObj.push_back(Pair(mne.getAlias(), statusObj));
continue;
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
}
Changed vote restrition model - Masternodes can only vote once per hour now, instead of 100 times a day total - UI reports back errors now
2015-07-26 16:01:49 +02:00
std::string strError = "";
if(budget.UpdateProposal(vote, NULL, strError)) {
budget.mapSeenMasternodeBudgetVotes.insert(make_pair(vote.GetHash(), vote));
vote.Relay();
success++;
statusObj.push_back(Pair("result", "success"));
} else {
failed++;
statusObj.push_back(Pair("result", strError.c_str()));
}
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
resultsObj.push_back(Pair(mne.getAlias(), statusObj));
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
}
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
Object returnObj;
returnObj.push_back(Pair("overall", strprintf("Voted successfully %d time(s) and failed %d time(s).", success, failed)));
returnObj.push_back(Pair("detail", resultsObj));
return returnObj;
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
}
if(strCommand == "vote")
{
std::vector<CMasternodeConfig::CMasternodeEntry> mnEntries;
mnEntries = masternodeConfig.getEntries();
if (params.size() != 3)
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
throw runtime_error("Correct usage is 'mnbudget vote proposal-hash yes|no'");
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
uint256 hash = ParseHashV(params[1], "parameter 1");
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
std::string strVote = params[2].get_str();
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
if(strVote != "yes" && strVote != "no") return "You can only vote 'yes' or 'no'";
int nVote = VOTE_ABSTAIN;
if(strVote == "yes") nVote = VOTE_YES;
if(strVote == "no") nVote = VOTE_NO;
CPubKey pubKeyMasternode;
CKey keyMasternode;
std::string errorMessage;
if(!darkSendSigner.SetKey(strMasterNodePrivKey, errorMessage, keyMasternode, pubKeyMasternode))
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
return "Error upon calling SetKey";
Proposal Security Overhaul Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network. To implement these changes we've introduced a few new commands: mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)] - To create the special transaction mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX - After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here mnbudget show - Get the proposal hash from here mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN - You can now simply vote by hash using this command
2015-07-10 00:08:26 +02:00
CBudgetVote vote(activeMasternode.vin, hash, nVote);
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
if(!vote.Sign(keyMasternode, pubKeyMasternode)){
return "Failure to sign.";
}
Changed vote restrition model - Masternodes can only vote once per hour now, instead of 100 times a day total - UI reports back errors now
2015-07-26 16:01:49 +02:00
std::string strError = "";
if(budget.UpdateProposal(vote, NULL, strError)){
budget.mapSeenMasternodeBudgetVotes.insert(make_pair(vote.GetHash(), vote));
vote.Relay();
return "Voted successfully";
} else {
return "Error voting : " + strError;
}
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
}
Added mnbudget projection and changed "show" - Show now shows every proposal that is known, which seems to be the general expected behavior of the users - Added "projection" for showing what will end up in the budget if it was finalized currently
2015-07-03 19:54:10 +02:00
if(strCommand == "projection")
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
{
Object resultObj;
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
CAmount nTotalAllotted = 0;
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
std::vector<CBudgetProposal*> winningProps = budget.GetBudget();
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
BOOST_FOREACH(CBudgetProposal* pbudgetProposal, winningProps)
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
{
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
nTotalAllotted += pbudgetProposal->GetAllotted();
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
fixed most of the budget functions
2015-04-30 19:11:34 +02:00
CTxDestination address1;
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
ExtractDestination(pbudgetProposal->GetPayee(), address1);
fixed most of the budget functions
2015-04-30 19:11:34 +02:00
CBitcoinAddress address2(address1);
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
Object bObj;
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
bObj.push_back(Pair("URL", pbudgetProposal->GetURL()));
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
bObj.push_back(Pair("Hash", pbudgetProposal->GetHash().ToString()));
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
bObj.push_back(Pair("BlockStart", (int64_t)pbudgetProposal->GetBlockStart()));
bObj.push_back(Pair("BlockEnd", (int64_t)pbudgetProposal->GetBlockEnd()));
bObj.push_back(Pair("TotalPaymentCount", (int64_t)pbudgetProposal->GetTotalPaymentCount()));
bObj.push_back(Pair("RemainingPaymentCount", (int64_t)pbudgetProposal->GetRemainingPaymentCount()));
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
bObj.push_back(Pair("PaymentAddress", address2.ToString()));
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
bObj.push_back(Pair("Ratio", pbudgetProposal->GetRatio()));
bObj.push_back(Pair("Yeas", (int64_t)pbudgetProposal->GetYeas()));
bObj.push_back(Pair("Nays", (int64_t)pbudgetProposal->GetNays()));
bObj.push_back(Pair("Abstains", (int64_t)pbudgetProposal->GetAbstains()));
Change variable naming for rpc commands - Added MonthlyPayment and TotalPayment
2015-07-18 17:46:44 +02:00
bObj.push_back(Pair("TotalPayment", ValueFromAmount(pbudgetProposal->GetAmount()*pbudgetProposal->GetTotalPaymentCount())));
bObj.push_back(Pair("MonthlyPayment", ValueFromAmount(pbudgetProposal->GetAmount())));
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
bObj.push_back(Pair("Alloted", ValueFromAmount(pbudgetProposal->GetAllotted())));
bObj.push_back(Pair("TotalBudgetAlloted", ValueFromAmount(nTotalAllotted)));
Vastly improved proposal management implementation -Syncing now happens in stages. Masternodes and Sporks, then Masternode winners, then proposals. Some of these require the masternode signatures, otherwise there are race conditions within the syncing process itself. -Resigning - When a proposal is sent to the network initially it's signed by a masternode, if that masternode goes inactive the proposal becomes invalid. Resigning allows other masternodes to update proposal keep it valid with the coming and going of masternodes. -Resigning compatibility - non masternodes will scan and flag proposals as invalid to accept updated owners. -Invalid votes are now actively removed from the proposals when they go inactive - Remove budgets with negative votes of more than 10% of network - Only allow proposals into budget that have more than 10% of network support - Faster removal of inactive masternodes
2015-07-04 16:49:49 +02:00
std::string strError = "";
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
bObj.push_back(Pair("IsValid", pbudgetProposal->IsValid(strError)));
Fixed proposal nTime calculation and usage
2015-07-28 17:55:11 +02:00
bObj.push_back(Pair("IsValidReason", strError.c_str()));
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
bObj.push_back(Pair("fValid", pbudgetProposal->fValid));
Vastly improved proposal management implementation -Syncing now happens in stages. Masternodes and Sporks, then Masternode winners, then proposals. Some of these require the masternode signatures, otherwise there are race conditions within the syncing process itself. -Resigning - When a proposal is sent to the network initially it's signed by a masternode, if that masternode goes inactive the proposal becomes invalid. Resigning allows other masternodes to update proposal keep it valid with the coming and going of masternodes. -Resigning compatibility - non masternodes will scan and flag proposals as invalid to accept updated owners. -Invalid votes are now actively removed from the proposals when they go inactive - Remove budgets with negative votes of more than 10% of network - Only allow proposals into budget that have more than 10% of network support - Faster removal of inactive masternodes
2015-07-04 16:49:49 +02:00
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
resultObj.push_back(Pair(pbudgetProposal->GetName(), bObj));
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
}
return resultObj;
}
Added mnbudget projection and changed "show" - Show now shows every proposal that is known, which seems to be the general expected behavior of the users - Added "projection" for showing what will end up in the budget if it was finalized currently
2015-07-03 19:54:10 +02:00
if(strCommand == "show")
{
Refactored CleanAndRemove Proposals
2015-07-15 00:52:07 +02:00
std::string strShow = "valid";
if (params.size() == 2)
std::string strProposalName = params[1].get_str();
Added mnbudget projection and changed "show" - Show now shows every proposal that is known, which seems to be the general expected behavior of the users - Added "projection" for showing what will end up in the budget if it was finalized currently
2015-07-03 19:54:10 +02:00
Object resultObj;
int64_t nTotalAllotted = 0;
std::vector<CBudgetProposal*> winningProps = budget.GetAllProposals();
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
BOOST_FOREACH(CBudgetProposal* pbudgetProposal, winningProps)
Added mnbudget projection and changed "show" - Show now shows every proposal that is known, which seems to be the general expected behavior of the users - Added "projection" for showing what will end up in the budget if it was finalized currently
2015-07-03 19:54:10 +02:00
{
Refactored CleanAndRemove Proposals
2015-07-15 00:52:07 +02:00
if(strShow == "valid" && !pbudgetProposal->fValid) continue;
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
nTotalAllotted += pbudgetProposal->GetAllotted();
Added mnbudget projection and changed "show" - Show now shows every proposal that is known, which seems to be the general expected behavior of the users - Added "projection" for showing what will end up in the budget if it was finalized currently
2015-07-03 19:54:10 +02:00
CTxDestination address1;
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
ExtractDestination(pbudgetProposal->GetPayee(), address1);
Added mnbudget projection and changed "show" - Show now shows every proposal that is known, which seems to be the general expected behavior of the users - Added "projection" for showing what will end up in the budget if it was finalized currently
2015-07-03 19:54:10 +02:00
CBitcoinAddress address2(address1);
Object bObj;
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
bObj.push_back(Pair("URL", pbudgetProposal->GetURL()));
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
bObj.push_back(Pair("Hash", pbudgetProposal->GetHash().ToString()));
bObj.push_back(Pair("FeeHash", pbudgetProposal->nFeeTXHash.ToString()));
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
bObj.push_back(Pair("BlockStart", (int64_t)pbudgetProposal->GetBlockStart()));
bObj.push_back(Pair("BlockEnd", (int64_t)pbudgetProposal->GetBlockEnd()));
bObj.push_back(Pair("TotalPaymentCount", (int64_t)pbudgetProposal->GetTotalPaymentCount()));
bObj.push_back(Pair("RemainingPaymentCount", (int64_t)pbudgetProposal->GetRemainingPaymentCount()));
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
bObj.push_back(Pair("PaymentAddress", address2.ToString()));
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
bObj.push_back(Pair("Ratio", pbudgetProposal->GetRatio()));
bObj.push_back(Pair("Yeas", (int64_t)pbudgetProposal->GetYeas()));
bObj.push_back(Pair("Nays", (int64_t)pbudgetProposal->GetNays()));
bObj.push_back(Pair("Abstains", (int64_t)pbudgetProposal->GetAbstains()));
Change variable naming for rpc commands - Added MonthlyPayment and TotalPayment
2015-07-18 17:46:44 +02:00
bObj.push_back(Pair("TotalPayment", ValueFromAmount(pbudgetProposal->GetAmount()*pbudgetProposal->GetTotalPaymentCount())));
bObj.push_back(Pair("MonthlyPayment", ValueFromAmount(pbudgetProposal->GetAmount())));
Vastly improved proposal management implementation -Syncing now happens in stages. Masternodes and Sporks, then Masternode winners, then proposals. Some of these require the masternode signatures, otherwise there are race conditions within the syncing process itself. -Resigning - When a proposal is sent to the network initially it's signed by a masternode, if that masternode goes inactive the proposal becomes invalid. Resigning allows other masternodes to update proposal keep it valid with the coming and going of masternodes. -Resigning compatibility - non masternodes will scan and flag proposals as invalid to accept updated owners. -Invalid votes are now actively removed from the proposals when they go inactive - Remove budgets with negative votes of more than 10% of network - Only allow proposals into budget that have more than 10% of network support - Faster removal of inactive masternodes
2015-07-04 16:49:49 +02:00
Fixed proposal nTime calculation and usage
2015-07-28 17:55:11 +02:00
bObj.push_back(Pair("IsEstablished", pbudgetProposal->IsEstablished()));
Vastly improved proposal management implementation -Syncing now happens in stages. Masternodes and Sporks, then Masternode winners, then proposals. Some of these require the masternode signatures, otherwise there are race conditions within the syncing process itself. -Resigning - When a proposal is sent to the network initially it's signed by a masternode, if that masternode goes inactive the proposal becomes invalid. Resigning allows other masternodes to update proposal keep it valid with the coming and going of masternodes. -Resigning compatibility - non masternodes will scan and flag proposals as invalid to accept updated owners. -Invalid votes are now actively removed from the proposals when they go inactive - Remove budgets with negative votes of more than 10% of network - Only allow proposals into budget that have more than 10% of network support - Faster removal of inactive masternodes
2015-07-04 16:49:49 +02:00
std::string strError = "";
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
bObj.push_back(Pair("IsValid", pbudgetProposal->IsValid(strError)));
Fixed proposal nTime calculation and usage
2015-07-28 17:55:11 +02:00
bObj.push_back(Pair("IsValidReason", strError.c_str()));
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
bObj.push_back(Pair("fValid", pbudgetProposal->fValid));
Vastly improved proposal management implementation -Syncing now happens in stages. Masternodes and Sporks, then Masternode winners, then proposals. Some of these require the masternode signatures, otherwise there are race conditions within the syncing process itself. -Resigning - When a proposal is sent to the network initially it's signed by a masternode, if that masternode goes inactive the proposal becomes invalid. Resigning allows other masternodes to update proposal keep it valid with the coming and going of masternodes. -Resigning compatibility - non masternodes will scan and flag proposals as invalid to accept updated owners. -Invalid votes are now actively removed from the proposals when they go inactive - Remove budgets with negative votes of more than 10% of network - Only allow proposals into budget that have more than 10% of network support - Faster removal of inactive masternodes
2015-07-04 16:49:49 +02:00
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
resultObj.push_back(Pair(pbudgetProposal->GetName(), bObj));
Added mnbudget projection and changed "show" - Show now shows every proposal that is known, which seems to be the general expected behavior of the users - Added "projection" for showing what will end up in the budget if it was finalized currently
2015-07-03 19:54:10 +02:00
}
return resultObj;
}
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
if(strCommand == "getinfo")
{
if (params.size() != 2)
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
throw runtime_error("Correct usage is 'mnbudget getinfo profilename'");
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
std::string strProposalName = params[1].get_str();
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
CBudgetProposal* pbudgetProposal = budget.FindProposal(strProposalName);
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
if(pbudgetProposal == NULL) return "Unknown proposal name";
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
fixed most of the budget functions
2015-04-30 19:11:34 +02:00
CTxDestination address1;
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
ExtractDestination(pbudgetProposal->GetPayee(), address1);
fixed most of the budget functions
2015-04-30 19:11:34 +02:00
CBitcoinAddress address2(address1);
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
Object obj;
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
obj.push_back(Pair("Name", pbudgetProposal->GetName()));
obj.push_back(Pair("Hash", pbudgetProposal->GetHash().ToString()));
obj.push_back(Pair("FeeHash", pbudgetProposal->nFeeTXHash.ToString()));
obj.push_back(Pair("URL", pbudgetProposal->GetURL()));
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
obj.push_back(Pair("BlockStart", (int64_t)pbudgetProposal->GetBlockStart()));
obj.push_back(Pair("BlockEnd", (int64_t)pbudgetProposal->GetBlockEnd()));
obj.push_back(Pair("TotalPaymentCount", (int64_t)pbudgetProposal->GetTotalPaymentCount()));
obj.push_back(Pair("RemainingPaymentCount", (int64_t)pbudgetProposal->GetRemainingPaymentCount()));
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
obj.push_back(Pair("PaymentAddress", address2.ToString()));
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
obj.push_back(Pair("Ratio", pbudgetProposal->GetRatio()));
obj.push_back(Pair("Yeas", (int64_t)pbudgetProposal->GetYeas()));
obj.push_back(Pair("Nays", (int64_t)pbudgetProposal->GetNays()));
obj.push_back(Pair("Abstains", (int64_t)pbudgetProposal->GetAbstains()));
Change variable naming for rpc commands - Added MonthlyPayment and TotalPayment
2015-07-18 17:46:44 +02:00
obj.push_back(Pair("TotalPayment", ValueFromAmount(pbudgetProposal->GetAmount()*pbudgetProposal->GetTotalPaymentCount())));
obj.push_back(Pair("MonthlyPayment", ValueFromAmount(pbudgetProposal->GetAmount())));
Fixed proposal nTime calculation and usage
2015-07-28 17:55:11 +02:00
obj.push_back(Pair("IsEstablished", pbudgetProposal->IsEstablished()));
fixed getinfo for 0-vote proposals
2015-07-07 00:06:09 +02:00
std::string strError = "";
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
obj.push_back(Pair("IsValid", pbudgetProposal->IsValid(strError)));
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
obj.push_back(Pair("fValid", pbudgetProposal->fValid));
fixed getinfo for 0-vote proposals
2015-07-07 00:06:09 +02:00
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
return obj;
}
if(strCommand == "getvotes")
{
if (params.size() != 2)
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
throw runtime_error("Correct usage is 'mnbudget getinfo profilename'");
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
std::string strProposalName = params[1].get_str();
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
Object obj;
Clear expired proposals / added mnbudget check
2015-07-06 22:23:09 +02:00
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
CBudgetProposal* pbudgetProposal = budget.FindProposal(strProposalName);
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
if(pbudgetProposal == NULL) return "Unknown proposal name";
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
std::map<uint256, CBudgetVote>::iterator it = pbudgetProposal->mapVotes.begin();
while(it != pbudgetProposal->mapVotes.end()){
Added more information to getvotes
2015-07-17 16:38:35 +02:00
Object bObj;
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
bObj.push_back(Pair("Vote", (*it).second.GetVoteString()));
Added more information to getvotes
2015-07-17 16:38:35 +02:00
bObj.push_back(Pair("nTime", (int64_t)(*it).second.nTime));
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
bObj.push_back(Pair("fValid", (*it).second.fValid));
Added more information to getvotes
2015-07-17 16:38:35 +02:00
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
obj.push_back(Pair((*it).second.vin.prevout.ToStringShort(), bObj));
Added more information to getvotes
2015-07-17 16:38:35 +02:00
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
it++;
}
Clear expired proposals / added mnbudget check
2015-07-06 22:23:09 +02:00
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
return obj;
}
Clear expired proposals / added mnbudget check
2015-07-06 22:23:09 +02:00
if(strCommand == "check")
{
budget.CheckAndRemove();
return "Success";
}
Reference Node / Stubbed Out Budget System - Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block. - Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-22 16:33:44 +02:00
return Value::null;
}
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
Value mnfinalbudget(const Array& params, bool fHelp)
{
string strCommand;
if (params.size() >= 1)
strCommand = params[0].get_str();
if (fHelp ||
(strCommand != "suggest" && strCommand != "vote-many" && strCommand != "vote" && strCommand != "show"))
throw runtime_error(
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
"mnfinalbudget \"command\"... ( \"passphrase\" )\n"
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
"Vote or show current budgets\n"
"\nAvailable commands:\n"
" vote-many - Vote on a finalized budget\n"
" vote - Vote on a finalized budget\n"
" show - Show existing finalized budgets\n"
);
if(strCommand == "vote-many")
{
std::vector<CMasternodeConfig::CMasternodeEntry> mnEntries;
mnEntries = masternodeConfig.getEntries();
if (params.size() != 2)
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
throw runtime_error("Correct usage is 'mnfinalbudget vote-many BUDGET_HASH'");
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
std::string strHash = params[1].get_str();
uint256 hash(strHash);
int success = 0;
int failed = 0;
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
Object resultsObj;
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
BOOST_FOREACH(CMasternodeConfig::CMasternodeEntry mne, masternodeConfig.getEntries()) {
std::string errorMessage;
std::vector<unsigned char> vchMasterNodeSignature;
std::string strMasterNodeSignMessage;
CPubKey pubKeyCollateralAddress;
CKey keyCollateralAddress;
CPubKey pubKeyMasternode;
CKey keyMasternode;
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
Object statusObj;
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
if(!darkSendSigner.SetKey(mne.getPrivKey(), errorMessage, keyMasternode, pubKeyMasternode)){
failed++;
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
statusObj.push_back(Pair("result", "failed"));
statusObj.push_back(Pair("errorMessage", "Masternode signing error, could not set key correctly: " + errorMessage));
resultsObj.push_back(Pair(mne.getAlias(), statusObj));
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
continue;
}
CMasternode* pmn = mnodeman.Find(pubKeyMasternode);
if(pmn == NULL)
{
failed++;
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
statusObj.push_back(Pair("result", "failed"));
statusObj.push_back(Pair("errorMessage", "Can't find masternode by pubkey"));
resultsObj.push_back(Pair(mne.getAlias(), statusObj));
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
continue;
Clear expired proposals / added mnbudget check
2015-07-06 22:23:09 +02:00
}
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
CFinalizedBudgetVote vote(pmn->vin, hash);
if(!vote.Sign(keyMasternode, pubKeyMasternode)){
failed++;
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
statusObj.push_back(Pair("result", "failed"));
statusObj.push_back(Pair("errorMessage", "Failure to sign."));
resultsObj.push_back(Pair(mne.getAlias(), statusObj));
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
continue;
}
Changed vote restrition model - Masternodes can only vote once per hour now, instead of 100 times a day total - UI reports back errors now
2015-07-26 16:01:49 +02:00
std::string strError = "";
if(budget.UpdateFinalizedBudget(vote, NULL, strError)){
budget.mapSeenFinalizedBudgetVotes.insert(make_pair(vote.GetHash(), vote));
vote.Relay();
success++;
statusObj.push_back(Pair("result", "success"));
} else {
failed++;
statusObj.push_back(Pair("result", strError.c_str()));
}
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
resultsObj.push_back(Pair(mne.getAlias(), statusObj));
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
}
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
Object returnObj;
returnObj.push_back(Pair("overall", strprintf("Voted successfully %d time(s) and failed %d time(s).", success, failed)));
returnObj.push_back(Pair("detail", resultsObj));
return returnObj;
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
}
if(strCommand == "vote")
{
std::vector<CMasternodeConfig::CMasternodeEntry> mnEntries;
mnEntries = masternodeConfig.getEntries();
if (params.size() != 2)
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
throw runtime_error("Correct usage is 'mnfinalbudget vote BUDGET_HASH'");
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
std::string strHash = params[1].get_str();
uint256 hash(strHash);
CPubKey pubKeyMasternode;
CKey keyMasternode;
std::string errorMessage;
if(!darkSendSigner.SetKey(strMasterNodePrivKey, errorMessage, keyMasternode, pubKeyMasternode))
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
return "Error upon calling SetKey";
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
CFinalizedBudgetVote vote(activeMasternode.vin, hash);
if(!vote.Sign(keyMasternode, pubKeyMasternode)){
return "Failure to sign.";
}
Changed vote restrition model - Masternodes can only vote once per hour now, instead of 100 times a day total - UI reports back errors now
2015-07-26 16:01:49 +02:00
std::string strError = "";
if(budget.UpdateFinalizedBudget(vote, NULL, strError)){
budget.mapSeenFinalizedBudgetVotes.insert(make_pair(vote.GetHash(), vote));
vote.Relay();
return "success";
} else {
return "Error voting : " + strError;
}
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
}
if(strCommand == "show")
{
Object resultObj;
std::vector<CFinalizedBudget*> winningFbs = budget.GetFinalizedBudgets();
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
BOOST_FOREACH(CFinalizedBudget* finalizedBudget, winningFbs)
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
{
Object bObj;
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
bObj.push_back(Pair("FeeTX", finalizedBudget->nFeeTXHash.ToString()));
bObj.push_back(Pair("Hash", finalizedBudget->GetHash().ToString()));
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
bObj.push_back(Pair("BlockStart", (int64_t)finalizedBudget->GetBlockStart()));
bObj.push_back(Pair("BlockEnd", (int64_t)finalizedBudget->GetBlockEnd()));
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
bObj.push_back(Pair("Proposals", finalizedBudget->GetProposals()));
use proper naming for variables in masternode-budget
2015-07-08 04:35:58 +02:00
bObj.push_back(Pair("VoteCount", (int64_t)finalizedBudget->GetVoteCount()));
Fixes for budget rpc - readability - drop c_str() - drop boost/lexical_cast - ValueFromAmount for money - fValid as bool - fix/simplify descriptions - more info on vote-many - feedback on mnbudget vote
2015-07-17 17:52:55 +02:00
bObj.push_back(Pair("Status", finalizedBudget->GetStatus()));
resultObj.push_back(Pair(finalizedBudget->GetName(), bObj));
Budgeting Software / Reference Node Removal - Added commands for using budgets "mnbudget" and "mnfinalbudget" - Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-04 17:04:09 +02:00
}
return resultObj;
}
return Value::null;
}
Reference in New Issue Copy Permalink