neobytes-project/neobytes
neobytes-project/neobytes
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Cleanup successful sessions before doing timeout check (#2712)

Browse Source 
Otherwise we get some false-positive timeout messages in logs.
This commit is contained in:
Alexander Block 2019-02-18 12:07:57 +01:00 committed by UdjinM6
parent 26db020d17
commit 104c6e7767
1 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/llmq/quorums_signing_shares.cpp
View File

@ -942,6 +942,20 @@ void CSigSharesManager::Cleanup()
{ {
LOCK(cs); LOCK(cs);
// Remove sessions which were succesfully recovered
std::unordered_set<uint256> doneSessions;
sigShares.ForEach([&](const SigShareKey& k, const CSigShare& sigShare) {
if (doneSessions.count(sigShare.GetSignHash())) {
return;
}
if (quorumSigningManager->HasRecoveredSigForSession(sigShare.GetSignHash())) {
doneSessions.emplace(sigShare.GetSignHash());
}
});
for (auto& signHash : doneSessions) {
RemoveSigSharesForSession(signHash);
}
// Remove sessions which timed out // Remove sessions which timed out
std::unordered_set<uint256> timeoutSessions; std::unordered_set<uint256> timeoutSessions;
for (auto& p : firstSeenForSessions) { for (auto& p : firstSeenForSessions) {
@ -969,20 +983,6 @@ void CSigSharesManager::Cleanup()
RemoveSigSharesForSession(signHash); RemoveSigSharesForSession(signHash);
} }
// Remove sessions which were succesfully recovered
std::unordered_set<uint256> doneSessions;
sigShares.ForEach([&](const SigShareKey& k, const CSigShare& sigShare) {
if (doneSessions.count(sigShare.GetSignHash())) {
return;
}
if (quorumSigningManager->HasRecoveredSigForSession(sigShare.GetSignHash())) {
doneSessions.emplace(sigShare.GetSignHash());
}
});
for (auto& signHash : doneSessions) {
RemoveSigSharesForSession(signHash);
}
sigShares.ForEach([&](const SigShareKey& k, const CSigShare& sigShare) { sigShares.ForEach([&](const SigShareKey& k, const CSigShare& sigShare) {
quorumsToCheck.emplace((Consensus::LLMQType) sigShare.llmqType, sigShare.quorumHash); quorumsToCheck.emplace((Consensus::LLMQType) sigShare.llmqType, sigShare.quorumHash);
}); });