fix sdaftuar's nits again
it boggles the mind why these nits can't be delivered on a more timely basis
This commit is contained in:
parent
0a79c04af3
commit
197c3760ff
10
src/main.cpp
10
src/main.cpp
@ -803,10 +803,10 @@ bool CheckSequenceLocks(const CTransaction &tx, int flags)
|
|||||||
index.pprev = tip;
|
index.pprev = tip;
|
||||||
// CheckSequenceLocks() uses chainActive.Height()+1 to evaluate
|
// CheckSequenceLocks() uses chainActive.Height()+1 to evaluate
|
||||||
// height based locks because when SequenceLocks() is called within
|
// height based locks because when SequenceLocks() is called within
|
||||||
// CBlock::AcceptBlock(), the height of the block *being*
|
// ConnectBlock(), the height of the block *being*
|
||||||
// evaluated is what is used. Thus if we want to know if a
|
// evaluated is what is used.
|
||||||
// transaction can be part of the *next* block, we need to call
|
// Thus if we want to know if a transaction can be part of the
|
||||||
// SequenceLocks() with one more than chainActive.Height().
|
// *next* block, we need to use one more than chainActive.Height()
|
||||||
index.nHeight = tip->nHeight + 1;
|
index.nHeight = tip->nHeight + 1;
|
||||||
|
|
||||||
// pcoinsTip contains the UTXO set for chainActive.Tip()
|
// pcoinsTip contains the UTXO set for chainActive.Tip()
|
||||||
@ -2221,7 +2221,7 @@ bool ConnectBlock(const CBlock& block, CValidationState& state, CBlockIndex* pin
|
|||||||
}
|
}
|
||||||
|
|
||||||
if (!SequenceLocks(tx, nLockTimeFlags, &prevheights, *pindex)) {
|
if (!SequenceLocks(tx, nLockTimeFlags, &prevheights, *pindex)) {
|
||||||
return state.DoS(100, error("ConnectBlock(): contains a non-BIP68-final transaction", __func__),
|
return state.DoS(100, error("%s: contains a non-BIP68-final transaction", __func__),
|
||||||
REJECT_INVALID, "bad-txns-nonfinal");
|
REJECT_INVALID, "bad-txns-nonfinal");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -362,7 +362,7 @@ bool SequenceLocks(const CTransaction &tx, int flags, std::vector<int>* prevHeig
|
|||||||
/**
|
/**
|
||||||
* Check if transaction will be BIP 68 final in the next block to be created.
|
* Check if transaction will be BIP 68 final in the next block to be created.
|
||||||
*
|
*
|
||||||
* Calls SequenceLocks() with data from the tip of the current active chain.
|
* Simulates calling SequenceLocks() with data from the tip of the current active chain.
|
||||||
*
|
*
|
||||||
* See consensus/consensus.h for flag definitions.
|
* See consensus/consensus.h for flag definitions.
|
||||||
*/
|
*/
|
||||||
|
@ -45,7 +45,7 @@ static const unsigned int STANDARD_SCRIPT_VERIFY_FLAGS = MANDATORY_SCRIPT_VERIFY
|
|||||||
/** For convenience, standard but not mandatory verify flags. */
|
/** For convenience, standard but not mandatory verify flags. */
|
||||||
static const unsigned int STANDARD_NOT_MANDATORY_VERIFY_FLAGS = STANDARD_SCRIPT_VERIFY_FLAGS & ~MANDATORY_SCRIPT_VERIFY_FLAGS;
|
static const unsigned int STANDARD_NOT_MANDATORY_VERIFY_FLAGS = STANDARD_SCRIPT_VERIFY_FLAGS & ~MANDATORY_SCRIPT_VERIFY_FLAGS;
|
||||||
|
|
||||||
/** Used as the flags parameter to LockTime() in non-consensus code. */
|
/** Used as the flags parameter to sequence and nLocktime checks in non-consensus code. */
|
||||||
static const unsigned int STANDARD_LOCKTIME_VERIFY_FLAGS = LOCKTIME_VERIFY_SEQUENCE |
|
static const unsigned int STANDARD_LOCKTIME_VERIFY_FLAGS = LOCKTIME_VERIFY_SEQUENCE |
|
||||||
LOCKTIME_MEDIAN_TIME_PAST;
|
LOCKTIME_MEDIAN_TIME_PAST;
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user