neobytes-project/neobytes
neobytes-project/neobytes
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Slightly optimize ApproximateBestSubset and its usage for PS txes (#3184)

Browse Source 
* From 2 best sets with the same `nTotal` in ApproximateBestSubset prefer the one with less inputs

* There is no reason to run ApproximateBestSubset again if nMinChange is 0

* Apply review suggestions
This commit is contained in:
UdjinM6 2019-11-04 20:35:58 +03:00 committed by GitHub
parent a55624b25f
commit 251fb5e69c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/wallet/wallet.cpp
View File

@ -2863,6 +2863,7 @@ static void ApproximateBestSubset(const std::vector<CInputCoin>& vValue, const C
vfBest.assign(vValue.size(), true);
nBest = nTotalLower;
int nBestInputCount = 0;
FastRandomContext insecure_rand;
@ -2870,6 +2871,7 @@ static void ApproximateBestSubset(const std::vector<CInputCoin>& vValue, const C
{
vfIncluded.assign(vValue.size(), false);
CAmount nTotal = 0;
int nTotalInputCount = 0;
bool fReachedTarget = false;
for (int nPass = 0; nPass < 2 && !fReachedTarget; nPass++)
{
@ -2884,16 +2886,19 @@ static void ApproximateBestSubset(const std::vector<CInputCoin>& vValue, const C
if (nPass == 0 ? insecure_rand.randbool() : !vfIncluded[i])
{
nTotal += vValue[i].txout.nValue;
++nTotalInputCount;
vfIncluded[i] = true;
if (nTotal >= nTargetValue)
{
fReachedTarget = true;
if (nTotal < nBest)
if (nTotal < nBest || (nTotal == nBest && nTotalInputCount < nBestInputCount))
{
nBest = nTotal;
nBestInputCount = nTotalInputCount;
vfBest = vfIncluded;
}
nTotal -= vValue[i].txout.nValue;
--nTotalInputCount;
vfIncluded[i] = false;
}
}
@ -3047,7 +3052,7 @@ bool CWallet::SelectCoinsMinConf(const CAmount& nTargetValue, const int nConfMin
CAmount nBest;
ApproximateBestSubset(vValue, nTotalLower, nTargetValue, vfBest, nBest);
if (nBest != nTargetValue && nTotalLower >= nTargetValue + nMinChange)
if (nBest != nTargetValue && nMinChange != 0 && nTotalLower >= nTargetValue + nMinChange)
ApproximateBestSubset(vValue, nTotalLower, nTargetValue + nMinChange, vfBest, nBest);
// If we have a bigger coin and (either the stochastic approximation didn't find a good solution,