From fe074ccb3798b0c7c8ddc221342eb3cfb593f168 Mon Sep 17 00:00:00 2001 From: xor-freenet Date: Mon, 25 Jan 2016 18:07:33 +0100 Subject: [PATCH 1/8] doc: Explain effects of -prune= parameter in release notes As discussed in the mailing list thread: [bitcoin-dev] Bitcoin Core 0.12.0 release candidate 1 available in the replies to this message: http://lists.linuxfoundation.org/pipermail/bitcoin-dev/2016-January/012276.html Please review thoroughly, I'm a newbie. --- doc/release-notes.md | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/doc/release-notes.md b/doc/release-notes.md index 3f1e57876..452e2dcbf 100644 --- a/doc/release-notes.md +++ b/doc/release-notes.md @@ -267,6 +267,9 @@ Wallet: Pruning --------------- With 0.12 it is possible to use wallet functionality in pruned mode. +This can reduce the disk usage from currently around 60 GB to +less than 1 GB. + However, rescans as well as the RPCs `importwallet`, `importaddress`, `importprivkey` are disabled. @@ -274,6 +277,14 @@ To enable block pruning set `prune=` on the command line or in `bitcoin.conf`, where `N` is the number of MiB to allot for raw block & undo data. +A value of 0 disables pruning. The minimal value above 0 is 550. Your +wallet is as secure with high values as it is with low ones. Higher +values merely reduce the network traffic in case of reorganization of +the blockchain. In future releases, a higher value may also help the +network as a whole: The stored blocks could be served to other nodes. +Currently, nodes with pruning enabled do not serve block data at all +and thus could be considered as "leechers". + `NODE_BLOOM` service bit ------------------------ From 46d7eb61372d4a507bf80924d1e19dafd46b8da1 Mon Sep 17 00:00:00 2001 From: xor-freenet Date: Mon, 25 Jan 2016 18:38:51 +0100 Subject: [PATCH 2/8] doc: Fix minimal disk usage with pruning enabled --- doc/release-notes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/release-notes.md b/doc/release-notes.md index 452e2dcbf..ca5a38cd5 100644 --- a/doc/release-notes.md +++ b/doc/release-notes.md @@ -268,7 +268,7 @@ Wallet: Pruning With 0.12 it is possible to use wallet functionality in pruned mode. This can reduce the disk usage from currently around 60 GB to -less than 1 GB. +less than 2 GB. However, rescans as well as the RPCs `importwallet`, `importaddress`, `importprivkey` are disabled. From be4b474287d6a3479678b6c0ef50587f49bfbc54 Mon Sep 17 00:00:00 2001 From: xor-freenet Date: Tue, 26 Jan 2016 13:06:32 +0100 Subject: [PATCH 3/8] doc: In release notes, do not claim that pruning is leeching Peter Todd says it does not matter currently. --- doc/release-notes.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/doc/release-notes.md b/doc/release-notes.md index ca5a38cd5..33f37bc19 100644 --- a/doc/release-notes.md +++ b/doc/release-notes.md @@ -282,8 +282,6 @@ wallet is as secure with high values as it is with low ones. Higher values merely reduce the network traffic in case of reorganization of the blockchain. In future releases, a higher value may also help the network as a whole: The stored blocks could be served to other nodes. -Currently, nodes with pruning enabled do not serve block data at all -and thus could be considered as "leechers". `NODE_BLOOM` service bit ------------------------ From 58e3abfffc69eaa5ea24f40f8428be48808ca664 Mon Sep 17 00:00:00 2001 From: xor-freenet Date: Tue, 26 Jan 2016 13:08:33 +0100 Subject: [PATCH 4/8] doc: In release notes, increase estimate of disk usage with pruning Jonas Schnelli recommended this to account for growth of utxo set, debug log, etc. --- doc/release-notes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/release-notes.md b/doc/release-notes.md index 33f37bc19..93ef8cf08 100644 --- a/doc/release-notes.md +++ b/doc/release-notes.md @@ -268,7 +268,7 @@ Wallet: Pruning With 0.12 it is possible to use wallet functionality in pruned mode. This can reduce the disk usage from currently around 60 GB to -less than 2 GB. +around 2 GB. However, rescans as well as the RPCs `importwallet`, `importaddress`, `importprivkey` are disabled. From a683d20d5f88f0685cdacdcba928d6ec572390dd Mon Sep 17 00:00:00 2001 From: xor-freenet Date: Wed, 27 Jan 2016 15:22:33 +0100 Subject: [PATCH 5/8] doc: Minor sentence length / capitalization fixes --- doc/release-notes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/release-notes.md b/doc/release-notes.md index 93ef8cf08..7049bd6c1 100644 --- a/doc/release-notes.md +++ b/doc/release-notes.md @@ -281,7 +281,7 @@ A value of 0 disables pruning. The minimal value above 0 is 550. Your wallet is as secure with high values as it is with low ones. Higher values merely reduce the network traffic in case of reorganization of the blockchain. In future releases, a higher value may also help the -network as a whole: The stored blocks could be served to other nodes. +network as a whole: stored blocks could be served to other nodes. `NODE_BLOOM` service bit ------------------------ From 54d390780feaef895fede8da3f436b932af29c1d Mon Sep 17 00:00:00 2001 From: xor-freenet Date: Wed, 27 Jan 2016 15:53:40 +0100 Subject: [PATCH 6/8] doc: Fix wrong claims about blockchain reorganization with pruning --- doc/release-notes.md | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/doc/release-notes.md b/doc/release-notes.md index 7049bd6c1..c22b4e760 100644 --- a/doc/release-notes.md +++ b/doc/release-notes.md @@ -279,9 +279,14 @@ raw block & undo data. A value of 0 disables pruning. The minimal value above 0 is 550. Your wallet is as secure with high values as it is with low ones. Higher -values merely reduce the network traffic in case of reorganization of -the blockchain. In future releases, a higher value may also help the -network as a whole: stored blocks could be served to other nodes. +values merely ensure that your node will not shutdown upon blockchain +reorganizations of more than 2 days - which are unlikely to happen in +practice unless there is a hard fork. In future releases, a higher value +may also help the network as a whole: stored blocks could be served to +other nodes. + +For further information about pruning, you may also consult the [release +notes of v0.11.0](https://github.com/bitcoin/bitcoin/blob/v0.11.0/doc/release-notes.md#block-file-pruning). `NODE_BLOOM` service bit ------------------------ From 15c0263ff1e4f4773005291e1eb584954900e197 Mon Sep 17 00:00:00 2001 From: xor-freenet Date: Wed, 27 Jan 2016 15:58:18 +0100 Subject: [PATCH 7/8] doc: Minor spelling fix --- doc/release-notes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/release-notes.md b/doc/release-notes.md index c22b4e760..bf45bf4f8 100644 --- a/doc/release-notes.md +++ b/doc/release-notes.md @@ -279,7 +279,7 @@ raw block & undo data. A value of 0 disables pruning. The minimal value above 0 is 550. Your wallet is as secure with high values as it is with low ones. Higher -values merely ensure that your node will not shutdown upon blockchain +values merely ensure that your node will not shut down upon blockchain reorganizations of more than 2 days - which are unlikely to happen in practice unless there is a hard fork. In future releases, a higher value may also help the network as a whole: stored blocks could be served to From 8c5f90306c12142586024023785f20cac7b22055 Mon Sep 17 00:00:00 2001 From: xor-freenet Date: Wed, 27 Jan 2016 16:29:39 +0100 Subject: [PATCH 8/8] doc: In release notes, reduce length of pruning section --- doc/release-notes.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/doc/release-notes.md b/doc/release-notes.md index bf45bf4f8..a2970fbb8 100644 --- a/doc/release-notes.md +++ b/doc/release-notes.md @@ -281,9 +281,8 @@ A value of 0 disables pruning. The minimal value above 0 is 550. Your wallet is as secure with high values as it is with low ones. Higher values merely ensure that your node will not shut down upon blockchain reorganizations of more than 2 days - which are unlikely to happen in -practice unless there is a hard fork. In future releases, a higher value -may also help the network as a whole: stored blocks could be served to -other nodes. +practice. In future releases, a higher value may also help the network +as a whole: stored blocks could be served to other nodes. For further information about pruning, you may also consult the [release notes of v0.11.0](https://github.com/bitcoin/bitcoin/blob/v0.11.0/doc/release-notes.md#block-file-pruning).