neobytes-project/neobytes
neobytes-project/neobytes
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Do not hold cs_vNodes in CSigSharesManager::SendMessages() for too long (#2758)

Browse Source
This commit is contained in:
UdjinM6 2019-03-11 16:33:17 +03:00 committed by GitHub
parent fbf0dcb086
commit 3a5e7c4334
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/llmq/quorums_signing_shares.cpp
View File

@ -1059,7 +1059,9 @@ bool CSigSharesManager::SendMessages()
bool didSend = false;
g_connman->ForEachNode([&](CNode* pnode) {
std::vector<CNode*> vNodesCopy = g_connman->CopyNodeVector(CConnman::FullyConnectedOnly);
for (auto& pnode : vNodesCopy) {
CNetMsgMaker msgMaker(pnode->GetSendVersion());
auto it1 = sigSessionAnnouncements.find(pnode->id);
@ -1145,9 +1147,10 @@ bool CSigSharesManager::SendMessages()
didSend = true;
}
}
}
return true;
});
// looped through all nodes, release them
g_connman->ReleaseNodeVector(vNodesCopy);
if (didSend) {
g_connman->WakeSelect();