Reject headers that build on an invalid parent
Rebased-From: 3497022347
Github-Pull: #5459
This commit is contained in:
parent
ad3d208fb9
commit
8446262597
@ -442,6 +442,10 @@ void FindNextBlocksToDownload(NodeId nodeid, unsigned int count, std::vector<CBl
|
|||||||
// are not yet downloaded and not in flight to vBlocks. In the mean time, update
|
// are not yet downloaded and not in flight to vBlocks. In the mean time, update
|
||||||
// pindexLastCommonBlock as long as all ancestors are already downloaded.
|
// pindexLastCommonBlock as long as all ancestors are already downloaded.
|
||||||
BOOST_FOREACH(CBlockIndex* pindex, vToFetch) {
|
BOOST_FOREACH(CBlockIndex* pindex, vToFetch) {
|
||||||
|
if (!pindex->IsValid(BLOCK_VALID_TREE)) {
|
||||||
|
// We consider the chain that this peer is on invalid.
|
||||||
|
return;
|
||||||
|
}
|
||||||
if (pindex->nStatus & BLOCK_HAVE_DATA) {
|
if (pindex->nStatus & BLOCK_HAVE_DATA) {
|
||||||
if (pindex->nChainTx)
|
if (pindex->nChainTx)
|
||||||
state->pindexLastCommonBlock = pindex;
|
state->pindexLastCommonBlock = pindex;
|
||||||
@ -2559,6 +2563,8 @@ bool AcceptBlockHeader(const CBlockHeader& block, CValidationState& state, CBloc
|
|||||||
if (mi == mapBlockIndex.end())
|
if (mi == mapBlockIndex.end())
|
||||||
return state.DoS(10, error("%s : prev block not found", __func__), 0, "bad-prevblk");
|
return state.DoS(10, error("%s : prev block not found", __func__), 0, "bad-prevblk");
|
||||||
pindexPrev = (*mi).second;
|
pindexPrev = (*mi).second;
|
||||||
|
if (pindexPrev->nStatus & BLOCK_FAILED_MASK)
|
||||||
|
return state.DoS(100, error("%s : prev block invalid", __func__), REJECT_INVALID, "bad-prevblk");
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!ContextualCheckBlockHeader(block, state, pindexPrev))
|
if (!ContextualCheckBlockHeader(block, state, pindexPrev))
|
||||||
|
Loading…
Reference in New Issue
Block a user