Fix review nits

This commit is contained in:
Alexander Block 2018-01-22 08:05:44 +01:00
parent ec81769605
commit b97eecc058
4 changed files with 10 additions and 13 deletions

View File

@ -251,7 +251,7 @@ public:
1507424630, // * UNIX timestamp of last known number of transactions
3701128, // * total number of transactions between genesis and that timestamp
// (the tx=... number in the SetBestChain debug.log lines)
0.1 // * estimated number of transactions second after that timestamp
0.1 // * estimated number of transactions per second after that timestamp
};
}
};
@ -367,11 +367,10 @@ public:
};
chainTxData = ChainTxData{
// Data as of block 0000024bc3f4f4cb30d29827c13d921ad77d2c6072e586c7f60d83c2722cdcc5 (height 2999)
1462856598,
3094, // * total number of transactions between genesis and last checkpoint
1462856598, // * UNIX timestamp of last known number of transactions
3094, // * total number of transactions between genesis and that timestamp
// (the tx=... number in the SetBestChain debug.log lines)
0.01 // * estimated number of transactions per day after checkpoint
0.01 // * estimated number of transactions per second after that timestamp
};
}
@ -488,11 +487,9 @@ public:
};
chainTxData = ChainTxData{
// Data as of block 0000024bc3f4f4cb30d29827c13d921ad77d2c6072e586c7f60d83c2722cdcc5 (height 2999)
devnetGenesis.GetBlockTime(),
2, // * total number of transactions between genesis and last checkpoint
// (the tx=... number in the SetBestChain debug.log lines)
0.01 // * estimated number of transactions per day after checkpoint
devnetGenesis.GetBlockTime(), // * UNIX timestamp of devnet genesis block
2, // * we only have 2 coinbase transactions when a devnet is started up
0.01 // * estimated number of transactions per second
};
}
};

View File

@ -64,7 +64,7 @@ struct Params {
/** Block height at which BIP66 becomes active */
int BIP66Height;
/**
* Minimum blocks including miner confirmation of the total of 2016 blocks in a retargetting period,
* Minimum blocks including miner confirmation of the total of nMinerConfirmationWindow blocks in a retargeting period,
* (nPowTargetTimespan / nPowTargetSpacing) which is also used for BIP9 deployments.
* Default BIP9Deployment::nThreshold value for deployments where it's not specified and for unknown deployments.
* Examples: 1916 for 95%, 1512 for testchains.

View File

@ -136,7 +136,7 @@ static const CRPCConvertParam vRPCConvertParams[] =
{ "prioritisetransaction", 2, "fee_delta" },
{ "setban", 2, "bantime" },
{ "setban", 3, "absolute" },
{ "setbip69enabled", 0 },
{ "setbip69enabled", 0, "enabled" },
{ "setnetworkactive", 0, "state" },
{ "getmempoolancestors", 1, "verbose" },
{ "getmempooldescendants", 1, "verbose" },

View File

@ -1718,7 +1718,7 @@ UniValue listsinceblock(const JSONRPCRequest& request)
}
}
else
throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid blockhash");
throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid blockhash");
}
if (request.params.size() > 1)