Few fixes in docs/comments (#3068)

* Few fixes in docs/comments

* Add descriptions

contrib/zmq/zmq_sub.py

@@ -7,7 +7,7 @@
     ZMQ example using python3's asyncio
 
     Dash should be started with the command line arguments:
-        dashd-testnet -daemon \
+        dashd -testnet -daemon \
                 -zmqpubrawtx=tcp://127.0.0.1:28332 \
                 -zmqpubrawblock=tcp://127.0.0.1:28332 \
                 -zmqpubhashtx=tcp://127.0.0.1:28332 \

doc/REST-interface.md

@@ -57,7 +57,7 @@ https://github.com/bitcoin/bips/blob/master/bip-0064.mediawiki
 
 Example:
 ```
-$ curl localhost:18332/rest/getutxos/checkmempool/b2cdfd7b89def827ff8af7cd9bff7627ff72e5e8b0f71210f92ea7a4000c5d75-0.json 2>/dev/null | json_pp
+$ curl localhost:19998/rest/getutxos/checkmempool/b2cdfd7b89def827ff8af7cd9bff7627ff72e5e8b0f71210f92ea7a4000c5d75-0.json 2>/dev/null | json_pp
 {
    "chainHeight" : 325347,
    "chaintipHash" : "00000000fb01a7f3745a717f8caebee056c484e6e0bfe4a9591c235bb70506fb",
@@ -99,4 +99,4 @@ Only supports JSON as output format.
 
 Risks
 -------------
-Running a web browser on the same node with a REST enabled bitcoind can be a risk. Accessing prepared XSS websites could read out tx/block data of your node by placing links like `<script src="http://127.0.0.1:8332/rest/tx/1234567890.json">` which might break the nodes privacy.
+Running a web browser on the same node with a REST enabled dashd can be a risk. Accessing prepared XSS websites could read out tx/block data of your node by placing links like `<script src="http://127.0.0.1:19998/rest/tx/1234567890.json">` which might break the nodes privacy.

doc/developer-notes.md

@@ -189,10 +189,19 @@ Threads
 
 - ThreadRPCServer : Remote procedure call handler, listens on port 9998 for connections and services them.
 
-- BitcoinMiner : Generates coins (if wallet is enabled).
-
 - Shutdown : Does an orderly shutdown of everything.
 
+- CSigSharesManager::WorkThreadMain : Processes pending BLS signature shares.
+
+- CInstantSendManager::WorkThreadMain : Processes pending InstantSend locks.
+
+Thread pools
+------------
+
+- CBLSWorker : A highly parallelized worker/helper for BLS/DKG calculations.
+
+- CDKGSessionManager : A thread pool for processing LLMQ messages.
+
 Ignoring IDE/editor files
 --------------------------
 

doc/release-process.md

@@ -165,7 +165,7 @@ Codesigner only: Sign the osx binary:
 
     transfer dashcore-osx-unsigned.tar.gz to osx for signing
     tar xf dashcore-osx-unsigned.tar.gz
-    ./detached-sig-create.sh -s "Key ID"
+    ./detached-sig-create.sh -s "Key ID" -o runtime
     Enter the keychain password and authorize the signature
     Move signature-osx.tar.gz back to the gitian host
 

src/chainparams.cpp

@@ -199,7 +199,7 @@ static Consensus::LLMQParams llmq400_85 = {
         .dkgMiningWindowEnd = 48, // give it a larger mining window to make sure it is mined
         .dkgBadVotesThreshold = 300,
 
-        .signingActiveQuorumCount = 4, // two days worth of LLMQs
+        .signingActiveQuorumCount = 4, // four days worth of LLMQs
 
         .keepOldConnections = 5,
 };