neobytes-project/neobytes
neobytes-project/neobytes
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Governance bug fix (#998)

Browse Source 
* Added more specific error message about attempts to submit superblocks by
non-masternodes

* Fixed governance object validation bug

* Fixed logic bug in governance object submission
This commit is contained in:
Tim Flynn 2016-09-09 11:52:10 -04:00 committed by UdjinM6
parent 740d1e0b1e
commit d81e729b0a
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/governance.cpp
View File

@ -956,7 +956,7 @@ bool CGovernanceObject::IsValidLocally(const CBlockIndex* pindex, std::string& s
if(fCheckCollateral) {
if(nObjectType == GOVERNANCE_OBJECT_TRIGGER) {
CMasternode mn;
if(mnodeman.Get(pubkeyMasternode, mn)) {
if(!mnodeman.Get(pubkeyMasternode, mn)) {
strError = "Masternode not found";
return false;
}

11
src/rpcgovernance.cpp
View File

@ -186,9 +186,14 @@ UniValue gobject(const UniValue& params, bool fHelp)
<< endl; );
// Attempt to sign triggers if we are a MN
if((govobj.GetObjectType() == GOVERNANCE_OBJECT_TRIGGER) && mnFound) {
govobj.SetMasternodeInfo(mn.vin, activeMasternode.pubKeyMasternode);
govobj.Sign(activeMasternode.keyMasternode);
if(govobj.GetObjectType() == GOVERNANCE_OBJECT_TRIGGER) {
if(mnFound) {
govobj.SetMasternodeInfo(mn.vin, activeMasternode.pubKeyMasternode);
govobj.Sign(activeMasternode.keyMasternode);
}
else {
throw JSONRPCError(RPC_INTERNAL_ERROR, "Only valid masternodes can submit this type of object");
}
}
std::string strError = "";