Wladimir J. van der Laan
089b10a28a
Merge pull request #1911 from Diapolo/fix_signed_unsigned
...
fix wrong (signed/unsigned) printf format specifier in bitcoinrpc.cpp
2012-10-11 00:40:08 -07:00
Wladimir J. van der Laan
ac0ad5dc63
Merge pull request #1901 from laanwj/2012_10_remove_strlcpy
...
get rid of strlcpy.h
2012-10-11 00:39:51 -07:00
Gavin Andresen
1d1f32d16d
Bump versions for 0.7.1 release
2012-10-09 12:37:35 -04:00
Gavin Andresen
de038acd96
Fix bad merge, pszDataDir duplication
2012-10-09 12:28:00 -04:00
Gavin Andresen
673021410f
Merge branch 'wallet_exceptions' of github.com:gavinandresen/bitcoin-git
2012-10-09 12:14:26 -04:00
Gavin Andresen
cf64347d70
Merge branch 'crash_at_exit' of github.com:gavinandresen/bitcoin-git
2012-10-09 12:10:18 -04:00
Wladimir J. van der Laan
0a5ce30bc1
Merge pull request #1915 from Diapolo/Qt5_compat_leftover
...
change Q_WS_MAC -> Q_OS_MAC (Qt5 compatibility)
2012-10-08 22:28:24 -07:00
Jeff Garzik
de2b9459bd
Merge pull request #1834 from jgarzik/kickblocks
...
P2P: Do not request blocks from peers with fewer blocks than us
2012-10-08 15:15:58 -07:00
Jeff Garzik
b855abb8db
Revert "Send 'mempool' P2P command at the start of each P2P session"
...
Fat-fingered on github, and merged this too early.
This reverts commit 22f9b06903
.
2012-10-08 18:14:15 -04:00
Jeff Garzik
56caa38a67
Merge pull request #1833 from jgarzik/mempool-query
...
Send 'mempool' P2P command at the start of each P2P session
2012-10-08 15:12:25 -07:00
Gavin Andresen
d0b3e77a08
Don't try to verify a non-existent wallet.dat
2012-10-08 17:46:46 -04:00
Gavin Andresen
eed1785f70
Handle corrupt wallets gracefully.
...
Corrupt wallets used to cause a DB_RUNRECOVERY uncaught exception and a
crash. This commit does three things:
1) Runs a BDB verify early in the startup process, and if there is a
low-level problem with the database:
+ Moves the bad wallet.dat to wallet.timestamp.bak
+ Runs a 'salvage' operation to get key/value pairs, and
writes them to a new wallet.dat
+ Continues with startup.
2) Much more tolerant of serialization errors. All errors in deserialization
are reported by tolerated EXCEPT for errors related to reading keypairs
or master key records-- those are reported and then shut down, so the user
can get help (or recover from a backup).
3) Adds a new -salvagewallet option, which:
+ Moves the wallet.dat to wallet.timestamp.bak
+ extracts ONLY keypairs and master keys into a new wallet.dat
+ soft-sets -rescan, to recreate transaction history
This was tested by randomly corrupting testnet wallets using a little
python script I wrote (https://gist.github.com/3812689 )
2012-10-08 17:46:45 -04:00
Gavin Andresen
8d5f461cb6
Handle incompatible BDB environments
...
Before, opening a -datadir that was created with a new
version of Berkeley DB would result in an un-caught DB_RUNRECOVERY
exception.
After these changes, the error is caught and the user is told
that there is a problem and is told how to try to recover from
it.
2012-10-08 17:25:17 -04:00
Gavin Andresen
c2bb42168b
Merge branch 'BDB_DOWNGRADE'
2012-10-08 17:18:17 -04:00
Gavin Andresen
e4954b1297
Handle incompatible BDB environments
...
Before, opening a -datadir that was created with a new
version of Berkeley DB would result in an un-caught DB_RUNRECOVERY
exception.
After these changes, the error is caught and the user is told
that there is a problem and is told how to try to recover from
it.
2012-10-08 15:51:59 -04:00
Jeff Garzik
bd2e140571
CAddrMan: verify pchMessageStart file marker, before reading address data
...
This avoids the case where you read the address data, before noticing it is
the wrong network.
2012-10-08 13:41:57 -04:00
Philip Kaufmann
ada2a39691
change Q_WS_MAC -> Q_OS_MAC (Qt5 compatibility)
...
- I missed that one in my former pull
2012-10-07 18:50:03 +02:00
Pieter Wuille
43de64949c
Merge pull request #1859 from Diapolo/proxy_locks
...
add LOCK() for proxy related data-structures
2012-10-07 07:03:06 -07:00
Pieter Wuille
e996521390
Use fdatasync instead of fsync on supported platforms
2012-10-07 15:51:40 +02:00
Pieter Wuille
4e882b7960
Remove I2P support from netbase
...
I2P apparently needs 256 bits to store a fully routable address. Garlicat
requires a centralized lookup service to map the 80-bit addresses to fully
routable ones (as far as I understood), so that's not really usable in our
situation.
To support I2P routing and peer exchange for it, another solution is needed.
This will most likely imply a network protocol change, and extension of the
'addr' message.
2012-10-07 15:10:14 +02:00
Wladimir J. van der Laan
6032e4f4e7
get rid of strlcpy.h
...
Don't use hand-rolled string manipulation routine with a fixed
buffer in the bitcoin core, instead make use of c++ strings and boost.
2012-10-07 14:38:37 +02:00
Philip Kaufmann
95e625d235
fix wrong (signed/unsigned) printf format specifier in bitcoinrpc.cpp
...
- also includes the required bitcoinstrings.cpp update
2012-10-05 23:31:58 +02:00
Wladimir J. van der Laan
ee0b648536
Merge pull request #1906 from laanwj/2012_10_help_stdout
...
Send --help message to stdout i.s.o stderr
2012-10-05 11:24:09 -07:00
Wladimir J. van der Laan
a6be58d536
Merge pull request #1905 from laanwj/2012_10_startup_gui_error
...
When datadir missing, show messagebox instead of printing error to stderr
2012-10-04 22:28:44 -07:00
Pieter Wuille
39930ca6ae
Merge pull request #1908 from laanwj/2012_10_rpcerrors
...
Document RPC error codes
2012-10-04 17:17:53 -07:00
Gavin Andresen
cac6b389d1
Avoid crashes at shutdown due to printf() in global destructors.
2012-10-04 16:35:08 -04:00
Wladimir J. van der Laan
285746d3db
Add constants for HTTP status codes
2012-10-04 15:49:15 +02:00
Wladimir J. van der Laan
738835d7b8
Document RPC error codes
...
Replace all "magic values" in RPCError(...) by constants.
2012-10-04 15:49:15 +02:00
Wladimir J. van der Laan
61fd72695f
When datadir missing, show messagebox instead of printing error to stderr
2012-10-04 12:04:12 +02:00
Philip Kaufmann
81bbef2609
add LOCK() for proxy related data-structures
...
- fix #1560 by properly locking proxy related data-structures
- update GetProxy() and introduce GetNameProxy() to be able to use a
thread-safe local copy from proxyInfo and nameproxyInfo
- update usage of GetProxy() all over the source to match the new
behaviour, as it now fills a full proxyType object
- rename GetNameProxy() into HaveNameProxy() to be more clear
2012-10-04 09:35:24 +02:00
Wladimir J. van der Laan
366944431b
Pull changed translations from transifex
...
There was also a new translation available, "ja" (Japanese), however
almost nothing was filled in yet, so I'm not including it for this release.
2012-10-04 08:18:12 +02:00
Wladimir J. van der Laan
f1e262c8e1
Translation update for 0.7.1
...
Also clarify translation process that the package `gettext` is needed to run string extractor.
2012-10-04 08:13:37 +02:00
Wladimir J. van der Laan
bb353618f1
Send --help message to stdout i.s.o stderr
...
This allows fun stuff such as `bitcoin --help | less`, and more
easy piping to files.
Looking at other tools such as bash, gcc, they all send their help
text to stdout.
2012-10-04 07:56:57 +02:00
Philip Kaufmann
7bc65ff108
move most explicit getters in optionsmodel to header
...
- is more consistent and saves quite some lines of code
2012-10-02 18:49:57 +02:00
Gavin Andresen
0547b02af7
Merge branch '2012_09_fixwformat' of github.com:laanwj/bitcoin
2012-10-01 16:52:42 -04:00
Gavin Andresen
d2cc6f489c
Merge branch 'master' of github.com:runeksvendsen/bitcoin
2012-10-01 16:51:24 -04:00
Gavin Andresen
da6e9fe634
Merge pull request #1893 from kjj2/issue1884
...
Issue 1884: Add a backup warning to the encryptwallet RPC command
2012-10-01 13:40:48 -07:00
Wladimir J. van der Laan
827d8c2e0c
Revert "Remove -Wformat* warnings from makefiles"
...
This reverts commit 14ac0adcc7
.
2012-10-01 19:45:42 +02:00
Philip Kaufmann
d210f4f5b8
fix -Wformat warnings all over the source
2012-10-01 19:45:42 +02:00
Wladimir J. van der Laan
bcc292b22d
Extend printf warnings to error()
2012-10-01 19:45:41 +02:00
Gavin Andresen
00a757375c
Merge branch '2012_09_base58tests' of github.com:laanwj/bitcoin
2012-10-01 11:22:38 -04:00
Wladimir J. van der Laan
d6b13283d1
data-driven base58 CBitcoinAddress/CBitcoinSecret tests
...
Arbitrary numbers of test vectors can be generated using the script
`gen_base58_test_vectors.py`.
2012-10-01 04:57:26 +02:00
Rune K. Svendsen
1bf66fcc0a
When encrypting the wallet, warn user that old backups will become useless.
...
Don't include HTML in translation strings. Do split the huge message over several lines.
Prettier lines
2012-09-30 15:57:53 +02:00
kjj2
31a8b70ee3
Add a backup warning to the encryptwallet RPC command
2012-09-30 08:50:59 -05:00
Philip Kaufmann
9c8dc7caf1
harmonize printf format characters
...
- remove the "%" character from format characters for (s)size_t and
ptrdiff_t and harmonize them with the ones for int64 and uint64
2012-09-30 11:57:25 +02:00
Wladimir J. van der Laan
018ec85ff7
Merge pull request #1875 from hsoft/master
...
Fix compilation with clang under OS X
2012-09-29 02:23:46 -07:00
Wladimir J. van der Laan
f72fd0e792
Merge pull request #1881 from xanatos/Tests
...
Removed a duplicated identical if
2012-09-29 01:00:55 -07:00
Wladimir J. van der Laan
552af52b45
Merge pull request #1851 from fanquake/OpenSSL-1.0.1c
...
Update to use OpenSSL 1.0.1c
2012-09-29 00:58:15 -07:00
Wladimir J. van der Laan
3b2eb49db9
Merge pull request #1883 from sipa/norandstack
...
Remove stack randomization
2012-09-29 00:56:25 -07:00
Jeff Garzik
3e37e7eca4
Merge pull request #1871 from jgarzik/wallet-deadcode
...
walletdb.h: remove dead code
2012-09-28 17:05:16 -07:00
Pieter Wuille
2e3ffb2d82
Remove stack randomization
2012-09-28 21:53:28 +02:00
Pieter Wuille
842a31ad1b
Merge pull request #1862 from kjj2/testports
...
Fix: when testnet=1 specified, change default RPC port to 18332
2012-09-28 08:03:45 -07:00
xanatos
50e01ee620
toHTML won't add empty wtx.mapValue elements
...
As the code was before, toHTML added empty elements to mapValue to check for their existance. Now first it check for their existance and then for their non-emptiness.
Removed a duplicated identical if
There are two equal ifs, one inside another. If the first one is true, then the second one is true.
2012-09-28 15:50:48 +02:00
Wladimir J. van der Laan
035cb4781d
Merge pull request #1868 from maaku/and_or_xor_sign_extension
...
Documented bug in sign-extension behavior of opcodes OP_AND, OP_OR, and OP_XOR
2012-09-27 22:48:27 -07:00
Virgil Dupras
fee10d800e
Fixed compilation error with clang.
...
Previously, trying to compile with clang would result in the error: assigning to 'objc_object *' from incompatible type 'DockIconClickEventHandler *'
2012-09-27 15:06:16 -04:00
Wladimir J. van der Laan
14ac0adcc7
Remove -Wformat* warnings from makefiles
...
commit 5a1a3622
effectively enabled these warnings, but they need
to be fixed before being enabled in the general build scripts.
2012-09-27 04:10:21 +02:00
Jeff Garzik
189eb6a989
walletdb.h: remove dead code
2012-09-26 21:56:45 -04:00
Wladimir J. van der Laan
5a1a362215
Merge pull request #1807 from laanwj/2012_09_printf_warnings
...
Add printf-style warnings to strprintf() and OutputDebugStringF()
2012-09-25 22:56:29 -07:00
Mark Friedenbach
95d7f00295
Documented bug in sign-extension behavior of opcodes OP_AND, OP_OR, and OP_XOR.
...
Due to a bug in the implementation of MakeSameSize(), using OP_AND, OP_OR, or OP_XOR with signed values of unequal size will result in the sign-value becoming part of the smaller integer, with nonsensical results. This patch documents the unexpected behavior and provides the basis of a solution should decision be made to fix the bug in the future.
2012-09-25 16:40:34 -07:00
Jeff Garzik
1381ad2b21
Merge pull request #1684 from jgarzik/bootstrap
...
Import $DataDir/bootstrap.dat automatically, if it exists.
2012-09-25 13:53:40 -07:00
Wladimir J. van der Laan
4d369ec30c
Update comment, we're no longer using boost::interprocess::scoped_lock
2012-09-25 12:16:37 +02:00
Wladimir J. van der Laan
1a52dd10a7
Merge pull request #1854 from Diapolo/fix_1843_V2
...
additional fix for #1843
2012-09-25 01:35:22 -07:00
kjj2
b202d43076
Fix: when testnet=1 specified, change default ports to 18332 and 18333
2012-09-24 15:26:04 -05:00
Jeff Garzik
22f9b06903
Send 'mempool' P2P command at the start of each P2P session
...
to query remote node mempool contents.
2012-09-24 13:53:44 -04:00
Jeff Garzik
52c90a2b2b
Import $DataDir/bootstrap.dat automatically, if it exists.
...
As discussed on IRC. Intended to make using an external blockchain download
solution just a bit easier.
2012-09-24 13:37:03 -04:00
Jeff Garzik
93dd68e924
P2P: Do not request blocks from peers with fewer blocks than us
...
If the remote node has a shorter chain, do not waste our
special getblocks request on them.
2012-09-24 13:26:09 -04:00
Wladimir J. van der Laan
feec18e329
Merge pull request #1836 from kjj2/stopdetach
...
Adds a stopdetach <detach> RPC command. <detach> defaults to true. Wor...
2012-09-23 05:49:42 -07:00
Wladimir J. van der Laan
49b09ec04f
Merge pull request #1853 from fanquake/qt-include
...
Update include for Qt5
2012-09-23 05:35:24 -07:00
kjj2
3731f5788e
Adds a stopdetach <detach> RPC command. <detach> defaults to true. Works just like stop, but overrides the commandline/config file
...
-detachdb option. Useful for upgrading, for example. Lets you use fast stops usually, but force a detach when needed. Also, allows
you to do a fast stop in a system normally configured for fast stops.
2012-09-22 18:17:29 -05:00
fanquake
ea9eaf9dec
Update Qt include
...
Update Qmenu include
This is to be more consistent with the rest of the source
Update Qt Includes
2012-09-22 18:56:22 +08:00
Wladimir J. van der Laan
2f91373a0a
Merge pull request #1852 from fanquake/bugreportlinks
...
Update links to Qt
2012-09-22 03:29:46 -07:00
Philip Kaufmann
bb86cffa56
additional fix for #1843
...
- a shortcut on "receive coins" was used twice
2012-09-22 12:15:41 +02:00
fanquake
e1eb3d4451
Update Bugreport Links
...
Update Qt Links
Revert Qt source link
Update Qt links
2012-09-22 18:05:25 +08:00
Wladimir J. van der Laan
f394f21594
Merge pull request #1844 from Diapolo/Qt5_compat1
...
enhance Qt5 compatibility
2012-09-22 02:21:06 -07:00
fanquake
0eaaa83ba5
Update Bitcoin to use OpenSSL 1.0.1c
...
Bump deps tp 0.0.5
Small docs corrections
2012-09-22 14:51:03 +08:00
Wladimir J. van der Laan
38682648c2
Remove unnecessary text from tooltip in AddressBookPage
2012-09-22 08:37:56 +02:00
Philip Kaufmann
da9413d913
fix #1843 by changing 2 GUI shortcuts
2012-09-21 19:31:53 +02:00
Philip Kaufmann
81605d90f5
enhance Qt5 compatibility
...
- replace Q_WS_MAC (not supported anymore in Qt5) with Q_OS_MAC (supported
in Qt4/5)
2012-09-21 19:06:53 +02:00
Wladimir J. van der Laan
e96a8c7d86
Merge pull request #1793 from Diapolo/fix_signed_unsigned_strprintf
...
fix signed/unsigned in strprintf and CNetAddr::GetByte()
2012-09-21 06:04:27 -07:00
Wladimir J. van der Laan
3ccbaa56f4
comment update: it's -> its
2012-09-21 14:15:26 +02:00
Wladimir J. van der Laan
1ba4925755
Merge pull request #1705 from Diapolo/cleanup_bitcoingui
...
Qt: re-order GUI code and remove FIRST_CLASS_MESSAGING
2012-09-20 23:08:52 -07:00
Wladimir J. van der Laan
2dca98511f
Merge pull request #1810 from laanwj/2012_09_rpcconsole_eventfilter
...
Improve RPC console key event behaviour
2012-09-20 23:02:52 -07:00
Pieter Wuille
58bc86e37f
Check for canonical public keys and signatures
...
Only enabled inside tests for now.
2012-09-21 01:24:25 +02:00
Gavin Andresen
f2b066da70
Update gitignore and Makefiles for build.h move from src/ to src/obj
2012-09-20 10:28:13 -04:00
Wladimir J. van der Laan
bfc24bd4ce
Merge pull request #1717 from Diapolo/Qt_change_TX_display
...
Qt: show mined transactions at depth 1
2012-09-20 00:42:31 -07:00
Gavin Andresen
6cbae37667
Merge branch 'testdata' of git://github.com/TheBlueMatt/bitcoin
2012-09-18 19:22:40 -04:00
Jeff Garzik
b1d3e95a0a
When rejected TX relay due to lack of fees, log full txid
2012-09-18 15:24:31 -04:00
Jeff Garzik
ea0796bde3
Trim trailing whitespace for src/*.{h,cpp}
2012-09-18 15:07:58 -04:00
Gavin Andresen
8b371316c5
Merge branch 'master' of github.com:bitcoin/bitcoin
2012-09-18 12:20:01 -04:00
Gavin Andresen
8f09e4cac4
Give makefiles 'test' and 'check' targets to compile and run unit tests
2012-09-18 12:18:51 -04:00
Jeff Garzik
f8c449b5c8
Merge pull request #1812 from jgarzik/misc-07
...
Two minor generic cleanups done during OP_DROP hacking
2012-09-18 09:14:53 -07:00
Gavin Andresen
a0971337d0
Merge branch 'refactor_times' of git://github.com/luke-jr/bitcoin
2012-09-18 10:59:31 -04:00
Gavin Andresen
5add0b0d0f
Bump client version to 0.7.0.99 now that 0.7.0 release is final.
2012-09-18 10:58:22 -04:00
Wladimir J. van der Laan
7fddf1210e
update comment, secure_allocator is defined in allocators.h
2012-09-15 12:10:00 +02:00
Philip Kaufmann
463a1cab43
fix signed/unsigned in strprintf and CNetAddr::GetByte()
...
- I checked every occurance of strprintf() in the code and used %u, where
unsigned vars are used
- the change to GetByte() was made, as ip is an unsigned char
2012-09-12 21:30:47 +02:00
Gavin Andresen
0a4e67afad
Bump client version number for 0.7.0rc3
2012-09-12 14:07:22 -04:00
Pieter Wuille
c1d79812f4
Do not abort if RPC listening for IPv6 fails
...
Instead, fall back to IPv4 listening.
2012-09-12 16:45:09 +02:00
Wladimir J. van der Laan
3b3d999618
Add format characters for (s)size_t and ptrdiff_t
2012-09-10 04:25:26 +02:00
Wladimir J. van der Laan
ac4e7f6269
HexStr: don't build a vector<char> first
...
Also const correctness for lookup tables in hex functions throughout the code.
2012-09-10 04:24:57 +02:00
Gregory Maxwell
ab91bf39b7
Apply BIP30 checks to all blocks except the two historic violations.
...
Matt pointed out some time ago that there existed a minor DOS
attack where a node in its initial block download could be wedged
by an overwrite attack in a fork created between checkpoints before
a time where BIP30 was enforced. Now that the BIP30 timestamp
is irreversibly past the check can be more aggressive and apply to
all blocks except the two historic violations.
2012-09-09 20:11:04 -04:00