Daniel Kraft
d0867acb0e
Use const CCoinsView's at some places.
...
At some places where it is possible (e. g., CheckInputs), use a const
version of CCoinsView instead of a non-const one.
2014-08-26 11:29:18 +02:00
Daniel Kraft
a3dc587a62
Make appropriate getter-routines "const" in CCoinsView.
...
Mark the "Get"/"Have" routines in CCoinsView and subclasses as "const".
2014-08-26 11:29:18 +02:00
Daniel Kraft
ffb4c210bc
Mark LevelDB "Read" and "Exists" functions as const.
...
Mark the "Read" and "Exists" functions in CLevelDBWrapper as "const".
They do not change anything in the DB, by definition.
2014-08-26 11:26:58 +02:00
Pieter Wuille
92bb6f2f17
Bypass reloading blocks from disk
2014-08-26 02:26:41 +02:00
Wladimir J. van der Laan
49f954f154
Merge pull request #4716
...
0d27dad
2014-08-25 15:04:28 +02:00
Wladimir J. van der Laan
26f3a05cf1
Merge pull request #4654
...
c4a7709
2014-08-25 13:44:41 +02:00
Wladimir J. van der Laan
11270ebde4
Merge pull request #4351
...
da2ec10
2014-08-25 10:37:40 +02:00
Peter Todd
aa41ac216e
Test IsPushOnly() with invalid push
2014-08-24 21:16:51 -04:00
Pieter Wuille
fff7455ded
Make CScript::clear() release its memory
2014-08-24 02:08:33 +02:00
Pieter Wuille
b0875eb3fe
Allow BatchWrite to destroy its input, reducing copying
2014-08-24 02:08:33 +02:00
Pieter Wuille
5cd00bc8cb
Merge pull request #4618
...
eb0b56b
2014-08-24 02:06:09 +02:00
Jeff Garzik
57fe1eaadc
Merge pull request #4632
2014-08-23 12:59:55 -04:00
jtimon
654871d436
replace ComputeMinWork with CheckMinWork
2014-08-23 13:21:51 +02:00
jtimon
b343c1a1e3
Move CBlockIndex::GetBlockWork() to pow::GetProofIncrement(nBits)
2014-08-23 13:21:51 +02:00
jtimon
c2c02f3fa9
Move UpdateTime to pow
2014-08-23 13:21:50 +02:00
Wladimir J. van der Laan
92b3d3630d
Merge pull request #4718
...
88fe88c
2014-08-23 09:30:47 +02:00
Jeff Garzik
fac54dcb71
Merge pull request #4733
2014-08-22 10:35:39 -04:00
Wladimir J. van der Laan
93ed3d9b4e
Merge pull request #4735
...
38022249b6d4c58121258
2014-08-21 16:05:47 +02:00
Wladimir J. van der Laan
56953925db
Merge pull request #4706
...
8695a39
2014-08-21 08:51:19 +02:00
Jeff Garzik
9c31174992
Merge pull request #4744
2014-08-20 23:16:21 -04:00
Jeff Garzik
7f836c66bd
rpc_tests: use BOOST_CHECK_EQUAL
...
Upon failure, BOOST_CHECK_EQUAL provides additional diagnostic information,
displaying that data that failed to match.
2014-08-20 22:43:36 -04:00
Wladimir J. van der Laan
3802224110
Remove all other print() methods
...
All unused.
2014-08-20 20:54:27 +02:00
Wladimir J. van der Laan
9b6d4c5cdc
Move strprintf define to tinyformat.h
...
This avoids a dependency on util.h if just tinyformat is needed.
2014-08-20 10:51:18 +02:00
Wladimir J. van der Laan
81212588c0
Remove print() from core functions
...
Break dependency on util.
2014-08-20 10:43:47 +02:00
Jeff Garzik
dc271fc025
UniValue tests: use more BOOST_CHECK()
2014-08-20 01:09:21 -04:00
Jeff Garzik
e85267be63
UniValue: add unit tests
2014-08-20 00:28:46 -04:00
Jeff Garzik
dee9324a0b
UniValue: compact (!pretty) output should not include extra whitespace
2014-08-20 00:27:49 -04:00
Jeff Garzik
42642c9695
UniValue: use correct setNumStr() input val, when setting number values
2014-08-20 00:27:42 -04:00
Jeff Garzik
df4d61e681
Add bitcoin-tx tests
...
Testing: delin, delout, locktime, and basic createrawtransaction-like
functionality.
2014-08-19 23:15:58 -04:00
Gavin Andresen
335e3a5c95
Merge pull request #4717 from cozz/cozz8
...
[Qt] Revert overviewpage from QFormLayout to QVBoxLayout
2014-08-19 13:37:25 -04:00
Gavin Andresen
10dcbc1be0
Merge pull request #4728 from laanwj/2014_08_rpcserver_password_delay
...
Don't reveal whether password is <20 or >20 characters in RPC
2014-08-19 13:32:40 -04:00
Jeff Garzik
fb14452c6c
bitcoin-tx: Accept input via stdin. Add input handling to tests.
2014-08-19 10:29:10 -04:00
Jeff Garzik
d789386371
Add "it works" test for bitcoin-tx
2014-08-19 10:28:58 -04:00
Wladimir J. van der Laan
01094bd01f
Don't reveal whether password is <20 or >20 characters in RPC
...
As discussed on IRC.
It seems bad to base a decision to delay based on the password length,
as it leaks a small amount of information.
2014-08-19 14:40:34 +02:00
Wladimir J. van der Laan
dd2819701a
Merge pull request #4670
...
a35b55b1e21c17
2014-08-19 12:23:56 +02:00
Wladimir J. van der Laan
c5a91216ae
Merge pull request #4672
...
22b3c4b
2014-08-19 11:00:43 +02:00
Wladimir J. van der Laan
691e9d28b5
Merge pull request #4725
...
e432a5f
2014-08-19 10:54:35 +02:00
Jeff Garzik
0367329549
Merge branch '2014_univalue_warn' into merge-PR4715
...
Merge pull request #4715
2014-08-19 00:49:31 -04:00
Jeff Garzik
3a56de7fc3
addrman: Do not propagate obviously poor addresses onto the network
2014-08-18 16:50:39 -04:00
Cory Fields
e432a5f08d
build: add option for reducing exports (v2)
...
This was committed previously as 4975ae172https://svn.boost.org/trac/boost/ticket/2309
Also, check for a default visibility attribute, so that we can mark future
api functions correctly.
2014-08-18 16:10:15 -04:00
Kamil Domanski
8695a39350
replace int with size_t in stream methods
...
Thus the read(...) and write(...) methods of all stream classes now have identical parameter lists.
This will bring these classes one step closer to a common interface.
2014-08-18 20:23:13 +02:00
Wladimir J. van der Laan
a4f151f714
Merge pull request #4704
...
54c7df8
2014-08-18 20:17:58 +02:00
Wladimir J. van der Laan
fad23a210b
Revert "build: add option for reducing exports"
...
Revert #4663 for now. It still breaks the pulltester.
This reverts commit 4975ae1722
2014-08-18 16:52:56 +02:00
Jeff Garzik
3cceba7abb
Univalue: Do not build JSON escape list at runtime
...
No need to waste startup time building something that can be done
at compile time.
This also resolves a clang++ warning originally reported in #4714 ,
univalue/univalue_write.cpp:33:12: warning: array subscript is of type 'char
escapes['"'] = "\\"";
^~~~
etc.
2014-08-18 10:36:21 -04:00
Wladimir J. van der Laan
e4731dd85c
qt: Use quint64 for formatServicesStr
...
`uint64_t` was causing a build error on some systems, as that type is
not known after including just the Qt headers.
2014-08-18 16:21:27 +02:00
Wladimir J. van der Laan
04d6c7d10c
Merge pull request #4605
...
aa82795075cf49c91a94760dc8e4
2014-08-18 13:37:54 +02:00
Wladimir J. van der Laan
aa8279513b
Add detailed network info to getnetworkinfo RPC
...
This commit adds per-network information to the
getnetworkinfo RPC call:
- Is the network limited?
- Is the network reachable
- Which proxy is used for this network, if any
Inspired by #2575 .
2014-08-18 13:36:10 +02:00
Wladimir J. van der Laan
88fe88cf36
gui: remove redundant numTransactions tracking
...
This number was still tracked even though it's shown nowhere in the UI
anymore. It was originally removed because it didn't match the actual number of
records in the view (which contains outputs, not transactions) thus was
confusing people.
2014-08-18 10:28:26 +02:00
Wladimir J. van der Laan
21e7a5690f
Merge pull request #4655
...
216e9a4
2014-08-18 09:55:24 +02:00
Cozz Lovan
cb5fa86f42
[Qt] Revert overviewpage from QFormLayout to QVBoxLayout
2014-08-17 23:50:44 +02:00
Cozz Lovan
0d27dad845
Clean-up SyncWithWallets/SyncTransaction
2014-08-17 17:39:30 +02:00
randy-waterhouse
c101c76907
build: Add --with-utils (bitcoin-cli and bitcoin-tx, default=yes).
...
Help string consistency tweaks. Target sanity check fix.
2014-08-17 20:22:12 +12:00
Wladimir J. van der Laan
b3ec053082
Merge pull request #4656
...
5cbda4f
2014-08-17 10:18:16 +02:00
Wladimir J. van der Laan
2eb3c85c9a
Merge pull request #4663
...
4975ae1
2014-08-17 09:29:59 +02:00
Ross Nicoll
5cbda4f10f
Changed LevelDB cursors to use scoped pointers to ensure destruction when going out of scope.
...
This corrects a bug where an exception thrown reading from the database causes the cursor to
be left open, which causes an assertion error to occur when the database is deleted (around
line 938 of init.cpp).
2014-08-16 15:27:18 +01:00
randy-waterhouse
a65668ddc0
build : fix CPPFLAGS for libbitcoin_cli
2014-08-16 10:56:28 +12:00
Cory Fields
4975ae1722
build: add option for reducing exports
...
Enabled automatically if boost >= 1.49.
See: https://svn.boost.org/trac/boost/ticket/2309
Also, check for a default visibility attribute, so that we can mark future
api functions correctly.
2014-08-15 17:42:53 -04:00
Cory Fields
54c7df81f3
build: Fix boost build on some platforms
...
When the libpath doesn't line up with the value from config.sub, we don't find
the correct path to boost's libs. This adds a hack to try another path before
giving up.
Should close #3219 .
2014-08-15 12:20:15 -04:00
Wladimir J. van der Laan
984ff68c67
Merge pull request #4638
...
6f2c26a
2014-08-15 14:09:33 +02:00
Cory Fields
6b099402b4
build: fix automake warnings about the use of INCLUDES
...
While we're at it, reduce the use of LIBS as well. This makes dependencies
explicit.
Fixes building with (the not-yet-merged) libsecp256k1 as well.
Github-Pull: #4689
Rebased-By: Wladimir J. van der laan <laanwj@gmail.com>
Rebased-From: 909b347 c0e5dda
2014-08-15 10:42:10 +02:00
Jeff Garzik
6f2c26a457
Closely track mempool byte total. Add "getmempoolinfo" RPC.
...
Goal: Gain live insight into the mempool. Groundwork for future work
that caps mempool size.
2014-08-14 12:34:38 -04:00
Jeff Garzik
c7b6117deb
Create new signal for notification of new blocks. Use w/ -blocknotify
2014-08-14 12:32:34 -04:00
Jeff Garzik
beb36e800c
ui_interface: remove unused NotifyBlocksChanged signal
2014-08-14 12:19:54 -04:00
Wladimir J. van der Laan
7accb7dbad
Merge pull request #4659
...
c4bae53
2014-08-14 15:52:01 +02:00
Cory Fields
616c24307f
bitcoin-tx: fix build warnings
...
Cleans up a bunch of:
warning: missing braces around initializer for ‘const<anonymous struct>’
2014-08-13 11:57:47 -04:00
Peter Todd
9ee09dc64f
Reapply: Reject transactions with excessive numbers of sigops
...
Reverting was based on a misunderstanding, it appears.
Github-Pull: #4150
2014-08-13 14:37:56 +02:00
Wladimir J. van der Laan
ce094d83ce
Merge pull request #4682
...
c33b983
2014-08-13 12:01:03 +02:00
Wladimir J. van der Laan
c33b983903
Don't poll showmyip.com, it doesn't exist anymore
...
Fixes #4679 .
This leaves us with only one candidate, checkip.dyndns.org.
GetMyExternalIP should be phased out as soon as possible.
2014-08-13 12:00:30 +02:00
Wladimir J. van der Laan
3b72fdfb86
Revert "Reject transactions with excessive numbers of sigops"
...
This reverts commit 4fad8e6d83
2014-08-12 15:06:20 +02:00
Wladimir J. van der Laan
8ebe42435a
Merge pull request #4150
...
4fad8e6
2014-08-12 14:57:13 +02:00
Wladimir J. van der Laan
e257b7c4c4
Merge pull request #4675
...
ea100c7
2014-08-12 14:40:59 +02:00
ntrgn
8bfdc9acaa
qt: better looking trayicon
...
Github-Pull: #4678
Rebased-By: Wladimir J. van der Laan <laanwj@gmail.com>
2014-08-12 13:16:01 +02:00
Wladimir J. van der Laan
4c61ba40b9
build: check for sys/prctl.h in the proper way
...
Use AC_CHECK_HEADERS to check for the header, and include it only
if detected and the subsequent HAVE_SYS_PRCTL_H is set.
2014-08-12 13:04:55 +02:00
Wladimir J. van der Laan
76c49c4138
Fix thread name setting
...
Because of a typo, thread names no longer appeared in the overview.
This was broken in 51ed9ec
2014-08-12 12:24:04 +02:00
Wladimir J. van der Laan
a38a98c476
Merge pull request #4603
...
f0c2915
2014-08-12 11:21:10 +02:00
Wladimir J. van der Laan
a63e86e01d
Merge pull request #4680
...
a381ee5
2014-08-12 08:35:33 +02:00
jtimon
a381ee5d1c
Remove unnecessary typedef and script.h include
2014-08-12 02:17:29 +02:00
jtimon
54e658f249
Remove unused CKeyStoreIsMineVisitor
2014-08-12 02:02:17 +02:00
Cozz Lovan
1c5f0af0fd
[Qt] Add column Watch-only to transactions list
2014-08-11 21:38:36 +02:00
Cozz Lovan
939ed97373
Add boolean HaveWatchonly and signal NotifyWatchonlyChanged
2014-08-11 18:47:02 +02:00
Wladimir J. van der Laan
d17ce77fc1
Merge pull request #4664
...
565e5698021cf8
2014-08-11 17:32:27 +02:00
Cozz Lovan
6b5b7cbfb4
Categorize rpc help overview
...
Conflicts:
src/rpcserver.cpp
Github-Pull: #4539
Rebased-By: Wladimir J. van der Laan <laanwj@gmail.com>
Rebased-From: df3d321
2014-08-11 16:20:40 +02:00
Wladimir J. van der Laan
fecab8773d
Merge pull request #4666
...
ab45ddb
2014-08-11 15:07:24 +02:00
Wladimir J. van der Laan
3e089a00e7
Merge pull request #4668
...
9297763
2014-08-11 15:06:43 +02:00
Wladimir J. van der Laan
85af3856e7
Merge pull request #4622
...
c7f3876
2014-08-11 15:06:19 +02:00
Wladimir J. van der Laan
ea96475d23
build: Add mention of --disable-wallet to bdb48 error messages
2014-08-11 14:42:02 +02:00
Mike Hearn
da2ec100f3
Add a getutxos command to the p2p protocol. It allows querying of the UTXO set
...
given a set of outpoints.
2014-08-11 13:59:47 +02:00
Wladimir J. van der Laan
ea100c73fa
Reduce maximum coinscache size during verification
...
Due to growing coinsviewcaches, the memory usage with checklevel=3
(and standard settings for dbcache) could be up to 500MiB on a
64-bit system. This is about twice the peak during reindexing,
unnecessarily extending bitcoind's memory envelope.
This commit reduces the maximum total size of the caches used during
verification to just nCoinCacheSize, which should be the limit.
2014-08-11 08:43:06 +02:00
Matt Corallo
a35b55b522
Dont run full check every time we decrypt wallet.
2014-08-10 18:36:07 -07:00
Gregory Maxwell
1e21c17d20
Make CCryptoKeyStore::Unlock check all keys.
...
CCryptoKeyStore::Unlock has a loop to attempt decrypting each key which
only executes once, likely due to a simple mistake when the code was
originally written.
This patch fixes the behavior by making it check all keys. It also adds
a fatal assertion in the case some decrypt but some do not, since that
indicates that the wallet is in some kind of really bad state.
This may make unlocking noticeably slower on wallets with many keys.
2014-08-10 18:36:06 -07:00
Philip Kaufmann
22b3c4bbbd
remove unused class CAddrMan; from db.h
2014-08-10 14:30:30 +02:00
Cozz Lovan
9297763dad
[Qt] Add TRY_LOCK back to peertablemodel
2014-08-10 02:28:23 +02:00
Derek701
ab45ddb599
Fix typo in gettransaction help
2014-08-08 23:13:06 -05:00
Pieter Wuille
eb0b56b190
Simplify serialize.h's exception handling
...
Remove the 'state' and 'exceptmask' from serialize.h's stream implementations,
as well as related methods.
As exceptmask always included 'failbit', and setstate was always called with
bits = failbit, all it did was immediately raise an exception. Get rid of
those variables, and replace the setstate with direct exception throwing
(which also removes some dead code).
As a result, good() is never reached after a failure (there are only 2
calls, one of which is in tests), and can just be replaced by !eof().
fail(), clear(n) and exceptions() are just never called. Delete them.
2014-08-09 01:43:23 +02:00
Pieter Wuille
216e9a4456
Add a way to limit deserialized string lengths
...
and use it for most strings being serialized.
2014-08-09 01:37:16 +02:00
Cory Fields
565e569772
libc-compat: add new symbol that's now needed
2014-08-08 15:21:50 -04:00
Ross Nicoll
c7f3876d4a
URLs containing a / after the address no longer cause parsing errors.
2014-08-08 19:10:35 +01:00
Philip Kaufmann
b197bf3270
[Qt] disable tray interactions when client model set to 0
...
- this prevents the ability to fiddle around with the system tray when
already shutting down (e.g. on slow shutdowns because of a proxy delay)
- extends solution for #4360
2014-08-08 12:13:39 +02:00
Philip Kaufmann
314fbd9ac7
[Qt] use BitcoinGUI::DEFAULT_WALLET constant in bitcoin.cpp
2014-08-08 12:13:27 +02:00
Philip Kaufmann
8ca6a16176
[Qt] ensure all class attributes are init to 0
...
- in BitcoinGUI and UnitDisplayStatusBarControl
2014-08-08 12:13:26 +02:00
