Russell Yanofsky
6bee150e8e
Require timestamps for importmulti keys
...
Additionally, accept a "now" timestamp, to allow avoiding rescans for keys
which are known never to have been used.
Note that the behavior when "now" is specified is slightly different than the
previous behavior when no timestamp was specified at all. Previously, when no
timestamp was specified, it would avoid rescanning during the importmulti call,
but set the key's nCreateTime value to 1, which would not prevent future block
reads in later ScanForWalletTransactions calls. With this change, passing a
"now" timestamp will set the key's nCreateTime to the current block time
instead of 1.
Fixes #9491
2018-01-21 14:14:34 +01:00
Wladimir J. van der Laan
edf3a00a29
Merge #9638 : qa: Actually test assertions in pruning.py
...
fab035f qa: Actually test assertions in pruning.py (MarcoFalke)
2018-01-21 12:48:34 +01:00
MarcoFalke
5a84b27dc1
Merge #9628 : qa: Increase a sync_blocks timeout in pruning.py
...
2f10f06 qa: Increase a sync_blocks timeout in pruning.py (Suhas Daftuar)
2018-01-21 12:48:34 +01:00
Wladimir J. van der Laan
119c3fe62f
Merge #9516 : Bug-fix: listsinceblock: use fork point as reference for blocks in reorg'd chains
...
7ba0a00 Testing: listsinceblock should not use orphan block height. (Karl-Johan Alm)
ee5c1ce Bug-fix: listsinceblock: use closest common ancestor when a block hash was provided for a chain that was not the main chain. (Karl-Johan Alm)
2018-01-21 12:48:33 +01:00
Wladimir J. van der Laan
96b4910fbe
Merge #9607 : Remove redundant semicolons in Python code
...
5cdf106 Remove redundant semicolons in Python code (practicalswift)
2018-01-21 12:48:33 +01:00
Wladimir J. van der Laan
36109e0580
Merge #9377 : fundrawtransaction: Keep change-output keys by default, make it optional
...
c9f3062 Add fundrawtransactions new reserveChangeKey option to the release notes (Jonas Schnelli)
9eb325d [QA] Add test for fundrawtransactions new reserveChangeKey option (Jonas Schnelli)
9aa4e6a [Wallet] Add an option to keep the change address key, true by default (Jonas Schnelli)
2018-01-21 12:48:33 +01:00
MarcoFalke
be63fb7953
Merge #9508 : Remove unused Python imports
...
95bab82 Remove unused Python imports (practicalswift)
2018-01-21 12:48:33 +01:00
Alexander Block
2adb35533f
Add assumevalid testcase
...
Missed in original backport of assumevalid
2018-01-21 12:48:33 +01:00
Wladimir J. van der Laan
4408b2d147
Merge #9222 : Add 'subtractFeeFromAmount' option to 'fundrawtransaction'.
...
453bda6 Add 'subtractFeeFromOutputs' option to 'fundrawtransaction'. (Chris Moore)
2018-01-21 12:48:32 +01:00
MarcoFalke
cee8cf1be6
Merge #9518 : Return height of last block pruned by pruneblockchain RPC
...
918d1fb Return height of last block pruned by pruneblockchain RPC (Russell Yanofsky)
2018-01-21 12:48:32 +01:00
Wladimir J. van der Laan
88b9aa45de
Merge #7871 : Manual block file pruning.
...
afffeea fixup! Add pruneblockchain RPC to enable manual block file pruning. (Russell Yanofsky)
1fc4ec7 Add pruneblockchain RPC to enable manual block file pruning. (mrbandrews)
2018-01-21 12:48:32 +01:00
Wladimir J. van der Laan
7321bfdd6b
Merge #8391 : Consensus: Remove ISM
...
122786d Consensus: Remove ISM (NicolasDorier)
2018-01-20 09:22:40 +01:00
Wladimir J. van der Laan
0fc37e8c56
Merge #7562 : Bump transaction version default to 2
...
c5c92c4 Update python tests for default tx version=2 (BtcDrak)
dab207e Preserve tx version=1 for certain tests (BtcDrak)
c5d746a tiny test fix for mempool_tests (Alex Morcos)
1f0ca1a Bump default transaction version to 2 (BtcDrak)
2018-01-20 09:22:38 +01:00
Pieter Wuille
3235aad493
Implement SipHash in Python
2018-01-20 09:21:13 +01:00
Alexander Block
29d5bdb55c
Fix import-rescan.py test
2018-01-18 07:38:58 +01:00
Wladimir J. van der Laan
eb7a6b08f1
Merge #8811 : rpc: Add support for JSON-RPC named arguments
...
4e7e2e1 Update RPC argument names (John Newbery)
481f289 rpc: Named argument support for bitcoin-cli (Wladimir J. van der Laan)
9adb4e1 rpc: Argument name consistency (Wladimir J. van der Laan)
8d713f7 rpc: Named arguments for rawtransaction calls (Wladimir J. van der Laan)
37a166f rpc: Named arguments for wallet calls (Wladimir J. van der Laan)
78b684f rpc: Named arguments for mining calls (Wladimir J. van der Laan)
b8ebc59 rpc: Named arguments for net calls (Wladimir J. van der Laan)
2ca9dcd test: Add test for RPC named arguments (Wladimir J. van der Laan)
fba1a61 rpc: Named arguments for misc calls (Wladimir J. van der Laan)
286ec08 rpc: Add 'echo' call for testing (Wladimir J. van der Laan)
495eb44 rpc: Named arguments for blockchain calls (Wladimir J. van der Laan)
6f1c76a rpc: Support named arguments (Wladimir J. van der Laan)
5865d41 authproxy: Add support for RPC named arguments (Wladimir J. van der Laan)
2018-01-18 07:38:57 +01:00
MarcoFalke
d2a8ecc8db
Merge #9395 : Add test for -walletrejectlongchains
...
ffeb195 add test for -walletrejectlongchains (Alex Morcos)
2018-01-18 07:33:44 +01:00
Wladimir J. van der Laan
dc1df137e3
Merge #9262 : Prefer coins that have fewer ancestors, sanity check txn before ATMP
...
cee1612 reduce number of lookups in TransactionWithinChainLimit (Gregory Sanders)
af9bedb Test for fix of txn chaining in wallet (Gregory Sanders)
5882c09 CreateTransaction: Don't return success with too-many-ancestor txn (Gregory Sanders)
0b2294a SelectCoinsMinConf: Prefer coins with fewer ancestors (Gregory Sanders)
2018-01-18 07:31:22 +01:00
Wladimir J. van der Laan
bf3cc9ff90
Merge #9331 : [qa] Add test for rescan feature of wallet key import RPCs
...
d8c0b9f [qa] Add test for rescan feature of wallet key import RPCs (Russell Yanofsky)
2018-01-18 07:31:22 +01:00
MarcoFalke
c0b0ae8be4
Merge #9309 : [qa] Wallet needs to stay unlocked for whole test
...
9359f8a Wallet needs to stay unlocked for whole test (Alex Morcos)
2018-01-17 17:31:12 +01:00
Alexander Block
7322489ca2
Merge #9276 : Some minor testing cleanups
...
30b620c remove obsolete run-bitcoind-for-test.sh (Alex Morcos)
2a99522 remove relaypriority from rpc tests (Alex Morcos)
e2184cc Reorder RPC tests for running time (Alex Morcos)
# Conflicts:
# qa/pull-tester/rpc-tests.py
# qa/pull-tester/run-bitcoind-for-test.sh.in
2018-01-17 17:31:12 +01:00
MarcoFalke
19958fecf9
Merge #9274 : [qa] Use cached utxo set to fix performance regression
...
fab1af3 [qa] maxuploadtarget: Use cached utxo set (MarcoFalke)
fa2ecc4 [qa] pruning: Use cached utxo set to run faster (MarcoFalke)
2018-01-17 17:31:12 +01:00
MarcoFalke
5d1f05afff
Merge #9221 : [qa] Get rid of duplicate code
...
facbfa5 [qa] Get rid of duplicate code (MarcoFalke)
2018-01-17 17:30:38 +01:00
MarcoFalke
5e09f275e2
Merge #9257 : [qa] Dump debug logs on travis failures.
...
0828619 [qa] Dump debug logs on travis failures. (Suhas Daftuar)
2018-01-17 17:30:38 +01:00
MarcoFalke
df24dfd4bc
Merge #9233 : Fix some typos
...
15fa95d Fix some typos (fsb4000)
2018-01-17 17:27:24 +01:00
MarcoFalke
f831710f46
Merge #9139 : Change sync_blocks to pick smarter maxheight (on top of #9196 )
...
1126c85 [qa] Change sync_blocks to pick smarter maxheight (Russell Yanofsky)
2018-01-17 17:25:36 +01:00
Alexander Block
9170c0e9c3
Fix rpc tests
...
1. Missing TX fees in some tests. No-fee transactions stopped working because
the free TX relay was set to 0
2. rawtransaction tests used "hash" instead of "txid". "hash" is only valid
if SegWit changes are included.
2018-01-15 08:26:15 +01:00
Wladimir J. van der Laan
ce3f38d6ca
Merge #9025 : getrawtransaction should take a bool for verbose
...
240189b add testcases for getrawtransaction (John Newbery)
ce2bb23 getrawtransaction should take a bool for verbose (jnewbery)
2018-01-15 06:14:16 +01:00
Wladimir J. van der Laan
e5cc7d0eb4
Merge #8872 : Remove block-request logic from INV message processing
...
037159c Remove block-request logic from INV message processing (Matt Corallo)
3451203 [qa] Respond to getheaders and do not assume a getdata on inv (Matt Corallo)
d768f15 [qa] Make comptool push blocks instead of relying on inv-fetch (mrbandrews)
2018-01-15 06:14:16 +01:00
MarcoFalke
a9a2db9a53
Merge #9168 : [qa] add assert_raises_message to check specific error message
...
307acdd [qa] add assert_raises_message to check specific error message (mrbandrews)
2018-01-15 06:14:16 +01:00
Wladimir J. van der Laan
e711f4ae23
Merge #9151 : [qa] proxy_test: Calculate hardcoded port numbers
...
fa80ef8 [qa] proxy_test: Calculate hardcoded port numbers instead (MarcoFalke)
2018-01-15 06:14:16 +01:00
MarcoFalke
12883cfe4d
Merge #9136 : sync_blocks cleanup
...
7943b13 [qa] Avoid 2 list comprehensions in sync_blocks (Russell Yanofsky)
05e57cc [qa] Fix sync_blocks timeout argument (Russell Yanofsky)
fd6bb70 [qa] Improve sync_blocks error messages. (Russell Yanofsky)
2018-01-15 06:14:16 +01:00
MarcoFalke
3a388d9c01
Merge #9097 : [qa] Rework sync_* and preciousblock.py
...
fa97ccb [qa] util: Rework sync_*() (MarcoFalke)
fac1141 [qa] preciousblock: Use assert_equal and BitcoinTestFramework.__init__ (MarcoFalke)
2018-01-15 06:14:15 +01:00
Wladimir J. van der Laan
56ed800843
Merge #8894 : [Testing] Include fRelay in mininode version messages
...
e5d682f Fix mininode version message format (jnewbery)
2018-01-15 06:14:15 +01:00
Wladimir J. van der Laan
1121f2f951
Merge #9098 : [qa] Handle zombies and cluttered tmpdirs
...
fab0f07 [qa] rpc-tests: Apply random offset to portseed (MarcoFalke)
fae19aa [qa] test_framework: Exit when tmpdir exists (MarcoFalke)
2018-01-15 06:14:15 +01:00
MarcoFalke
3d7bb9cf55
Merge #9077 : [qa] Increase wallet-dump RPC timeout
...
e89614b [qa] Add more helpful RPC timeout message (Russell Yanofsky)
8463aaa [qa] Increase wallet-dump RPC timeout (Russell Yanofsky)
2018-01-15 06:14:11 +01:00
Wladimir J. van der Laan
9d661f4337
Merge #8675 : Make copyright header lines uniform
...
4b04e32 [copyright] copyright header style uniform (isle2983)
2018-01-13 13:44:39 +01:00
Wladimir J. van der Laan
efded3ca9c
Merge #7551 : Add importmulti RPC call
...
215caba Add consistency check to RPC call importmulti (Pedro Branco)
cb08fdb Add importmulti rpc call (Pedro Branco)
2018-01-13 13:44:37 +01:00
Wladimir J. van der Laan
dc9556a890
Merge #7948 : RPC: augment getblockchaininfo bip9_softforks data
...
fc14609 RPC: augment getblockchaininfo bip9_softforks data (mruddy)
2018-01-13 13:44:37 +01:00
Wladimir J. van der Laan
6e871c0c2e
Merge #6996 : Add preciousblock RPC
...
5805ac8 Add preciousblock tests (Pieter Wuille)
5127c4f Add preciousblock RPC (Pieter Wuille)
2018-01-12 09:58:15 +01:00
MarcoFalke
23ac000008
Merge #8860 : [qa] util: Move wait_bitcoinds() into stop_nodes()
...
fa7c35c [qa] util: Move wait_bitcoinds() into stop_nodes() (MarcoFalke)
2018-01-12 09:57:56 +01:00
MarcoFalke
16532f8ee0
Merge #8857 : [qa] mininode: Only allow named args in wait_until
...
fa66609 [qa] mininode: Only allow named args in wait_until (MarcoFalke)
2018-01-12 09:57:56 +01:00
Wladimir J. van der Laan
6b1842af87
Merge #8839 : test: Avoid ConnectionResetErrors during RPC tests
...
1d28faf test: Avoid ConnectionResetErrors during RPC tests (Wladimir J. van der Laan)
2018-01-12 09:56:54 +01:00
Wladimir J. van der Laan
942fe0ed49
Merge #8840 : test: Explicitly set encoding to utf8 when opening text files
...
30930e8 test: Explicitly set encoding to utf8 when opening text files (Wladimir J. van der Laan)
2018-01-12 09:56:53 +01:00
Wladimir J. van der Laan
e6af218659
Merge #8834 : [qa] blockstore: Switch to dumb dbm
...
fa9cd25 [qa] blockstore: Switch to dumb dbm (MarcoFalke)
2018-01-12 09:56:53 +01:00
MarcoFalke
cf4bdab3b5
Merge #8827 : [qa] Split up slow RPC calls to avoid pruning test timeouts
...
a0f8482 [qa] Split up slow RPC calls to avoid pruning test timeouts (Suhas Daftuar)
2018-01-12 08:02:45 +01:00
Alexander Block
205ff3519e
Fix wallet.py test by redirecting stderr to stdout
...
Changes in start_node args result in warnings being printed to stderr
2018-01-11 14:47:10 +01:00
Wladimir J. van der Laan
acf0295014
Merge #8810 : tests: Add exception error message for JSONRPCException
...
42f6aed tests: Add exception error message for JSONRPCException (Wladimir J. van der Laan)
2018-01-11 13:22:22 +01:00
Wladimir J. van der Laan
0028dbfbfd
Merge #8780 : [rpc] Deprecate getinfo
...
fa6e71b [qa] Add getinfo smoke tests and rework versionbits test (MarcoFalke)
ddddaaf [rpc] Deprecate getinfo (MarcoFalke)
2018-01-11 13:22:22 +01:00
MarcoFalke
7f4439fa63
Merge #8789 : [qa] pull-tester: Only print output when failed
...
fa427ce [qa] pull-tester: Only print output when failed (MarcoFalke)
2018-01-11 13:22:22 +01:00