UdjinM6
94e891c020
Merge pull request #1842 from codablock/pr_backport_bitcoin_0.14-2
...
Backport missing PRs from Bitcoin 0.14 - Part 2
2018-01-11 04:58:52 +03:00
Alexander Block
c2de362b98
Actually honor fMiningRequiresPeers in getblocktemplate ( #1844 )
...
MiningRequiresPeers() was not used at all. I checked the Bitcoin
code and even there it is set but then ignored. Updated getblocktemplate
to actually honor the value.
The check also removes the need for IsInitialBlockDownload() to be false.
As regtest nodes start with an empty chain they won't be able to use
getblocktemplate for mining otherwise.
2018-01-10 15:22:00 +03:00
Alexander Block
81fb931fb8
Don't delay GETHEADERS when no blocks have arrived yet in devnet ( #1807 )
...
When the first mined block arrives from another node on devnet, we have to
send GETHEADERS immediately as we otherwise will never leave the IBD mode.
2018-01-10 15:20:08 +03:00
Wladimir J. van der Laan
fdd0638161
Merge #8928 : Fix init segfault where InitLoadWallet() calls ATMP before genesis
...
37aefff Fix init segfault where InitLoadWallet() calls ATMP before genesis (Matt Corallo)
2018-01-09 17:23:39 +01:00
Pieter Wuille
3baee7ba24
Merge #8681 : Performance Regression Fix: Pre-Allocate txChanged vector
...
ec81881 Performance Regression Fix: Pre-Allocate txChanged vector (Jeremy Rubin)
2018-01-09 14:16:39 +01:00
Wladimir J. van der Laan
0324fa0121
Merge #8677 : Do not shadow upper local variable 'send', prevent -Wshadow compiler warning.
...
125b946 Do not shadow upper local variable 'send', prevent -Wshadow compiler warning. (Pavel Janík)
2018-01-09 14:16:39 +01:00
Wladimir J. van der Laan
c2a601f507
Merge #8680 : Address Travis spurious failures
...
d6a5dc4 add waitfornewblock/waitforblock/waitforblockheight rpcs and use them for tests (Cory Fields)
2018-01-09 14:16:39 +01:00
MarcoFalke
3d26438bec
Merge #8673 : Trivial: Fix obvious assignment/equality error in test
...
426e7bc Fix obvious assignment/equality error in test (Jeremy Rubin)
2018-01-09 14:16:39 +01:00
Pieter Wuille
f7e9bc613a
Merge #8606 : Fix some locks
...
144ed76 Fix some locks (Pieter Wuille)
2018-01-09 14:16:38 +01:00
Wladimir J. van der Laan
75f920e897
Merge #8663 : trivial: remove unnecessary variable fDaemon
...
ff2ed7a trivial: remove unnecessary variable fDaemon (mruddy)
2018-01-09 14:16:38 +01:00
Wladimir J. van der Laan
313cfb09da
Merge #8466 : [Trivial] Do not shadow variables in networking code
...
b7c349d Do not shadow variables in networking code (Pavel Janík)
2018-01-09 14:16:38 +01:00
Wladimir J. van der Laan
414272af93
Merge #8629 : C++11: s/boost::scoped_ptr/std::unique_ptr/
...
cdd79eb C++11: s/boost::scoped_ptr/std::unique_ptr/ (Jorge Timón)
2018-01-09 14:16:38 +01:00
Wladimir J. van der Laan
4d0be42c6e
Merge #8272 : Make the dummy argument to getaddednodeinfo optional
...
854f1af Make the dummy argument to getaddednodeinfo optional (Pieter Wuille)
2018-01-09 14:16:38 +01:00
Wladimir J. van der Laan
bc91f34da6
Merge #8638 : rest.cpp: change HTTP_INTERNAL_SERVER_ERROR to HTTP_BAD_REQUEST
...
f012a85 rest.cpp: change HTTP_INTERNAL_SERVER_ERROR to HTTP_BAD_REQUEST (djpnewton)
2018-01-09 14:16:38 +01:00
Wladimir J. van der Laan
88fcf3fbd2
Merge #8191 : Do not shadow variables in src/wallet
...
b175cb7 Do not shadow variables. (Pavel Janík)
2018-01-09 14:16:37 +01:00
Wladimir J. van der Laan
5ce7ba6115
Merge #8291 : [util] CopyrightHolders: Check for untranslated substitution
...
33336e1 [util] CopyrightHolders: Check for untranslated substitution (MarcoFalke)
2018-01-09 14:16:37 +01:00
Wladimir J. van der Laan
9d061a2730
Merge #8163 : Do not shadow global RPC table variable (tableRPC)
...
de1bbe3 Do not shadow global RPC table variable (tableRPC) (Pavel Janík)
2018-01-09 14:16:37 +01:00
Wladimir J. van der Laan
3b45caeeb7
Merge #8626 : Berkeley DB v6 compatibility fix
...
323a5fe Berkeley DB v6 compatibility fix (Alexey Vesnin)
2018-01-09 14:16:37 +01:00
Wladimir J. van der Laan
f6658c07f3
Merge #8611 : Reduce default number of blocks to check at startup
...
203f212 Reduce default number of blocks to check at startup (Pieter Wuille)
2018-01-09 14:16:37 +01:00
Pieter Wuille
707e2945a4
Merge #8564 : [Wallet] remove unused code/conditions in ReadAtCursor
...
beef966 [Wallet] remove unused code/conditions in ReadAtCursor (Jonas Schnelli)
2018-01-09 14:04:21 +01:00
Wladimir J. van der Laan
22604cbbcc
Merge #8607 : [doc] Fix doxygen off-by-one comments, fix typos
...
fafe7b3 contrib: Make fix-copyright-headers.py more portable (MarcoFalke)
fa27c0a [doc] Fix typos in comments, doxygen: Fix comment syntax (MarcoFalke)
fabfd5d [qa] pull-tester: Don't mute zmq ImportError (MarcoFalke)
67a5502 init: Fix typo in help message for -whitelistforcerelay (Wladimir J. van der Laan)
2018-01-09 14:04:21 +01:00
Pieter Wuille
30066a6004
Merge #8109 : Do not shadow member variables
...
ff8d279 Do not shadow member variables (Pavel Janík)
2018-01-09 14:04:20 +01:00
Wladimir J. van der Laan
95c61637d5
Merge #8590 : Remove unused variables
...
fa6dc9f Remove unused variables (MarcoFalke)
2018-01-09 14:04:20 +01:00
Wladimir J. van der Laan
15b9e43abe
Merge #8581 : [wallet] rpc: Drop misleading option
...
fab5ecb [wallet] rpc: Drop misleading option (MarcoFalke)
2018-01-09 14:04:20 +01:00
Wladimir J. van der Laan
b00f025dd8
Merge #8583 : Show XTHIN in GUI
...
4c3e2cb Show XTHIN in GUI (R E Broadley)
2018-01-09 14:04:20 +01:00
Wladimir J. van der Laan
df07a31743
Merge #8561 : Show "end" instead of many zeros when getheaders request received with a hashStop of Null
...
259ee09 Show "end" instead of many zeros when getheaders request received with a hashStop of Null. (R E Broadley)
2018-01-09 14:04:20 +01:00
Pieter Wuille
3a497a6b5c
Merge #8462 : Move AdvertiseLocal debug output to net category
...
f13c1ba Move AdvertiseLocal debug output to net category (Michael Rotarius)
2018-01-09 14:04:20 +01:00
Jonas Schnelli
3fca7e2044
Merge #7579 : [Qt] show network/chain errors in the GUI
...
2f32c82 [Qt] show network/chain errors in the GUI (Jonas Schnelli)
2018-01-09 14:04:20 +01:00
MarcoFalke
249e720254
Merge #8578 : [test] Remove unused code
...
fa1cf9e [test] Remove unused code (MarcoFalke)
2018-01-09 14:04:19 +01:00
Wladimir J. van der Laan
e61556e20e
Merge #8450 : [Test] Replace rpc_wallet_tests.cpp with python RPC unit tests
...
9578333 Remove rpc_wallet_tests.cpp (Patrick Strateman)
25400c4 Account wallet feature RPC tests. (Patrick Strateman)
2018-01-09 14:04:19 +01:00
Pieter Wuille
c9ebd95163
Merge #8560 : Trivial: Fix two VarInt examples in serialize.h
...
7bd5ff4 Trivial: Fix two VarInt examples in serialize.h (Christian Barcenas)
2018-01-09 14:04:19 +01:00
Wladimir J. van der Laan
d97fa0402f
Merge #8445 : Move CWallet::setKeyPool to private section of CWallet.
...
8680d3a Move wallet initialization logic from AppInit2 to CWallet::InitLoadWallet (Patrick Strateman)
e86eb71 Move CWallet::setKeyPool to private section of CWallet (Patrick Strateman)
2018-01-09 14:04:19 +01:00
Wladimir J. van der Laan
61a3d9aeb4
Merge #8554 : trivial: remove unused variable
...
4207630 trivial: remove unused variable (Daniel Kraft)
2018-01-09 12:24:57 +01:00
Wladimir J. van der Laan
39909d3736
Merge #8558 : Add copyright header to wallet_text_fixture.cpp
...
653bb3d Add copyright header to wallet_text_fixture.cpp (Wladimir J. van der Laan)
2018-01-09 12:24:57 +01:00
Kamil Woźniak
1cffb8a7ec
Include p2pk into addressindex ( #1839 )
...
* Add simple test for p2pk script
refs #1767
* Add p2pk transaction addresses indexing
Addresses from p2pk transaction are now indexed by transations pubkeys
hashes. Even if it isn't strict behavior and the p2pk are rare
and obsolete, it is transaction that should be able to be looked up.
fixes #1767
* Add p2pk script checking tests
refs #1767
2018-01-09 14:23:46 +03:00
UdjinM6
eecec4535c
Merge pull request #1824 from codablock/pr_backport_bitcoin_0.14-1
...
Backport missing PRs from Bitcoin 0.14 - Part 1
2018-01-09 14:22:25 +03:00
UdjinM6
9965d51bb6
Avoid reference leakage in CKeyHolderStorage::AddKey ( #1840 )
2018-01-09 14:11:43 +03:00
UdjinM6
c532be1c06
Protect CKeyHolderStorage via mutex ( #1834 )
2018-01-09 12:18:10 +03:00
UdjinM6
d69ad9d619
Skip existing masternode conections on mixing ( #1833 )
2018-01-09 12:17:54 +03:00
Alexander Block
e2a795fd84
Return EXIT_SUCCESS instead of 0 in main()
2018-01-08 18:41:25 +01:00
Alexander Block
e3da73ebf8
Update Dash related code to use new SyncTransaction notifications interface
2018-01-08 18:41:06 +01:00
Alexander Block
f8ffc55af2
Partially cherry-pick tests refactorings found in Bitcoin SegWit PRs
...
These were mixed into SegWit related PRs and are still needed in Dash.
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
b47cc13317
Merge #8548 : [wallet] Use __func__ to get function name for output printing
...
fa785d1 Use __func__ to get function name for output printing (MarcoFalke)
2018-01-08 18:04:55 +01:00
Alexander Block
ae90d0f09e
Align HD wallet status icon code with Bitcoin code
...
Rename labelEncryptionIcon to labelWalletEncryptionIcon
Reorder icons in Makefile.qt.include
Add missing entries in debian/copyright
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
5bf3dadcb6
Merge #8461 : document return value of networkhashps for getmininginfo RPC endpoint
...
65f4532 document return value of networkhashps for getmininginfo RPC endpoint (Jameson Lopp)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
80573f2bf4
Merge #8540 : qt: Fix random segfault when closing "Choose data directory" dialog
...
b4a9aa5 qt: Fix random segfault when closing "Choose data directory" dialog (Wladimir J. van der Laan)
2018-01-08 18:04:55 +01:00
Pieter Wuille
55ccc56a80
Merge #8453 : Bring secp256k1 subtree up to date with master
...
b213535 Squashed 'src/secp256k1/' changes from 6c527ec..7a49cac (Wladimir J. van der Laan)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
10aaf04b73
Merge #8505 : Trivial: Fix typos in various files
...
1aacfc2 various typos (leijurv)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
6b8160ba20
Merge #8513 : Fix a type error that would not compile on OSX.
...
8194a6e Fix a type error that would not compile on Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn) (Jeremy Rubin)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
5c928f0052
Merge #8512 : Trivial: Corrected JSON typo on setban of net.cpp
...
6ffd996 Corrected JSON typo on setban of net.cpp (Sev)
2018-01-08 18:04:55 +01:00