Commit Graph

9251 Commits

Author SHA1 Message Date
Chris Kleeschulte
645ae33bec Merge pull request #20 from braydonf/0.12.1-bitcore-inputconfs
rpc: add input confirmations to getrawtransaction
2016-06-15 13:36:31 -04:00
Braydon Fuller
c01f78375e mempool: same address and index for an input and output bug
fixes a bug that would happen when an output would match an input with
the same address and index, and would lead to the outputs not appearing
in results.
2016-06-13 11:23:30 -04:00
Braydon Fuller
4dcf3e821c mempool: fix bug with mempool address index iteration
fixes a minor bug where iteration would not end when there are matching
hashes for a p2sh and p2pkh address, and would return results for
both addresses
2016-06-13 11:23:30 -04:00
Braydon Fuller
347f0d1ed4 main: do not log error when spent info not found 2016-06-13 11:18:36 -04:00
Braydon Fuller
fea930aa8c rpc: add input confirmations to getrawtransaction 2016-06-13 11:15:34 -04:00
crowning-
0ee1bb522c Merge #884: [UI] Transaction Date Range: persistence added and format modified
b7546d2 [UI] Transaction Date Range: persistence added and format modified
2016-06-13 14:11:26 +02:00
UdjinM6
a2ad8628a7 Merge #886: also ignore outpoints which are not from currently loaded wallet
c333e09 follow up for #885 - also ignore outpoints which are not from currently loaded wallet
2016-06-13 14:11:17 +02:00
UdjinM6
5945b7053e Merge #885: Fix mnconflock
fd5cca7 Fix mnconflock - could lock spent input if it still was in masternode.conf which makes no sense and looks confusing
2016-06-13 08:39:34 +02:00
UdjinM6
2252f30a66 Merge #883: fix GetAnonymizableCredit
a78ad41 fix GetAnonymizableCredit
2016-06-13 08:39:28 +02:00
Evan Duffield
b43381c2c6 Merge #878: governance propagation
98b7d29 fix invalid cached govobj values
581b46a added information explaining cached variable meanings
390c9c3 add dirty flag for future use
b76304e added other cached flags into output
2016-06-10 07:16:32 +02:00
Pavel Janík
2d2b04543d Reenable multithread scheduler test
Github-Pull: #8016
Rebased-From: db18ab28c7a74bb289bfe6a5f9a4a9f963f71c0b 166e4b0dfa283fbdedc9a6a1e83296500c853a31
2016-06-09 22:52:04 +02:00
Wladimir J. van der Laan
658307e835 test: Add more thorough test for dbwrapper iterators
Github-Pull: #7992
Rebased-From: 84c13e759dbb0de282e2c8ce43d77f4d52fda6d9 6030625631c62b0ffab2ac545c8351fa59dca483 269a4402a8617a539a70b2c332e86f0fe292a7a6
2016-06-09 22:47:27 +02:00
Wladimir J. van der Laan
20d00a180e
Merge #7938: [0.12.2] Backports
c3d1bc3 CBase58Data::SetString: cleanse the full vector (Kaz Wesley)
43c14ac Fix headers announcements edge case (Suhas Daftuar)
06c73a1 Removed call to `TryCreateDirectory` from `GetDefaultDataDir` in `src/util.cpp`. (Alexander Regueiro)
7e71785 Use txid as key in mapAlreadyAskedFor (Suhas Daftuar)
5583a3d Add curl to Gitian setup instrustions (BtcDrak)
d3ead9b Avoid "Unknown command" messages when receiving getaddr on outbound connections. (R E Broadley)
a5bc6a1 Remove vfReachable and modify IsReachable to only use vfLimited. (Patrick Strateman)
52c1011 Clarify description of blockindex (Matthew Zipkin)
21b2f82 Don't resend wallet txs that aren't in our own mempool (Alex Morcos)
66d5408 Fix memleak in TorController [rework] (Wladimir J. van der Laan)
1c3d38b Remove spurious dollar sign. Fixes #7189. (Chris Moore)
64fd0ce fix spelling of advertise in src and doc (jloughry)
a9e73f7 Fix and cleanup listreceivedbyX documentation (instagibbs)
9095594 Do not download transactions during inital sync (ptschip)
2016-06-09 10:22:52 +02:00
UdjinM6
de64f11347 Merge #875: Fix color for PS transaction labels
37bb138 Fix color for PS transaction labels, fixes #874
2016-06-09 08:26:11 +02:00
UdjinM6
36a2c4c92e Merge #872: Dynamically adjust recent tx list item count
befde96 Dynamically adjust recent tx list item count (on overview screen) in correspondence with fShowAdvancedPSUI state and litemode.

Also including a fix for #789
2016-06-08 20:33:00 +02:00
crowning-
9fcca947bb Merge #870: [UI] Masternode Icon Color Adjustment
b158401 [UI] Masternode Icon Color Adjustment
2016-06-08 20:31:44 +02:00
crowning-
779cfe8fff Merge #869: [UI] Overviewpage digits and number of recent transactions changed
8207643 [UI] Overviewpage digits and number of recent transactions changed
9a7d26c [UI] Number of digits on transaction-page reverted
1f707ab [UI] Overview-page NUM_ITEMS reverted to 5
2016-06-08 20:30:57 +02:00
Johnathan Corgan
932aedd99a Cherry-pick of f59dceb (#7925) to 0.12.
=====

qt: Fix out-of-tree GUI builds

Without this patch:

- When I compile the GUI from the bitcoin directory itself, it works as
  expected.

- When I build the GUI in an out-of-tree build, I cannot get it to
  select tabs. When I click, say the "Receive" tab nothing happens,
  the button selects but it doesn't switch the page. The rest - even
  the debug window - seems to work.

See full discussion here:
https://github.com/bitcoin/bitcoin/pull/7911#issuecomment-212413442

This turned out to be caused by a mismatch in the arguments to moc,
preventing it from finding `bitcoin-config.h`. Fix this by passing
`$(DEFAULT_INCLUDES)` to it, which gets set to the appropriate
path by autoconf itself.
2016-06-08 06:29:27 -07:00
Evan Duffield
95ba71570b Merge #864: govobj sync
487674f Governance object/vote syncing fixes
- disable fCached values
- use two maps for storing votes, by hash and parent-hash/type
- disable part of flatdb.dump (still overwriting)
- fixed govobj/votes relay and sync

15821fe various fixes
- Added const where possible
- Uncommented sync block
- Protocol min 70201
- Fixed bug which flags invalid votes incorrectly
- Formatting

aa8fdd7 fix curly braces

d8e39b1 Fix GetTypeHash bug
- Should not collide based on the outcome

732a8a3 fixed mismatched index for vote map
2016-06-08 08:57:16 +02:00
UdjinM6
4d4a9df059 Merge #867: Implement an option to enable/disable advanced PrivateSend UI
953d9fb Implement an option to enable/disable advanced PrivateSend UI, more DS->PS in overview tab code
2016-06-06 21:52:24 +02:00
snogcel
51515775b3 Merge #868: checkbox image for wallet themes
b7ad787 use checkbox image for themes
b9e1c27 checkbox images
1a985cc checkbox images adjustment
2016-06-06 21:52:09 +02:00
crowning-
5ac043c1ba Merge #866: [UI] Column alignement of Transaction-Tab adjusted
191ca63 [UI] Column alignement of Transaction-Tab adjusted
2016-06-06 07:44:59 +02:00
Johnathan Corgan
03c709b422 Backport leveldb build integration to 0.12
This is a cherry-pick of a4625acb with minor conflict
resolution.

Conflicts:
	src/Makefile.am

=====

leveldb: integrate leveldb into our buildsystem

leveldb's buildsystem causes us a few problems:
- breaks out-of-tree builds
- forces flags used for some tools
- limits cross builds

Rather than continuing to add wrappers around it, simply integrate it into our
build.
2016-06-05 12:48:57 -07:00
crowning-
ee31604d59 Merge #865: [Wallet] Transaction View: LastMonth calculation simplyfied
6d20175 [Wallet] Transaction View: LastMonth calculation simplyfied
2016-06-05 07:11:22 +02:00
crowning-
ee830eef06 Merge #822: [Core]: fix restart hanging during wallet-repair
37a934c [Core]: fix restart hanging during wallet-repair
2016-06-05 07:10:41 +02:00
Kaz Wesley
c3d1bc33b5 CBase58Data::SetString: cleanse the full vector
SetString seems to be passing the length of the wrong variable to
memory_cleanse, resulting in the last byte of the temporary buffer not being
securely erased.

Github-Pull: #7922
Rebased-From: 57704499be948c640c789c7fc11ed1abf8a681bd
2016-06-04 18:01:02 +02:00
UdjinM6
3d2bc6a4ca Merge #861: More compatibility for old ipv6 format + refactor
- try old format ipv6 if new format failed to verify
- sanitize log strings
- remove redundant ability to sign CMasternodeBroadcast in `protocolVersion < 70201` way
- verify CMasternodeBroadcast immediately on Sign
- move all CMasternodeBroadcast sig verification from CheckAndUpdate to VerifySignature
- initialize nDos at the beginning of functions so that we don't accidentally ban or reject legit MN if caller function forgot to reinitialize it
2016-06-03 06:59:19 +02:00
UdjinM6
c615a22898 Merge #862: make MasternodeList qt4 compatible
9c61b11 make MasternodeList qt4 compatible, fixes #859
2016-06-03 06:59:14 +02:00
Braydon Fuller
55fa4798eb main: spentindex for the mempool 2016-06-02 12:15:59 -04:00
Braydon Fuller
4c7dc871d1 rpc: add input value and address to getrawtransaction if spentindex enabled 2016-06-02 12:15:38 -04:00
Braydon Fuller
16d35eb228 main: add amount and address to spentindex value 2016-06-02 12:15:38 -04:00
Braydon Fuller
87dfd13694 rpc: include satoshis in verbose raw transaction 2016-06-02 12:15:38 -04:00
Braydon Fuller
1c022b9fc2 rpc: add blockindex to getaddressdeltas method
for the purposes of secondary sorting by block order
2016-06-02 12:15:37 -04:00
Braydon Fuller
3c74fff552 rpc: include help text for addressindex and related commands 2016-06-02 12:15:37 -04:00
Braydon Fuller
eb82f39655 rpcclient: add params to be parsed as JSON
There was an issue where getblockhashes wouldn't work from bitcoin-cli
as the two params would be strings instead of integers. This fixes that
issue, and will parse the first param as JSON for other addressindex
related rpc methods.
2016-06-02 12:15:37 -04:00
Braydon Fuller
5fa85bc9ae rpc: update oksafemode for address commands 2016-06-02 12:15:37 -04:00
Braydon Fuller
98f8fdddc8 rpc: optional "start" and "end" params for getaddressdeltas 2016-06-02 12:15:37 -04:00
Braydon Fuller
8391ff0b0a rpc: include base58check encoded address in results 2016-06-02 12:15:37 -04:00
Braydon Fuller
5c3cf5f631 rpc: include prevhash and prevout information for spending deltas 2016-06-02 12:15:37 -04:00
Braydon Fuller
04da9306c6 build: fix darwin build 2016-06-02 12:15:37 -04:00
Braydon Fuller
94ea69a4d5 rpc: fix issue with querying txids by block heights 2016-06-02 12:15:37 -04:00
Braydon Fuller
96d8307b55 rpc: query txids for addresses within block height range 2016-06-02 12:15:37 -04:00
Braydon Fuller
abe40712ce rpc: include height in spentinfo 2016-06-02 12:15:37 -04:00
Braydon Fuller
b752fbe09e rpc: include spent info if spentindex enabled with getrawtransaction verbose 2016-06-02 12:15:37 -04:00
Braydon Fuller
e3d9207e5a main: add spentindex option 2016-06-02 12:15:37 -04:00
Braydon Fuller
8636f36477 rpc: cast indexes to ints 2016-06-02 12:15:14 -04:00
Braydon Fuller
4678f2d438 build: add addressindex.h to make 2016-06-02 12:15:14 -04:00
Braydon Fuller
7c68235cf4 main: include timestampindex in help 2016-06-02 12:15:14 -04:00
Braydon Fuller
d99f17de1a rpc: give back base58 encoded address format in utxos 2016-06-02 12:15:14 -04:00
Braydon Fuller
b66eff47cf main: mempool address index 2016-06-02 12:15:14 -04:00
Braydon Fuller
1bd65a5c4b main: sort address index utxos by height 2016-06-02 12:15:14 -04:00
Braydon Fuller
d0483c9aa0 main: remove spent address utxo indexes 2016-06-02 12:15:14 -04:00
Braydon Fuller
21c675855f main: don't undo indexes when verifying blocks at startup 2016-06-02 12:15:14 -04:00
Braydon Fuller
24894cb748 main: update unspent address index during reorgs 2016-06-02 12:15:14 -04:00
Braydon Fuller
08836972c0 rpc: fix argument check for getaddressutxos 2016-06-02 12:15:14 -04:00
Braydon Fuller
0b42ba227a main: index unspent outputs by address 2016-06-02 12:15:14 -04:00
Braydon Fuller
8597289d8b main: fix order of address index when disconnecting block 2016-06-02 12:15:14 -04:00
Braydon Fuller
186e11fde7 main: update address index during reorgs 2016-06-02 12:15:14 -04:00
Braydon Fuller
38a7d6d323 rpc: optimize address txid queries 2016-06-02 12:15:14 -04:00
Braydon Fuller
cad092aebb main: get address deltas between range of block heights 2016-06-02 12:15:14 -04:00
Braydon Fuller
206882cd4b main: fixed bug with overlapping address index keys
There was a bug where the spending address index could have the same key
as the receiving address index if the input and output indexes matched. This lead
to the output always overwriting the input index leading to incorrect balances
with missing spent amounts. This patch separates the two so that they have unique
keys so balances will be correctly calculated.
2016-06-02 12:15:14 -04:00
Braydon Fuller
935ca8f832 main: add block timestamp index 2016-06-02 12:15:13 -04:00
Braydon Fuller
24deb4efc1 rpc: include height in getrawtransaction results 2016-06-02 12:15:13 -04:00
Braydon Fuller
2e8a4c00fa rpc: add receieved to balance 2016-06-02 12:15:13 -04:00
Braydon Fuller
5bb6d69ff8 rpc: added getaddressbalance method using addressindex 2016-06-02 12:15:13 -04:00
Braydon Fuller
7dbbb79cec rpc: only sort when combining multiple results
It's only necessary to sort when combining results for several addresses
as the results are already in order from the database.
2016-06-02 12:15:13 -04:00
Braydon Fuller
7959a19085 main: serialize height in BE for address index key
fixes a sorting issue when iterating over keys
2016-06-02 12:15:13 -04:00
Braydon Fuller
5b5f3f7d00 rpc: sort txids by height for multiple addresses 2016-06-02 12:15:13 -04:00
Braydon Fuller
f4d11ffc7c rpc: query for multiple addresses txids 2016-06-02 12:15:13 -04:00
Braydon Fuller
2500d1d115 rpc: update getaddresstxids for uniqueness 2016-06-02 12:15:13 -04:00
Braydon Fuller
fcac6bcdc8 rpc: fix issue for querying txids for p2sh addresses 2016-06-02 12:15:13 -04:00
Braydon Fuller
18ea599a71 main: index address index sorted by height 2016-06-02 12:15:13 -04:00
Braydon Fuller
73b2d0851b test: added unit tests for CScript.IsPayToPublicKeyHash 2016-06-02 12:15:13 -04:00
Braydon Fuller
9babc7ff9f main: start of address index
Adds a configuration option for addressindex to search for txids by address. Includes
an additional rpc method for getting the txids for an address.
2016-06-02 12:15:13 -04:00
UdjinM6
914802bab4 merge #857: add difficulty in getchaintips output for convenience
a50861e add `difficulty` in `getchaintips` output for convenience
2016-06-02 14:40:39 +02:00
Holger Schinzel
839ae4ba17 merge #856: update testnet checkpoint
0143dc9 update testnet checkpoint
2016-06-02 08:12:02 +02:00
UdjinM6
284e2c41cc merge #855: Fix bad mn sig ipv6
51696ac make use of getnameinfo() optional (default: true)
bec39b8 fix mnb sig bug for ipv6 addresses: use pure byte to hex conversion for construction of masternode broadcast signature, better logging
2016-06-02 08:11:56 +02:00
Holger Schinzel
b5924a2451 merge #850: update splash screen
bd9d27a update splash screen
2016-06-02 08:11:47 +02:00
Holger Schinzel
9b9d105c23 merge #854: update testnet checkpoint
c4b12e9 update testnet checkpoint
2016-06-01 19:33:26 +02:00
Evan Duffield
d0ad4ad0e4 V0.12.1.x govobj submission (#846)
* Remove nTime from IsCollateralValid and document function
2016-05-31 22:00:01 +02:00
Holger Schinzel
dad85d9c12 Merge pull request #845 from dashpay/v0.12.1.x-update-seeders
updated testnet seeders
2016-05-31 20:05:13 +02:00
Evan Duffield
2d429a7f31 Merge pull request #836 from UdjinM6/fixMasternodeSignatures
Fix masternode signatures, bump PROTOCOL_VERSION
2016-05-31 10:57:10 -07:00
Wladimir J. van der Laan
e7ec24e336
Merge #8001: [0.12.2] backport script_tests improvements
e3a9ce9 Refactor script tests (Pieter Wuille)
87129b2 test: script_error checking in script_invalid tests (Wladimir J. van der Laan)
2016-05-31 15:52:55 +02:00
Holger Schinzel
3f76398e68
updated testnet seeders 2016-05-31 13:54:09 +02:00
Holger Schinzel
2b286bbc35 Merge pull request #842 from UdjinM6/utf8
Add full UTF-8 support to RPC
2016-05-31 06:57:19 +02:00
UdjinM6
77d34da4dc less locking in IsInitialBlockDownload (#843) 2016-05-31 06:57:05 +02:00
UdjinM6
aa9803473b Yet another fix for rpc autoCompleter, #752 was not enough (#844) 2016-05-31 06:56:58 +02:00
Wladimir J. van der Laan
3f7f64a66b univalue: Handle UTF-8
Input: read and validate full UTF-8, both Basic Multilingual Plane
and extended characters.
Collate surrogate pairs as specified in RFC467.
This ensures that UTF-8 strings that reach the application are
always valid.

Output: Assume UTF-8 strings provided for output are valid.
The escaping was broken, fix this by not encoding UTF-8 characters with \u.
Simply write them to the output stream as-is.

This is the right thing to do. See https://www.ietf.org/rfc/rfc4627.txt:

    "JSON text SHALL be encoded in Unicode.  The default encoding is UTF-8."

Fixes #16.
Also add tests for the new functionality.
2016-05-31 04:31:02 +03:00
UdjinM6
fb1ffded70 There is a bug in mnw fix, so... fix the fix (should be && not ||) (#837)
Also make `nMinBlocksToStore` and `nStorageCoeff` const
2016-05-30 14:11:09 +02:00
UdjinM6
d705da741c fix masternode signatures, bump PROTOCOL_VERSION
strMessage for masternode broadcast (which we sign and verify) looks like this currently:
[2001:1608:45:3::242:ac11:6]:199991464464536
                                  ?~}&?Q?S?Ǚ?q	?0??????O?I/Y?(
?f?jJF??m??bssknN??9鲜JXVs?ә?5T?8??????~70200
which I believe in some cases leads to "Got bad Masternode ping signature" errors and banning.

I propose to change the way strMessage is composed so that it looks like this:
[2002:82ff:c04:2:a90f:2261:43c4:2745]:1999514645552319591ec70225aacadfafa4ab5d21e87cdce641fd4030d029485434533c5e481578a9d471089fb5ec170200

Further more nDos for old masternodes is set to 0 to stop false positives (message still gets rejected though).
2016-05-30 11:37:35 +03:00
UdjinM6
4d55bc9666 Cleanup/maintenance (#830)
* remove instance references inside own class

* better logging

* remove unused

* fix tabs/spaces

* bitcoin->dash

* fix README.md
2016-05-30 08:22:30 +02:00
UdjinM6
f5e3042b7a create INSTANTSEND_MIN_FEE to manage IS fee in one place (#829) 2016-05-30 08:22:15 +02:00
UdjinM6
9745914c15 remove hardcoded strDarksendPoolDummyAddress (#828)
- use "" account address instead
- remove `collateralPubKey` and `SetCollateralAddress()` from darksend and create `dummyScriptPubkey` and `InitDummyScriptPubkey()` in masternodeman instead
- initialize `dummyScriptPubkey` before loading cache otherwise MNs could be removed because of the invalid tx
2016-05-30 08:22:08 +02:00
UdjinM6
989317c036 fix mnw sync issues (#825) 2016-05-29 20:35:09 +02:00
UdjinM6
6323c91cb0 Fix inv messages, revert part of #806 (#823)
If we want to be compatible to 12.0 on network layer we need them back in ppszTypeName[] to keep inv type consistent (allNetMessageTypes[] should not have them, we shouldn't accept non-implmented messages)
2016-05-29 13:46:39 +02:00
Evan Duffield
a4954bf0fd Fixed governance object submission issues (#817)
- Terrible bug which caused governance objects to have their hashes corrupted, causing objects to become invalid
- More proposal -> governance name changes
2016-05-28 12:31:44 +02:00
Holger Schinzel
940035393c updated testnet checkpoint (#819) 2016-05-28 12:31:38 +02:00
crowning-
37b4666c09 [UI] Rebranding: DS reference changed to PS (#814) 2016-05-27 08:25:00 +02:00
UdjinM6
c3b950d457 fix mn anounce: (#813)
- every node should check for "pre-enabled" status of a newly added mn to relay message further (was "enabled" which is wrong - if node is enabled, that's not the first announce, so no need to relay it because most likely we were the one who asked for that mn directly via dseg)
- we should not add ourselves to mn list if announce message has outdated protocol version (report this in log)
- we should remove ourselves from saved list if we start updated mn for the first time and just loaded old list from mncache.dat
2016-05-27 08:24:44 +02:00
crowning-
517ffd7b7d [UI] Rebranding: DS reference changed to PS (#810)
* [UI] Rebranding: DS reference changed to PS

DarkSend -> PrivateSend

* [UI] Rebranding: DS reference changed to PS (part 2)
2016-05-27 00:05:05 +02:00
UdjinM6
6698d2ce89 Re-enable FillBlockPayee for mnpayments, fix CreateNewBlock calculations (#811)
* Reenable FillBlockPayee for mnpayments, fix CreateNewBlock calculations

* revert blockchain.py fix #772
2016-05-27 00:04:15 +02:00
Evan Duffield
5411d78b11 Fixed governance object submission issues (#812)
- Cleaned up governance object / added comments
2016-05-27 00:03:37 +02:00
Evan Duffield
7f52065c38 Merge pull request #806 from evan82/v0.12.1.x-sync-process-2
V0.12.1.x Sync Processing
2016-05-25 14:47:13 -07:00
Evan Duffield
ff06e58186 Added back logic to only allow X votes per masternode winner 2016-05-25 10:06:48 -07:00
Evan Duffield
8cbe280dd1 fix compiling issues 2016-05-25 09:56:58 -07:00
Holger Schinzel
585544a2f1 Merge pull request #808 from crowning-/patch-2
[UI] Fixed missplaced mixing buttons for traditional wallet theme
2016-05-25 15:36:20 +02:00
TheLazieR Yip
bf650e8386 Rebranding: PrivateSend/InstantSend (update 2d) 2016-05-25 13:39:23 +07:00
crowning-
7ee810d3b6 [UI] Rebranding: PrivateSend/InstantSend (update 2) (#804)
* [UI] Rebranding: PrivateSend/InstantSend (update 2)
* [UI] Changed name of sendtoaddress parameters: use_ix -> use_is and use_ds -> use_ps
2016-05-25 07:25:16 +02:00
crowning-
0851a9fc88 [UI] Fixed missplaced mixing buttons for traditional wallet theme 2016-05-24 23:25:17 +02:00
Evan Duffield
7240f96e29 - removed hybrid mode (masternode winners reference node). This feature was added to 12.0 incase we had network troubles and required a "safe-mode" to run in. We've experiences no issues like so it should be safe to remove
- fixed masternode winners calculation and listing
2016-05-24 14:16:42 -07:00
Evan Duffield
26b297f7fd blockout calc-score for removal 2016-05-24 13:17:03 -07:00
Evan Duffield
5e990d3859 fixed cleanup for sync 2016-05-24 13:14:47 -07:00
Evan Duffield
349e750e73 Cleanup
- removed some old comments
- renamed sync tracking requests to friendlier names
2016-05-24 13:12:20 -07:00
Evan Duffield
c6e0643d9e enabled governance item syncing 2016-05-24 12:25:33 -07:00
Evan Duffield
ac913c0258 Removed unimplemented commands / mnquorum / mnscanerror
- Scanning errors should be implemented via sentinel
2016-05-24 12:20:10 -07:00
Evan Duffield
49ad98d1f3 cleanup 2016-05-24 11:29:23 -07:00
Evan Duffield
19664dac8f calculate sentinel flags from votes 2016-05-24 11:11:59 -07:00
Holger Schinzel
16671cdf9a Merge pull request #799 from UdjinM6/fixMNTab
fixes for Masternodes Tab, issues #790, #795, #796
2016-05-24 07:21:45 +02:00
Holger Schinzel
7dbe17d34a Merge pull request #801 from UdjinM6/moveDSOptions
Move DS qt options from Main to Wallet tab in Options dialog
2016-05-24 07:21:00 +02:00
Holger Schinzel
3e15bf47d0 Merge pull request #800 from UdjinM6/fixCheckInputsAndAdd
Optimize processing of a (potentially) new MN
2016-05-24 07:20:53 +02:00
Holger Schinzel
773744ed16 Merge pull request #798 from UdjinM6/fixDSSignFinal
Fix final dstx signing
2016-05-24 07:20:45 +02:00
Holger Schinzel
960864790f Merge pull request #797 from UdjinM6/fixDSIXRelay
fix RelayTransaction to relay correct message (dstx/ix)
2016-05-24 07:20:39 +02:00
UdjinM6
5c5ddfe71e Move DS qt options to Wallet tab in Options dialog 2016-05-24 05:21:36 +03:00
UdjinM6
87ad368643 Optimize processing of a (potentially) new MN:
- Move heavy `IsVinAssociatedWithPubkey` deep inside of `CheckInputsAndAdd` to be actually executed only once per masternode and only after much simpler checks were executed;
- Verify `GetInputAge` (it uses cache) before trying to enter `AcceptToMemoryPool` (which hash many ifs and checks inside).
2016-05-24 03:15:53 +03:00
UdjinM6
d82680af1b fixes for Masternode Tab, issues #790, #795, #796 2016-05-24 02:51:37 +03:00
UdjinM6
519577d4f4 Fix final dstx signing:
- Should fail if at least one AddScriptSig() fails (currently will pass if at least one is ok, which is no good)
- Should log this accordingly
2016-05-24 02:40:12 +03:00
UdjinM6
c845e5922f fix RelayTransaction to relay correct message (dstx/ix) 2016-05-24 02:06:09 +03:00
Evan Duffield
869ff89d3b update gethash() 2016-05-23 15:52:10 -07:00
Evan Duffield
528c5edb19 fix fValid caching engine 2016-05-23 14:39:10 -07:00
Evan Duffield
18e9a33e2a changed fee to 0.1D for govobj submission 2016-05-23 11:16:46 -07:00
Evan Duffield
39d9ad87fb more refactoring 2016-05-23 11:10:20 -07:00
Evan Duffield
623ac049e2 More cleanup
- AddProposal -> AddGovernanceObject
- mapOrphanMasternodeBudgetVotes -> mapOrphanVotes
- UpdateProposal -> UpdateGovernanceObject
2016-05-23 10:58:39 -07:00
Evan Duffield
860d29f9c4 Budget system -> Governance System
- Changed Action -> Signal for clarity
- CBudgetVote -> CGovernanceVote
2016-05-23 10:53:05 -07:00
Holger Schinzel
06b84a4e4a Merge pull request #787 from UdjinM6/lightTheme
fix tab text truncation
2016-05-21 10:45:24 +02:00
UdjinM6
d7cf3393c0 fix tab text truncation 2016-05-20 21:34:52 +03:00
UdjinM6
f89635f73a fix flat-db:
- no reason to read twice on load
- should read using temp object instead the one we want to save on dump
2016-05-20 20:46:34 +03:00
Evan Duffield
2c3e480681 Merge pull request #786 from UdjinM6/rightClickStartAlias
right-click to start alias in "My Masternodes" sub-tab
2016-05-20 10:21:22 -07:00
Evan Duffield
35aa7668a5 Merge branch 'v0.12.1.x' of https://www.github.com/dashpay/dash into v0.12.1.x 2016-05-20 10:19:19 -07:00
UdjinM6
16c20006ca right-click to start alias in "My Masternodes" sub-tab 2016-05-20 16:15:02 +03:00
Holger Schinzel
43cd805282 Merge pull request #781 from UdjinM6/fixLibpngWarning
fix libpng warning
2016-05-20 07:43:57 +02:00
Holger Schinzel
95224abf8e Merge pull request #784 from UdjinM6/fixMasternodeConfRead
fix CMasternodeConfig::read()
2016-05-20 06:01:32 +02:00
Holger Schinzel
bc1f83c02c Merge pull request #779 from evan82/v0.12.1.x
Use chainparams instead of standalone func for mn confirms
2016-05-20 06:01:23 +02:00
UdjinM6
6fb9962424 fix CMasternodeConfig::read() 2016-05-20 01:29:34 +03:00
Evan Duffield
49b8123ae1 commenting out part of flatfile.dump, which is causing data corruption 2016-05-19 14:27:09 -07:00
Evan Duffield
deb0f0ca14 fixed vote casting 2016-05-19 14:08:57 -07:00
Evan Duffield
d8453bb92b Use chainparams instead of standalone func for mn confirms
- Use function instead of chainparams directly
2016-05-19 13:54:23 -07:00
UdjinM6
5d775240b0 fix "GUI: libpng warning: iCCP: known incorrect sRGB profile" using mogrify 2016-05-19 23:14:56 +03:00
Holger Schinzel
cbfbc096d1 Update masternodeconfig.h
removing printf - breaks the build https://travis-ci.org/dashpay/dash/jobs/131496337#L1485
2016-05-19 22:05:58 +02:00
Evan Duffield
a3116768ab Use chainparams instead of standalone func for mn confirms
- Use function instead of chainparams directly
2016-05-19 12:18:16 -07:00
Evan Duffield
22661ad60d Merge pull request #778 from UdjinM6/lightTheme
Fixing light theme
2016-05-19 11:37:08 -07:00
Evan Duffield
a69a643c6e Merge pull request #777 from crowning-/UI_Enhancements
[UI] Change default theme to "DASH-light"
2016-05-19 11:36:47 -07:00
Evan Duffield
1376208c61 Merge pull request #776 from UdjinM6/masternodeTab
Add masternode tab in qt wallet
2016-05-19 11:36:26 -07:00
Evan Duffield
2ca8c85820 fixed voting errors 2016-05-19 11:34:43 -07:00
UdjinM6
86bca13e1e fix dumb bug in signal connection 2016-05-16 22:27:43 +03:00
UdjinM6
c5c0aa78fc moved "Show Masternodes Tab" to Expert features 2016-05-16 15:43:45 +03:00
UdjinM6
050b707d9f Icon update (thanks @salmion) 2016-05-16 02:05:42 +03:00
UdjinM6
020ecebb3e Use options to choose whether to show Masternodes tab or not. Should be set to true at first run for those who have masternodes in their masternode.conf and false for others. 2016-05-16 01:55:20 +03:00
UdjinM6
843453fb66 More fixes for Masternodes tab:
- set initial columns size
- use resizable columns
- use theme-dependent masternodes icon (placeholder, should be replaced)
- removed unused event binding
- capitalization, more verbose ui element names
2016-05-15 19:43:22 +03:00
Evan Duffield
2cec48631e Merge branch 'v0.12.1.x' of https://www.github.com/dashpay/dash into v0.12.1.x 2016-05-13 09:03:35 -07:00
Evan Duffield
9031c5e3cb Update some governance logic 2016-05-13 09:03:01 -07:00
UdjinM6
12239be138 Fix tx icons for light theme (thanks @snogcel) 2016-05-13 12:42:51 +03:00
UdjinM6
9101c54d30 Fixing light theme:
- colorized few images/icons to use “Strong blue” #1c75bc
- replaced "smile" icon with pick-axe
- fixed ds status overlap
- trying to make theme less "heavy" - fewer bold labels, lighter colors for labels
- removed unused files
2016-05-12 16:59:33 +03:00
crowning-
4584201d9b [UI] Change default theme to "DASH-light" 2016-05-11 20:42:38 +02:00
UdjinM6
3764e6869a Add masternode tab in qt wallet 2016-05-11 15:50:04 +03:00
Holger Schinzel
25c4341311 Merge pull request #775 from UdjinM6/fixPid
fix pid dash.pid -> dashd.pid
2016-05-11 11:37:54 +02:00
Holger Schinzel
c77d9830ae Merge pull request #774 from thelazier/patch-2
Fix Hot Masternode
2016-05-11 11:37:46 +02:00
Holger Schinzel
28fc3bae6e Merge pull request #762 from crowning-/patch-3
[UI] Enable themed *.png icons again for Linux
2016-05-11 11:37:41 +02:00
UdjinM6
12317fa13e fix pid dash.pid -> dashd.pid 2016-05-11 12:30:52 +03:00
TheLazieR Yip
fe66b5acd0 Fix Hot Masternode
Add Update Masternode List from created masternode broadcast before relay.
2016-05-11 03:45:11 +07:00
Holger Schinzel
e5bcd0598b Merge pull request #773 from thelazier/patch-1
Fix Hot Masternode
2016-05-10 19:39:33 +02:00
Holger Schinzel
feabb140a3 Merge pull request #772 from UdjinM6/fixTests
Fix tests
2016-05-10 19:39:08 +02:00
TheLazieR Yip
56adee2de2 Fix Hot Masternode
Revert to master branch
2016-05-10 21:53:08 +07:00
UdjinM6
a4c098141a fix tests to follow #767 2016-05-10 16:12:21 +03:00
Evan Duffield
0c6c21f099 Merge pull request #768 from UdjinM6/unifySubsidy
Unify subsidy formulas for different networks, add few comments
2016-05-10 06:11:17 -07:00
Holger Schinzel
8a03d1630d Merge pull request #770 from crowning-/patch-5
[UI] Rebranding: PrivateSend/InstantSend (update)
2016-05-10 13:36:02 +02:00
UdjinM6
b9ad319d00 Unify subsidy formulas for different networks, add few comments 2016-05-10 12:50:57 +03:00
Holger Schinzel
05661617a6 Some houskeeping:
- fixed testnet checkpoints
- revert testnet mining patch
2016-05-10 09:57:05 +02:00
crowning-
5091ac939b [UI] Rebranding: PrivateSend/InstantSend (update)
Accidentally overwrote my final version locally, so the change of the (unfortunately most prominent) InstantX label on the sendcoins page got lost. 

Sorry  :-/
2016-05-10 05:39:36 +02:00
Holger Schinzel
d61edf8452 Remove log spam 2016-05-10 00:28:36 +02:00
Evan Duffield
e0a4c6ec19 Merge pull request #760 from crowning-/UI_Enhancements
[UI] Rebranding: Darksend/InstantX changed to PrivateSend/InstantSend (UI+log)
2016-05-09 13:54:21 -07:00
Evan Duffield
bfaa5b6970 Merge pull request #761 from UdjinM6/fixStyling
Assign app name in NetworkStyle::NetworkStyle()
2016-05-09 13:52:37 -07:00
Evan Duffield
684994ca4e Merge pull request #764 from crowning-/UI_Icons
[UI] Some standard Bitcoin icons beautified
2016-05-09 13:51:33 -07:00
Evan Duffield
f13b9ad418 Merge pull request #767 from moocowmoo/v0.12.1.x
config - changed network bip32 values, testnet/regtest pubkey
2016-05-09 13:51:03 -07:00
Evan Duffield
736d22262f fixed mining 2016-05-09 12:51:23 -07:00
moocowmoo
c5004ce308 config - changed network bip32 values, testnet/regtest pubkey
mainnet bip32 seeds start with dpub/dprv
testnet/regtest  bip32 seeds start with DPUB/DPRV
only create public testnet/regtest addresses starting with y
2016-05-09 19:13:22 +00:00
crowning-
243067c0ee [UI] Rebranding: Darksend/InstantX changed to PrivateSend/InstantSend 2016-05-09 21:08:13 +02:00
Evan Duffield
60e048071f added budget item func 2016-05-09 09:31:11 -07:00
Evan Duffield
8c48d9dbb9 fixed endian issues 2016-05-09 08:58:17 -07:00
Evan Duffield
4caf64569f merged 2016-05-09 08:39:31 -07:00
Evan Duffield
358be66084 reset testnet 2016-05-09 08:32:47 -07:00
Evan Duffield
9b7504cb32 Fix dumb errors on ubuntu 2016-05-06 18:36:11 -04:00
Evan Duffield
e6d7f4ed7f fixing more errors 2016-05-05 10:44:46 -07:00
Evan Duffield
aee86618cd fixed greedy find/replace (opps) 2016-05-05 10:30:28 -07:00
Pieter Wuille
e3a9ce9c94 Refactor script tests
Github-Pull: #7818
Rebased-From: c7c664191fd6ca4843cfe9d00abf8f2362b9550f 269281b7cc56e728fa64803fc7509ab3a0ce1805 d03e46625ac95954bb9ecbc2cf73ffd8de6b8a13 76da7613517d05aca31c2cee42b5ebf3d5c54974 009b503792737ab03aeb6e15060bc4f499500a96 dde46d3ae1de18700e089bc1861cf1e18649dc5d
2016-05-04 13:01:59 +02:00
Wladimir J. van der Laan
87129b24e1 test: script_error checking in script_invalid tests
Github-Pull: #7517
Rebased-From: b0ff8572aeb8211ad30f24ca42d20a46debb5e9d 2317ad7c56c6f5a55984459947f69cc3bfbe340a 0ecb3401fe157cb0779d3970c6080b463b1b0ed2
2016-05-04 13:01:55 +02:00
Suhas Daftuar
43c14acf14 Fix headers announcements edge case
Previously we would assert that if every block in vBlockHashesToAnnounce is in
chainActive, then the blocks to be announced must connect.  However, there are
edge cases where this assumption could be violated (eg using invalidateblock /
reconsiderblock), so just check for this case and revert to inv-announcement
instead.

Github-Pull: #7919
Rebased-From: 3a99fb2cb14955f5e029d315041a093e957e6c3e
2016-04-27 22:34:48 +02:00
Alexander Regueiro
06c73a1751 Removed call to TryCreateDirectory from GetDefaultDataDir in src/util.cpp.
See https://github.com/bitcoin/bitcoin/issues/7845#issuecomment-207684728.
Also refactored `GetDefaultDataDir` function to return path for Mac in one expression.

Github-Pull: #7850
Rebased-From: 41dbc4849e0bf14eef98962b0f0bddcde0bb3014
2016-04-27 22:34:48 +02:00
Suhas Daftuar
7e71785c40 Use txid as key in mapAlreadyAskedFor
Previously we used the CInv that would be sent to the peer announcing the
transaction as the key, but using the txid instead allows us to decouple the
p2p layer from the application logic (which relies on this map to avoid
duplicate tx requests).

Github-Pull: #7862
Rebased-From: 7e91f632c70ff1848a152f24ee67a06796803943
2016-04-27 22:34:48 +02:00
R E Broadley
d3ead9bcb6 Avoid "Unknown command" messages when receiving getaddr on outbound connections.
Github-Pull: #7642
Rebased-From: d84ea1a59ce3704457a162f1fd8a7353047156de
2016-04-27 22:34:48 +02:00
Patrick Strateman
a5bc6a1bc4 Remove vfReachable and modify IsReachable to only use vfLimited.
We do not know that a class of Network is reachable, only that it is not.

Github-Pull: #7553
Rebased-From: 110b62f06992d0fb989153afff2dc3aea62a674f
2016-04-27 22:34:48 +02:00
Matthew Zipkin
52c101158f Clarify description of blockindex
see issues:

https://github.com/bitcoin-dot-org/bitcoin.org/issues/1237

https://github.com/bitcoin/bitcoin/issues/7532

Github-Pull: #7541
Rebased-From: 7eef1d0dad0c48e9faefdc4fe5cfb6182edc79ab
2016-04-27 22:34:48 +02:00
Alex Morcos
21b2f82eb7 Don't resend wallet txs that aren't in our own mempool
Github-Pull: #7521
Rebased-From: 5a2b1c0c8b49c5ae79946e71b9f989b33c9fcf5c
2016-04-27 22:34:48 +02:00
Wladimir J. van der Laan
66d5408559 Fix memleak in TorController [rework]
It looks like, TorController::disconnected_cb(TorControlConnection&
conn) gets called multiple times which results in multiple event_new().

Avoid this by creating the event only once in the constructore, and
deleting it only once in the destructor (thanks to Cory Fields for the
idea).

Replaces the fix by Jonas Schnelli in #7610, see discussion there.

Github-Pull: #7637
Rebased-From: e2195037116f47b11b66452351dba4fe606423a2
2016-04-27 22:34:48 +02:00
jloughry
64fd0ce1d9 fix spelling of advertise in src and doc
Github-Pull: #7526
Rebased-From: 37767fd46f673a06864df6e14d3030622b1cb2c9
2016-04-27 22:34:48 +02:00
instagibbs
a9e73f71d4 Fix and cleanup listreceivedbyX documentation
Github-Pull: #7527
Rebased-From: c372572595b6b19a4dd88258401d8a0046ce4469
2016-04-27 22:34:48 +02:00
ptschip
90955940d5 Do not download transactions during inital sync
Github-Pull: #7164
Rebased-From: 39a525c21fd1b34df63ab30868423b97b708ee49
2016-04-27 22:34:47 +02:00
Evan Duffield
f2de437f05 mixed up actions/outcomes 2016-04-26 11:36:07 -07:00
Evan Duffield
7e742d2e7d cleaned up couple bugs 2016-04-26 11:34:53 -07:00
Evan Duffield
ad5d48dae4 Created nice interface for converting between:
- vote outcomes between string and int
- vote actions between string and int
2016-04-26 11:27:22 -07:00
Evan Duffield
d9d72dd7af enable governance cache 2016-04-26 10:48:09 -07:00
Evan Duffield
2df4059f4e Fix masternode voting object 2016-04-26 10:45:06 -07:00
UdjinM6
26b8d99be2 fix CGovernanceObject step1.5: not really a fix, just commented out simple broken parts (undeclared vars and functions, wrong number of arguments etc) to prove that it compiles now, needs to be actually fixed 2016-04-26 10:31:14 -07:00
UdjinM6
71bdc09470 fix CGovernanceObject step1: make, copy constructor, uint256, rpc 2016-04-26 10:31:00 -07:00
Evan Duffield
3fe02f4777 any help? 2016-04-25 21:08:36 -07:00
MarcoFalke
89ae85484c
Merge #7811: [0.12.2] qa Backports
6862627 Add listunspent() test for spendable/unspendable UTXO (Joao Fonseca)
28ba22c [qa] Remove misleading "errorString syntax" (MarcoFalke)
f1f1b82 [qa] py2: Unfiddle strings into bytes explicitly (MarcoFalke)
c0d9e31 Tests: make prioritise_transaction.py more robust (Suhas Daftuar)
ff9b436 [qa] Bug fixes and refactor (MarcoFalke)
b1dd64b [qa] wallet: Wait for reindex to catch up (MarcoFalke)
f23cb7c [qa] Add tests verifychain, lockunspent, getbalance, listsinceblock (MarcoFalke)
3316552 [qa] Test walletpassphrase timeout (MarcoFalke)
6aae129 [qa] wallet: Print maintenance (MarcoFalke)
ad8c743 [qa] Extend tests (MarcoFalke)
d89fbfe [qa] rpc-test: Normalize assert() (MarcoFalke)
2016-04-25 14:59:52 +02:00
crowning-
ddfc3e98f0 [UI] Obsolete icons (+references) removed 2016-04-24 23:03:27 +02:00
crowning-
d439375e3a [UI] Some standard (old) Bitcoin icons beautified (comment removed) 2016-04-20 22:39:21 +02:00
crowning-
00266a876f [UI] Some standard (old) Bitcoin icons beautified 2016-04-20 22:35:24 +02:00
crowning-
c755c45a93 [UI] Enable themed *.png icons again for Linux
Reference: my first comment here: https://github.com/dashpay/dash/pull/761
2016-04-20 17:35:53 +02:00
UdjinM6
b8109eb06b Assign app name in NetworkStyle::NetworkStyle(), fixes splash screen 2016-04-20 17:03:22 +03:00
crowning-
67214d9971 [UI] Parts of PR612 re-added 2016-04-20 08:04:46 +02:00
Evan Duffield
421678ac1d comment 2016-04-19 13:24:00 -07:00
Evan Duffield
73c430e4ca merged 2016-04-19 13:22:04 -07:00
Evan Duffield
378582fce5 update vote types 2016-04-19 12:08:01 -07:00
crowning-
b61849c697 [UI] Rebranding: removed PrivacyProtect from mixing button 2016-04-19 20:49:19 +02:00
Evan Duffield
fe5c4dd811 Converting governance system
- Generic usage of governance objects
- Added different voting types of signaling
- Removed budget commands (projection, mesc -- see sentinel https://github.com/evan82/sentinel/blob/master/docs/example4.md)
- Added various voting signaling mechanisms (origin funding, remove, valid, endorsed, milestones, outerstorage)
2016-04-19 09:51:15 -07:00
crowning-
e44dab084a [UI] Darksend changed to PrivacyProtect (UI+log) 2016-04-18 23:46:51 +02:00
Evan Duffield
94f448d6fa update gitignore 2016-04-16 17:29:41 -07:00
Evan Duffield
c981f296e1 update code to correctly use governance objects 2016-04-16 14:42:27 -07:00
Evan Duffield
59ddc0d71e added dynamic registers 2016-04-16 10:19:17 -07:00
Evan Duffield
31d8a4d16f clean up local mods 2016-04-15 09:39:33 -07:00
Evan Duffield
fe2b606f67 register notes 2016-04-15 02:10:38 -07:00
MarcoFalke
f1f1b82033 [qa] py2: Unfiddle strings into bytes explicitly
Github-Pull: #7853
Rebased-From: faa41ee204124da19dcf1e5b8a3aef1e216bf5e6, fa7abe0a00464e6aa88d55c63dba40878bbe5b79

 Conflicts:
	qa/rpc-tests/invalidtxrequest.py
	qa/rpc-tests/p2p-feefilter.py
	qa/rpc-tests/proxy_test.py
	qa/rpc-tests/test_framework/mininode.py
	qa/rpc-tests/test_framework/netutil.py
	src/test/bctest.py
2016-04-15 09:55:12 +02:00
Evan Duffield
6a68aea461 cleanup 2016-04-14 19:54:11 -07:00
Evan Duffield
e37ef5b386 fixing more errors 2016-04-14 19:14:27 -07:00
Evan Duffield
59976f3ee1 fixing more issues 2016-04-14 14:28:33 -07:00
Evan Duffield
8f0f5343ce added vote types and outcomes 2016-04-14 13:01:15 -07:00
Evan Duffield
b5476ca60a progress 2016-04-14 11:53:46 -07:00
Evan Duffield
f69d282256 cleaning up errors 2016-04-14 11:07:59 -07:00
Evan Duffield
7f64ed42ae clean up 2016-04-13 18:52:26 -07:00
Evan Duffield
3c8a3f6814 governance progress 2016-04-13 15:41:40 -07:00
UdjinM6
30dc6f4c97 fix flat database compiling 2016-04-13 10:53:13 -07:00
Evan Duffield
019eb07ac0 almost compiles 2016-04-12 09:00:19 -07:00
Evan Duffield
3c42774eb7 more progress spliting up the clasess 2016-04-10 07:46:19 -07:00
Evan Duffield
ebaee8f083 moved serialdb to template based class 2016-04-09 23:31:32 -07:00
Evan Duffield
8a13bc5180 updating colateral algo 2016-04-09 17:43:15 -07:00
Evan Duffield
138511f879 splitting progress pt . 2016-04-09 13:55:52 -07:00
Evan Duffield
a89d3164f6 removed finalized budget functionality from governance.* 2016-04-09 13:31:01 -07:00
Evan Duffield
fe7946f9fa preparing to split budgets and governance 2016-04-09 12:57:53 -07:00
Evan Duffield
7539ec3af8 move file 2016-04-09 12:02:02 -07:00