Alexander Block
206e5a1b47
Use big endian inversed height in CInstantSendDb
2019-04-05 13:40:18 +02:00
Alexander Block
4b9f6cd3a9
Use big endian inversed height in BuildInversedHeightKey
...
Otherwise keys are not properly sorted.
2019-04-05 13:39:29 +02:00
Alexander Block
53656b3e82
Compare CDataStream internal vector with unsigned comparison
2019-04-05 13:37:58 +02:00
Alexander Block
dd21d046f5
Avoid unnecessary calls to parentIt->GetKey
2019-04-05 13:37:25 +02:00
Alexander Block
1caee15425
Merge pull request #2836 from codablock/pr_is_removeconfirmed
...
Better handle removing of fully confirmed IS locks
2019-04-05 10:13:56 +02:00
Alexander Block
d34ec78664
Update wallet transactions when confirmed IS locks are removed
2019-04-05 08:18:56 +02:00
Alexander Block
b897505f85
Remove the need for maintaining the last ChainLocked block in the DB
2019-04-05 08:05:12 +02:00
Alexander Block
8e7083cb89
Use db.RemoveConfirmedISLocks() in NotifyChainLock to remove confirmed locks
...
Also move the actual logic into HandleFullyConfirmedBlock and call it
from NotifyChainLock and UpdatedBlockTip.
2019-04-05 08:05:12 +02:00
Alexander Block
4577438e87
Implement RemoveConfirmedInstantSendLocks to prune confirmed IS locks from DB
2019-04-05 08:05:12 +02:00
Alexander Block
d6e7758519
Keep track of when IS locks were mined
2019-04-05 06:36:09 +02:00
Alexander Block
20ec1de4c6
Merge pull request #2833 from codablock/pr_dip4_quorums
...
Implement quorum merkle roots for DIP4 coinbases and add quorums to MNLISTDIFF
2019-04-05 05:58:05 +02:00
UdjinM6
0a6416e064
Wipe llmq db on reindex ( #2835 )
2019-04-05 05:57:46 +02:00
Peter Bushnell
4af5ea8a7f
Remove netfulfilledman.h duplicate ( #2834 )
2019-04-05 05:57:33 +02:00
UdjinM6
208406df71
Re-introduce nInstantSendKeepLock check for LLMQ-based IS when spork19 is OFF ( #2829 )
2019-04-05 05:55:30 +02:00
Alexander Block
7d765a0fce
Track best block to later know if a DB upgrade is needed
2019-04-04 17:58:51 +02:00
UdjinM6
1a25c2084c
Apply suggestions from code review
...
Co-Authored-By: codablock <ablock84@gmail.com>
2019-04-04 17:41:30 +02:00
Alexander Block
282cb697aa
Use version 2 CCbTx in create_coinbase to fix test failures
2019-04-04 12:27:35 +02:00
Alexander Block
adc101a11a
Implement quorum commitment merkle root tests in dip4-coinbasemerkleroots.py
2019-04-04 12:27:35 +02:00
Alexander Block
40ad06e775
Return the fresh quorum hash from mine_quorum
2019-04-04 12:27:35 +02:00
Alexander Block
17b9318a04
Mine SIGN_HEIGHT_OFFSET additional blocks after the quorum commitment
...
Otherwise the fresh quorum won't be eligable for signing sessions.
2019-04-04 12:27:35 +02:00
Alexander Block
5e832e2fa6
Implement support for CbTx version 2 (with quorum merkle root)
...
Also implement support for new fields in MNLISTDIFF.
2019-04-04 12:27:35 +02:00
Alexander Block
b1b41f02ae
Fix a crash in mininode.py when inventory type is unknown
2019-04-04 12:27:35 +02:00
Alexander Block
44a3b9c90f
Don't use pindex->GetBlockHash() in ProcessCommitment
...
The block hash is not necessarily set at this point, for example when
coming from TestBlockValidity().
2019-04-04 12:27:35 +02:00
Alexander Block
f9dbe3ed50
Track in which block a quorum commitment was mined
...
And return it in GetMinedCommitment and the "quorum info" RPC
2019-04-04 12:27:35 +02:00
Alexander Block
ba459663be
Add deletedQuorums and newQuorums to CSimplifiedMNListEntry
2019-04-04 12:27:35 +02:00
Alexander Block
8f7929bed8
Implement and enforce quorum commitment merkle roots in coinbases
...
This bumps CCbTx::CURRENT_VERSION to 2 and enforces the new version after
DIP8 BIP9 activation.
2019-04-04 12:27:35 +02:00
Alexander Block
07620746a5
Implement GetMined(AndActive)CommitmentsUntilBlock and use it in ScanQuorums
...
This fixes a bug in ScanQuorums which made it return quorums which were not
mined at the time of pindexStart. This was due to quorumHashes being based
on older blocks (the phase=0 block) which are ancestors of pindexStart even
if the commitment was actually mined in a later block.
GetMinedAndActiveCommitmentsUntilBlock is also going to be used for quorum
commitment merkle roots in CCbTx.
This also removes GetFirstMinedQuorumHash as it's not needed anymore.
2019-04-04 12:27:35 +02:00
Alexander Block
d5250a333a
Track at which height a quorum commitment was mined
...
Also add upgrade code to allow smooth upgrades from v13 to v14.
2019-04-04 12:27:35 +02:00
Alexander Block
806948f90e
Store the full commitment in CQuorum
...
Instead of just individual fields of it.
2019-04-04 12:27:35 +02:00
Alexander Block
b67f6a0dc6
Implement CDBTransactionIterator
...
This iterator allows merged iteration of the key/values from the parent and
the not-yet-committed key/values from the transaction. This also works for
nested transactions (as used in CEvoDB).
It's interface mimics CDBIterator.
2019-04-04 12:27:35 +02:00
Alexander Block
6d1599bc68
Change CDBTransaction to compare keys by their serialized form
...
...instead of comparing by using the keys < operator.
There are 2 reasons for this:
1. This better mimics the behavior of CDBWrapper. Otherwise there is
a chance of discrepancy when it comes to key equality.
2. Next commit will introduce CDBTransactionIterator, which relies on
CDBTransaction and CDBWrapper being compatible in the way keys are
compared.
2019-04-04 12:27:35 +02:00
Alexander Block
5482083eba
Support passing CDataStream as key into CDBWrapper/CDBBatch/CDBIterator
...
This allow to pre-serialize keys in advance and pass the serialized form
into these classes.
2019-04-04 12:27:35 +02:00
Alexander Block
92c1cdcb81
Merge pull request #2832 from codablock/pr_dip4_tests
...
Implement DIP4 integration tests
2019-04-04 12:26:38 +02:00
UdjinM6
c23dfaf573
Update qa/rpc-tests/dip4-coinbasemerkleroots.py
...
Co-Authored-By: codablock <ablock84@gmail.com>
2019-04-04 11:46:52 +02:00
Alexander Block
9f2e5d0852
Use FromHex to deserialize block header
2019-04-04 10:42:13 +02:00
Alexander Block
999848432a
Implement dip4-coinbasemerkleroots.py integration tests
2019-04-04 10:39:15 +02:00
Alexander Block
ade5760a92
Allow registering MNs without actually starting them
...
This can be done by calling prepare_masternode() when inside run_test.
Also implement remove_masternode() which spends the collateral.
2019-04-04 10:39:15 +02:00
Alexander Block
ef6b6a1e64
Implement support for GETMNLISTD and MNLISTDIFF P2P message in mininode.py
2019-04-04 10:39:15 +02:00
Alexander Block
585b9c2818
Make CBlock.get_merkle_root static
...
We'll later need this method to calculate merkle roots outside of CBlock.
I'd like to avoid moving this code outside of CBlock as it might later
conflict with Bitcoin backports.
2019-04-04 10:39:15 +02:00
Alexander Block
1e0bdbc9b7
Implement CPartialMerkleTree and CMerkleBlock in mininode.py
...
Needed for upcoming MNLISTDIFF message support.
2019-04-04 10:39:15 +02:00
Alexander Block
297c266e91
Merge pull request #2831 from codablock/pr_v13_release
...
[0.13.x] Bump version to 0.13.3.0 and add release notes
2019-04-04 10:33:03 +02:00
UdjinM6
7022e83432
Update doc/release-notes.md
...
Co-Authored-By: codablock <ablock84@gmail.com>
2019-04-04 09:32:24 +02:00
Alexander Block
317ca5003b
Add release notes for 0.13.3.0
2019-04-04 09:23:12 +02:00
Alexander Block
25038ff36e
Bump version to 0.13.3.0
2019-04-04 09:02:09 +02:00
Alexander Block
53b2162e28
Harden spork15 value to 1047200 when on mainnet ( #2830 )
...
This is a hackish version of https://github.com/dashpay/dash/pull/2824 ,
meant for 0.13.x only. The reason for this hackish version is that the
code has diverged quite a bit and its not worth the effort to backport
the hardening code.
Even though 0.13.x included a lot of fixes for sporks handling and syncing,
I still feel more safe with hardening the spork15 block height. If
something goes wrong with spork syncing (e.g. its slower then the first
DIP2/3 block arrives), the whole sync process will fail otherwise.
2019-04-04 09:01:28 +02:00
Alexander Block
3db4e3111d
Merge pull request #2828 from codablock/pr_v13_backports
...
[0.13.x] Backports from develop
2019-04-04 08:35:21 +02:00
Alexander Block
d8778f5554
Implement CService in mininode.py
2019-04-04 08:24:38 +02:00
Alexander Block
02480402be
Implement deser_dyn_bitset and ser_dyn_bitset in mininode.py
2019-04-04 08:24:33 +02:00
Alexander Block
575cafc011
Do not skip pushing of vMatch and vHashes in CMerkleBlock ( #2826 )
...
Even if its a TX type which we don't want in merkle blocks. Wrongfully
omitting the pushes causes invalid partial merkle trees, which in turn
causes SPV nodes to ban us.
2019-04-04 08:21:52 +02:00
Alexander Block
b0850fad06
Do not skip pushing of vMatch and vHashes in CMerkleBlock ( #2826 )
...
Even if its a TX type which we don't want in merkle blocks. Wrongfully
omitting the pushes causes invalid partial merkle trees, which in turn
causes SPV nodes to ban us.
2019-04-04 08:11:04 +02:00