521d4ae08f
* Let Commit() return void
The boolean return value will loose its meaning in the next commit
* Implement 2-stage commits for CDBTransaction and CScopedDBTransaction
CDBTransaction is changed to allow CDBBatch, CDBWrapper and other
CDBTransactions as parent instead of just CDBWrapper. This in turn allows
to implement multi-staged commits in CEvoDB.
We now have the "current transaction" which is started and ended (commit
or rollback) for each call to Connect-/DisconnectBlock. When the current
transaction is committed, it moves its contents into the "root transaction"
instead of directly writing to CDBWrapper.
CommitRootTransaction() then handles the final commitment to CDBWrapper. It
is called at the same time when the chainstate is flushed to disk, which
guarantees consistency between chainstate and CEvoDB.
* Allow to efficiently move values into parent transactions to avoid copies
When CDBTransaction<CDBTransaction<...>>::Commit() is called, we can avoid
copying values from this transaction to the parent transaction and instead
pass values by rvalue and let the contents be moved.
* Revert "Force FlushStateToDisk on ConnectTip/DisconnectTip while not in IBD (#2560)"
This reverts commit 6dfceaba5a.
42 lines
1.1 KiB
C++
42 lines
1.1 KiB
C++
// Copyright (c) 2018 The Dash Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include "evodb.h"
|
|
|
|
CEvoDB* evoDb;
|
|
|
|
CEvoDB::CEvoDB(size_t nCacheSize, bool fMemory, bool fWipe) :
|
|
db(fMemory ? "" : (GetDataDir() / "evodb"), nCacheSize, fMemory, fWipe),
|
|
rootBatch(db),
|
|
rootDBTransaction(db, rootBatch),
|
|
curDBTransaction(rootDBTransaction, rootDBTransaction)
|
|
{
|
|
}
|
|
|
|
bool CEvoDB::CommitRootTransaction()
|
|
{
|
|
assert(curDBTransaction.IsClean());
|
|
rootDBTransaction.Commit();
|
|
bool ret = db.WriteBatch(rootBatch);
|
|
rootBatch.Clear();
|
|
return ret;
|
|
}
|
|
|
|
bool CEvoDB::VerifyBestBlock(const uint256& hash)
|
|
{
|
|
// Make sure evodb is consistent.
|
|
// If we already have best block hash saved, the previous block should match it.
|
|
uint256 hashBestBlock;
|
|
bool fHasBestBlock = Read(EVODB_BEST_BLOCK, hashBestBlock);
|
|
uint256 hashBlockIndex = fHasBestBlock ? hash : uint256();
|
|
assert(hashBestBlock == hashBlockIndex);
|
|
|
|
return fHasBestBlock;
|
|
}
|
|
|
|
void CEvoDB::WriteBestBlock(const uint256& hash)
|
|
{
|
|
Write(EVODB_BEST_BLOCK, hash);
|
|
}
|