neobytes/doc
Alexander Block 2f21e55514 Remove legacy InstantSend code (#3020)
* Remove ppszTypeName from protocol.cpp and reimplement GetCommand

This removes the need to carefully maintain ppszTypeName, which required
correct order and also did not allow to permanently remove old message
types.

To get the command name for an INV type, GetCommandInternal uses a switch
which needs to be maintained from now on.

The way this is implemented also resembles the way it is implemented in
Bitcoin today, but it's not identical. The original PR that introduced the
switch case in Bitcoin was part of the Segwit changes and thus never got
backported. I decided to implement it in a slightly different way that
avoids throwing exceptions when an unknown INV type is encountered.

IsKnownType will now also leverage GetCommandInternal() to figure out if
the INV type is known locally. This has the side effect of old/legacy
message types to return false from now on. We will depend on this side
effect in later commits when we remove legacy InstantSend code.

* Stop handling/relaying legacy IX messages

When we receive an IX message, we simply treat it as a regular TX and relay
it as such.

We'll however still request IX messages when they are announced to us. We
can't simply revert to requesting TX messages in this case as it might
result in the other peer not answering due to the TX not being in mapRelay
yet. We should at some point in the future completely drop handling of IX
messages instead.

* Remove IsNewInstantSendEnabled() and only use IsInstantSendEnabled()

* Remove legacy InstantSend from GUI

* Remove InstantSend from Bitcoin/Dash URIs

* Remove legacy InstantSend from RPC commands

* Remove legacy InstantSend from wallet

* Remove legacy instantsend.h include

* Remove legacy InstantSend from validation code

* Completely remove remaining legacy InstantSend code

* Remove now unused spork

* Fix InstantSend related test failures

* Remove now obsolete auto IS tests

* Make spork2 and spork3 disabled by default

This should have no influence on mainnet as these sporks are actually set
there. This will however affect regtest, which shouldn't have LLMQ based
InstantSend enabled by default.

* Remove instantsend tests from dip3-deterministicmns.py

These were only testing legacy InstantSend

* Fix .QCheckBox#checkUsePrivateSend styling a bit

* s/TXLEGACYLOCKREQUEST/LEGACYTXLOCKREQUEST/

* Revert "verified via InstantSend" back to "verified via LLMQ based InstantSend"

* Use cmd == nullptr instead of !cmd

* Remove last parameter from AvailableCoins call

This was for fUseInstantSend which is not present anymore since rebase
2019-07-09 17:50:08 +03:00
..
gitian-building
man Update manpages for 0.14.0.2 (#2999) 2019-06-26 06:03:05 +02:00
release-notes/dash Bump version to 0.14.0.2 and copy release notes (#2991) 2019-06-24 12:50:35 +02:00
.gitignore Merge #10166: Ignore Doxyfile generated from Doxyfile.in template. 2019-05-19 20:43:00 -05:00
assets-attribution.md
benchmarking.md Use "Dash Core" instead of "dash-core" in some places and Dashify 2018-01-16 08:30:14 +01:00
bips.md Revert "Merge #7542: Implement "feefilter" P2P message" (#2025) 2018-04-11 18:16:43 +03:00
bitcoin_logo_doxygen.png
build-cross.md Missing = characters (#2676) 2019-02-01 12:07:39 +03:00
build-generic.md Missing = characters (#2676) 2019-02-01 12:07:39 +03:00
build-osx.md Drop --c++11 brew flag in build-osx.md (#2755) 2019-03-11 11:16:28 +03:00
build-unix.md Minor build documentation updates (#2343) 2018-10-15 14:53:38 +03:00
build-windows.md Update build documentation (#2323) 2018-09-28 10:55:46 +03:00
developer-notes.md Merge #10381: Shadowing warnings are not enabled by default, update doc accordingly 2019-06-19 08:20:15 -05:00
dnsseed-policy.md Update dnsseed-policy.md (#2751) 2019-03-08 21:21:20 +03:00
Doxyfile.in Merge #10155: build: Deduplicate version numbers 2019-06-14 01:25:59 -05:00
files.md Remove legacy InstantSend code (#3020) 2019-07-09 17:50:08 +03:00
gitian-building.md Merge #10566: [docs] Use the "domain name setup" image (previously unused) in the gitian docs 2019-07-08 13:50:05 -05:00
init.md
instantsend.md Report instantlock: true for transactions locked via ChainLocks (#2877) 2019-04-25 18:38:26 +03:00
keepass.md Update links and references to current communication channels (#1906) 2018-02-08 08:44:21 +03:00
masternode-budget.md Remove all legacy/compatibility MN code (#2600) 2019-01-03 12:17:43 +03:00
README_osx.md
README_windows.txt Merge #10155: build: Deduplicate version numbers 2019-06-14 01:25:59 -05:00
README.md Merge #10155: build: Deduplicate version numbers 2019-06-14 01:25:59 -05:00
reduce-traffic.md
release-notes.md [v0.14.0.x] Update release notes for 0.14.0.2 (#3012) 2019-07-03 15:56:09 +02:00
release-process.md Merge #10155: build: Deduplicate version numbers 2019-06-14 01:25:59 -05:00
REST-interface.md
shared-libraries.md Merge #8848: Add NULLDUMMY verify flag in bitcoinconsensus.h 2018-01-30 20:28:51 +01:00
tor.md
translation_process.md Update links and references to current communication channels (#1906) 2018-02-08 08:44:21 +03:00
translation_strings_policy.md Translations201804 (#2012) 2018-04-30 01:10:20 +03:00
travis-ci.md
zmq.md Implement rawchainlocksig and rawtxlocksig (#2930) 2019-05-23 12:13:58 +03:00

Dash Core

This is the official reference wallet for Dash digital currency and comprises the backbone of the Dash peer-to-peer network. You can download Dash Core or build it yourself using the guides below.

Running

The following are some helpful notes on how to run Dash on your native platform.

Unix

Unpack the files into a directory and run:

  • bin/dash-qt (GUI) or
  • bin/dashd (headless)

Windows

Unpack the files into a directory, and then run dash-qt.exe.

OS X

Drag Dash-Qt to your applications folder, and then run Dash-Qt.

Need Help?

Building

The following are developer notes on how to build Dash Core on your native platform. They are not complete guides, but include notes on the necessary libraries, compile flags, etc.

Development

The Dash Core repo's root README contains relevant information on the development process and automated testing.

Resources

Miscellaneous

License

Distributed under the MIT software license. This product includes software developed by the OpenSSL Project for use in the OpenSSL Toolkit. This product includes cryptographic software written by Eric Young (eay@cryptsoft.com), and UPnP software written by Thomas Bernard.