17bb230d74
7148b74dc [tests] Functional tests must explicitly set num_nodes (John Newbery) 5448a1471 [tests] don't override __init__() in individual tests (John Newbery) 6cf094a02 [tests] Avoid passing around member variables in test_framework (John Newbery) 36b626867 [tests] TestNode: separate add_node from start_node (John Newbery) be2a2ab6a [tests] fix - use rpc_timeout as rpc timeout (John Newbery) Pull request description: Some additional tidyups after the introduction of TestNode: - commit 1 makes TestNode use the correct rpc timeout. This should have been included in #11077 - commit 2 separates `add_node()` from `start_node()` as originally discussed here: https://github.com/bitcoin/bitcoin/pull/10556#discussion_r121161453 with @kallewoof . The test writer no longer needs to assign to `self.nodes` when starting/stopping nodes. - commit 3 adds a `set_test_params()` method, so individual tests don't need to override `__init__()` and call `super().__init__()` Tree-SHA512: 0adb030623b96675b5c29e2890ce99ccd837ed05f721d0c91b35378c5ac01b6658174aac12f1f77402e1d38b61f39b3c43b4df85c96952565dde1cda05b0db84
79 lines
3.2 KiB
Python
Executable File
79 lines
3.2 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2014-2016 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test the zapwallettxes functionality.
|
|
|
|
- start two dashd nodes
|
|
- create two transactions on node 0 - one is confirmed and one is unconfirmed.
|
|
- restart node 0 and verify that both the confirmed and the unconfirmed
|
|
transactions are still available.
|
|
- restart node 0 with zapwallettxes and persistmempool, and verify that both
|
|
the confirmed and the unconfirmed transactions are still available.
|
|
- restart node 0 with just zapwallettxed and verify that the confirmed
|
|
transactions are still available, but that the unconfirmed transaction has
|
|
been zapped.
|
|
"""
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import (
|
|
assert_equal,
|
|
assert_raises_jsonrpc,
|
|
)
|
|
from test_framework.mininode import wait_until
|
|
|
|
class ZapWalletTXesTest (BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 2
|
|
|
|
def run_test(self):
|
|
self.log.info("Mining blocks...")
|
|
self.nodes[0].generate(1)
|
|
self.sync_all()
|
|
self.nodes[1].generate(100)
|
|
self.sync_all()
|
|
|
|
# This transaction will be confirmed
|
|
txid1 = self.nodes[0].sendtoaddress(self.nodes[1].getnewaddress(), 10)
|
|
|
|
self.nodes[0].generate(1)
|
|
self.sync_all()
|
|
|
|
# This transaction will not be confirmed
|
|
txid2 = self.nodes[0].sendtoaddress(self.nodes[1].getnewaddress(), 20)
|
|
|
|
# Confirmed and unconfirmed transactions are now in the wallet.
|
|
assert_equal(self.nodes[0].gettransaction(txid1)['txid'], txid1)
|
|
assert_equal(self.nodes[0].gettransaction(txid2)['txid'], txid2)
|
|
|
|
# Stop-start node0. Both confirmed and unconfirmed transactions remain in the wallet.
|
|
self.stop_node(0)
|
|
self.start_node(0)
|
|
|
|
assert_equal(self.nodes[0].gettransaction(txid1)['txid'], txid1)
|
|
assert_equal(self.nodes[0].gettransaction(txid2)['txid'], txid2)
|
|
|
|
# Stop node0 and restart with zapwallettxes and persistmempool. The unconfirmed
|
|
# transaction is zapped from the wallet, but is re-added when the mempool is reloaded.
|
|
self.stop_node(0)
|
|
self.start_node(0, ["-persistmempool=1", "-zapwallettxes=2"])
|
|
|
|
wait_until(lambda: self.nodes[0].getmempoolinfo()['size'] == 1, timeout=3)
|
|
|
|
assert_equal(self.nodes[0].gettransaction(txid1)['txid'], txid1)
|
|
assert_equal(self.nodes[0].gettransaction(txid2)['txid'], txid2)
|
|
|
|
# Stop node0 and restart with zapwallettxes, but not persistmempool.
|
|
# The unconfirmed transaction is zapped and is no longer in the wallet.
|
|
self.stop_node(0)
|
|
self.start_node(0, ["-zapwallettxes=2"])
|
|
|
|
# tx1 is still be available because it was confirmed
|
|
assert_equal(self.nodes[0].gettransaction(txid1)['txid'], txid1)
|
|
|
|
# This will raise an exception because the unconfirmed transaction has been zapped
|
|
assert_raises_jsonrpc(-5, 'Invalid or non-wallet transaction id', self.nodes[0].gettransaction, txid2)
|
|
|
|
if __name__ == '__main__':
|
|
ZapWalletTXesTest().main()
|