neobytes/src/evo
Alexander Block 88f7bf0d82
Don't delete/add values to the unique property map when it's null (#2538)
* Don't delete/add values to the unique property map when it's null

This happens when revoking operator keys, as the revoked MN will then have
the address and operator keys set to the null representation. We shouldn't
add the null value to the unique property map as otherwise future revokes
crash in an assert.

* Assert that no null values are passed to Add/DeleteUniqueProperty

* Check for null values before calling Add/DeleteUniqueProperty

* Apply suggestions from code review

Co-Authored-By: codablock <ablock84@gmail.com>

* Add user generated default constructors to BLS primitives

Fixes build issues on Mac:

In file included from evo/deterministicmns.cpp:5:
./evo/deterministicmns.h:375:24: error: default initialization of an object of const type 'const CBLSPublicKey' without a user-provided default constructor
        static const T nullValue;
                       ^
2018-12-10 08:31:09 +01:00
..
cbtx.cpp Avoid printing DIP3/DIP4 related logs twice (#2525) 2018-12-06 08:06:37 +01:00
cbtx.h Clang evo folder and activemasternode.* (#2418) 2018-11-06 11:54:23 +03:00
deterministicmns.cpp Don't delete/add values to the unique property map when it's null (#2538) 2018-12-10 08:31:09 +01:00
deterministicmns.h Don't delete/add values to the unique property map when it's null (#2538) 2018-12-10 08:31:09 +01:00
evodb.cpp Clang evo folder and activemasternode.* (#2418) 2018-11-06 11:54:23 +03:00
evodb.h Clang evo folder and activemasternode.* (#2418) 2018-11-06 11:54:23 +03:00
providertx.cpp Forbid version=0 in special TXs (#2473) 2018-11-22 06:05:32 +01:00
providertx.h Clang evo folder and activemasternode.* (#2418) 2018-11-06 11:54:23 +03:00
simplifiedmns.cpp Properly initialize confirmedHash in CSimplifiedMNListEntry (#2479) 2018-11-23 10:40:46 +01:00
simplifiedmns.h Implement BuildSimplifiedDiff in CDeterministicMNList 2018-11-15 10:42:39 +01:00
specialtx.cpp Refactor CQuorumBlockProcessor and CDeterministicMNManager (#2536) 2018-12-10 06:05:29 +01:00
specialtx.h Clang evo folder and activemasternode.* (#2418) 2018-11-06 11:54:23 +03:00