8b5f47e686
* Remove un-needed #includes (what is the policy?) Data was duplicated in masternode_info_t and CMasternode classes: * CMasternode is changed to inherit from masternode_info_t so the data members are inherited rather than repeated (also inherits unrepeated nTimeLastPing and fInfoValid members; this slight intrusiveness made up for in simplicity). * Use in-class member initializers (C++11) for defaults, so only non-default initializers are required in the lists. Allows to shorten repetitous constructor initializer lists. This makes checking for uninitialized data simpler. * Default constructors are defined as "= default;" if possible. * masternode_info_t is changed to behave like an aggregate (but requires over-complicated constructors until c++14). There are pros and cons here - aggregate initialization is convenient but implicit). * Removed user-defined swap functions. They appear to only be used in operator= definitions, using the copy-in,swap-and-return idiom: * Default operator=, where possible. * Move in class `friend bool operator==` out-of-class. |
||
---|---|---|
.tx | ||
build-aux/m4 | ||
contrib | ||
dash-docs | ||
depends | ||
doc | ||
qa | ||
share | ||
src | ||
.gitattributes | ||
.gitignore | ||
.travis.yml | ||
autogen.sh | ||
configure.ac | ||
CONTRIBUTING.md | ||
COPYING | ||
INSTALL | ||
libdashconsensus.pc.in | ||
Makefile.am | ||
README.md |
Dash Core staging tree 0.12.1
What is Dash?
Dash is an experimental new digital currency that enables anonymous, instant payments to anyone, anywhere in the world. Dash uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Dash Core is the name of the open source software which enables the use of this currency.
For more information, as well as an immediately useable, binary version of the Dash Core software, see https://www.dash.org/get-dash/.
License
Dash Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.
Development Process
The master
branch is meant to be stable. Development is normally done in separate branches.
Tags are created to indicate new official,
stable release versions of Dash Core.
The contribution workflow is described in CONTRIBUTING.md.
Testing
Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
Automated Testing
Developers are strongly encouraged to write unit tests for new code, and to
submit new unit tests for old code. Unit tests can be compiled and run
(assuming they weren't disabled in configure) with: make check
There are also regression and integration tests of the RPC interface, written
in Python, that are run automatically on the build server.
These tests can be run (if the test dependencies are installed) with: qa/pull-tester/rpc-tests.py
The Travis CI system makes sure that every pull request is built for Windows and Linux, OS X, and that unit and sanity tests are automatically run.
Manual Quality Assurance (QA) Testing
Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
Translations
Changes to translations as well as new translations can be submitted to Dash Core's Transifex page.
Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.
Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.
Translators should also follow the forum.