e3df910822
* Pass CCoinsView reference to special TX handling methods * Allow referencing other TX outputs for ProRegTx collateral * Remove "collateralAmount" from "protx register" * Rename "protx register" to "protx fund_register" * Remove UpdateSpork15Value from CDeterministicMNManager Was not used/implemented anymore * Lock masternode collaterals after chain/DIP3 is fully initialized Otherwise detection of collaterals does not work. * Implement new "protx register" RPC which uses existing collaterals * Remove "masternode info" RPC It is not consistent with other "masternode" RPCs anymore as it requires the ProRegTx hash while all other RPCs work with the collateral. * Load sporks from disk cache before initializing the chain Otherwise spork15 is not loaded when we check it for the first time. * Implement "protx info" RPC * Use "protx info" instead of "masternode info" in DIP3 tests * Test external collaterals for ProTx * Handle review comments * Don't pass CCoinView reference when it's not used * Revert "Pass CCoinsView reference to special TX handling methods" This reverts commit 28688724e112c8fe18e44aef055768dbbc068d7d. * Use GetUTXOCoin instead of now removed coinsView Also remove collateral height check as GetUTXOCoin only returns confirmed coins. * Add conflict handling for external collaterals to mempool * Handle review comments (squashed Github suggestions) Co-Authored-By: codablock <ablock84@gmail.com> |
||
---|---|---|
.github | ||
.tx | ||
build-aux/m4 | ||
ci | ||
contrib | ||
dash-docs | ||
depends | ||
doc | ||
docker | ||
qa | ||
share | ||
src | ||
.gitattributes | ||
.gitignore | ||
.travis.yml | ||
autogen.sh | ||
CMakeLists.txt | ||
configure.ac | ||
CONTRIBUTING.md | ||
COPYING | ||
INSTALL.md | ||
Jenkinsfile | ||
Jenkinsfile.gitian | ||
libdashconsensus.pc.in | ||
Makefile.am | ||
README.md |
Dash Core staging tree 0.12.4
What is Dash?
Dash is an experimental digital currency that enables anonymous, instant payments to anyone, anywhere in the world. Dash uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Dash Core is the name of the open source software which enables the use of this currency.
For more information, as well as an immediately useable, binary version of the Dash Core software, see https://www.dash.org/get-dash/.
License
Dash Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.
Development Process
The master
branch is meant to be stable. Development is normally done in separate branches.
Tags are created to indicate new official,
stable release versions of Dash Core.
The contribution workflow is described in CONTRIBUTING.md.
Testing
Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
Automated Testing
Developers are strongly encouraged to write unit tests for new code, and to
submit new unit tests for old code. Unit tests can be compiled and run
(assuming they weren't disabled in configure) with: make check
. Further details on running
and extending unit tests can be found in /src/test/README.md.
There are also regression and integration tests of the RPC interface, written
in Python, that are run automatically on the build server.
These tests can be run (if the test dependencies are installed) with: qa/pull-tester/rpc-tests.py
The Travis CI system makes sure that every pull request is built for Windows, Linux, and OS X, and that unit/sanity tests are run automatically.
Manual Quality Assurance (QA) Testing
Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
Translations
Changes to translations as well as new translations can be submitted to Dash Core's Transifex page.
Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.
Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.
Translators should also follow the forum.