Neobytes - Reinventing Cryptocurrency https://neobytes.network/
Go to file
Wladimir J. van der Laan e5e3572e9d Merge #13946: p2p: Clarify control flow in ProcessMessage
fa6c3dea420b6c50c164ccc34f4e9e8a7d9a8022 p2p: Clarify control flow in ProcessMessage() (MarcoFalke)

Pull request description:

  `ProcessMessage` is effectively a massive switch case construct. In the past there were attempts to clarify the control flow in `ProcessMessage()` by moving each case into a separate static function (see #9608). It was closed because it wasn't clear if moving each case into a function was the right approach.
  Though, we can quasi treat each case as a function by adding a return statement to each case. (Can be seen as a continuation of bugfix #13162)

  This patch does exactly that.

  Also note that this patch is a subset of previous approaches such as #9608 and #10145.

  Review suggestion: `git diff HEAD~ --function-context`

Tree-SHA512: 91f6106840de2f29bb4f10d27bae0616b03a91126e6c6013479e1dd79bee53f22a78902b631fe85517dd5dc0fa7239939b4fefc231851a13c819458559f6c201
2020-02-03 13:04:00 +03:00
.github Add link to bugcrowd in issue template (#2716) 2019-02-19 13:05:59 +03:00
.tx Merge remote-tracking branch 'bitcoin/0.12' into HEAD 2016-02-06 16:48:04 +03:00
build-aux/m4 Merge #10803: Explicitly search for bdb5.3. 2019-07-24 11:59:09 -05:00
ci Use -Wno-psabi for arm builds on Travis/Gitlab (#3264) 2020-01-10 13:30:08 +03:00
contrib Add automake package to dash-win-signer's packages list (#3307) 2020-02-03 13:04:00 +03:00
depends Merge #12607: depends: Remove ccache 2019-11-04 13:20:45 +01:00
doc [Trivial] Release note update (#3308) 2020-01-29 09:25:23 +01:00
docker Automatically build and push docker image to docker.io/dashpay/dashd-develop (#1809) 2018-01-10 12:17:43 +03:00
share trivial: adding SVG and high contrast icons (#3209) 2020-01-17 15:50:24 +01:00
src Merge #13946: p2p: Clarify control flow in ProcessMessage 2020-02-03 13:04:00 +03:00
test Fix dip4-coinbasemerkleroots.py race condition (#3297) 2020-01-23 00:23:11 +03:00
.gitattributes
.gitignore bitcoin -> dash 2019-08-24 11:11:25 -05:00
.gitlab-ci.yml Fix pull request detection in .gitlab-ci.yml (#3256) 2020-01-10 13:29:22 +03:00
.travis.yml Add support for Gitlab CI (#3149) 2019-10-16 11:48:46 +02:00
autogen.sh Merge #8784: Copyright headers for build scripts 2018-01-12 08:02:45 +01:00
CMakeLists.txt Enable stacktrace support in gitian builds (#3006) 2019-07-02 07:16:11 +03:00
configure.ac Bump copyright year to 2020 (#3290) 2020-01-17 15:51:08 +01:00
CONTRIBUTING.md Merge #11003: Docs: Capitalize bullet points in CONTRIBUTING guide 2019-08-12 09:07:03 -05:00
COPYING Bump copyright year to 2020 (#3290) 2020-01-17 15:51:08 +01:00
INSTALL.md Dashify INSTALL.md and build-unix.md 2018-01-12 16:12:54 +01:00
Jenkinsfile Perform Jenkins builds in /dash-src all the time to fix caching issues (#2242) 2018-08-29 13:03:18 +03:00
Jenkinsfile.gitian Let ccache compress the cache by itself instead of compressing ccache.tar (#2456) 2018-11-19 07:31:13 +01:00
libdashconsensus.pc.in Merge #7192: Unify product name to as few places as possible 2017-12-11 08:30:26 +01:00
Makefile.am Merge #11530: Add share/rpcuser to dist. source code archive 2019-09-30 08:33:16 +02:00
README.md Bump version to 0.15 and update few const-s/chainparams (#3204) 2019-11-21 23:52:35 +03:00

Dash Core staging tree 0.15

master: Build Status develop: Build Status

https://www.dash.org

What is Dash?

Dash is an experimental digital currency that enables instant, private payments to anyone, anywhere in the world. Dash uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Dash Core is the name of the open source software which enables the use of this currency.

For more information, as well as an immediately useable, binary version of the Dash Core software, see https://www.dash.org/get-dash/.

License

Dash Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is meant to be stable. Development is normally done in separate branches. Tags are created to indicate new official, stable release versions of Dash Core.

The contribution workflow is described in CONTRIBUTING.md.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python, that are run automatically on the build server. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The Travis CI system makes sure that every pull request is built for Windows, Linux, and OS X, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Dash Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.

Translators should also follow the forum.