f95aae2b30
* Remove CActiveLegacyMasternodeManager * Remove sentinelping RPC * Remove unused P2P messages and inv types There are still places where these are used in the code. The next commits will clean these up. * Remove MNB/MNP/MNVERIFY related code from masternode(man).h/cpp * Remove all legacy code regarding block MN payee voting * Remove MASTERNODE_SYNC_LIST and MASTERNODE_SYNC_MNW states Also replace all uses of IsMasternodeListSynced and IsWinnersListSynced with IsBlockchainSynced. * Remove unsupported masternode RPCs * Remove UpdateLastPaid methods * Remove duplicate deterministicmns.h include * Remove masternode.conf support * Remove legacy MN lists support from masternode list GUI * Remove unnecessary AskForMN call * Remove compatibility code in CPrivateSendQueue::GetSignatureHash * Don't add locally calculated MN payee in case GetBlockTxOuts failed This is not valid in DIP3 mode * Remove check for IsDeterministicMNsSporkActive in "masternode status" * Move CMasternode::IsValidNetAddr to CActiveDeterministicMasternodeManager * Remove use of CMasternode::CheckCollateral in governance code * Remove uses of MASTERNODE_SENTINEL_PING_MAX_SECONDS/MASTERNODE_SENTINEL_PING_MAX_SECONDS * Remove support for "-masternodeprivkey" * Remove pre-DIP3 vote cleanup * Remove compatibility code for quorumModifierHash/masternodeProTxHash * Remove check for invalid nBlockHeight in CMasternodePayments::GetBlockTxOuts ...and let it crash instead. We expect this method to be called with the correct height now (after DIP3 was fully deployed). * Remove ECDSA based Sign/CheckSignature from CGovernanceObject Only masternodes sign governance objects, so there is no need for ECDSA support here anymore. * Always add superblock and MN reward payments into new block * Always check block payees (except if fLiteMode==true) * Always allow superblock and MN payees in same block * Remove/Fix a few references to masternode.conf and related stuff Also delete guide-startmany.md and masternode_conf.md * Implement NotifyMasternodeListChanged signal and call governance maintenance * Remove non-DIP3 code path from CMasternodeMan::Find * Remove remaining unused code from CMasternode/CMasternodeMan * Always load governance.dat on startup * Mine an empty block instead of incrementing nHeight from chain tip in miner tests This test is crashing otherwise in GetBlockTxOuts as it tries to access a previous block that is not existing. * Skip MN payments verification on historical blocks (pre-DIP3 blocks) Even though DIP3 was active on BIP9 level, the spork was not active yet at that point meaning that payments were not enforced at that time. * Remove unused state and CollateralStatus enums * Unconditionally return false from IsBlockPayeeValid when IsTransactionValid returns false IsTransactionValid already handles the case where IsDIP3Active() returns false, making it return true. * Add override keyword to CDSNotificationInterface::NotifyMasternodeListChanged * Fix help for masternodelist status (POSE_BANNED and no OUTPOINT_SPENT)
770 lines
25 KiB
C++
770 lines
25 KiB
C++
// Copyright (c) 2014-2018 The Dash Core developers
|
|
// Distributed under the MIT/X11 software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include "governance-object.h"
|
|
#include "core_io.h"
|
|
#include "governance-classes.h"
|
|
#include "governance-validators.h"
|
|
#include "governance-vote.h"
|
|
#include "governance.h"
|
|
#include "instantx.h"
|
|
#include "masternode-sync.h"
|
|
#include "masternodeman.h"
|
|
#include "messagesigner.h"
|
|
#include "util.h"
|
|
|
|
#include <string>
|
|
#include <univalue.h>
|
|
|
|
CGovernanceObject::CGovernanceObject() :
|
|
cs(),
|
|
nObjectType(GOVERNANCE_OBJECT_UNKNOWN),
|
|
nHashParent(),
|
|
nRevision(0),
|
|
nTime(0),
|
|
nDeletionTime(0),
|
|
nCollateralHash(),
|
|
vchData(),
|
|
masternodeOutpoint(),
|
|
vchSig(),
|
|
fCachedLocalValidity(false),
|
|
strLocalValidityError(),
|
|
fCachedFunding(false),
|
|
fCachedValid(true),
|
|
fCachedDelete(false),
|
|
fCachedEndorsed(false),
|
|
fDirtyCache(true),
|
|
fExpired(false),
|
|
fUnparsable(false),
|
|
mapCurrentMNVotes(),
|
|
cmmapOrphanVotes(),
|
|
fileVotes()
|
|
{
|
|
// PARSE JSON DATA STORAGE (VCHDATA)
|
|
LoadData();
|
|
}
|
|
|
|
CGovernanceObject::CGovernanceObject(const uint256& nHashParentIn, int nRevisionIn, int64_t nTimeIn, const uint256& nCollateralHashIn, const std::string& strDataHexIn) :
|
|
cs(),
|
|
nObjectType(GOVERNANCE_OBJECT_UNKNOWN),
|
|
nHashParent(nHashParentIn),
|
|
nRevision(nRevisionIn),
|
|
nTime(nTimeIn),
|
|
nDeletionTime(0),
|
|
nCollateralHash(nCollateralHashIn),
|
|
vchData(ParseHex(strDataHexIn)),
|
|
masternodeOutpoint(),
|
|
vchSig(),
|
|
fCachedLocalValidity(false),
|
|
strLocalValidityError(),
|
|
fCachedFunding(false),
|
|
fCachedValid(true),
|
|
fCachedDelete(false),
|
|
fCachedEndorsed(false),
|
|
fDirtyCache(true),
|
|
fExpired(false),
|
|
fUnparsable(false),
|
|
mapCurrentMNVotes(),
|
|
cmmapOrphanVotes(),
|
|
fileVotes()
|
|
{
|
|
// PARSE JSON DATA STORAGE (VCHDATA)
|
|
LoadData();
|
|
}
|
|
|
|
CGovernanceObject::CGovernanceObject(const CGovernanceObject& other) :
|
|
cs(),
|
|
nObjectType(other.nObjectType),
|
|
nHashParent(other.nHashParent),
|
|
nRevision(other.nRevision),
|
|
nTime(other.nTime),
|
|
nDeletionTime(other.nDeletionTime),
|
|
nCollateralHash(other.nCollateralHash),
|
|
vchData(other.vchData),
|
|
masternodeOutpoint(other.masternodeOutpoint),
|
|
vchSig(other.vchSig),
|
|
fCachedLocalValidity(other.fCachedLocalValidity),
|
|
strLocalValidityError(other.strLocalValidityError),
|
|
fCachedFunding(other.fCachedFunding),
|
|
fCachedValid(other.fCachedValid),
|
|
fCachedDelete(other.fCachedDelete),
|
|
fCachedEndorsed(other.fCachedEndorsed),
|
|
fDirtyCache(other.fDirtyCache),
|
|
fExpired(other.fExpired),
|
|
fUnparsable(other.fUnparsable),
|
|
mapCurrentMNVotes(other.mapCurrentMNVotes),
|
|
cmmapOrphanVotes(other.cmmapOrphanVotes),
|
|
fileVotes(other.fileVotes)
|
|
{
|
|
}
|
|
|
|
bool CGovernanceObject::ProcessVote(CNode* pfrom,
|
|
const CGovernanceVote& vote,
|
|
CGovernanceException& exception,
|
|
CConnman& connman)
|
|
{
|
|
LOCK(cs);
|
|
|
|
// do not process already known valid votes twice
|
|
if (fileVotes.HasVote(vote.GetHash())) {
|
|
// nothing to do here, not an error
|
|
std::ostringstream ostr;
|
|
ostr << "CGovernanceObject::ProcessVote -- Already known valid vote";
|
|
LogPrint("gobject", "%s\n", ostr.str());
|
|
exception = CGovernanceException(ostr.str(), GOVERNANCE_EXCEPTION_NONE);
|
|
return false;
|
|
}
|
|
|
|
auto mnList = deterministicMNManager->GetListAtChainTip();
|
|
|
|
if (!mnList.HasValidMNByCollateral(vote.GetMasternodeOutpoint())) {
|
|
std::ostringstream ostr;
|
|
ostr << "CGovernanceObject::ProcessVote -- Masternode " << vote.GetMasternodeOutpoint().ToStringShort() << " not found";
|
|
exception = CGovernanceException(ostr.str(), GOVERNANCE_EXCEPTION_WARNING);
|
|
if (cmmapOrphanVotes.Insert(vote.GetMasternodeOutpoint(), vote_time_pair_t(vote, GetAdjustedTime() + GOVERNANCE_ORPHAN_EXPIRATION_TIME))) {
|
|
LogPrintf("%s\n", ostr.str());
|
|
} else {
|
|
LogPrint("gobject", "%s\n", ostr.str());
|
|
}
|
|
return false;
|
|
}
|
|
|
|
vote_m_it it = mapCurrentMNVotes.emplace(vote_m_t::value_type(vote.GetMasternodeOutpoint(), vote_rec_t())).first;
|
|
vote_rec_t& voteRecordRef = it->second;
|
|
vote_signal_enum_t eSignal = vote.GetSignal();
|
|
if (eSignal == VOTE_SIGNAL_NONE) {
|
|
std::ostringstream ostr;
|
|
ostr << "CGovernanceObject::ProcessVote -- Vote signal: none";
|
|
LogPrint("gobject", "%s\n", ostr.str());
|
|
exception = CGovernanceException(ostr.str(), GOVERNANCE_EXCEPTION_WARNING);
|
|
return false;
|
|
}
|
|
if (eSignal > MAX_SUPPORTED_VOTE_SIGNAL) {
|
|
std::ostringstream ostr;
|
|
ostr << "CGovernanceObject::ProcessVote -- Unsupported vote signal: " << CGovernanceVoting::ConvertSignalToString(vote.GetSignal());
|
|
LogPrintf("%s\n", ostr.str());
|
|
exception = CGovernanceException(ostr.str(), GOVERNANCE_EXCEPTION_PERMANENT_ERROR, 20);
|
|
return false;
|
|
}
|
|
vote_instance_m_it it2 = voteRecordRef.mapInstances.emplace(vote_instance_m_t::value_type(int(eSignal), vote_instance_t())).first;
|
|
vote_instance_t& voteInstanceRef = it2->second;
|
|
|
|
// Reject obsolete votes
|
|
if (vote.GetTimestamp() < voteInstanceRef.nCreationTime) {
|
|
std::ostringstream ostr;
|
|
ostr << "CGovernanceObject::ProcessVote -- Obsolete vote";
|
|
LogPrint("gobject", "%s\n", ostr.str());
|
|
exception = CGovernanceException(ostr.str(), GOVERNANCE_EXCEPTION_NONE);
|
|
return false;
|
|
}
|
|
|
|
int64_t nNow = GetAdjustedTime();
|
|
int64_t nVoteTimeUpdate = voteInstanceRef.nTime;
|
|
if (governance.AreRateChecksEnabled()) {
|
|
int64_t nTimeDelta = nNow - voteInstanceRef.nTime;
|
|
if (nTimeDelta < GOVERNANCE_UPDATE_MIN) {
|
|
std::ostringstream ostr;
|
|
ostr << "CGovernanceObject::ProcessVote -- Masternode voting too often"
|
|
<< ", MN outpoint = " << vote.GetMasternodeOutpoint().ToStringShort()
|
|
<< ", governance object hash = " << GetHash().ToString()
|
|
<< ", time delta = " << nTimeDelta;
|
|
LogPrint("gobject", "%s\n", ostr.str());
|
|
exception = CGovernanceException(ostr.str(), GOVERNANCE_EXCEPTION_TEMPORARY_ERROR);
|
|
nVoteTimeUpdate = nNow;
|
|
return false;
|
|
}
|
|
}
|
|
|
|
bool onlyVotingKeyAllowed = nObjectType == GOVERNANCE_OBJECT_PROPOSAL && vote.GetSignal() == VOTE_SIGNAL_FUNDING;
|
|
|
|
// Finally check that the vote is actually valid (done last because of cost of signature verification)
|
|
if (!vote.IsValid(onlyVotingKeyAllowed)) {
|
|
std::ostringstream ostr;
|
|
ostr << "CGovernanceObject::ProcessVote -- Invalid vote"
|
|
<< ", MN outpoint = " << vote.GetMasternodeOutpoint().ToStringShort()
|
|
<< ", governance object hash = " << GetHash().ToString()
|
|
<< ", vote hash = " << vote.GetHash().ToString();
|
|
LogPrintf("%s\n", ostr.str());
|
|
exception = CGovernanceException(ostr.str(), GOVERNANCE_EXCEPTION_PERMANENT_ERROR, 20);
|
|
governance.AddInvalidVote(vote);
|
|
return false;
|
|
}
|
|
|
|
if (!mnodeman.AddGovernanceVote(vote.GetMasternodeOutpoint(), vote.GetParentHash())) {
|
|
std::ostringstream ostr;
|
|
ostr << "CGovernanceObject::ProcessVote -- Unable to add governance vote"
|
|
<< ", MN outpoint = " << vote.GetMasternodeOutpoint().ToStringShort()
|
|
<< ", governance object hash = " << GetHash().ToString();
|
|
LogPrint("gobject", "%s\n", ostr.str());
|
|
exception = CGovernanceException(ostr.str(), GOVERNANCE_EXCEPTION_PERMANENT_ERROR);
|
|
return false;
|
|
}
|
|
|
|
voteInstanceRef = vote_instance_t(vote.GetOutcome(), nVoteTimeUpdate, vote.GetTimestamp());
|
|
fileVotes.AddVote(vote);
|
|
fDirtyCache = true;
|
|
return true;
|
|
}
|
|
|
|
void CGovernanceObject::ClearMasternodeVotes()
|
|
{
|
|
LOCK(cs);
|
|
|
|
auto mnList = deterministicMNManager->GetListAtChainTip();
|
|
|
|
vote_m_it it = mapCurrentMNVotes.begin();
|
|
while (it != mapCurrentMNVotes.end()) {
|
|
if (!mnList.HasValidMNByCollateral(it->first)) {
|
|
fileVotes.RemoveVotesFromMasternode(it->first);
|
|
mapCurrentMNVotes.erase(it++);
|
|
} else {
|
|
++it;
|
|
}
|
|
}
|
|
}
|
|
|
|
std::set<uint256> CGovernanceObject::RemoveInvalidProposalVotes(const COutPoint& mnOutpoint)
|
|
{
|
|
LOCK(cs);
|
|
|
|
if (nObjectType != GOVERNANCE_OBJECT_PROPOSAL) {
|
|
return {};
|
|
}
|
|
|
|
auto it = mapCurrentMNVotes.find(mnOutpoint);
|
|
if (it == mapCurrentMNVotes.end()) {
|
|
// don't even try as we don't have any votes from this MN
|
|
return {};
|
|
}
|
|
|
|
auto removedVotes = fileVotes.RemoveInvalidProposalVotes(mnOutpoint);
|
|
if (removedVotes.empty()) {
|
|
return {};
|
|
}
|
|
|
|
auto nParentHash = GetHash();
|
|
for (auto jt = it->second.mapInstances.begin(); jt != it->second.mapInstances.end(); ) {
|
|
CGovernanceVote tmpVote(mnOutpoint, nParentHash, (vote_signal_enum_t)jt->first, jt->second.eOutcome);
|
|
tmpVote.SetTime(jt->second.nCreationTime);
|
|
if (removedVotes.count(tmpVote.GetHash())) {
|
|
jt = it->second.mapInstances.erase(jt);
|
|
} else {
|
|
++jt;
|
|
}
|
|
}
|
|
if (it->second.mapInstances.empty()) {
|
|
mapCurrentMNVotes.erase(it);
|
|
}
|
|
|
|
if (!removedVotes.empty()) {
|
|
std::string removedStr;
|
|
for (auto& h : removedVotes) {
|
|
removedStr += strprintf(" %s\n", h.ToString());
|
|
}
|
|
LogPrintf("CGovernanceObject::%s -- Removed %d invalid votes for %s from MN %s:\n%s\n", __func__, removedVotes.size(), nParentHash.ToString(), mnOutpoint.ToString(), removedStr);
|
|
fDirtyCache = true;
|
|
}
|
|
|
|
return removedVotes;
|
|
}
|
|
|
|
std::string CGovernanceObject::GetSignatureMessage() const
|
|
{
|
|
LOCK(cs);
|
|
std::string strMessage = nHashParent.ToString() + "|" +
|
|
std::to_string(nRevision) + "|" +
|
|
std::to_string(nTime) + "|" +
|
|
GetDataAsHexString() + "|" +
|
|
masternodeOutpoint.ToStringShort() + "|" +
|
|
nCollateralHash.ToString();
|
|
|
|
return strMessage;
|
|
}
|
|
|
|
uint256 CGovernanceObject::GetHash() const
|
|
{
|
|
// Note: doesn't match serialization
|
|
|
|
// CREATE HASH OF ALL IMPORTANT PIECES OF DATA
|
|
|
|
CHashWriter ss(SER_GETHASH, PROTOCOL_VERSION);
|
|
ss << nHashParent;
|
|
ss << nRevision;
|
|
ss << nTime;
|
|
ss << GetDataAsHexString();
|
|
ss << masternodeOutpoint << uint8_t{} << 0xffffffff; // adding dummy values here to match old hashing
|
|
ss << vchSig;
|
|
// fee_tx is left out on purpose
|
|
|
|
DBG(printf("CGovernanceObject::GetHash %i %li %s\n", nRevision, nTime, GetDataAsHexString().c_str()););
|
|
|
|
return ss.GetHash();
|
|
}
|
|
|
|
uint256 CGovernanceObject::GetSignatureHash() const
|
|
{
|
|
return SerializeHash(*this);
|
|
}
|
|
|
|
void CGovernanceObject::SetMasternodeOutpoint(const COutPoint& outpoint)
|
|
{
|
|
masternodeOutpoint = outpoint;
|
|
}
|
|
|
|
bool CGovernanceObject::Sign(const CBLSSecretKey& key)
|
|
{
|
|
CBLSSignature sig = key.Sign(GetSignatureHash());
|
|
if (!key.IsValid()) {
|
|
return false;
|
|
}
|
|
sig.GetBuf(vchSig);
|
|
return true;
|
|
}
|
|
|
|
bool CGovernanceObject::CheckSignature(const CBLSPublicKey& pubKey) const
|
|
{
|
|
CBLSSignature sig;
|
|
sig.SetBuf(vchSig);
|
|
if (!sig.VerifyInsecure(pubKey, GetSignatureHash())) {
|
|
LogPrintf("CGovernanceObject::CheckSignature -- VerifyInsecure() failed\n");
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
/**
|
|
Return the actual object from the vchData JSON structure.
|
|
|
|
Returns an empty object on error.
|
|
*/
|
|
UniValue CGovernanceObject::GetJSONObject()
|
|
{
|
|
UniValue obj(UniValue::VOBJ);
|
|
if (vchData.empty()) {
|
|
return obj;
|
|
}
|
|
|
|
UniValue objResult(UniValue::VOBJ);
|
|
GetData(objResult);
|
|
|
|
if (objResult.isObject()) {
|
|
obj = objResult;
|
|
} else {
|
|
std::vector<UniValue> arr1 = objResult.getValues();
|
|
std::vector<UniValue> arr2 = arr1.at(0).getValues();
|
|
obj = arr2.at(1);
|
|
}
|
|
|
|
return obj;
|
|
}
|
|
|
|
/**
|
|
* LoadData
|
|
* --------------------------------------------------------
|
|
*
|
|
* Attempt to load data from vchData
|
|
*
|
|
*/
|
|
|
|
void CGovernanceObject::LoadData()
|
|
{
|
|
// todo : 12.1 - resolved
|
|
//return;
|
|
|
|
if (vchData.empty()) {
|
|
return;
|
|
}
|
|
|
|
try {
|
|
// ATTEMPT TO LOAD JSON STRING FROM VCHDATA
|
|
UniValue objResult(UniValue::VOBJ);
|
|
GetData(objResult);
|
|
|
|
DBG(std::cout << "CGovernanceObject::LoadData GetDataAsPlainString = "
|
|
<< GetDataAsPlainString()
|
|
<< std::endl;);
|
|
|
|
UniValue obj = GetJSONObject();
|
|
nObjectType = obj["type"].get_int();
|
|
} catch (std::exception& e) {
|
|
fUnparsable = true;
|
|
std::ostringstream ostr;
|
|
ostr << "CGovernanceObject::LoadData Error parsing JSON"
|
|
<< ", e.what() = " << e.what();
|
|
DBG(std::cout << ostr.str() << std::endl;);
|
|
LogPrintf("%s\n", ostr.str());
|
|
return;
|
|
} catch (...) {
|
|
fUnparsable = true;
|
|
std::ostringstream ostr;
|
|
ostr << "CGovernanceObject::LoadData Unknown Error parsing JSON";
|
|
DBG(std::cout << ostr.str() << std::endl;);
|
|
LogPrintf("%s\n", ostr.str());
|
|
return;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* GetData - Example usage:
|
|
* --------------------------------------------------------
|
|
*
|
|
* Decode governance object data into UniValue(VOBJ)
|
|
*
|
|
*/
|
|
|
|
void CGovernanceObject::GetData(UniValue& objResult)
|
|
{
|
|
UniValue o(UniValue::VOBJ);
|
|
std::string s = GetDataAsPlainString();
|
|
o.read(s);
|
|
objResult = o;
|
|
}
|
|
|
|
/**
|
|
* GetData - As
|
|
* --------------------------------------------------------
|
|
*
|
|
*/
|
|
|
|
std::string CGovernanceObject::GetDataAsHexString() const
|
|
{
|
|
return HexStr(vchData);
|
|
}
|
|
|
|
std::string CGovernanceObject::GetDataAsPlainString() const
|
|
{
|
|
return std::string(vchData.begin(), vchData.end());
|
|
}
|
|
|
|
void CGovernanceObject::UpdateLocalValidity()
|
|
{
|
|
LOCK(cs_main);
|
|
// THIS DOES NOT CHECK COLLATERAL, THIS IS CHECKED UPON ORIGINAL ARRIVAL
|
|
fCachedLocalValidity = IsValidLocally(strLocalValidityError, false);
|
|
};
|
|
|
|
|
|
bool CGovernanceObject::IsValidLocally(std::string& strError, bool fCheckCollateral) const
|
|
{
|
|
bool fMissingMasternode = false;
|
|
bool fMissingConfirmations = false;
|
|
|
|
return IsValidLocally(strError, fMissingMasternode, fMissingConfirmations, fCheckCollateral);
|
|
}
|
|
|
|
bool CGovernanceObject::IsValidLocally(std::string& strError, bool& fMissingMasternode, bool& fMissingConfirmations, bool fCheckCollateral) const
|
|
{
|
|
fMissingMasternode = false;
|
|
fMissingConfirmations = false;
|
|
|
|
if (fUnparsable) {
|
|
strError = "Object data unparseable";
|
|
return false;
|
|
}
|
|
|
|
switch (nObjectType) {
|
|
case GOVERNANCE_OBJECT_WATCHDOG: {
|
|
// watchdogs are deprecated
|
|
return false;
|
|
}
|
|
case GOVERNANCE_OBJECT_PROPOSAL: {
|
|
CProposalValidator validator(GetDataAsHexString());
|
|
// Note: It's ok to have expired proposals
|
|
// they are going to be cleared by CGovernanceManager::UpdateCachesAndClean()
|
|
// TODO: should they be tagged as "expired" to skip vote downloading?
|
|
if (!validator.Validate(false)) {
|
|
strError = strprintf("Invalid proposal data, error messages: %s", validator.GetErrorMessages());
|
|
return false;
|
|
}
|
|
if (fCheckCollateral && !IsCollateralValid(strError, fMissingConfirmations)) {
|
|
strError = "Invalid proposal collateral";
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
case GOVERNANCE_OBJECT_TRIGGER: {
|
|
if (!fCheckCollateral) {
|
|
// nothing else we can check here (yet?)
|
|
return true;
|
|
}
|
|
|
|
auto mnList = deterministicMNManager->GetListAtChainTip();
|
|
|
|
std::string strOutpoint = masternodeOutpoint.ToStringShort();
|
|
auto dmn = mnList.GetMNByCollateral(masternodeOutpoint);
|
|
if (!dmn) {
|
|
strError = "Failed to find Masternode by UTXO, missing masternode=" + strOutpoint + "\n";
|
|
return false;
|
|
}
|
|
if (!mnList.IsMNValid(dmn)) {
|
|
if (mnList.IsMNPoSeBanned(dmn)) {
|
|
strError = "Masternode is POSE_BANNED, masternode=" + strOutpoint + "\n";
|
|
} else {
|
|
strError = "Masternode is invalid for unknown reason, masternode=" + strOutpoint + "\n";
|
|
}
|
|
return false;
|
|
}
|
|
|
|
// Check that we have a valid MN signature
|
|
if (!CheckSignature(dmn->pdmnState->pubKeyOperator)) {
|
|
strError = "Invalid masternode signature for: " + strOutpoint + ", pubkey = " + dmn->pdmnState->pubKeyOperator.ToString();
|
|
return false;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
default: {
|
|
strError = strprintf("Invalid object type %d", nObjectType);
|
|
return false;
|
|
}
|
|
}
|
|
}
|
|
|
|
CAmount CGovernanceObject::GetMinCollateralFee() const
|
|
{
|
|
// Only 1 type has a fee for the moment but switch statement allows for future object types
|
|
switch (nObjectType) {
|
|
case GOVERNANCE_OBJECT_PROPOSAL:
|
|
return GOVERNANCE_PROPOSAL_FEE_TX;
|
|
case GOVERNANCE_OBJECT_TRIGGER:
|
|
return 0;
|
|
case GOVERNANCE_OBJECT_WATCHDOG:
|
|
return 0;
|
|
default:
|
|
return MAX_MONEY;
|
|
}
|
|
}
|
|
|
|
bool CGovernanceObject::IsCollateralValid(std::string& strError, bool& fMissingConfirmations) const
|
|
{
|
|
strError = "";
|
|
fMissingConfirmations = false;
|
|
CAmount nMinFee = GetMinCollateralFee();
|
|
uint256 nExpectedHash = GetHash();
|
|
|
|
CTransactionRef txCollateral;
|
|
uint256 nBlockHash;
|
|
|
|
// RETRIEVE TRANSACTION IN QUESTION
|
|
|
|
if (!GetTransaction(nCollateralHash, txCollateral, Params().GetConsensus(), nBlockHash, true)) {
|
|
strError = strprintf("Can't find collateral tx %s", nCollateralHash.ToString());
|
|
LogPrintf("CGovernanceObject::IsCollateralValid -- %s\n", strError);
|
|
return false;
|
|
}
|
|
|
|
if (nBlockHash == uint256()) {
|
|
strError = strprintf("Collateral tx %s is not mined yet", txCollateral->ToString());
|
|
LogPrintf("CGovernanceObject::IsCollateralValid -- %s\n", strError);
|
|
return false;
|
|
}
|
|
|
|
if (txCollateral->vout.size() < 1) {
|
|
strError = strprintf("tx vout size less than 1 | %d", txCollateral->vout.size());
|
|
LogPrintf("CGovernanceObject::IsCollateralValid -- %s\n", strError);
|
|
return false;
|
|
}
|
|
|
|
// LOOK FOR SPECIALIZED GOVERNANCE SCRIPT (PROOF OF BURN)
|
|
|
|
CScript findScript;
|
|
findScript << OP_RETURN << ToByteVector(nExpectedHash);
|
|
|
|
DBG(std::cout << "IsCollateralValid: txCollateral->vout.size() = " << txCollateral->vout.size() << std::endl;);
|
|
|
|
DBG(std::cout << "IsCollateralValid: findScript = " << ScriptToAsmStr(findScript, false) << std::endl;);
|
|
|
|
DBG(std::cout << "IsCollateralValid: nMinFee = " << nMinFee << std::endl;);
|
|
|
|
|
|
bool foundOpReturn = false;
|
|
for (const auto& output : txCollateral->vout) {
|
|
DBG(std::cout << "IsCollateralValid txout : " << output.ToString()
|
|
<< ", output.nValue = " << output.nValue
|
|
<< ", output.scriptPubKey = " << ScriptToAsmStr(output.scriptPubKey, false)
|
|
<< std::endl;);
|
|
if (!output.scriptPubKey.IsPayToPublicKeyHash() && !output.scriptPubKey.IsUnspendable()) {
|
|
strError = strprintf("Invalid Script %s", txCollateral->ToString());
|
|
LogPrintf("CGovernanceObject::IsCollateralValid -- %s\n", strError);
|
|
return false;
|
|
}
|
|
if (output.scriptPubKey == findScript && output.nValue >= nMinFee) {
|
|
DBG(std::cout << "IsCollateralValid foundOpReturn = true" << std::endl;);
|
|
foundOpReturn = true;
|
|
} else {
|
|
DBG(std::cout << "IsCollateralValid No match, continuing" << std::endl;);
|
|
}
|
|
}
|
|
|
|
if (!foundOpReturn) {
|
|
strError = strprintf("Couldn't find opReturn %s in %s", nExpectedHash.ToString(), txCollateral->ToString());
|
|
LogPrintf("CGovernanceObject::IsCollateralValid -- %s\n", strError);
|
|
return false;
|
|
}
|
|
|
|
// GET CONFIRMATIONS FOR TRANSACTION
|
|
|
|
AssertLockHeld(cs_main);
|
|
int nConfirmationsIn = 0;
|
|
if (nBlockHash != uint256()) {
|
|
BlockMap::iterator mi = mapBlockIndex.find(nBlockHash);
|
|
if (mi != mapBlockIndex.end() && (*mi).second) {
|
|
CBlockIndex* pindex = (*mi).second;
|
|
if (chainActive.Contains(pindex)) {
|
|
nConfirmationsIn += chainActive.Height() - pindex->nHeight + 1;
|
|
}
|
|
}
|
|
}
|
|
|
|
if ((nConfirmationsIn < GOVERNANCE_FEE_CONFIRMATIONS) &&
|
|
(!instantsend.IsLockedInstantSendTransaction(nCollateralHash))) {
|
|
strError = strprintf("Collateral requires at least %d confirmations to be relayed throughout the network (it has only %d)", GOVERNANCE_FEE_CONFIRMATIONS, nConfirmationsIn);
|
|
if (nConfirmationsIn >= GOVERNANCE_MIN_RELAY_FEE_CONFIRMATIONS) {
|
|
fMissingConfirmations = true;
|
|
strError += ", pre-accepted -- waiting for required confirmations";
|
|
} else {
|
|
strError += ", rejected -- try again later";
|
|
}
|
|
LogPrintf("CGovernanceObject::IsCollateralValid -- %s\n", strError);
|
|
|
|
return false;
|
|
}
|
|
|
|
strError = "valid";
|
|
return true;
|
|
}
|
|
|
|
int CGovernanceObject::CountMatchingVotes(vote_signal_enum_t eVoteSignalIn, vote_outcome_enum_t eVoteOutcomeIn) const
|
|
{
|
|
LOCK(cs);
|
|
|
|
int nCount = 0;
|
|
for (const auto& votepair : mapCurrentMNVotes) {
|
|
const vote_rec_t& recVote = votepair.second;
|
|
vote_instance_m_cit it2 = recVote.mapInstances.find(eVoteSignalIn);
|
|
if (it2 != recVote.mapInstances.end() && it2->second.eOutcome == eVoteOutcomeIn) {
|
|
++nCount;
|
|
}
|
|
}
|
|
return nCount;
|
|
}
|
|
|
|
/**
|
|
* Get specific vote counts for each outcome (funding, validity, etc)
|
|
*/
|
|
|
|
int CGovernanceObject::GetAbsoluteYesCount(vote_signal_enum_t eVoteSignalIn) const
|
|
{
|
|
return GetYesCount(eVoteSignalIn) - GetNoCount(eVoteSignalIn);
|
|
}
|
|
|
|
int CGovernanceObject::GetAbsoluteNoCount(vote_signal_enum_t eVoteSignalIn) const
|
|
{
|
|
return GetNoCount(eVoteSignalIn) - GetYesCount(eVoteSignalIn);
|
|
}
|
|
|
|
int CGovernanceObject::GetYesCount(vote_signal_enum_t eVoteSignalIn) const
|
|
{
|
|
return CountMatchingVotes(eVoteSignalIn, VOTE_OUTCOME_YES);
|
|
}
|
|
|
|
int CGovernanceObject::GetNoCount(vote_signal_enum_t eVoteSignalIn) const
|
|
{
|
|
return CountMatchingVotes(eVoteSignalIn, VOTE_OUTCOME_NO);
|
|
}
|
|
|
|
int CGovernanceObject::GetAbstainCount(vote_signal_enum_t eVoteSignalIn) const
|
|
{
|
|
return CountMatchingVotes(eVoteSignalIn, VOTE_OUTCOME_ABSTAIN);
|
|
}
|
|
|
|
bool CGovernanceObject::GetCurrentMNVotes(const COutPoint& mnCollateralOutpoint, vote_rec_t& voteRecord) const
|
|
{
|
|
LOCK(cs);
|
|
|
|
vote_m_cit it = mapCurrentMNVotes.find(mnCollateralOutpoint);
|
|
if (it == mapCurrentMNVotes.end()) {
|
|
return false;
|
|
}
|
|
voteRecord = it->second;
|
|
return true;
|
|
}
|
|
|
|
void CGovernanceObject::Relay(CConnman& connman)
|
|
{
|
|
// Do not relay until fully synced
|
|
if (!masternodeSync.IsSynced()) {
|
|
LogPrint("gobject", "CGovernanceObject::Relay -- won't relay until fully synced\n");
|
|
return;
|
|
}
|
|
|
|
CInv inv(MSG_GOVERNANCE_OBJECT, GetHash());
|
|
connman.RelayInv(inv, MIN_GOVERNANCE_PEER_PROTO_VERSION);
|
|
}
|
|
|
|
void CGovernanceObject::UpdateSentinelVariables()
|
|
{
|
|
// CALCULATE MINIMUM SUPPORT LEVELS REQUIRED
|
|
|
|
int nMnCount = (int)deterministicMNManager->GetListAtChainTip().GetValidMNsCount();
|
|
if (nMnCount == 0) return;
|
|
|
|
// CALCULATE THE MINUMUM VOTE COUNT REQUIRED FOR FULL SIGNAL
|
|
|
|
int nAbsVoteReq = std::max(Params().GetConsensus().nGovernanceMinQuorum, nMnCount / 10);
|
|
int nAbsDeleteReq = std::max(Params().GetConsensus().nGovernanceMinQuorum, (2 * nMnCount) / 3);
|
|
|
|
// SET SENTINEL FLAGS TO FALSE
|
|
|
|
fCachedFunding = false;
|
|
fCachedValid = true; //default to valid
|
|
fCachedEndorsed = false;
|
|
fDirtyCache = false;
|
|
|
|
// SET SENTINEL FLAGS TO TRUE IF MIMIMUM SUPPORT LEVELS ARE REACHED
|
|
// ARE ANY OF THESE FLAGS CURRENTLY ACTIVATED?
|
|
|
|
if (GetAbsoluteYesCount(VOTE_SIGNAL_FUNDING) >= nAbsVoteReq) fCachedFunding = true;
|
|
if ((GetAbsoluteYesCount(VOTE_SIGNAL_DELETE) >= nAbsDeleteReq) && !fCachedDelete) {
|
|
fCachedDelete = true;
|
|
if (nDeletionTime == 0) {
|
|
nDeletionTime = GetAdjustedTime();
|
|
}
|
|
}
|
|
if (GetAbsoluteYesCount(VOTE_SIGNAL_ENDORSED) >= nAbsVoteReq) fCachedEndorsed = true;
|
|
|
|
if (GetAbsoluteNoCount(VOTE_SIGNAL_VALID) >= nAbsVoteReq) fCachedValid = false;
|
|
}
|
|
|
|
void CGovernanceObject::CheckOrphanVotes(CConnman& connman)
|
|
{
|
|
int64_t nNow = GetAdjustedTime();
|
|
auto mnList = deterministicMNManager->GetListAtChainTip();
|
|
const vote_cmm_t::list_t& listVotes = cmmapOrphanVotes.GetItemList();
|
|
vote_cmm_t::list_cit it = listVotes.begin();
|
|
while (it != listVotes.end()) {
|
|
bool fRemove = false;
|
|
const COutPoint& key = it->key;
|
|
const vote_time_pair_t& pairVote = it->value;
|
|
const CGovernanceVote& vote = pairVote.first;
|
|
if (pairVote.second < nNow) {
|
|
fRemove = true;
|
|
} else if (!mnList.HasValidMNByCollateral(vote.GetMasternodeOutpoint())) {
|
|
++it;
|
|
continue;
|
|
}
|
|
CGovernanceException exception;
|
|
if (!ProcessVote(nullptr, vote, exception, connman)) {
|
|
LogPrintf("CGovernanceObject::CheckOrphanVotes -- Failed to add orphan vote: %s\n", exception.what());
|
|
} else {
|
|
vote.Relay(connman);
|
|
fRemove = true;
|
|
}
|
|
++it;
|
|
if (fRemove) {
|
|
cmmapOrphanVotes.Erase(key, pairVote);
|
|
}
|
|
}
|
|
}
|