2023-02-13 04:15:23 +01:00
|
|
|
***Please remove the italicized help prompts before submitting or merging***
|
2019-09-30 09:48:10 +02:00
|
|
|
|
2023-02-13 04:15:23 +01:00
|
|
|
_Provide a general summary of your changes in the Title above_
|
2021-10-13 16:49:37 +02:00
|
|
|
|
2023-02-13 04:15:23 +01:00
|
|
|
_Pull requests without a rationale and clear improvement may be closed
|
|
|
|
|
immediately._
|
2018-09-28 13:53:47 +02:00
|
|
|
|
2023-02-13 04:15:23 +01:00
|
|
|
_Please provide clear motivation for your patch and explain how it improves
|
2018-09-28 13:53:47 +02:00
|
|
|
Dash Core user experience or Dash Core developer experience
|
2023-02-13 04:15:23 +01:00
|
|
|
significantly:_
|
2018-09-28 13:53:47 +02:00
|
|
|
|
2023-02-13 04:15:23 +01:00
|
|
|
* _Any test improvements or new tests that improve coverage are always welcome._
|
|
|
|
|
* _All other changes should have accompanying unit tests (see `src/test/`) or
|
2018-09-28 13:53:47 +02:00
|
|
|
functional tests (see `test/`). Contributors should note which tests cover
|
|
|
|
|
modified code. If no tests exist for a region of modified code, new tests
|
2023-02-13 04:15:23 +01:00
|
|
|
should accompany the change._
|
|
|
|
|
* _Bug fixes are most welcome when they come with steps to reproduce or an
|
2018-09-28 13:53:47 +02:00
|
|
|
explanation of the potential issue as well as reasoning for the way the bug
|
2023-02-13 04:15:23 +01:00
|
|
|
was fixed._
|
|
|
|
|
* _Features are welcome, but might be rejected due to design or scope issues.
|
2018-09-28 13:53:47 +02:00
|
|
|
If a feature is based on a lot of dependencies, contributors should first
|
2023-02-13 04:15:23 +01:00
|
|
|
consider building the system outside of Dash Core, if possible._
|
|
|
|
|
|
2021-10-13 16:49:37 +02:00
|
|
|
|
|
|
|
|
## Issue being fixed or feature implemented
|
2023-02-13 04:15:23 +01:00
|
|
|
- _Why is this change required? What problem does it solve?_
|
|
|
|
|
- _If it fixes an open issue, please link to the issue here._
|
2021-10-13 16:49:37 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
## What was done?
|
2023-02-13 04:15:23 +01:00
|
|
|
_Describe your changes in detail_
|
2021-10-13 16:49:37 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
## How Has This Been Tested?
|
2023-02-13 04:15:23 +01:00
|
|
|
_Please describe in detail how you tested your changes._
|
|
|
|
|
|
|
|
|
|
_Include details of your testing environment, and the tests you ran
|
|
|
|
|
to see how your change affects other areas of the code, etc._
|
2021-10-13 16:49:37 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
## Breaking Changes
|
2023-02-13 04:15:23 +01:00
|
|
|
_Please describe any breaking changes your code introduces_
|
2021-10-13 16:49:37 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
## Checklist:
|
2023-02-13 04:15:23 +01:00
|
|
|
_Go over all the following points, and put an `x` in all the boxes that apply._
|
2021-10-13 16:49:37 +02:00
|
|
|
- [ ] I have performed a self-review of my own code
|
|
|
|
|
- [ ] I have commented my code, particularly in hard-to-understand areas
|
|
|
|
|
- [ ] I have added or updated relevant unit/integration/functional/e2e tests
|
|
|
|
|
- [ ] I have made corresponding changes to the documentation
|
2023-02-13 04:15:23 +01:00
|
|
|
- [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
|
2021-10-13 16:49:37 +02:00
|
|
|
|
