2015-12-13 14:51:43 +01:00
|
|
|
// Copyright (c) 2014-2015 The Bitcoin Core developers
|
2014-10-31 01:43:19 +01:00
|
|
|
// Distributed under the MIT software license, see the accompanying
|
2014-04-12 23:34:00 +02:00
|
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
|
2014-05-09 23:42:20 +02:00
|
|
|
#include "base58.h"
|
|
|
|
|
|
|
|
#include "hash.h"
|
|
|
|
#include "uint256.h"
|
|
|
|
|
2014-04-12 23:34:00 +02:00
|
|
|
#include <assert.h>
|
|
|
|
#include <stdint.h>
|
|
|
|
#include <string.h>
|
|
|
|
#include <vector>
|
|
|
|
#include <string>
|
2014-05-09 23:42:20 +02:00
|
|
|
#include <boost/variant/apply_visitor.hpp>
|
|
|
|
#include <boost/variant/static_visitor.hpp>
|
2014-04-12 23:34:00 +02:00
|
|
|
|
2014-10-31 01:43:19 +01:00
|
|
|
/** All alphanumeric characters except for "0", "I", "O", and "l" */
|
2014-04-12 23:34:00 +02:00
|
|
|
static const char* pszBase58 = "123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz";
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
bool DecodeBase58(const char* psz, std::vector<unsigned char>& vch)
|
|
|
|
{
|
2014-04-12 23:34:00 +02:00
|
|
|
// Skip leading spaces.
|
|
|
|
while (*psz && isspace(*psz))
|
|
|
|
psz++;
|
|
|
|
// Skip and count leading '1's.
|
|
|
|
int zeroes = 0;
|
2017-05-09 19:06:51 +02:00
|
|
|
int length = 0;
|
2014-04-12 23:34:00 +02:00
|
|
|
while (*psz == '1') {
|
|
|
|
zeroes++;
|
|
|
|
psz++;
|
|
|
|
}
|
|
|
|
// Allocate enough space in big-endian base256 representation.
|
2017-05-09 19:06:51 +02:00
|
|
|
int size = strlen(psz) * 733 /1000 + 1; // log(58) / log(256), rounded up.
|
|
|
|
std::vector<unsigned char> b256(size);
|
2014-04-12 23:34:00 +02:00
|
|
|
// Process the characters.
|
|
|
|
while (*psz && !isspace(*psz)) {
|
|
|
|
// Decode base58 character
|
2014-09-19 19:21:46 +02:00
|
|
|
const char* ch = strchr(pszBase58, *psz);
|
2019-08-06 05:08:33 +02:00
|
|
|
if (ch == nullptr)
|
2014-04-12 23:34:00 +02:00
|
|
|
return false;
|
|
|
|
// Apply "b256 = b256 * 58 + ch".
|
|
|
|
int carry = ch - pszBase58;
|
2017-05-09 19:06:51 +02:00
|
|
|
int i = 0;
|
|
|
|
for (std::vector<unsigned char>::reverse_iterator it = b256.rbegin(); (carry != 0 || i < length) && (it != b256.rend()); ++it, ++i) {
|
2014-04-12 23:34:00 +02:00
|
|
|
carry += 58 * (*it);
|
|
|
|
*it = carry % 256;
|
|
|
|
carry /= 256;
|
|
|
|
}
|
|
|
|
assert(carry == 0);
|
2017-05-09 19:06:51 +02:00
|
|
|
length = i;
|
2014-04-12 23:34:00 +02:00
|
|
|
psz++;
|
|
|
|
}
|
|
|
|
// Skip trailing spaces.
|
|
|
|
while (isspace(*psz))
|
|
|
|
psz++;
|
|
|
|
if (*psz != 0)
|
|
|
|
return false;
|
|
|
|
// Skip leading zeroes in b256.
|
2017-05-09 19:06:51 +02:00
|
|
|
std::vector<unsigned char>::iterator it = b256.begin() + (size - length);
|
2014-04-12 23:34:00 +02:00
|
|
|
while (it != b256.end() && *it == 0)
|
|
|
|
it++;
|
|
|
|
// Copy result into output vector.
|
|
|
|
vch.reserve(zeroes + (b256.end() - it));
|
|
|
|
vch.assign(zeroes, 0x00);
|
|
|
|
while (it != b256.end())
|
2014-09-19 19:21:46 +02:00
|
|
|
vch.push_back(*(it++));
|
2014-04-12 23:34:00 +02:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
std::string EncodeBase58(const unsigned char* pbegin, const unsigned char* pend)
|
|
|
|
{
|
2014-04-12 23:34:00 +02:00
|
|
|
// Skip & count leading zeroes.
|
|
|
|
int zeroes = 0;
|
2017-05-09 19:06:51 +02:00
|
|
|
int length = 0;
|
2014-04-12 23:34:00 +02:00
|
|
|
while (pbegin != pend && *pbegin == 0) {
|
|
|
|
pbegin++;
|
|
|
|
zeroes++;
|
|
|
|
}
|
|
|
|
// Allocate enough space in big-endian base58 representation.
|
2017-05-09 19:06:51 +02:00
|
|
|
int size = (pend - pbegin) * 138 / 100 + 1; // log(256) / log(58), rounded up.
|
|
|
|
std::vector<unsigned char> b58(size);
|
2014-04-12 23:34:00 +02:00
|
|
|
// Process the bytes.
|
|
|
|
while (pbegin != pend) {
|
|
|
|
int carry = *pbegin;
|
2017-05-09 19:06:51 +02:00
|
|
|
int i = 0;
|
2014-04-12 23:34:00 +02:00
|
|
|
// Apply "b58 = b58 * 256 + ch".
|
2017-05-09 19:06:51 +02:00
|
|
|
for (std::vector<unsigned char>::reverse_iterator it = b58.rbegin(); (carry != 0 || i < length) && (it != b58.rend()); it++, i++) {
|
2014-04-12 23:34:00 +02:00
|
|
|
carry += 256 * (*it);
|
|
|
|
*it = carry % 58;
|
|
|
|
carry /= 58;
|
|
|
|
}
|
2017-05-09 19:06:51 +02:00
|
|
|
|
2014-04-12 23:34:00 +02:00
|
|
|
assert(carry == 0);
|
2017-05-09 19:06:51 +02:00
|
|
|
length = i;
|
2014-04-12 23:34:00 +02:00
|
|
|
pbegin++;
|
|
|
|
}
|
|
|
|
// Skip leading zeroes in base58 result.
|
2017-05-09 19:06:51 +02:00
|
|
|
std::vector<unsigned char>::iterator it = b58.begin() + (size - length);
|
2014-04-12 23:34:00 +02:00
|
|
|
while (it != b58.end() && *it == 0)
|
|
|
|
it++;
|
|
|
|
// Translate the result into a string.
|
|
|
|
std::string str;
|
|
|
|
str.reserve(zeroes + (b58.end() - it));
|
|
|
|
str.assign(zeroes, '1');
|
|
|
|
while (it != b58.end())
|
|
|
|
str += pszBase58[*(it++)];
|
|
|
|
return str;
|
|
|
|
}
|
2014-05-09 23:42:20 +02:00
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
std::string EncodeBase58(const std::vector<unsigned char>& vch)
|
|
|
|
{
|
2017-07-13 01:23:59 +02:00
|
|
|
return EncodeBase58(vch.data(), vch.data() + vch.size());
|
2014-05-09 23:42:20 +02:00
|
|
|
}
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
bool DecodeBase58(const std::string& str, std::vector<unsigned char>& vchRet)
|
|
|
|
{
|
2014-05-09 23:42:20 +02:00
|
|
|
return DecodeBase58(str.c_str(), vchRet);
|
|
|
|
}
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
std::string EncodeBase58Check(const std::vector<unsigned char>& vchIn)
|
|
|
|
{
|
2014-05-09 23:42:20 +02:00
|
|
|
// add 4-byte hash check to the end
|
|
|
|
std::vector<unsigned char> vch(vchIn);
|
|
|
|
uint256 hash = Hash(vch.begin(), vch.end());
|
|
|
|
vch.insert(vch.end(), (unsigned char*)&hash, (unsigned char*)&hash + 4);
|
|
|
|
return EncodeBase58(vch);
|
|
|
|
}
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
bool DecodeBase58Check(const char* psz, std::vector<unsigned char>& vchRet)
|
|
|
|
{
|
2014-06-12 05:20:37 +02:00
|
|
|
if (!DecodeBase58(psz, vchRet) ||
|
2014-09-19 19:21:46 +02:00
|
|
|
(vchRet.size() < 4)) {
|
2014-05-09 23:42:20 +02:00
|
|
|
vchRet.clear();
|
|
|
|
return false;
|
|
|
|
}
|
2017-03-22 08:37:58 +01:00
|
|
|
// re-calculate the checksum, ensure it matches the included 4-byte checksum
|
2014-09-19 19:21:46 +02:00
|
|
|
uint256 hash = Hash(vchRet.begin(), vchRet.end() - 4);
|
2017-10-09 16:40:36 +02:00
|
|
|
if (memcmp(&hash, &vchRet[vchRet.size() - 4], 4) != 0) {
|
2014-05-09 23:42:20 +02:00
|
|
|
vchRet.clear();
|
|
|
|
return false;
|
|
|
|
}
|
2014-09-19 19:21:46 +02:00
|
|
|
vchRet.resize(vchRet.size() - 4);
|
2014-05-09 23:42:20 +02:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
bool DecodeBase58Check(const std::string& str, std::vector<unsigned char>& vchRet)
|
|
|
|
{
|
2014-05-09 23:42:20 +02:00
|
|
|
return DecodeBase58Check(str.c_str(), vchRet);
|
|
|
|
}
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
CBase58Data::CBase58Data()
|
|
|
|
{
|
2014-05-09 23:42:20 +02:00
|
|
|
vchVersion.clear();
|
|
|
|
vchData.clear();
|
|
|
|
}
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
void CBase58Data::SetData(const std::vector<unsigned char>& vchVersionIn, const void* pdata, size_t nSize)
|
|
|
|
{
|
2014-05-09 23:42:20 +02:00
|
|
|
vchVersion = vchVersionIn;
|
|
|
|
vchData.resize(nSize);
|
|
|
|
if (!vchData.empty())
|
2017-07-13 01:23:59 +02:00
|
|
|
memcpy(vchData.data(), pdata, nSize);
|
2014-05-09 23:42:20 +02:00
|
|
|
}
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
void CBase58Data::SetData(const std::vector<unsigned char>& vchVersionIn, const unsigned char* pbegin, const unsigned char* pend)
|
|
|
|
{
|
2014-05-09 23:42:20 +02:00
|
|
|
SetData(vchVersionIn, (void*)pbegin, pend - pbegin);
|
|
|
|
}
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
bool CBase58Data::SetString(const char* psz, unsigned int nVersionBytes)
|
|
|
|
{
|
2014-05-09 23:42:20 +02:00
|
|
|
std::vector<unsigned char> vchTemp;
|
2014-06-12 05:20:37 +02:00
|
|
|
bool rc58 = DecodeBase58Check(psz, vchTemp);
|
|
|
|
if ((!rc58) || (vchTemp.size() < nVersionBytes)) {
|
2014-05-09 23:42:20 +02:00
|
|
|
vchData.clear();
|
|
|
|
vchVersion.clear();
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
vchVersion.assign(vchTemp.begin(), vchTemp.begin() + nVersionBytes);
|
|
|
|
vchData.resize(vchTemp.size() - nVersionBytes);
|
|
|
|
if (!vchData.empty())
|
2017-07-13 01:23:59 +02:00
|
|
|
memcpy(vchData.data(), vchTemp.data() + nVersionBytes, vchData.size());
|
|
|
|
memory_cleanse(vchTemp.data(), vchTemp.size());
|
2014-05-09 23:42:20 +02:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
bool CBase58Data::SetString(const std::string& str)
|
|
|
|
{
|
2014-05-09 23:42:20 +02:00
|
|
|
return SetString(str.c_str());
|
|
|
|
}
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
std::string CBase58Data::ToString() const
|
|
|
|
{
|
2014-05-09 23:42:20 +02:00
|
|
|
std::vector<unsigned char> vch = vchVersion;
|
|
|
|
vch.insert(vch.end(), vchData.begin(), vchData.end());
|
|
|
|
return EncodeBase58Check(vch);
|
|
|
|
}
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
int CBase58Data::CompareTo(const CBase58Data& b58) const
|
|
|
|
{
|
|
|
|
if (vchVersion < b58.vchVersion)
|
|
|
|
return -1;
|
|
|
|
if (vchVersion > b58.vchVersion)
|
|
|
|
return 1;
|
|
|
|
if (vchData < b58.vchData)
|
|
|
|
return -1;
|
|
|
|
if (vchData > b58.vchData)
|
|
|
|
return 1;
|
2014-05-09 23:42:20 +02:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
namespace
|
|
|
|
{
|
Merge #11117: Prepare for non-Base58 addresses (#3294)
* Merge #11117: Prepare for non-Base58 addresses
864cd2787 Move CBitcoinAddress to base58.cpp (Pieter Wuille)
5c8ff0d44 Introduce wrappers around CBitcoinAddress (Pieter Wuille)
Pull request description:
This patch removes the need for the intermediary Base58 type `CBitcoinAddress`, by providing {`Encode`,`Decode`,`IsValid`}`Destination` functions that directly operate on the conversion between `std::string`s and `CTxDestination`.
As a side, it also fixes a number of indentation issues, and removes probably several unnecessary implicit `CTxDestination`<->`CBitcoinAddress` conversions.
This change is far from complete. In follow-ups I'd like to:
* Split off the specific address and key encoding logic from base58.h, and move it to a address.h or so.
* Replace `CTxDestination` with a non-`boost::variant` version (which can be more efficient as `boost::variant` allocates everything on the heap, and remove the need for `boost::get<...>` and `IsValidDestination` calls everywhere).
* Do the same for `CBitcoinSecret`, `CBitcoinExtKey`, and `CBitcoinExtPubKey`.
However, I've tried to keep this patch to be minimally invasive, but still enough to support non-Base58 addresses. Perhaps a smaller patch is possible to hack Bech32 support into `CBitcoinAddress`, but I would consider that a move in the wrong direction.
Tree-SHA512: c2c77ffb57caeadf2429b1c2562ce60e8c7be8aa9f8e51b591f354b6b441162625b2efe14c023a1ae485cf2ed417263afa35c892891dfaa7844e7fbabccab85e
* CBitcoinAddress -> EncodeDestination in providertx.h
Signed-off-by: Pasta <pasta@dashboost.org>
* more CBitcoinAddress -> EncodeDestination in providertx.h
Signed-off-by: Pasta <pasta@dashboost.org>
* more CBitcoinAddress -> EncodeDestination in providertx.h
Signed-off-by: Pasta <pasta@dashboost.org>
* more CBitcoinAddress -> EncodeDestination in providertx.h
Signed-off-by: Pasta <pasta@dashboost.org>
* fix CBitcoinAddress GetKeyID check
Signed-off-by: Pasta <pasta@dashboost.org>
* fix providertx.cpp
Signed-off-by: Pasta <pasta@dashboost.org>
* hopefully fix governance-classes.cpp
Signed-off-by: Pasta <pasta@dashboost.org>
* partially fix governance-validators.cpp, unable to resolve "address.IsScript()"
Signed-off-by: Pasta <pasta@dashboost.org>
* partially fix governance-classes.cpp, unable to resolve "address.IsScript()"
Signed-off-by: Pasta <pasta@dashboost.org>
* fix governance-classes.h
Signed-off-by: Pasta <pasta@dashboost.org>
* DecodeTransaction -> DecodeDestination, fix governance-validators.cpp
Signed-off-by: Pasta <pasta@dashboost.org>
* More fixes for 3294
* Move GetIndexKey into rpc/misc.cpp near getAddressesFromParams
No need to have it in base58.cpp anymore as this is only used in getAddressesFromParams
Co-authored-by: Wladimir J. van der Laan <laanwj@gmail.com>
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
Co-authored-by: Alexander Block <ablock84@gmail.com>
2020-01-22 11:35:04 +01:00
|
|
|
/** base58-encoded Bitcoin addresses.
|
|
|
|
* Public-key-hash-addresses have version 0 (or 111 testnet).
|
|
|
|
* The data vector contains RIPEMD160(SHA256(pubkey)), where pubkey is the serialized public key.
|
|
|
|
* Script-hash-addresses have version 5 (or 196 testnet).
|
|
|
|
* The data vector contains RIPEMD160(SHA256(cscript)), where cscript is the serialized redemption script.
|
|
|
|
*/
|
|
|
|
class CBitcoinAddress : public CBase58Data {
|
|
|
|
public:
|
|
|
|
bool Set(const CKeyID &id);
|
|
|
|
bool Set(const CScriptID &id);
|
|
|
|
bool Set(const CTxDestination &dest);
|
|
|
|
bool IsValid() const;
|
|
|
|
bool IsValid(const CChainParams ¶ms) const;
|
|
|
|
|
|
|
|
CBitcoinAddress() {}
|
|
|
|
CBitcoinAddress(const CTxDestination &dest) { Set(dest); }
|
|
|
|
CBitcoinAddress(const std::string& strAddress) { SetString(strAddress); }
|
|
|
|
CBitcoinAddress(const char* pszAddress) { SetString(pszAddress); }
|
|
|
|
|
|
|
|
CTxDestination Get() const;
|
|
|
|
};
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
class CBitcoinAddressVisitor : public boost::static_visitor<bool>
|
|
|
|
{
|
|
|
|
private:
|
|
|
|
CBitcoinAddress* addr;
|
2014-06-24 14:17:43 +02:00
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
public:
|
2017-08-17 22:59:56 +02:00
|
|
|
explicit CBitcoinAddressVisitor(CBitcoinAddress* addrIn) : addr(addrIn) {}
|
2014-05-09 23:42:20 +02:00
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
bool operator()(const CKeyID& id) const { return addr->Set(id); }
|
|
|
|
bool operator()(const CScriptID& id) const { return addr->Set(id); }
|
|
|
|
bool operator()(const CNoDestination& no) const { return false; }
|
|
|
|
};
|
2014-06-24 14:17:43 +02:00
|
|
|
|
2017-06-26 13:37:42 +02:00
|
|
|
} // namespace
|
2014-05-09 23:42:20 +02:00
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
bool CBitcoinAddress::Set(const CKeyID& id)
|
|
|
|
{
|
2014-05-09 23:42:20 +02:00
|
|
|
SetData(Params().Base58Prefix(CChainParams::PUBKEY_ADDRESS), &id, 20);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
bool CBitcoinAddress::Set(const CScriptID& id)
|
|
|
|
{
|
2014-05-09 23:42:20 +02:00
|
|
|
SetData(Params().Base58Prefix(CChainParams::SCRIPT_ADDRESS), &id, 20);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
bool CBitcoinAddress::Set(const CTxDestination& dest)
|
|
|
|
{
|
2014-05-09 23:42:20 +02:00
|
|
|
return boost::apply_visitor(CBitcoinAddressVisitor(this), dest);
|
|
|
|
}
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
bool CBitcoinAddress::IsValid() const
|
|
|
|
{
|
2014-08-02 20:54:57 +02:00
|
|
|
return IsValid(Params());
|
|
|
|
}
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
bool CBitcoinAddress::IsValid(const CChainParams& params) const
|
|
|
|
{
|
2014-05-09 23:42:20 +02:00
|
|
|
bool fCorrectSize = vchData.size() == 20;
|
2014-08-02 20:54:57 +02:00
|
|
|
bool fKnownVersion = vchVersion == params.Base58Prefix(CChainParams::PUBKEY_ADDRESS) ||
|
|
|
|
vchVersion == params.Base58Prefix(CChainParams::SCRIPT_ADDRESS);
|
2014-05-09 23:42:20 +02:00
|
|
|
return fCorrectSize && fKnownVersion;
|
|
|
|
}
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
CTxDestination CBitcoinAddress::Get() const
|
|
|
|
{
|
2014-05-09 23:42:20 +02:00
|
|
|
if (!IsValid())
|
|
|
|
return CNoDestination();
|
|
|
|
uint160 id;
|
2017-07-13 01:23:59 +02:00
|
|
|
memcpy(&id, vchData.data(), 20);
|
2014-05-09 23:42:20 +02:00
|
|
|
if (vchVersion == Params().Base58Prefix(CChainParams::PUBKEY_ADDRESS))
|
|
|
|
return CKeyID(id);
|
|
|
|
else if (vchVersion == Params().Base58Prefix(CChainParams::SCRIPT_ADDRESS))
|
|
|
|
return CScriptID(id);
|
|
|
|
else
|
|
|
|
return CNoDestination();
|
|
|
|
}
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
void CBitcoinSecret::SetKey(const CKey& vchSecret)
|
|
|
|
{
|
2014-05-09 23:42:20 +02:00
|
|
|
assert(vchSecret.IsValid());
|
|
|
|
SetData(Params().Base58Prefix(CChainParams::SECRET_KEY), vchSecret.begin(), vchSecret.size());
|
|
|
|
if (vchSecret.IsCompressed())
|
|
|
|
vchData.push_back(1);
|
|
|
|
}
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
CKey CBitcoinSecret::GetKey()
|
|
|
|
{
|
2014-05-09 23:42:20 +02:00
|
|
|
CKey ret;
|
2014-09-22 22:24:42 +02:00
|
|
|
assert(vchData.size() >= 32);
|
|
|
|
ret.Set(vchData.begin(), vchData.begin() + 32, vchData.size() > 32 && vchData[32] == 1);
|
2014-05-09 23:42:20 +02:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
bool CBitcoinSecret::IsValid() const
|
|
|
|
{
|
2014-05-09 23:42:20 +02:00
|
|
|
bool fExpectedFormat = vchData.size() == 32 || (vchData.size() == 33 && vchData[32] == 1);
|
|
|
|
bool fCorrectVersion = vchVersion == Params().Base58Prefix(CChainParams::SECRET_KEY);
|
|
|
|
return fExpectedFormat && fCorrectVersion;
|
|
|
|
}
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
bool CBitcoinSecret::SetString(const char* pszSecret)
|
|
|
|
{
|
2014-05-09 23:42:20 +02:00
|
|
|
return CBase58Data::SetString(pszSecret) && IsValid();
|
|
|
|
}
|
|
|
|
|
2014-09-19 19:21:46 +02:00
|
|
|
bool CBitcoinSecret::SetString(const std::string& strSecret)
|
|
|
|
{
|
2014-05-09 23:42:20 +02:00
|
|
|
return SetString(strSecret.c_str());
|
|
|
|
}
|
Merge #11117: Prepare for non-Base58 addresses (#3294)
* Merge #11117: Prepare for non-Base58 addresses
864cd2787 Move CBitcoinAddress to base58.cpp (Pieter Wuille)
5c8ff0d44 Introduce wrappers around CBitcoinAddress (Pieter Wuille)
Pull request description:
This patch removes the need for the intermediary Base58 type `CBitcoinAddress`, by providing {`Encode`,`Decode`,`IsValid`}`Destination` functions that directly operate on the conversion between `std::string`s and `CTxDestination`.
As a side, it also fixes a number of indentation issues, and removes probably several unnecessary implicit `CTxDestination`<->`CBitcoinAddress` conversions.
This change is far from complete. In follow-ups I'd like to:
* Split off the specific address and key encoding logic from base58.h, and move it to a address.h or so.
* Replace `CTxDestination` with a non-`boost::variant` version (which can be more efficient as `boost::variant` allocates everything on the heap, and remove the need for `boost::get<...>` and `IsValidDestination` calls everywhere).
* Do the same for `CBitcoinSecret`, `CBitcoinExtKey`, and `CBitcoinExtPubKey`.
However, I've tried to keep this patch to be minimally invasive, but still enough to support non-Base58 addresses. Perhaps a smaller patch is possible to hack Bech32 support into `CBitcoinAddress`, but I would consider that a move in the wrong direction.
Tree-SHA512: c2c77ffb57caeadf2429b1c2562ce60e8c7be8aa9f8e51b591f354b6b441162625b2efe14c023a1ae485cf2ed417263afa35c892891dfaa7844e7fbabccab85e
* CBitcoinAddress -> EncodeDestination in providertx.h
Signed-off-by: Pasta <pasta@dashboost.org>
* more CBitcoinAddress -> EncodeDestination in providertx.h
Signed-off-by: Pasta <pasta@dashboost.org>
* more CBitcoinAddress -> EncodeDestination in providertx.h
Signed-off-by: Pasta <pasta@dashboost.org>
* more CBitcoinAddress -> EncodeDestination in providertx.h
Signed-off-by: Pasta <pasta@dashboost.org>
* fix CBitcoinAddress GetKeyID check
Signed-off-by: Pasta <pasta@dashboost.org>
* fix providertx.cpp
Signed-off-by: Pasta <pasta@dashboost.org>
* hopefully fix governance-classes.cpp
Signed-off-by: Pasta <pasta@dashboost.org>
* partially fix governance-validators.cpp, unable to resolve "address.IsScript()"
Signed-off-by: Pasta <pasta@dashboost.org>
* partially fix governance-classes.cpp, unable to resolve "address.IsScript()"
Signed-off-by: Pasta <pasta@dashboost.org>
* fix governance-classes.h
Signed-off-by: Pasta <pasta@dashboost.org>
* DecodeTransaction -> DecodeDestination, fix governance-validators.cpp
Signed-off-by: Pasta <pasta@dashboost.org>
* More fixes for 3294
* Move GetIndexKey into rpc/misc.cpp near getAddressesFromParams
No need to have it in base58.cpp anymore as this is only used in getAddressesFromParams
Co-authored-by: Wladimir J. van der Laan <laanwj@gmail.com>
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
Co-authored-by: Alexander Block <ablock84@gmail.com>
2020-01-22 11:35:04 +01:00
|
|
|
|
|
|
|
std::string EncodeDestination(const CTxDestination& dest)
|
|
|
|
{
|
|
|
|
CBitcoinAddress addr(dest);
|
|
|
|
if (!addr.IsValid()) return "";
|
|
|
|
return addr.ToString();
|
|
|
|
}
|
|
|
|
|
|
|
|
CTxDestination DecodeDestination(const std::string& str)
|
|
|
|
{
|
|
|
|
return CBitcoinAddress(str).Get();
|
|
|
|
}
|
|
|
|
|
|
|
|
bool IsValidDestinationString(const std::string& str, const CChainParams& params)
|
|
|
|
{
|
|
|
|
return CBitcoinAddress(str).IsValid(params);
|
|
|
|
}
|
|
|
|
|
|
|
|
bool IsValidDestinationString(const std::string& str)
|
|
|
|
{
|
|
|
|
return CBitcoinAddress(str).IsValid();
|
|
|
|
}
|
|
|
|
|