2017-12-21 20:33:47 +01:00
#!/usr/bin/env python3
2017-09-20 22:31:12 +02:00
# Copyright (c) 2014-2015 The Bitcoin Core developers
# Distributed under the MIT software license, see the accompanying
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
# Exercise the wallet keypool, and interaction with wallet encryption/locking
# Add python-bitcoinrpc to module search path:
Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
68400d8b96 tests: Use explicit imports (practicalswift)
Pull request description:
Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools.
An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports.
Before this commit:
```
$ contrib/devtools/lint-python.sh | head -10
./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
$
```
After this commit:
```
$ contrib/devtools/lint-python.sh | head -10
$
```
Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
2018-08-13 14:24:43 +02:00
import time
2020-04-18 11:37:20 +02:00
from decimal import Decimal
Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
68400d8b96 tests: Use explicit imports (practicalswift)
Pull request description:
Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools.
An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports.
Before this commit:
```
$ contrib/devtools/lint-python.sh | head -10
./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
$
```
After this commit:
```
$ contrib/devtools/lint-python.sh | head -10
$
```
Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
2018-08-13 14:24:43 +02:00
from test_framework . authproxy import JSONRPCException
2017-09-20 22:31:12 +02:00
from test_framework . test_framework import BitcoinTestFramework
2018-10-24 00:11:26 +02:00
from test_framework . util import assert_equal , assert_raises_rpc_error
2017-09-20 22:31:12 +02:00
class KeyPoolTest ( BitcoinTestFramework ) :
2019-09-24 00:56:31 +02:00
def set_test_params ( self ) :
2018-04-18 13:48:59 +02:00
self . num_nodes = 1
2019-09-24 00:54:00 +02:00
self . extra_args = [ [ ' -usehd=1 ' ] ]
2018-04-18 13:48:59 +02:00
2018-09-13 12:33:15 +02:00
def skip_test_if_missing_module ( self ) :
self . skip_if_no_wallet ( )
2017-09-20 22:31:12 +02:00
def run_test ( self ) :
nodes = self . nodes
addr_before_encrypting = nodes [ 0 ] . getnewaddress ( )
2020-12-17 13:46:20 +01:00
addr_before_encrypting_data = nodes [ 0 ] . getaddressinfo ( addr_before_encrypting )
2017-09-20 22:31:12 +02:00
wallet_info_old = nodes [ 0 ] . getwalletinfo ( )
2021-08-27 21:03:02 +02:00
assert addr_before_encrypting_data [ ' hdchainid ' ] == wallet_info_old [ ' hdchainid ' ]
2017-09-20 22:31:12 +02:00
# Encrypt wallet and wait to terminate
2018-09-14 10:28:27 +02:00
nodes [ 0 ] . encryptwallet ( ' test ' )
2017-09-20 22:31:12 +02:00
# Keep creating keys
addr = nodes [ 0 ] . getnewaddress ( )
2020-12-17 13:46:20 +01:00
addr_data = nodes [ 0 ] . getaddressinfo ( addr )
2017-09-20 22:31:12 +02:00
wallet_info = nodes [ 0 ] . getwalletinfo ( )
2021-08-27 21:03:02 +02:00
assert addr_before_encrypting_data [ ' hdchainid ' ] == wallet_info [ ' hdchainid ' ]
assert addr_data [ ' hdchainid ' ] == wallet_info [ ' hdchainid ' ]
2017-09-20 22:31:12 +02:00
try :
addr = nodes [ 0 ] . getnewaddress ( )
raise AssertionError ( ' Keypool should be exhausted after one address ' )
except JSONRPCException as e :
2021-08-27 21:03:02 +02:00
assert e . error [ ' code ' ] == - 12
2017-09-20 22:31:12 +02:00
# put six (plus 2) new keys in the keypool (100% external-, +100% internal-keys, 1 in min)
nodes [ 0 ] . walletpassphrase ( ' test ' , 12000 )
nodes [ 0 ] . keypoolrefill ( 6 )
nodes [ 0 ] . walletlock ( )
wi = nodes [ 0 ] . getwalletinfo ( )
assert_equal ( wi [ ' keypoolsize_hd_internal ' ] , 6 )
assert_equal ( wi [ ' keypoolsize ' ] , 6 )
# drain the internal keys
nodes [ 0 ] . getrawchangeaddress ( )
nodes [ 0 ] . getrawchangeaddress ( )
nodes [ 0 ] . getrawchangeaddress ( )
nodes [ 0 ] . getrawchangeaddress ( )
nodes [ 0 ] . getrawchangeaddress ( )
nodes [ 0 ] . getrawchangeaddress ( )
# the next one should fail
try :
nodes [ 0 ] . getrawchangeaddress ( )
raise AssertionError ( ' Keypool should be exhausted after six addresses ' )
except JSONRPCException as e :
2021-08-27 21:03:02 +02:00
assert e . error [ ' code ' ] == - 12
2017-09-20 22:31:12 +02:00
addr = set ( )
# drain the external keys
addr . add ( nodes [ 0 ] . getnewaddress ( ) )
addr . add ( nodes [ 0 ] . getnewaddress ( ) )
addr . add ( nodes [ 0 ] . getnewaddress ( ) )
addr . add ( nodes [ 0 ] . getnewaddress ( ) )
addr . add ( nodes [ 0 ] . getnewaddress ( ) )
addr . add ( nodes [ 0 ] . getnewaddress ( ) )
2021-08-27 21:03:02 +02:00
assert len ( addr ) == 6
2017-09-20 22:31:12 +02:00
# the next one should fail
try :
addr = nodes [ 0 ] . getnewaddress ( )
raise AssertionError ( ' Keypool should be exhausted after six addresses ' )
except JSONRPCException as e :
2021-08-27 21:03:02 +02:00
assert e . error [ ' code ' ] == - 12
2017-09-20 22:31:12 +02:00
# refill keypool with three new addresses
nodes [ 0 ] . walletpassphrase ( ' test ' , 1 )
nodes [ 0 ] . keypoolrefill ( 3 )
# test walletpassphrase timeout
time . sleep ( 1.1 )
assert_equal ( nodes [ 0 ] . getwalletinfo ( ) [ " unlocked_until " ] , 0 )
2018-10-24 00:11:26 +02:00
# drain the keypool
for _ in range ( 3 ) :
nodes [ 0 ] . getnewaddress ( )
assert_raises_rpc_error ( - 12 , " Keypool ran out " , nodes [ 0 ] . getnewaddress )
2017-09-20 22:31:12 +02:00
nodes [ 0 ] . walletpassphrase ( ' test ' , 100 )
nodes [ 0 ] . keypoolrefill ( 100 )
wi = nodes [ 0 ] . getwalletinfo ( )
assert_equal ( wi [ ' keypoolsize_hd_internal ' ] , 100 )
assert_equal ( wi [ ' keypoolsize ' ] , 100 )
2020-04-18 11:37:20 +02:00
# create a blank wallet
nodes [ 0 ] . createwallet ( wallet_name = ' w2 ' , blank = True )
w2 = nodes [ 0 ] . get_wallet_rpc ( ' w2 ' )
# refer to initial wallet as w1
w1 = nodes [ 0 ] . get_wallet_rpc ( self . default_wallet_name )
# import private key and fund it
address = addr . pop ( )
privkey = w1 . dumpprivkey ( address )
res = w2 . importmulti ( [ { ' scriptPubKey ' : { ' address ' : address } , ' keys ' : [ privkey ] , ' timestamp ' : ' now ' } ] )
assert_equal ( res [ 0 ] [ ' success ' ] , True )
w1 . walletpassphrase ( ' test ' , 100 )
res = w1 . sendtoaddress ( address = address , amount = 0.00010000 )
nodes [ 0 ] . generate ( 1 )
destination = addr . pop ( )
# Using a fee rate (10 sat / byte) well above the minimum relay rate
# creating a 5,000 sat transaction with change should not be possible
assert_raises_rpc_error ( - 4 , " Transaction needs a change address, but we can ' t generate it. Please call keypoolrefill first. " , w2 . walletcreatefundedpsbt , inputs = [ ] , outputs = [ { addr . pop ( ) : 0.00005000 } ] , options = { " subtractFeeFromOutputs " : [ 0 ] , " feeRate " : 0.000010 } )
# creating a 10,000 sat transaction without change, with a manual input, should still be possible
res = w2 . walletcreatefundedpsbt ( inputs = w2 . listunspent ( ) , outputs = [ { destination : 0.00010000 } ] , options = { " subtractFeeFromOutputs " : [ 0 ] , " feeRate " : 0.000010 } )
assert_equal ( " psbt " in res , True )
# creating a 10,000 sat transaction without change should still be possible
res = w2 . walletcreatefundedpsbt ( inputs = [ ] , outputs = [ { destination : 0.00010000 } ] , options = { " subtractFeeFromOutputs " : [ 0 ] , " feeRate " : 0.000010 } )
assert_equal ( " psbt " in res , True )
# should work without subtractFeeFromOutputs if the exact fee is subtracted from the amount
res = w2 . walletcreatefundedpsbt ( inputs = [ ] , outputs = [ { destination : 0.00008900 } ] , options = { " feeRate " : 0.000010 } )
assert_equal ( " psbt " in res , True )
# dust change should be removed
res = w2 . walletcreatefundedpsbt ( inputs = [ ] , outputs = [ { destination : 0.00008800 } ] , options = { " feeRate " : 0.000010 } )
assert_equal ( " psbt " in res , True )
# create a transaction without change at the maximum fee rate, such that the output is still spendable:
res = w2 . walletcreatefundedpsbt ( inputs = [ ] , outputs = [ { destination : 0.00010000 } ] , options = { " subtractFeeFromOutputs " : [ 0 ] , " feeRate " : 0.00008824 } )
assert_equal ( " psbt " in res , True )
assert_equal ( res [ " fee " ] , Decimal ( " 0.00001685 " ) )
# creating a 10,000 sat transaction with a manual change address should be possible
res = w2 . walletcreatefundedpsbt ( inputs = [ ] , outputs = [ { destination : 0.00010000 } ] , options = { " subtractFeeFromOutputs " : [ 0 ] , " feeRate " : 0.000010 , " changeAddress " : addr . pop ( ) } )
assert_equal ( " psbt " in res , True )
2017-09-20 22:31:12 +02:00
if __name__ == ' __main__ ' :
KeyPoolTest ( ) . main ( )