2016-05-06 11:23:48 +02:00
|
|
|
#!/usr/bin/env python3
|
2023-08-16 19:27:31 +02:00
|
|
|
# Copyright (c) 2015-2020 The Bitcoin Core developers
|
2016-05-06 11:23:48 +02:00
|
|
|
# Distributed under the MIT software license, see the accompanying
|
2015-06-28 20:42:17 +02:00
|
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
2019-01-07 10:55:35 +01:00
|
|
|
"""Test BIP65 (CHECKLOCKTIMEVERIFY).
|
|
|
|
|
2021-08-27 01:35:02 +02:00
|
|
|
Test that the CHECKLOCKTIMEVERIFY soft-fork activates.
|
2019-01-07 10:55:35 +01:00
|
|
|
"""
|
2015-06-28 20:42:17 +02:00
|
|
|
|
2021-04-22 12:58:18 +02:00
|
|
|
from test_framework.blocktools import (
|
Merge bitcoin/bitcoin#22550: test: improve `test_signing_with_{csv,cltv}` subtests (speed, prevent timeout)
12f094ec215aacf30e4e380c0399f80d4e45c345 test: use constants for CSV/CLTV activation heights in rpc_signrawtransaction (Sebastian Falbesoner)
746f203f1950a7df50b9a7de87a361cc7354ffb4 test: introduce `generate_to_height` helper, use in rpc_signrawtransaction (Sebastian Falbesoner)
e3237b1cd07a5099fbb0108218194eb653b6a9f3 test: check that CSV/CLTV are active in rpc_signrawtransaction (Sebastian Falbesoner)
Pull request description:
This PR primarily aims to solve the current RPC timeout problem for test rpc_signrawtransaction.py, as described in #22542. In the course of that the test is also improved in other ways (see https://github.com/bitcoin/bitcoin/pull/22542#pullrequestreview-714297804).
Reviewers guideline:
* In `test_signing_with_cltv()`, a comment is fixed -- it wrongly referred to CSV, it should be CLTV.
* As preparation, assertions are added that ensure that CSV and CLTV have been really activated after generating blocks by checking the 'softforks' output of the getblockchaininfo() RPC. Right now in master, one could remove (or decrease, like in #22542) the generate calls and the test would still pass, when it shouldn't.
* A helper `generate_to_height()` is introduced which improves the previous way of reaching a block height in two ways:
- instead of blindly generating TH blocks to reach target block height >= TH, the current block height CH is taken into account, and only (TH - CH) are generated in total
- to avoid potential RPC timeouts, the block generation is split up into multiple generatetoaddress RPC calls ([as suggested by laanwj](https://github.com/bitcoin/bitcoin/pull/22542#issuecomment-886237866)); here chunks of 200 blocks have been chosen
* The helper is used in the affected sub-tests, which should both speed-up the test (from ~18s to ~12s on my machine) and avoid potential timeouts
* Finally, the activation constants for CSV and CLTV are used instead of using magic numbers 500 and 1500
Open questions:
* Any good naming alternatives for `generate_to_height()`? Not really happy with the name, happy to hear suggestions
* Where to put the CSV and CLTV activation height constants in the test_framewor folder? I guess importing constants from other tests isn't really the desired way to go
ACKs for top commit:
laanwj:
Code review and tested ACK 12f094ec215aacf30e4e380c0399f80d4e45c345
rajarshimaitra:
reACK https://github.com/bitcoin/bitcoin/pull/22550/commits/12f094ec215aacf30e4e380c0399f80d4e45c345
Tree-SHA512: 14509f6d3e5a5a05d6a30a3145bb82cd96a29d9d8a589abf1944a8bf34291cde78ce711195f52e9426588dc822b3618ec9b455e057360021ae46152bb7613516
2021-07-28 13:56:04 +02:00
|
|
|
CLTV_HEIGHT,
|
2021-04-22 12:58:18 +02:00
|
|
|
create_block,
|
|
|
|
create_coinbase,
|
|
|
|
)
|
|
|
|
from test_framework.messages import (
|
|
|
|
CTransaction,
|
|
|
|
msg_block,
|
|
|
|
)
|
2024-01-15 20:35:29 +01:00
|
|
|
from test_framework.p2p import P2PInterface
|
2021-04-22 12:58:18 +02:00
|
|
|
from test_framework.script import (
|
|
|
|
CScript,
|
|
|
|
CScriptNum,
|
|
|
|
OP_1NEGATE,
|
|
|
|
OP_CHECKLOCKTIMEVERIFY,
|
|
|
|
OP_DROP,
|
|
|
|
)
|
Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
68400d8b96 tests: Use explicit imports (practicalswift)
Pull request description:
Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools.
An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports.
Before this commit:
```
$ contrib/devtools/lint-python.sh | head -10
./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
$
```
After this commit:
```
$ contrib/devtools/lint-python.sh | head -10
$
```
Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
2018-08-13 14:24:43 +02:00
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
2018-09-08 06:56:51 +02:00
|
|
|
from test_framework.util import (
|
|
|
|
assert_equal,
|
|
|
|
assert_raises_rpc_error,
|
|
|
|
)
|
2021-05-25 07:26:18 +02:00
|
|
|
from test_framework.wallet import (
|
|
|
|
MiniWallet,
|
|
|
|
MiniWalletMode,
|
|
|
|
)
|
2015-06-28 20:42:17 +02:00
|
|
|
|
2019-09-08 18:07:07 +02:00
|
|
|
|
2021-04-22 12:58:18 +02:00
|
|
|
# Helper function to modify a transaction by
|
|
|
|
# 1) prepending a given script to the scriptSig of vin 0 and
|
|
|
|
# 2) (optionally) modify the nSequence of vin 0 and the tx's nLockTime
|
2021-06-01 14:55:40 +02:00
|
|
|
def cltv_modify_tx(tx, prepend_scriptsig, nsequence=None, nlocktime=None):
|
2024-07-23 19:39:49 +02:00
|
|
|
assert_equal(len(tx.vin), 1)
|
2021-04-22 12:58:18 +02:00
|
|
|
if nsequence is not None:
|
|
|
|
tx.vin[0].nSequence = nsequence
|
|
|
|
tx.nLockTime = nlocktime
|
|
|
|
|
2024-07-23 19:39:49 +02:00
|
|
|
tx.vin[0].scriptSig = CScript(prepend_scriptsig + list(CScript(tx.vin[0].scriptSig)))
|
|
|
|
tx.rehash()
|
2015-06-28 20:42:17 +02:00
|
|
|
|
2019-09-08 18:07:07 +02:00
|
|
|
|
2021-06-01 14:55:40 +02:00
|
|
|
def cltv_invalidate(tx, failure_reason):
|
2021-04-22 12:58:18 +02:00
|
|
|
# Modify the signature in vin 0 and nSequence/nLockTime of the tx to fail CLTV
|
|
|
|
#
|
|
|
|
# According to BIP65, OP_CHECKLOCKTIMEVERIFY can fail due the following reasons:
|
|
|
|
# 1) the stack is empty
|
|
|
|
# 2) the top item on the stack is less than 0
|
|
|
|
# 3) the lock-time type (height vs. timestamp) of the top stack item and the
|
|
|
|
# nLockTime field are not the same
|
|
|
|
# 4) the top stack item is greater than the transaction's nLockTime field
|
|
|
|
# 5) the nSequence field of the txin is 0xffffffff
|
|
|
|
assert failure_reason in range(5)
|
|
|
|
scheme = [
|
|
|
|
# | Script to prepend to scriptSig | nSequence | nLockTime |
|
|
|
|
# +-------------------------------------------------+------------+--------------+
|
|
|
|
[[OP_CHECKLOCKTIMEVERIFY], None, None],
|
|
|
|
[[OP_1NEGATE, OP_CHECKLOCKTIMEVERIFY, OP_DROP], None, None],
|
2021-08-27 01:35:02 +02:00
|
|
|
[[CScriptNum(100), OP_CHECKLOCKTIMEVERIFY, OP_DROP], 0, 1296688602], # timestamp of genesis block
|
|
|
|
[[CScriptNum(100), OP_CHECKLOCKTIMEVERIFY, OP_DROP], 0, 50],
|
|
|
|
[[CScriptNum(50), OP_CHECKLOCKTIMEVERIFY, OP_DROP], 0xffffffff, 50],
|
2021-04-22 12:58:18 +02:00
|
|
|
][failure_reason]
|
|
|
|
|
2021-06-01 14:55:40 +02:00
|
|
|
cltv_modify_tx(tx, prepend_scriptsig=scheme[0], nsequence=scheme[1], nlocktime=scheme[2])
|
2021-04-22 12:58:18 +02:00
|
|
|
|
2015-06-28 20:42:17 +02:00
|
|
|
|
2021-06-01 14:55:40 +02:00
|
|
|
def cltv_validate(tx, height):
|
2021-04-22 12:58:18 +02:00
|
|
|
# Modify the signature in vin 0 and nSequence/nLockTime of the tx to pass CLTV
|
|
|
|
scheme = [[CScriptNum(height), OP_CHECKLOCKTIMEVERIFY, OP_DROP], 0, height]
|
|
|
|
|
2021-06-01 14:55:40 +02:00
|
|
|
cltv_modify_tx(tx, prepend_scriptsig=scheme[0], nsequence=scheme[1], nlocktime=scheme[2])
|
2019-09-08 18:07:07 +02:00
|
|
|
|
2018-09-08 06:56:51 +02:00
|
|
|
|
2019-09-08 18:07:07 +02:00
|
|
|
class BIP65Test(BitcoinTestFramework):
|
2017-09-01 18:47:13 +02:00
|
|
|
def set_test_params(self):
|
2015-06-28 20:42:17 +02:00
|
|
|
self.num_nodes = 1
|
2019-07-16 22:07:14 +02:00
|
|
|
self.extra_args = [[
|
2020-02-28 05:18:57 +01:00
|
|
|
'-whitelist=noban@127.0.0.1',
|
2019-07-16 22:07:14 +02:00
|
|
|
'-dip3params=9000:9000',
|
|
|
|
'-par=1', # Use only one script thread to get the exact reject reason for testing
|
|
|
|
'-acceptnonstdtxn=1', # cltv_invalidate is nonstandard
|
2021-04-15 03:33:47 +02:00
|
|
|
'-vbparams=v20:0:999999999999:0:480:384:288:5:0' # Delay v20 for this test as we don't need it
|
2019-07-16 22:07:14 +02:00
|
|
|
]]
|
2019-09-08 18:07:07 +02:00
|
|
|
self.setup_clean_chain = True
|
2020-03-11 13:38:59 +01:00
|
|
|
self.rpc_timeout = 480
|
2015-06-28 20:42:17 +02:00
|
|
|
|
2019-07-03 18:11:39 +02:00
|
|
|
def test_cltv_info(self, *, is_active):
|
2021-04-22 12:58:18 +02:00
|
|
|
assert_equal(self.nodes[0].getblockchaininfo()['softforks']['bip65'], {
|
2019-08-15 22:02:02 +02:00
|
|
|
"active": is_active,
|
|
|
|
"height": CLTV_HEIGHT,
|
|
|
|
"type": "buried",
|
2019-07-03 18:11:39 +02:00
|
|
|
},
|
|
|
|
)
|
|
|
|
|
2015-06-28 20:42:17 +02:00
|
|
|
def run_test(self):
|
2020-09-25 14:18:21 +02:00
|
|
|
peer = self.nodes[0].add_p2p_connection(P2PInterface())
|
2021-05-25 07:26:18 +02:00
|
|
|
wallet = MiniWallet(self.nodes[0], mode=MiniWalletMode.RAW_OP_TRUE)
|
2019-09-08 18:07:07 +02:00
|
|
|
|
2019-07-03 18:11:39 +02:00
|
|
|
self.test_cltv_info(is_active=False)
|
|
|
|
|
2019-09-08 18:07:07 +02:00
|
|
|
self.log.info("Mining %d blocks", CLTV_HEIGHT - 2)
|
2024-07-23 19:39:49 +02:00
|
|
|
wallet.generate(10)
|
|
|
|
self.nodes[0].generate(CLTV_HEIGHT - 2 - 10)
|
2021-08-27 01:35:02 +02:00
|
|
|
assert_equal(self.nodes[0].getblockcount(), CLTV_HEIGHT - 2)
|
2019-09-08 18:07:07 +02:00
|
|
|
|
2021-04-22 12:58:18 +02:00
|
|
|
self.log.info("Test that invalid-according-to-CLTV transactions can still appear in a block")
|
2019-09-08 18:07:07 +02:00
|
|
|
|
2021-04-22 12:58:18 +02:00
|
|
|
# create one invalid tx per CLTV failure reason (5 in total) and collect them
|
2021-06-01 14:55:40 +02:00
|
|
|
invalid_cltv_txs = []
|
2021-04-22 12:58:18 +02:00
|
|
|
for i in range(5):
|
2024-07-23 19:39:49 +02:00
|
|
|
spendtx = wallet.create_self_transfer(from_node=self.nodes[0])['tx']
|
2021-06-01 14:55:40 +02:00
|
|
|
cltv_invalidate(spendtx, i)
|
|
|
|
invalid_cltv_txs.append(spendtx)
|
2015-06-28 20:42:17 +02:00
|
|
|
|
2019-09-08 18:07:07 +02:00
|
|
|
tip = self.nodes[0].getbestblockhash()
|
|
|
|
block_time = self.nodes[0].getblockheader(tip)['mediantime'] + 1
|
|
|
|
block = create_block(int(tip, 16), create_coinbase(CLTV_HEIGHT - 1), block_time)
|
|
|
|
block.nVersion = 3
|
2021-06-01 14:55:40 +02:00
|
|
|
block.vtx.extend(invalid_cltv_txs)
|
2015-06-28 20:42:17 +02:00
|
|
|
block.hashMerkleRoot = block.calc_merkle_root()
|
|
|
|
block.solve()
|
|
|
|
|
2019-08-15 22:02:02 +02:00
|
|
|
self.test_cltv_info(is_active=False) # Not active as of current tip and next block does not need to obey rules
|
2020-09-25 14:18:21 +02:00
|
|
|
peer.send_and_ping(msg_block(block))
|
2019-08-15 22:02:02 +02:00
|
|
|
self.test_cltv_info(is_active=True) # Not active as of current tip, but next block must obey rules
|
2019-09-08 18:07:07 +02:00
|
|
|
assert_equal(self.nodes[0].getbestblockhash(), block.hash)
|
|
|
|
|
|
|
|
self.log.info("Test that blocks must now be at least version 4")
|
|
|
|
tip = block.sha256
|
|
|
|
block_time += 1
|
|
|
|
block = create_block(tip, create_coinbase(CLTV_HEIGHT), block_time)
|
2015-06-28 20:42:17 +02:00
|
|
|
block.nVersion = 3
|
|
|
|
block.solve()
|
|
|
|
|
2018-09-08 06:56:51 +02:00
|
|
|
with self.nodes[0].assert_debug_log(expected_msgs=['{}, bad-version(0x00000003)'.format(block.hash)]):
|
2020-09-25 14:18:21 +02:00
|
|
|
peer.send_and_ping(msg_block(block))
|
2018-09-08 06:56:51 +02:00
|
|
|
assert_equal(int(self.nodes[0].getbestblockhash(), 16), tip)
|
2020-09-25 14:18:21 +02:00
|
|
|
peer.sync_with_ping()
|
2019-09-08 18:07:07 +02:00
|
|
|
|
2021-04-22 12:58:18 +02:00
|
|
|
self.log.info("Test that invalid-according-to-CLTV transactions cannot appear in a block")
|
2015-06-28 20:42:17 +02:00
|
|
|
block.nVersion = 4
|
2021-04-22 12:58:18 +02:00
|
|
|
block.vtx.append(CTransaction()) # dummy tx after coinbase that will be replaced later
|
|
|
|
|
|
|
|
# create and test one invalid tx per CLTV failure reason (5 in total)
|
|
|
|
for i in range(5):
|
2024-07-23 19:39:49 +02:00
|
|
|
spendtx = wallet.create_self_transfer(from_node=self.nodes[0])['tx']
|
2021-06-01 14:55:40 +02:00
|
|
|
cltv_invalidate(spendtx, i)
|
2021-04-22 12:58:18 +02:00
|
|
|
|
|
|
|
expected_cltv_reject_reason = [
|
|
|
|
"non-mandatory-script-verify-flag (Operation not valid with the current stack size)",
|
|
|
|
"non-mandatory-script-verify-flag (Negative locktime)",
|
|
|
|
"non-mandatory-script-verify-flag (Locktime requirement not satisfied)",
|
|
|
|
"non-mandatory-script-verify-flag (Locktime requirement not satisfied)",
|
|
|
|
"non-mandatory-script-verify-flag (Locktime requirement not satisfied)",
|
|
|
|
][i]
|
|
|
|
# First we show that this tx is valid except for CLTV by getting it
|
|
|
|
# rejected from the mempool for exactly that reason.
|
|
|
|
assert_raises_rpc_error(-26, expected_cltv_reject_reason, self.nodes[0].sendrawtransaction, spendtx.serialize().hex(), 0)
|
|
|
|
|
|
|
|
# Now we verify that a block with this transaction is also invalid.
|
|
|
|
block.vtx[1] = spendtx
|
|
|
|
block.hashMerkleRoot = block.calc_merkle_root()
|
|
|
|
block.solve()
|
|
|
|
|
|
|
|
with self.nodes[0].assert_debug_log(expected_msgs=['CheckInputScripts on {} failed with {}'.format(
|
|
|
|
block.vtx[-1].hash, expected_cltv_reject_reason)]):
|
|
|
|
peer.send_and_ping(msg_block(block))
|
|
|
|
assert_equal(int(self.nodes[0].getbestblockhash(), 16), tip)
|
|
|
|
peer.sync_with_ping()
|
2019-09-08 18:07:07 +02:00
|
|
|
|
|
|
|
self.log.info("Test that a version 4 block with a valid-according-to-CLTV transaction is accepted")
|
2021-06-01 14:55:40 +02:00
|
|
|
cltv_validate(spendtx, CLTV_HEIGHT - 1)
|
2019-09-08 18:07:07 +02:00
|
|
|
|
|
|
|
block.vtx.pop(1)
|
|
|
|
block.vtx.append(spendtx)
|
|
|
|
block.hashMerkleRoot = block.calc_merkle_root()
|
2015-06-28 20:42:17 +02:00
|
|
|
block.solve()
|
2019-09-08 18:07:07 +02:00
|
|
|
|
2019-08-15 22:02:02 +02:00
|
|
|
self.test_cltv_info(is_active=True) # Not active as of current tip, but next block must obey rules
|
2020-09-25 14:18:21 +02:00
|
|
|
peer.send_and_ping(msg_block(block))
|
2019-07-03 18:11:39 +02:00
|
|
|
self.test_cltv_info(is_active=True) # Active as of current tip
|
2019-09-08 18:07:07 +02:00
|
|
|
assert_equal(int(self.nodes[0].getbestblockhash(), 16), block.sha256)
|
|
|
|
|
2015-06-28 20:42:17 +02:00
|
|
|
|
|
|
|
if __name__ == '__main__':
|
|
|
|
BIP65Test().main()
|