2021-01-25 03:50:16 +01:00
|
|
|
#!/usr/bin/env python3
|
2023-12-31 01:00:00 +01:00
|
|
|
# Copyright (c) 2021-2024 The Dash Core developers
|
2021-01-25 03:50:16 +01:00
|
|
|
# Distributed under the MIT software license, see the accompanying
|
|
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
|
Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
68400d8b96 tests: Use explicit imports (practicalswift)
Pull request description:
Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools.
An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports.
Before this commit:
```
$ contrib/devtools/lint-python.sh | head -10
./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
$
```
After this commit:
```
$ contrib/devtools/lint-python.sh | head -10
$
```
Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
2018-08-13 14:24:43 +02:00
|
|
|
from test_framework.messages import hash256
|
2024-01-15 20:35:29 +01:00
|
|
|
from test_framework.p2p import P2PInterface
|
2021-01-25 03:50:16 +01:00
|
|
|
from test_framework.test_framework import DashTestFramework
|
2021-08-27 21:03:02 +02:00
|
|
|
from test_framework.util import assert_equal, assert_raises_rpc_error, hex_str_to_bytes
|
2021-01-25 03:50:16 +01:00
|
|
|
|
|
|
|
'''
|
|
|
|
rpc_mnauth.py
|
|
|
|
|
|
|
|
Tests mnauth RPC command
|
|
|
|
'''
|
|
|
|
|
|
|
|
|
|
|
|
class FakeMNAUTHTest(DashTestFramework):
|
|
|
|
def set_test_params(self):
|
|
|
|
self.set_dash_test_params(2, 1, fast_dip3_enforcement=True)
|
|
|
|
|
|
|
|
def run_test(self):
|
|
|
|
|
|
|
|
masternode = self.mninfo[0]
|
2018-08-09 14:07:16 +02:00
|
|
|
masternode.node.add_p2p_connection(P2PInterface())
|
2021-01-25 03:50:16 +01:00
|
|
|
|
|
|
|
protx_hash = masternode.proTxHash
|
2022-12-30 06:45:31 +01:00
|
|
|
#TODO: Fix that with basic BLS
|
2021-01-25 03:50:16 +01:00
|
|
|
public_key = masternode.pubKeyOperator
|
|
|
|
|
|
|
|
# The peerinfo should not yet contain verified_proregtx_hash/verified_pubkey_hash
|
2021-08-27 21:03:02 +02:00
|
|
|
assert "verified_proregtx_hash" not in masternode.node.getpeerinfo()[-1]
|
|
|
|
assert "verified_pubkey_hash" not in masternode.node.getpeerinfo()[-1]
|
2021-01-25 03:50:16 +01:00
|
|
|
# Fake-Authenticate the P2P connection to the masternode
|
|
|
|
node_id = masternode.node.getpeerinfo()[-1]["id"]
|
2021-08-27 21:03:02 +02:00
|
|
|
assert masternode.node.mnauth(node_id, protx_hash, public_key)
|
2021-01-25 03:50:16 +01:00
|
|
|
# The peerinfo should now contain verified_proregtx_hash and verified_pubkey_hash
|
|
|
|
peerinfo = masternode.node.getpeerinfo()[-1]
|
2021-08-27 21:03:02 +02:00
|
|
|
assert "verified_proregtx_hash" in peerinfo
|
|
|
|
assert "verified_pubkey_hash" in peerinfo
|
2021-01-25 03:50:16 +01:00
|
|
|
assert_equal(peerinfo["verified_proregtx_hash"], protx_hash)
|
2021-08-27 21:03:02 +02:00
|
|
|
assert_equal(peerinfo["verified_pubkey_hash"], hash256(hex_str_to_bytes(public_key))[::-1].hex())
|
2021-01-25 03:50:16 +01:00
|
|
|
# Test some error cases
|
|
|
|
null_hash = "0000000000000000000000000000000000000000000000000000000000000000"
|
|
|
|
assert_raises_rpc_error(-8, "proTxHash invalid", masternode.node.mnauth,
|
|
|
|
node_id,
|
|
|
|
null_hash,
|
|
|
|
public_key)
|
|
|
|
assert_raises_rpc_error(-8, "publicKey invalid", masternode.node.mnauth,
|
|
|
|
node_id,
|
|
|
|
protx_hash,
|
|
|
|
null_hash)
|
2021-08-27 21:03:02 +02:00
|
|
|
assert not masternode.node.mnauth(-1, protx_hash, public_key)
|
2021-01-25 03:50:16 +01:00
|
|
|
|
|
|
|
|
|
|
|
if __name__ == '__main__':
|
|
|
|
FakeMNAUTHTest().main()
|