sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-29 13:59:06 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
42e0b37cb2
dash/src/masternode/utils.h

21 lines
600 B
C
Raw Normal View History

chore: run `copyright_header.py update`
2023-01-12 22:26:21 +01:00
// Copyright (c) 2014-2023 The Dash Core developers
Refactor remains of CMasternode/-Man into CMasternodeMeta/-Man (#2606) * Split up remaining logic from CMasternodeMan into CMasternodeMetaMan and CMasternodeUtils Also get rid of CMastermode and store remaining meta info in CMasternodeMetaInfo * Also allow non-const T in Serialize/Unserialize for shared_ptr * Rename CActiveDeterministicMasternodeManager to CActiveMasternodeManager * Fix nowallet compile in masternode-utils.cpp
2019-01-03 21:08:34 +01:00
// Distributed under the MIT/X11 software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
refactor: remove redundant filename prefixes for Dash-specific logic (#4475) * refactor: coinjoin/coinjoin-*[cpp/h] --> coinjoin/*.[cpp/h] * refactor: governance/governance-*[cpp/h] --> governance/*.[cpp/h] * refactor: masternode/masternode-*[cpp/h] --> masternode/*.[cpp/h] * fix linter Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
2021-10-01 21:19:08 +02:00
#ifndef BITCOIN_MASTERNODE_UTILS_H
#define BITCOIN_MASTERNODE_UTILS_H
Refactor remains of CMasternode/-Man into CMasternodeMeta/-Man (#2606) * Split up remaining logic from CMasternodeMan into CMasternodeMetaMan and CMasternodeUtils Also get rid of CMastermode and store remaining meta info in CMasternodeMetaInfo * Also allow non-const T in Serialize/Unserialize for shared_ptr * Rename CActiveDeterministicMasternodeManager to CActiveMasternodeManager * Fix nowallet compile in masternode-utils.cpp
2019-01-03 21:08:34 +01:00
class CConnman;
refactor: trim globals use in net threads and functions
2024-03-30 17:23:45 +01:00
class CDeterministicMNManager;
refactor: begin to de-globalize masternodeSync (#5103) <!-- *** Please remove the following help text before submitting: *** Provide a general summary of your changes in the Title above Pull requests without a rationale and clear improvement may be closed immediately. Please provide clear motivation for your patch and explain how it improves Dash Core user experience or Dash Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Dash Core, if possible. --> ## Issue being fixed or feature implemented <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> minimizing global uses ## What was done? <!--- Describe your changes in detail --> Started the deglobalization, a future PR should be done to continue this deglobalization ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Breaking Changes <!--- Please describe any breaking changes your code introduces --> none ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation **For repository code-owners and collaborators only** - [x] I have assigned this pull request to a milestone Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
2023-01-04 21:37:20 +01:00
class CMasternodeSync;
refactor: subsume CoinJoin objects under CJContext, deglobalize coinJoin{ClientQueueManager,Server} (#5337) ## Motivation CoinJoin's subsystems are initialized by variables and managers that occupy the global context. The _extent_ to which these subsystems entrench themselves into the codebase is difficult to assess and moving them out of the global context forces us to enumerate the subsystems in the codebase that rely on CoinJoin logic and enumerate the order in which components are initialized and destroyed. Keeping this in mind, the scope of this pull request aims to: * Reduce the amount of CoinJoin-specific entities present in the global scope * Make the remaining usage of these entities in the global scope explicit and easily searchable ## Additional Information * The initialization of `CCoinJoinClientQueueManager` is dependent on blocks-only mode being disabled (which can be alternatively interpreted as enabling the relay of transactions). The same applies to `CBlockPolicyEstimator`, which `CCoinJoinClientQueueManager` depends. Therefore, `CCoinJoinClientQueueManager` is only initialized if transaction relaying is enabled and so is its scheduled maintenance task. This can be found by looking at `init.cpp` [here](https://github.com/dashpay/dash/blob/93f8df1c31fdce6a14f149acfdff22678c3f22ca/src/init.cpp#L1681-L1683), [here](https://github.com/dashpay/dash/blob/93f8df1c31fdce6a14f149acfdff22678c3f22ca/src/init.cpp#L2253-L2255) and [here](https://github.com/dashpay/dash/blob/93f8df1c31fdce6a14f149acfdff22678c3f22ca/src/init.cpp#L2326-L2327). For this reason, `CBlockPolicyEstimator` is not a member of `CJContext` and its usage is fulfilled by passing it as a reference when initializing the scheduling task. * `CJClientManager` has not used `CConnman` or `CTxMemPool` as `const` as existing code that is outside the scope of this PR would cast away constness, which would be unacceptable. Furthermore, some logical paths are taken that will grind to a halt if they are stored as `const`. Examples of such a call chains would be: * `CJClientManager::DoMaintenance > CCoinJoinClientManager::DoMaintenance > DoAutomaticDenominating > CCoinJoinClientSession::DoAutomaticDenominating > CCoinJoinClientSession::StartNewQueue > CConnman::AddPendingMasternode` which modifies `CConnman::vPendingMasternodes`, which is non-const behaviour * `CJClientManager::DoMaintenance > CCoinJoinClientManager::DoMaintenance > DoAutomaticDenominating > CCoinJoin::IsCollateralValid > AcceptToMemoryPool` which adds a transaction to the memory pool, which is non-const behaviour * There were cppcheck [linter failures](https://github.com/dashpay/dash/pull/5337#issuecomment-1685084688) that seemed to be caused by the usage of `Assert` in `coinjoin/client.h`. This seems to be resolved by backporting [bitcoin#24714](https://github.com/bitcoin/bitcoin/pull/24714). (Thanks @knst!) * Depends on #5546 --------- Co-authored-by: Kittywhiskers Van Gogh <63189531+kittywhiskers@users.noreply.github.com> Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>
2023-09-13 19:52:38 +02:00
struct CJContext;
Refactor remains of CMasternode/-Man into CMasternodeMeta/-Man (#2606) * Split up remaining logic from CMasternodeMan into CMasternodeMetaMan and CMasternodeUtils Also get rid of CMastermode and store remaining meta info in CMasternodeMetaInfo * Also allow non-const T in Serialize/Unserialize for shared_ptr * Rename CActiveDeterministicMasternodeManager to CActiveMasternodeManager * Fix nowallet compile in masternode-utils.cpp
2019-01-03 21:08:34 +01:00
class CMasternodeUtils
{
public:
refactor: trim globals use in net threads and functions
2024-03-30 17:23:45 +01:00
static void DoMaintenance(CConnman &connman, CDeterministicMNManager& dmnman,
const CMasternodeSync& mn_sync, const CJContext& cj_ctx);
Refactor remains of CMasternode/-Man into CMasternodeMeta/-Man (#2606) * Split up remaining logic from CMasternodeMan into CMasternodeMetaMan and CMasternodeUtils Also get rid of CMastermode and store remaining meta info in CMasternodeMetaInfo * Also allow non-const T in Serialize/Unserialize for shared_ptr * Rename CActiveDeterministicMasternodeManager to CActiveMasternodeManager * Fix nowallet compile in masternode-utils.cpp
2019-01-03 21:08:34 +01:00
};
refactor: remove redundant filename prefixes for Dash-specific logic (#4475) * refactor: coinjoin/coinjoin-*[cpp/h] --> coinjoin/*.[cpp/h] * refactor: governance/governance-*[cpp/h] --> governance/*.[cpp/h] * refactor: masternode/masternode-*[cpp/h] --> masternode/*.[cpp/h] * fix linter Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
2021-10-01 21:19:08 +02:00
#endif // BITCOIN_MASTERNODE_UTILS_H
Reference in New Issue Copy Permalink