2016-05-06 11:23:48 +02:00
|
|
|
#!/usr/bin/env python3
|
2023-08-16 19:27:31 +02:00
|
|
|
# Copyright (c) 2015-2020 The Bitcoin Core developers
|
2016-05-06 11:23:48 +02:00
|
|
|
# Distributed under the MIT software license, see the accompanying
|
2015-06-28 20:42:17 +02:00
|
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
2019-01-07 10:55:35 +01:00
|
|
|
"""Test BIP65 (CHECKLOCKTIMEVERIFY).
|
|
|
|
|
2019-09-08 18:07:07 +02:00
|
|
|
Test that the CHECKLOCKTIMEVERIFY soft-fork activates at (regtest) block height
|
|
|
|
1351.
|
2019-01-07 10:55:35 +01:00
|
|
|
"""
|
2015-06-28 20:42:17 +02:00
|
|
|
|
2021-04-22 12:58:18 +02:00
|
|
|
from test_framework.blocktools import (
|
|
|
|
create_block,
|
|
|
|
create_coinbase,
|
|
|
|
create_transaction,
|
|
|
|
)
|
|
|
|
from test_framework.messages import (
|
|
|
|
CTransaction,
|
|
|
|
msg_block,
|
|
|
|
)
|
2024-01-15 20:35:29 +01:00
|
|
|
from test_framework.p2p import P2PInterface
|
2021-04-22 12:58:18 +02:00
|
|
|
from test_framework.script import (
|
|
|
|
CScript,
|
|
|
|
CScriptNum,
|
|
|
|
OP_1NEGATE,
|
|
|
|
OP_CHECKLOCKTIMEVERIFY,
|
|
|
|
OP_DROP,
|
|
|
|
)
|
Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
68400d8b96 tests: Use explicit imports (practicalswift)
Pull request description:
Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools.
An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports.
Before this commit:
```
$ contrib/devtools/lint-python.sh | head -10
./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
$
```
After this commit:
```
$ contrib/devtools/lint-python.sh | head -10
$
```
Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
2018-08-13 14:24:43 +02:00
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
2018-09-08 06:56:51 +02:00
|
|
|
from test_framework.util import (
|
|
|
|
assert_equal,
|
|
|
|
assert_raises_rpc_error,
|
|
|
|
hex_str_to_bytes,
|
|
|
|
)
|
Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
68400d8b96 tests: Use explicit imports (practicalswift)
Pull request description:
Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools.
An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports.
Before this commit:
```
$ contrib/devtools/lint-python.sh | head -10
./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
$
```
After this commit:
```
$ contrib/devtools/lint-python.sh | head -10
$
```
Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
2018-08-13 14:24:43 +02:00
|
|
|
|
2016-03-19 21:36:32 +01:00
|
|
|
from io import BytesIO
|
2015-06-28 20:42:17 +02:00
|
|
|
|
2019-09-08 18:07:07 +02:00
|
|
|
CLTV_HEIGHT = 1351
|
|
|
|
|
|
|
|
|
2021-04-22 12:58:18 +02:00
|
|
|
# Helper function to modify a transaction by
|
|
|
|
# 1) prepending a given script to the scriptSig of vin 0 and
|
|
|
|
# 2) (optionally) modify the nSequence of vin 0 and the tx's nLockTime
|
|
|
|
def cltv_modify_tx(node, tx, prepend_scriptsig, nsequence=None, nlocktime=None):
|
|
|
|
if nsequence is not None:
|
|
|
|
tx.vin[0].nSequence = nsequence
|
|
|
|
tx.nLockTime = nlocktime
|
|
|
|
|
|
|
|
# Need to re-sign, since nSequence and nLockTime changed
|
|
|
|
signed_result = node.signrawtransactionwithwallet(tx.serialize().hex())
|
|
|
|
new_tx = CTransaction()
|
|
|
|
new_tx.deserialize(BytesIO(hex_str_to_bytes(signed_result['hex'])))
|
|
|
|
else:
|
|
|
|
new_tx = tx
|
|
|
|
|
|
|
|
new_tx.vin[0].scriptSig = CScript(prepend_scriptsig + list(CScript(new_tx.vin[0].scriptSig)))
|
|
|
|
return new_tx
|
2015-06-28 20:42:17 +02:00
|
|
|
|
2019-09-08 18:07:07 +02:00
|
|
|
|
2021-04-22 12:58:18 +02:00
|
|
|
def cltv_invalidate(node, tx, failure_reason):
|
|
|
|
# Modify the signature in vin 0 and nSequence/nLockTime of the tx to fail CLTV
|
|
|
|
#
|
|
|
|
# According to BIP65, OP_CHECKLOCKTIMEVERIFY can fail due the following reasons:
|
|
|
|
# 1) the stack is empty
|
|
|
|
# 2) the top item on the stack is less than 0
|
|
|
|
# 3) the lock-time type (height vs. timestamp) of the top stack item and the
|
|
|
|
# nLockTime field are not the same
|
|
|
|
# 4) the top stack item is greater than the transaction's nLockTime field
|
|
|
|
# 5) the nSequence field of the txin is 0xffffffff
|
|
|
|
assert failure_reason in range(5)
|
|
|
|
scheme = [
|
|
|
|
# | Script to prepend to scriptSig | nSequence | nLockTime |
|
|
|
|
# +-------------------------------------------------+------------+--------------+
|
|
|
|
[[OP_CHECKLOCKTIMEVERIFY], None, None],
|
|
|
|
[[OP_1NEGATE, OP_CHECKLOCKTIMEVERIFY, OP_DROP], None, None],
|
|
|
|
[[CScriptNum(1000), OP_CHECKLOCKTIMEVERIFY, OP_DROP], 0, 1296688602], # timestamp of genesis block
|
|
|
|
[[CScriptNum(1000), OP_CHECKLOCKTIMEVERIFY, OP_DROP], 0, 500],
|
|
|
|
[[CScriptNum(500), OP_CHECKLOCKTIMEVERIFY, OP_DROP], 0xffffffff, 500],
|
|
|
|
][failure_reason]
|
|
|
|
|
|
|
|
return cltv_modify_tx(node, tx, prepend_scriptsig=scheme[0], nsequence=scheme[1], nlocktime=scheme[2])
|
|
|
|
|
2015-06-28 20:42:17 +02:00
|
|
|
|
2019-09-08 18:07:07 +02:00
|
|
|
def cltv_validate(node, tx, height):
|
2021-04-22 12:58:18 +02:00
|
|
|
# Modify the signature in vin 0 and nSequence/nLockTime of the tx to pass CLTV
|
|
|
|
scheme = [[CScriptNum(height), OP_CHECKLOCKTIMEVERIFY, OP_DROP], 0, height]
|
|
|
|
|
|
|
|
return cltv_modify_tx(node, tx, prepend_scriptsig=scheme[0], nsequence=scheme[1], nlocktime=scheme[2])
|
2019-09-08 18:07:07 +02:00
|
|
|
|
2018-09-08 06:56:51 +02:00
|
|
|
|
2019-09-08 18:07:07 +02:00
|
|
|
class BIP65Test(BitcoinTestFramework):
|
2017-09-01 18:47:13 +02:00
|
|
|
def set_test_params(self):
|
2015-06-28 20:42:17 +02:00
|
|
|
self.num_nodes = 1
|
2019-07-16 22:07:14 +02:00
|
|
|
self.extra_args = [[
|
2020-02-28 05:18:57 +01:00
|
|
|
'-whitelist=noban@127.0.0.1',
|
2019-07-16 22:07:14 +02:00
|
|
|
'-dip3params=9000:9000',
|
|
|
|
'-par=1', # Use only one script thread to get the exact reject reason for testing
|
|
|
|
'-acceptnonstdtxn=1', # cltv_invalidate is nonstandard
|
2021-04-15 03:33:47 +02:00
|
|
|
'-vbparams=v20:0:999999999999:0:480:384:288:5:0' # Delay v20 for this test as we don't need it
|
2019-07-16 22:07:14 +02:00
|
|
|
]]
|
2019-09-08 18:07:07 +02:00
|
|
|
self.setup_clean_chain = True
|
2020-03-11 13:38:59 +01:00
|
|
|
self.rpc_timeout = 480
|
2015-06-28 20:42:17 +02:00
|
|
|
|
2019-07-03 18:11:39 +02:00
|
|
|
def test_cltv_info(self, *, is_active):
|
2021-04-22 12:58:18 +02:00
|
|
|
assert_equal(self.nodes[0].getblockchaininfo()['softforks']['bip65'], {
|
2019-08-15 22:02:02 +02:00
|
|
|
"active": is_active,
|
|
|
|
"height": CLTV_HEIGHT,
|
|
|
|
"type": "buried",
|
2019-07-03 18:11:39 +02:00
|
|
|
},
|
|
|
|
)
|
|
|
|
|
2018-09-13 12:33:15 +02:00
|
|
|
def skip_test_if_missing_module(self):
|
|
|
|
self.skip_if_no_wallet()
|
|
|
|
|
2015-06-28 20:42:17 +02:00
|
|
|
def run_test(self):
|
2020-09-25 14:18:21 +02:00
|
|
|
peer = self.nodes[0].add_p2p_connection(P2PInterface())
|
2019-09-08 18:07:07 +02:00
|
|
|
|
2019-07-03 18:11:39 +02:00
|
|
|
self.test_cltv_info(is_active=False)
|
|
|
|
|
2019-09-08 18:07:07 +02:00
|
|
|
self.log.info("Mining %d blocks", CLTV_HEIGHT - 2)
|
Merge #13669: Tests: Cleanup create_transaction implementations
44bbceeef1 [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput object (Conor Scott)
736f941424 [Tests] Cleanup extra instances of create_transaction (Conor Scott)
157651855f [Tests] Rename create_tx and move to blocktools.py (Conor Scott)
Pull request description:
There currently exist seven ([1](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_cltv.py#L52-L60), [2](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_csv_activation.py#L88-L95) [3](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_dersig.py#L40-L48), [4](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_nulldummy.py#L100-L108), [5](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/util.py#L529-L535), [6](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/blocktools.py#L120-L129), [7](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_block.py#L1218-L1220)) implementations of a function called something similar to `create_transaction` in the functional tests, some of which are exact copies of each other.
This PR aims to clean this up into [three different cases implemented in blocktools.py](https://github.com/conscott/bitcoin/blob/create_tx_cleanup/test/functional/test_framework/blocktools.py#L121-L149)
1. `create_tx_with_script`: Return transaction object spending generic tx output optionally specifying scriptSig and scriptPubKey
2. `create_transaction`: Return transaction object spending coinbase tx
2. `create_raw_transaction`: Return raw transaction (hex string) spending coinbase tx
I am not committed to any of these function names, so I'll gladly take suggestions on there.
Additionally there are some related cleanups to feature_block.py tests, specifically removing the [PreviousSpendableOutput](https://github.com/conscott/bitcoin/blob/master/test/functional/feature_block.py#L51-L54) object, which seems like an unnecessary layer given that every instance spends the 0 output.
Tree-SHA512: 63c6233b6f0942c81ba1ca67ea6770809b8c9409314c6d4cf8e5a3991cb9ee92b22bebe88c0dde45cd71e754eb351230c4c404b70ff118f5f43c034452ada65c
2018-08-09 18:09:27 +02:00
|
|
|
self.coinbase_txids = [self.nodes[0].getblock(b)['tx'][0] for b in self.nodes[0].generate(CLTV_HEIGHT - 2)]
|
2015-06-28 20:42:17 +02:00
|
|
|
self.nodeaddress = self.nodes[0].getnewaddress()
|
2019-09-08 18:07:07 +02:00
|
|
|
|
2021-04-22 12:58:18 +02:00
|
|
|
self.log.info("Test that invalid-according-to-CLTV transactions can still appear in a block")
|
2019-09-08 18:07:07 +02:00
|
|
|
|
2021-04-22 12:58:18 +02:00
|
|
|
# create one invalid tx per CLTV failure reason (5 in total) and collect them
|
|
|
|
invalid_ctlv_txs = []
|
|
|
|
for i in range(5):
|
|
|
|
spendtx = create_transaction(self.nodes[0], self.coinbase_txids[i],
|
|
|
|
self.nodeaddress, amount=1.0)
|
|
|
|
spendtx = cltv_invalidate(self.nodes[0], spendtx, i)
|
|
|
|
spendtx.rehash()
|
|
|
|
invalid_ctlv_txs.append(spendtx)
|
2015-06-28 20:42:17 +02:00
|
|
|
|
2019-09-08 18:07:07 +02:00
|
|
|
tip = self.nodes[0].getbestblockhash()
|
|
|
|
block_time = self.nodes[0].getblockheader(tip)['mediantime'] + 1
|
|
|
|
block = create_block(int(tip, 16), create_coinbase(CLTV_HEIGHT - 1), block_time)
|
|
|
|
block.nVersion = 3
|
2021-04-22 12:58:18 +02:00
|
|
|
block.vtx.extend(invalid_ctlv_txs)
|
2015-06-28 20:42:17 +02:00
|
|
|
block.hashMerkleRoot = block.calc_merkle_root()
|
|
|
|
block.solve()
|
|
|
|
|
2019-08-15 22:02:02 +02:00
|
|
|
self.test_cltv_info(is_active=False) # Not active as of current tip and next block does not need to obey rules
|
2020-09-25 14:18:21 +02:00
|
|
|
peer.send_and_ping(msg_block(block))
|
2019-08-15 22:02:02 +02:00
|
|
|
self.test_cltv_info(is_active=True) # Not active as of current tip, but next block must obey rules
|
2019-09-08 18:07:07 +02:00
|
|
|
assert_equal(self.nodes[0].getbestblockhash(), block.hash)
|
|
|
|
|
|
|
|
self.log.info("Test that blocks must now be at least version 4")
|
|
|
|
tip = block.sha256
|
|
|
|
block_time += 1
|
|
|
|
block = create_block(tip, create_coinbase(CLTV_HEIGHT), block_time)
|
2015-06-28 20:42:17 +02:00
|
|
|
block.nVersion = 3
|
|
|
|
block.solve()
|
|
|
|
|
2018-09-08 06:56:51 +02:00
|
|
|
with self.nodes[0].assert_debug_log(expected_msgs=['{}, bad-version(0x00000003)'.format(block.hash)]):
|
2020-09-25 14:18:21 +02:00
|
|
|
peer.send_and_ping(msg_block(block))
|
2018-09-08 06:56:51 +02:00
|
|
|
assert_equal(int(self.nodes[0].getbestblockhash(), 16), tip)
|
2020-09-25 14:18:21 +02:00
|
|
|
peer.sync_with_ping()
|
2019-09-08 18:07:07 +02:00
|
|
|
|
2021-04-22 12:58:18 +02:00
|
|
|
self.log.info("Test that invalid-according-to-CLTV transactions cannot appear in a block")
|
2015-06-28 20:42:17 +02:00
|
|
|
block.nVersion = 4
|
2021-04-22 12:58:18 +02:00
|
|
|
block.vtx.append(CTransaction()) # dummy tx after coinbase that will be replaced later
|
|
|
|
|
|
|
|
# create and test one invalid tx per CLTV failure reason (5 in total)
|
|
|
|
for i in range(5):
|
|
|
|
spendtx = create_transaction(self.nodes[0], self.coinbase_txids[10+i],
|
|
|
|
self.nodeaddress, amount=1.0)
|
|
|
|
spendtx = cltv_invalidate(self.nodes[0], spendtx, i)
|
|
|
|
spendtx.rehash()
|
|
|
|
|
|
|
|
expected_cltv_reject_reason = [
|
|
|
|
"non-mandatory-script-verify-flag (Operation not valid with the current stack size)",
|
|
|
|
"non-mandatory-script-verify-flag (Negative locktime)",
|
|
|
|
"non-mandatory-script-verify-flag (Locktime requirement not satisfied)",
|
|
|
|
"non-mandatory-script-verify-flag (Locktime requirement not satisfied)",
|
|
|
|
"non-mandatory-script-verify-flag (Locktime requirement not satisfied)",
|
|
|
|
][i]
|
|
|
|
# First we show that this tx is valid except for CLTV by getting it
|
|
|
|
# rejected from the mempool for exactly that reason.
|
|
|
|
assert_raises_rpc_error(-26, expected_cltv_reject_reason, self.nodes[0].sendrawtransaction, spendtx.serialize().hex(), 0)
|
|
|
|
|
|
|
|
# Now we verify that a block with this transaction is also invalid.
|
|
|
|
block.vtx[1] = spendtx
|
|
|
|
block.hashMerkleRoot = block.calc_merkle_root()
|
|
|
|
block.solve()
|
|
|
|
|
|
|
|
with self.nodes[0].assert_debug_log(expected_msgs=['CheckInputScripts on {} failed with {}'.format(
|
|
|
|
block.vtx[-1].hash, expected_cltv_reject_reason)]):
|
|
|
|
peer.send_and_ping(msg_block(block))
|
|
|
|
assert_equal(int(self.nodes[0].getbestblockhash(), 16), tip)
|
|
|
|
peer.sync_with_ping()
|
2019-09-08 18:07:07 +02:00
|
|
|
|
|
|
|
self.log.info("Test that a version 4 block with a valid-according-to-CLTV transaction is accepted")
|
|
|
|
spendtx = cltv_validate(self.nodes[0], spendtx, CLTV_HEIGHT - 1)
|
|
|
|
spendtx.rehash()
|
|
|
|
|
|
|
|
block.vtx.pop(1)
|
|
|
|
block.vtx.append(spendtx)
|
|
|
|
block.hashMerkleRoot = block.calc_merkle_root()
|
2015-06-28 20:42:17 +02:00
|
|
|
block.solve()
|
2019-09-08 18:07:07 +02:00
|
|
|
|
2019-08-15 22:02:02 +02:00
|
|
|
self.test_cltv_info(is_active=True) # Not active as of current tip, but next block must obey rules
|
2020-09-25 14:18:21 +02:00
|
|
|
peer.send_and_ping(msg_block(block))
|
2019-07-03 18:11:39 +02:00
|
|
|
self.test_cltv_info(is_active=True) # Active as of current tip
|
2019-09-08 18:07:07 +02:00
|
|
|
assert_equal(int(self.nodes[0].getbestblockhash(), 16), block.sha256)
|
|
|
|
|
2015-06-28 20:42:17 +02:00
|
|
|
|
|
|
|
if __name__ == '__main__':
|
|
|
|
BIP65Test().main()
|