2016-05-06 11:23:48 +02:00
|
|
|
#!/usr/bin/env python3
|
|
|
|
# Copyright (c) 2014-2016 The Bitcoin Core developers
|
2015-11-30 15:42:27 +01:00
|
|
|
# Distributed under the MIT software license, see the accompanying
|
|
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
2019-01-07 10:55:35 +01:00
|
|
|
"""Test mempool limiting together/eviction with the wallet."""
|
2015-11-30 15:42:27 +01:00
|
|
|
|
Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
68400d8b96 tests: Use explicit imports (practicalswift)
Pull request description:
Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools.
An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports.
Before this commit:
```
$ contrib/devtools/lint-python.sh | head -10
./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
$
```
After this commit:
```
$ contrib/devtools/lint-python.sh | head -10
$
```
Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
2018-08-13 14:24:43 +02:00
|
|
|
from decimal import Decimal
|
|
|
|
|
2021-09-14 11:10:08 +02:00
|
|
|
from test_framework.blocktools import COINBASE_MATURITY
|
2015-11-30 15:42:27 +01:00
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
2021-09-14 11:10:08 +02:00
|
|
|
from test_framework.util import assert_equal, assert_greater_than, assert_raises_rpc_error, gen_return_txouts
|
|
|
|
from test_framework.wallet import MiniWallet
|
|
|
|
|
2015-11-30 15:42:27 +01:00
|
|
|
|
|
|
|
class MempoolLimitTest(BitcoinTestFramework):
|
2017-09-01 18:47:13 +02:00
|
|
|
def set_test_params(self):
|
2016-05-20 15:16:51 +02:00
|
|
|
self.setup_clean_chain = True
|
|
|
|
self.num_nodes = 1
|
2019-07-16 22:07:14 +02:00
|
|
|
self.extra_args = [[
|
|
|
|
"-acceptnonstdtxn=1",
|
|
|
|
"-maxmempool=5",
|
|
|
|
"-spendzeroconfchange=0",
|
|
|
|
]]
|
2019-12-09 19:52:38 +01:00
|
|
|
self.supports_cli = False
|
2015-11-30 15:42:27 +01:00
|
|
|
|
2021-09-14 11:10:08 +02:00
|
|
|
def send_large_txs(self, node, miniwallet, txouts, fee_rate, tx_batch_size):
|
|
|
|
for _ in range(tx_batch_size):
|
|
|
|
tx = miniwallet.create_self_transfer(from_node=node, fee_rate=fee_rate)['tx']
|
|
|
|
for txout in txouts:
|
|
|
|
tx.vout.append(txout)
|
|
|
|
miniwallet.sendrawtransaction(from_node=node, tx_hex=tx.serialize().hex())
|
2018-09-13 12:33:15 +02:00
|
|
|
|
2015-11-30 15:42:27 +01:00
|
|
|
def run_test(self):
|
2017-05-02 20:02:55 +02:00
|
|
|
txouts = gen_return_txouts()
|
2021-09-14 11:10:08 +02:00
|
|
|
node=self.nodes[0]
|
|
|
|
miniwallet = MiniWallet(node)
|
|
|
|
relayfee = node.getnetworkinfo()['relayfee']
|
|
|
|
|
|
|
|
self.log.info('Check that mempoolminfee is minrelaytxfee')
|
|
|
|
assert_equal(node.getmempoolinfo()['minrelaytxfee'], Decimal('0.00001000'))
|
|
|
|
assert_equal(node.getmempoolinfo()['mempoolminfee'], Decimal('0.00001000'))
|
2017-05-02 20:02:55 +02:00
|
|
|
|
2021-09-14 11:10:08 +02:00
|
|
|
tx_batch_size = 25
|
|
|
|
num_of_batches = 3
|
|
|
|
# Generate UTXOs to flood the mempool
|
|
|
|
# 1 to create a tx initially that will be evicted from the mempool later
|
|
|
|
# 3 batches of multiple transactions with a fee rate much higher than the previous UTXO
|
|
|
|
# And 1 more to verify that this tx does not get added to the mempool with a fee rate less than the mempoolminfee
|
|
|
|
self.generate(miniwallet, 1 + (num_of_batches * tx_batch_size) + 1)
|
2018-01-04 09:22:40 +01:00
|
|
|
|
2021-09-14 11:10:08 +02:00
|
|
|
# Mine 99 blocks so that the UTXOs are allowed to be spent
|
|
|
|
self.generate(node, COINBASE_MATURITY - 1)
|
2015-11-30 15:42:27 +01:00
|
|
|
|
2018-01-04 09:22:40 +01:00
|
|
|
self.log.info('Create a mempool tx that will be evicted')
|
2021-09-14 11:10:08 +02:00
|
|
|
tx_to_be_evicted_id = miniwallet.send_self_transfer(from_node=node, fee_rate=relayfee)["txid"]
|
|
|
|
|
|
|
|
# Increase the tx fee rate massively to give the subsequent transactions a higher priority in the mempool
|
|
|
|
base_fee = relayfee * 1000
|
|
|
|
|
|
|
|
self.log.info("Fill up the mempool with txs with higher fee rate")
|
|
|
|
for batch_of_txid in range(num_of_batches):
|
|
|
|
fee_rate=(batch_of_txid + 1) * base_fee
|
|
|
|
self.send_large_txs(node, miniwallet, txouts, fee_rate, tx_batch_size)
|
2015-11-30 15:42:27 +01:00
|
|
|
|
2018-01-04 09:22:40 +01:00
|
|
|
self.log.info('The tx should be evicted by now')
|
2021-09-14 11:10:08 +02:00
|
|
|
# The number of transactions created should be greater than the ones present in the mempool
|
|
|
|
assert_greater_than(tx_batch_size * num_of_batches, len(node.getrawmempool()))
|
|
|
|
# Initial tx created should not be present in the mempool anymore as it had a lower fee rate
|
|
|
|
assert tx_to_be_evicted_id not in node.getrawmempool()
|
2015-11-30 15:42:27 +01:00
|
|
|
|
2021-09-14 11:10:08 +02:00
|
|
|
self.log.info('Check that mempoolminfee is larger than minrelaytxfee')
|
|
|
|
assert_equal(node.getmempoolinfo()['minrelaytxfee'], Decimal('0.00001000'))
|
|
|
|
assert_greater_than(node.getmempoolinfo()['mempoolminfee'], Decimal('0.00001000'))
|
2018-01-04 09:22:40 +01:00
|
|
|
|
2021-09-14 11:10:08 +02:00
|
|
|
# Deliberately try to create a tx with a fee less than the minimum mempool fee to assert that it does not get added to the mempool
|
2018-02-15 16:35:12 +01:00
|
|
|
self.log.info('Create a mempool tx that will not pass mempoolminfee')
|
2021-09-14 11:10:08 +02:00
|
|
|
assert_raises_rpc_error(-26, "mempool min fee not met", miniwallet.send_self_transfer, from_node=node, fee_rate=relayfee, mempool_valid=False)
|
|
|
|
|
2018-02-15 16:35:12 +01:00
|
|
|
|
2015-11-30 15:42:27 +01:00
|
|
|
if __name__ == '__main__':
|
|
|
|
MempoolLimitTest().main()
|