2016-09-22 10:20:44 +02:00
|
|
|
#!/usr/bin/env python3
|
|
|
|
# Copyright (c) 2016 The Bitcoin Core developers
|
|
|
|
# Distributed under the MIT software license, see the accompanying
|
|
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
2019-01-07 10:55:35 +01:00
|
|
|
"""Test NULLDUMMY softfork.
|
|
|
|
|
|
|
|
Connect to a single node.
|
|
|
|
Generate 2 blocks (save the coinbases for later).
|
|
|
|
Generate 427 more blocks.
|
|
|
|
[Policy/Consensus] Check that NULLDUMMY compliant transactions are accepted in the 430th block.
|
|
|
|
[Policy] Check that non-NULLDUMMY transactions are rejected before activation.
|
|
|
|
[Consensus] Check that the new NULLDUMMY rules are not enforced on the 431st block.
|
|
|
|
[Policy/Consensus] Check that the new NULLDUMMY rules are enforced on the 432nd block.
|
|
|
|
"""
|
2016-09-22 10:20:44 +02:00
|
|
|
|
Merge #13669: Tests: Cleanup create_transaction implementations
44bbceeef1 [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput object (Conor Scott)
736f941424 [Tests] Cleanup extra instances of create_transaction (Conor Scott)
157651855f [Tests] Rename create_tx and move to blocktools.py (Conor Scott)
Pull request description:
There currently exist seven ([1](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_cltv.py#L52-L60), [2](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_csv_activation.py#L88-L95) [3](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_dersig.py#L40-L48), [4](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_nulldummy.py#L100-L108), [5](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/util.py#L529-L535), [6](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/blocktools.py#L120-L129), [7](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_block.py#L1218-L1220)) implementations of a function called something similar to `create_transaction` in the functional tests, some of which are exact copies of each other.
This PR aims to clean this up into [three different cases implemented in blocktools.py](https://github.com/conscott/bitcoin/blob/create_tx_cleanup/test/functional/test_framework/blocktools.py#L121-L149)
1. `create_tx_with_script`: Return transaction object spending generic tx output optionally specifying scriptSig and scriptPubKey
2. `create_transaction`: Return transaction object spending coinbase tx
2. `create_raw_transaction`: Return raw transaction (hex string) spending coinbase tx
I am not committed to any of these function names, so I'll gladly take suggestions on there.
Additionally there are some related cleanups to feature_block.py tests, specifically removing the [PreviousSpendableOutput](https://github.com/conscott/bitcoin/blob/master/test/functional/feature_block.py#L51-L54) object, which seems like an unnecessary layer given that every instance spends the 0 output.
Tree-SHA512: 63c6233b6f0942c81ba1ca67ea6770809b8c9409314c6d4cf8e5a3991cb9ee92b22bebe88c0dde45cd71e754eb351230c4c404b70ff118f5f43c034452ada65c
2018-08-09 18:09:27 +02:00
|
|
|
from test_framework.blocktools import create_coinbase, create_block, create_transaction
|
Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
68400d8b96 tests: Use explicit imports (practicalswift)
Pull request description:
Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools.
An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports.
Before this commit:
```
$ contrib/devtools/lint-python.sh | head -10
./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
$
```
After this commit:
```
$ contrib/devtools/lint-python.sh | head -10
$
```
Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
2018-08-13 14:24:43 +02:00
|
|
|
from test_framework.messages import CTransaction
|
2016-09-22 10:20:44 +02:00
|
|
|
from test_framework.script import CScript
|
Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
68400d8b96 tests: Use explicit imports (practicalswift)
Pull request description:
Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools.
An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports.
Before this commit:
```
$ contrib/devtools/lint-python.sh | head -10
./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
$
```
After this commit:
```
$ contrib/devtools/lint-python.sh | head -10
$
```
Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
2018-08-13 14:24:43 +02:00
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
2021-08-27 21:03:02 +02:00
|
|
|
from test_framework.util import assert_equal, assert_raises_rpc_error
|
Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
68400d8b96 tests: Use explicit imports (practicalswift)
Pull request description:
Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools.
An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports.
Before this commit:
```
$ contrib/devtools/lint-python.sh | head -10
./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
$
```
After this commit:
```
$ contrib/devtools/lint-python.sh | head -10
$
```
Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
2018-08-13 14:24:43 +02:00
|
|
|
|
2016-09-22 10:20:44 +02:00
|
|
|
|
2018-02-15 16:35:12 +01:00
|
|
|
NULLDUMMY_ERROR = "non-mandatory-script-verify-flag (Dummy CHECKMULTISIG argument must be zero) (code 64)"
|
2016-09-22 10:20:44 +02:00
|
|
|
|
|
|
|
def trueDummy(tx):
|
|
|
|
scriptSig = CScript(tx.vin[0].scriptSig)
|
|
|
|
newscript = []
|
|
|
|
for i in scriptSig:
|
|
|
|
if (len(newscript) == 0):
|
2021-08-27 21:03:02 +02:00
|
|
|
assert len(i) == 0
|
2016-09-22 10:20:44 +02:00
|
|
|
newscript.append(b'\x51')
|
|
|
|
else:
|
|
|
|
newscript.append(i)
|
|
|
|
tx.vin[0].scriptSig = CScript(newscript)
|
|
|
|
tx.rehash()
|
|
|
|
|
2016-09-29 16:45:42 +02:00
|
|
|
class NULLDUMMYTest(BitcoinTestFramework):
|
2016-09-22 10:20:44 +02:00
|
|
|
|
2017-09-01 18:47:13 +02:00
|
|
|
def set_test_params(self):
|
2016-09-22 10:20:44 +02:00
|
|
|
self.num_nodes = 1
|
2016-09-29 16:45:42 +02:00
|
|
|
self.setup_clean_chain = True
|
2017-05-02 20:02:55 +02:00
|
|
|
self.extra_args = [['-whitelist=127.0.0.1']]
|
2016-09-22 10:20:44 +02:00
|
|
|
|
2018-09-13 12:33:15 +02:00
|
|
|
def skip_test_if_missing_module(self):
|
|
|
|
self.skip_if_no_wallet()
|
|
|
|
|
2016-09-22 10:20:44 +02:00
|
|
|
def run_test(self):
|
|
|
|
self.address = self.nodes[0].getnewaddress()
|
2018-09-13 12:33:15 +02:00
|
|
|
self.ms_address = self.nodes[0].addmultisigaddress(1, [self.address])['address']
|
2016-09-22 10:20:44 +02:00
|
|
|
|
|
|
|
self.coinbase_blocks = self.nodes[0].generate(2) # Block 2
|
|
|
|
coinbase_txid = []
|
|
|
|
for i in self.coinbase_blocks:
|
|
|
|
coinbase_txid.append(self.nodes[0].getblock(i)['tx'][0])
|
|
|
|
self.nodes[0].generate(427) # Block 429
|
|
|
|
self.lastblockhash = self.nodes[0].getbestblockhash()
|
|
|
|
self.tip = int("0x" + self.lastblockhash, 0)
|
|
|
|
self.lastblockheight = 429
|
2019-08-09 01:14:11 +02:00
|
|
|
self.lastblocktime = self.mocktime + 429
|
2016-09-22 10:20:44 +02:00
|
|
|
|
2017-03-09 21:16:20 +01:00
|
|
|
self.log.info("Test 1: NULLDUMMY compliant base transactions should be accepted to mempool and mined before activation [430]")
|
2018-08-13 13:29:32 +02:00
|
|
|
test1txs = [create_transaction(self.nodes[0], coinbase_txid[0], self.ms_address, amount=49)]
|
2021-12-12 07:27:44 +01:00
|
|
|
txid1 = self.nodes[0].sendrawtransaction(test1txs[0].serialize().hex(), 0)
|
2018-08-13 13:29:32 +02:00
|
|
|
test1txs.append(create_transaction(self.nodes[0], txid1, self.ms_address, amount=48))
|
2021-12-12 07:27:44 +01:00
|
|
|
txid2 = self.nodes[0].sendrawtransaction(test1txs[1].serialize().hex(), 0)
|
2018-01-30 20:18:17 +01:00
|
|
|
self.block_submit(self.nodes[0], test1txs, True)
|
2016-09-22 10:20:44 +02:00
|
|
|
|
2017-03-09 21:16:20 +01:00
|
|
|
self.log.info("Test 2: Non-NULLDUMMY base multisig transaction should not be accepted to mempool before activation")
|
2018-08-13 13:29:32 +02:00
|
|
|
test2tx = create_transaction(self.nodes[0], txid2, self.ms_address, amount=47)
|
2016-09-22 10:20:44 +02:00
|
|
|
trueDummy(test2tx)
|
2021-12-12 07:27:44 +01:00
|
|
|
assert_raises_rpc_error(-26, NULLDUMMY_ERROR, self.nodes[0].sendrawtransaction, test2tx.serialize().hex(), 0)
|
2016-09-22 10:20:44 +02:00
|
|
|
|
2017-03-09 21:16:20 +01:00
|
|
|
self.log.info("Test 3: Non-NULLDUMMY base transactions should be accepted in a block before activation [431]")
|
2018-01-30 20:18:17 +01:00
|
|
|
self.block_submit(self.nodes[0], [test2tx], True)
|
2016-09-22 10:20:44 +02:00
|
|
|
|
2017-03-19 10:13:45 +01:00
|
|
|
self.log.info("Test 4: Non-NULLDUMMY base multisig transaction is invalid after activation")
|
2018-08-13 13:29:32 +02:00
|
|
|
test4tx = create_transaction(self.nodes[0], test2tx.hash, self.address, amount=46)
|
2016-09-22 10:20:44 +02:00
|
|
|
test6txs=[CTransaction(test4tx)]
|
|
|
|
trueDummy(test4tx)
|
2021-12-12 07:27:44 +01:00
|
|
|
assert_raises_rpc_error(-26, NULLDUMMY_ERROR, self.nodes[0].sendrawtransaction, test4tx.serialize().hex(), 0)
|
2016-09-22 10:20:44 +02:00
|
|
|
self.block_submit(self.nodes[0], [test4tx])
|
|
|
|
|
2017-03-09 21:16:20 +01:00
|
|
|
self.log.info("Test 6: NULLDUMMY compliant transactions should be accepted to mempool and in block after activation [432]")
|
2016-09-22 10:20:44 +02:00
|
|
|
for i in test6txs:
|
2021-12-12 07:27:44 +01:00
|
|
|
self.nodes[0].sendrawtransaction(i.serialize().hex(), 0)
|
2018-01-30 20:18:17 +01:00
|
|
|
self.block_submit(self.nodes[0], test6txs, True)
|
2016-09-22 10:20:44 +02:00
|
|
|
|
|
|
|
|
2017-03-17 14:30:48 +01:00
|
|
|
def block_submit(self, node, txs, accept = False):
|
2019-04-03 14:40:18 +02:00
|
|
|
dip4_activated = self.lastblockheight + 1 >= 432
|
2018-05-29 14:13:50 +02:00
|
|
|
block = create_block(self.tip, create_coinbase(self.lastblockheight + 1, dip4_activated=dip4_activated), self.lastblocktime + 1)
|
2016-09-22 10:20:44 +02:00
|
|
|
block.nVersion = 4
|
|
|
|
for tx in txs:
|
|
|
|
tx.rehash()
|
|
|
|
block.vtx.append(tx)
|
|
|
|
block.hashMerkleRoot = block.calc_merkle_root()
|
|
|
|
block.rehash()
|
|
|
|
block.solve()
|
2020-04-24 22:34:38 +02:00
|
|
|
assert_equal(None if accept else 'block-validation-failed', node.submitblock(block.serialize().hex()))
|
2016-09-22 10:20:44 +02:00
|
|
|
if (accept):
|
|
|
|
assert_equal(node.getbestblockhash(), block.hash)
|
|
|
|
self.tip = block.sha256
|
|
|
|
self.lastblockhash = block.hash
|
|
|
|
self.lastblocktime += 1
|
|
|
|
self.lastblockheight += 1
|
|
|
|
else:
|
|
|
|
assert_equal(node.getbestblockhash(), self.lastblockhash)
|
|
|
|
|
|
|
|
if __name__ == '__main__':
|
2016-09-29 16:45:42 +02:00
|
|
|
NULLDUMMYTest().main()
|