2016-05-06 11:23:48 +02:00
|
|
|
#!/usr/bin/env python3
|
|
|
|
# Copyright (c) 2014-2016 The Bitcoin Core developers
|
2014-12-06 23:14:25 +01:00
|
|
|
# Distributed under the MIT software license, see the accompanying
|
|
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
2019-01-07 10:55:35 +01:00
|
|
|
"""Test the RPC HTTP basics."""
|
2014-12-06 23:14:25 +01:00
|
|
|
|
2015-05-02 12:53:35 +02:00
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
68400d8b96 tests: Use explicit imports (practicalswift)
Pull request description:
Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools.
An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports.
Before this commit:
```
$ contrib/devtools/lint-python.sh | head -10
./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
$
```
After this commit:
```
$ contrib/devtools/lint-python.sh | head -10
$
```
Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
2018-08-13 14:24:43 +02:00
|
|
|
from test_framework.util import assert_equal, str_to_b64str
|
2014-12-06 23:14:25 +01:00
|
|
|
|
2016-05-06 11:23:48 +02:00
|
|
|
import http.client
|
|
|
|
import urllib.parse
|
2014-12-06 23:14:25 +01:00
|
|
|
|
2015-05-19 10:20:31 +02:00
|
|
|
class HTTPBasicsTest (BitcoinTestFramework):
|
2017-09-01 18:47:13 +02:00
|
|
|
def set_test_params(self):
|
2016-05-20 15:16:51 +02:00
|
|
|
self.num_nodes = 3
|
2019-12-09 19:52:38 +01:00
|
|
|
self.supports_cli = False
|
2016-05-20 15:16:51 +02:00
|
|
|
|
|
|
|
def setup_network(self):
|
2017-05-02 20:02:55 +02:00
|
|
|
self.setup_nodes()
|
2015-01-14 12:45:11 +01:00
|
|
|
|
2015-05-19 10:20:31 +02:00
|
|
|
def run_test(self):
|
|
|
|
|
2014-12-06 23:14:25 +01:00
|
|
|
#################################################
|
|
|
|
# lowlevel check for http persistent connection #
|
|
|
|
#################################################
|
2016-05-06 11:23:48 +02:00
|
|
|
url = urllib.parse.urlparse(self.nodes[0].url)
|
2021-08-18 21:11:23 +02:00
|
|
|
authpair = f'{url.username}:{url.password}'
|
|
|
|
headers = {"Authorization": f"Basic {str_to_b64str(authpair)}"}
|
2015-05-19 10:20:31 +02:00
|
|
|
|
2016-05-06 11:23:48 +02:00
|
|
|
conn = http.client.HTTPConnection(url.hostname, url.port)
|
2014-12-06 23:14:25 +01:00
|
|
|
conn.connect()
|
2015-01-17 16:34:27 +01:00
|
|
|
conn.request('POST', '/', '{"method": "getbestblockhash"}', headers)
|
2015-12-02 18:12:23 +01:00
|
|
|
out1 = conn.getresponse().read()
|
2021-08-27 21:03:02 +02:00
|
|
|
assert b'"error":null' in out1
|
2018-12-13 12:57:41 +01:00
|
|
|
assert conn.sock is not None #according to http/1.1 connection must still be open!
|
2015-05-19 10:20:31 +02:00
|
|
|
|
2014-12-06 23:14:25 +01:00
|
|
|
#send 2nd request without closing connection
|
2015-01-17 16:34:27 +01:00
|
|
|
conn.request('POST', '/', '{"method": "getchaintips"}', headers)
|
2016-04-03 20:35:57 +02:00
|
|
|
out1 = conn.getresponse().read()
|
2021-08-27 21:03:02 +02:00
|
|
|
assert b'"error":null' in out1 #must also response with a correct json-rpc message
|
2018-12-13 12:57:41 +01:00
|
|
|
assert conn.sock is not None #according to http/1.1 connection must still be open!
|
2014-12-06 23:14:25 +01:00
|
|
|
conn.close()
|
2015-05-19 10:20:31 +02:00
|
|
|
|
2014-12-06 23:14:25 +01:00
|
|
|
#same should be if we add keep-alive because this should be the std. behaviour
|
2021-08-18 21:11:23 +02:00
|
|
|
headers = {"Authorization": f"Basic {str_to_b64str(authpair)}", "Connection": "keep-alive"}
|
2015-05-19 10:20:31 +02:00
|
|
|
|
2016-05-06 11:23:48 +02:00
|
|
|
conn = http.client.HTTPConnection(url.hostname, url.port)
|
2014-12-06 23:14:25 +01:00
|
|
|
conn.connect()
|
2015-01-17 16:34:27 +01:00
|
|
|
conn.request('POST', '/', '{"method": "getbestblockhash"}', headers)
|
2015-12-02 18:12:23 +01:00
|
|
|
out1 = conn.getresponse().read()
|
2021-08-27 21:03:02 +02:00
|
|
|
assert b'"error":null' in out1
|
2018-12-13 12:57:41 +01:00
|
|
|
assert conn.sock is not None #according to http/1.1 connection must still be open!
|
2015-05-19 10:20:31 +02:00
|
|
|
|
2014-12-06 23:14:25 +01:00
|
|
|
#send 2nd request without closing connection
|
2015-01-17 16:34:27 +01:00
|
|
|
conn.request('POST', '/', '{"method": "getchaintips"}', headers)
|
2016-04-03 20:35:57 +02:00
|
|
|
out1 = conn.getresponse().read()
|
2021-08-27 21:03:02 +02:00
|
|
|
assert b'"error":null' in out1 #must also response with a correct json-rpc message
|
2018-12-13 12:57:41 +01:00
|
|
|
assert conn.sock is not None #according to http/1.1 connection must still be open!
|
2014-12-06 23:14:25 +01:00
|
|
|
conn.close()
|
2015-05-19 10:20:31 +02:00
|
|
|
|
2014-12-06 23:14:25 +01:00
|
|
|
#now do the same with "Connection: close"
|
2021-08-18 21:11:23 +02:00
|
|
|
headers = {"Authorization": f"Basic {str_to_b64str(authpair)}", "Connection":"close"}
|
2015-05-19 10:20:31 +02:00
|
|
|
|
2016-05-06 11:23:48 +02:00
|
|
|
conn = http.client.HTTPConnection(url.hostname, url.port)
|
2014-12-06 23:14:25 +01:00
|
|
|
conn.connect()
|
2015-01-17 16:34:27 +01:00
|
|
|
conn.request('POST', '/', '{"method": "getbestblockhash"}', headers)
|
2015-12-02 18:12:23 +01:00
|
|
|
out1 = conn.getresponse().read()
|
2021-08-27 21:03:02 +02:00
|
|
|
assert b'"error":null' in out1
|
2018-12-13 12:57:41 +01:00
|
|
|
assert conn.sock is None #now the connection must be closed after the response
|
2015-05-19 10:20:31 +02:00
|
|
|
|
2015-01-14 16:36:48 +01:00
|
|
|
#node1 (2nd node) is running with disabled keep-alive option
|
2016-05-06 11:23:48 +02:00
|
|
|
urlNode1 = urllib.parse.urlparse(self.nodes[1].url)
|
2021-08-18 21:11:23 +02:00
|
|
|
authpair = f'{urlNode1.username}:{urlNode1.password}'
|
|
|
|
headers = {"Authorization": f"Basic {str_to_b64str(authpair)}"}
|
2015-05-19 10:20:31 +02:00
|
|
|
|
2016-05-06 11:23:48 +02:00
|
|
|
conn = http.client.HTTPConnection(urlNode1.hostname, urlNode1.port)
|
2015-01-14 16:36:48 +01:00
|
|
|
conn.connect()
|
2015-01-17 16:34:27 +01:00
|
|
|
conn.request('POST', '/', '{"method": "getbestblockhash"}', headers)
|
2015-12-02 18:12:23 +01:00
|
|
|
out1 = conn.getresponse().read()
|
2021-08-27 21:03:02 +02:00
|
|
|
assert b'"error":null' in out1
|
2015-05-19 10:20:31 +02:00
|
|
|
|
2015-01-23 07:54:27 +01:00
|
|
|
#node2 (third node) is running with standard keep-alive parameters which means keep-alive is on
|
2016-05-06 11:23:48 +02:00
|
|
|
urlNode2 = urllib.parse.urlparse(self.nodes[2].url)
|
2021-08-18 21:11:23 +02:00
|
|
|
authpair = f'{urlNode2.username}:{urlNode2.password}'
|
|
|
|
headers = {"Authorization": f"Basic {str_to_b64str(authpair)}"}
|
2015-05-19 10:20:31 +02:00
|
|
|
|
2016-05-06 11:23:48 +02:00
|
|
|
conn = http.client.HTTPConnection(urlNode2.hostname, urlNode2.port)
|
2015-01-14 16:36:48 +01:00
|
|
|
conn.connect()
|
2015-01-17 16:34:27 +01:00
|
|
|
conn.request('POST', '/', '{"method": "getbestblockhash"}', headers)
|
2015-12-02 18:12:23 +01:00
|
|
|
out1 = conn.getresponse().read()
|
2021-08-27 21:03:02 +02:00
|
|
|
assert b'"error":null' in out1
|
2018-12-13 12:57:41 +01:00
|
|
|
assert conn.sock is not None #connection must be closed because dashd should use keep-alive by default
|
2015-05-19 10:20:31 +02:00
|
|
|
|
2015-10-20 11:35:10 +02:00
|
|
|
# Check excessive request size
|
2016-05-06 11:23:48 +02:00
|
|
|
conn = http.client.HTTPConnection(urlNode2.hostname, urlNode2.port)
|
2015-10-20 11:35:10 +02:00
|
|
|
conn.connect()
|
2021-08-18 21:11:23 +02:00
|
|
|
conn.request('GET', f'/{"x"*1000}', '', headers)
|
2015-10-20 11:35:10 +02:00
|
|
|
out1 = conn.getresponse()
|
2016-05-06 11:23:48 +02:00
|
|
|
assert_equal(out1.status, http.client.NOT_FOUND)
|
2015-10-20 11:35:10 +02:00
|
|
|
|
2016-05-06 11:23:48 +02:00
|
|
|
conn = http.client.HTTPConnection(urlNode2.hostname, urlNode2.port)
|
2015-10-20 11:35:10 +02:00
|
|
|
conn.connect()
|
2021-08-18 21:11:23 +02:00
|
|
|
conn.request('GET', f'/{"x"*10000}', '', headers)
|
2015-10-20 11:35:10 +02:00
|
|
|
out1 = conn.getresponse()
|
2016-05-06 11:23:48 +02:00
|
|
|
assert_equal(out1.status, http.client.BAD_REQUEST)
|
2015-10-20 11:35:10 +02:00
|
|
|
|
|
|
|
|
2014-12-06 23:14:25 +01:00
|
|
|
if __name__ == '__main__':
|
2014-12-17 22:37:54 +01:00
|
|
|
HTTPBasicsTest ().main ()
|