2016-05-06 11:23:48 +02:00
|
|
|
#!/usr/bin/env python3
|
2019-02-01 15:35:08 +01:00
|
|
|
# Copyright (c) 2014-2019 The Bitcoin Core developers
|
2016-01-07 22:31:12 +01:00
|
|
|
# Distributed under the MIT software license, see the accompanying
|
|
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
2019-01-07 10:55:35 +01:00
|
|
|
"""Test the abandontransaction RPC.
|
2016-01-07 22:31:12 +01:00
|
|
|
|
2019-01-07 10:55:35 +01:00
|
|
|
The abandontransaction RPC marks a transaction and all its in-wallet
|
|
|
|
descendants as abandoned which allows their inputs to be respent. It can be
|
|
|
|
used to replace "stuck" or evicted transactions. It only works on transactions
|
|
|
|
which are not included in a block and are not currently in the mempool. It has
|
2018-02-08 15:57:08 +01:00
|
|
|
no effect on transactions which are already abandoned.
|
2019-01-07 10:55:35 +01:00
|
|
|
"""
|
Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
68400d8b96 tests: Use explicit imports (practicalswift)
Pull request description:
Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools.
An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports.
Before this commit:
```
$ contrib/devtools/lint-python.sh | head -10
./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
$
```
After this commit:
```
$ contrib/devtools/lint-python.sh | head -10
$
```
Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
2018-08-13 14:24:43 +02:00
|
|
|
from decimal import Decimal
|
2016-01-07 22:31:12 +01:00
|
|
|
|
Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
68400d8b96 tests: Use explicit imports (practicalswift)
Pull request description:
Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools.
An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports.
Before this commit:
```
$ contrib/devtools/lint-python.sh | head -10
./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
$
```
After this commit:
```
$ contrib/devtools/lint-python.sh | head -10
$
```
Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
2018-08-13 14:24:43 +02:00
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
2019-02-01 15:35:08 +01:00
|
|
|
from test_framework.util import (
|
|
|
|
assert_equal,
|
|
|
|
assert_raises_rpc_error,
|
|
|
|
connect_nodes,
|
|
|
|
disconnect_nodes,
|
2019-12-05 21:52:12 +01:00
|
|
|
wait_until,
|
2019-02-01 15:35:08 +01:00
|
|
|
)
|
|
|
|
|
2018-02-08 15:57:08 +01:00
|
|
|
|
2016-01-07 22:31:12 +01:00
|
|
|
class AbandonConflictTest(BitcoinTestFramework):
|
2017-09-01 18:47:13 +02:00
|
|
|
def set_test_params(self):
|
2016-05-20 15:16:51 +02:00
|
|
|
self.num_nodes = 2
|
2019-02-19 16:30:36 +01:00
|
|
|
self.extra_args = [["-minrelaytxfee=0.00001"], []]
|
2016-01-07 22:31:12 +01:00
|
|
|
|
2018-09-13 12:33:15 +02:00
|
|
|
def skip_test_if_missing_module(self):
|
|
|
|
self.skip_if_no_wallet()
|
|
|
|
|
2016-01-07 22:31:12 +01:00
|
|
|
def run_test(self):
|
|
|
|
self.nodes[1].generate(100)
|
2020-04-14 12:00:16 +02:00
|
|
|
self.sync_blocks()
|
2016-01-07 22:31:12 +01:00
|
|
|
balance = self.nodes[0].getbalance()
|
|
|
|
txA = self.nodes[0].sendtoaddress(self.nodes[0].getnewaddress(), Decimal("10"))
|
|
|
|
txB = self.nodes[0].sendtoaddress(self.nodes[0].getnewaddress(), Decimal("10"))
|
|
|
|
txC = self.nodes[0].sendtoaddress(self.nodes[0].getnewaddress(), Decimal("10"))
|
2020-04-14 12:00:16 +02:00
|
|
|
self.sync_mempools()
|
2016-01-07 22:31:12 +01:00
|
|
|
self.nodes[1].generate(1)
|
|
|
|
|
2018-02-08 15:57:08 +01:00
|
|
|
# Can not abandon non-wallet transaction
|
|
|
|
assert_raises_rpc_error(-5, 'Invalid or non-wallet transaction id', lambda: self.nodes[0].abandontransaction(txid='ff' * 32))
|
|
|
|
# Can not abandon confirmed transaction
|
|
|
|
assert_raises_rpc_error(-5, 'Transaction not eligible for abandonment', lambda: self.nodes[0].abandontransaction(txid=txA))
|
|
|
|
|
2020-04-14 12:00:16 +02:00
|
|
|
self.sync_blocks()
|
2016-01-07 22:31:12 +01:00
|
|
|
newbalance = self.nodes[0].getbalance()
|
2019-02-01 15:35:08 +01:00
|
|
|
assert balance - newbalance < Decimal("0.001") #no more than fees lost
|
2016-01-07 22:31:12 +01:00
|
|
|
balance = newbalance
|
|
|
|
|
2017-05-06 12:00:01 +02:00
|
|
|
# Disconnect nodes so node0's transactions don't get into node1's mempool
|
|
|
|
disconnect_nodes(self.nodes[0], 1)
|
2016-01-07 22:31:12 +01:00
|
|
|
|
|
|
|
# Identify the 10btc outputs
|
2019-02-01 15:35:08 +01:00
|
|
|
nA = next(tx_out["vout"] for tx_out in self.nodes[0].gettransaction(txA)["details"] if tx_out["amount"] == Decimal("10"))
|
|
|
|
nB = next(tx_out["vout"] for tx_out in self.nodes[0].gettransaction(txB)["details"] if tx_out["amount"] == Decimal("10"))
|
|
|
|
nC = next(tx_out["vout"] for tx_out in self.nodes[0].gettransaction(txC)["details"] if tx_out["amount"] == Decimal("10"))
|
2016-01-07 22:31:12 +01:00
|
|
|
|
2019-02-01 15:35:08 +01:00
|
|
|
inputs = []
|
2016-01-07 22:31:12 +01:00
|
|
|
# spend 10btc outputs from txA and txB
|
2019-02-01 15:35:08 +01:00
|
|
|
inputs.append({"txid": txA, "vout": nA})
|
|
|
|
inputs.append({"txid": txB, "vout": nB})
|
2016-01-07 22:31:12 +01:00
|
|
|
outputs = {}
|
|
|
|
|
|
|
|
outputs[self.nodes[0].getnewaddress()] = Decimal("14.99998")
|
|
|
|
outputs[self.nodes[1].getnewaddress()] = Decimal("5")
|
2018-02-20 03:29:22 +01:00
|
|
|
signed = self.nodes[0].signrawtransactionwithwallet(self.nodes[0].createrawtransaction(inputs, outputs))
|
2016-01-07 22:31:12 +01:00
|
|
|
txAB1 = self.nodes[0].sendrawtransaction(signed["hex"])
|
|
|
|
|
|
|
|
# Identify the 14.99998btc output
|
2019-02-01 15:35:08 +01:00
|
|
|
nAB = next(tx_out["vout"] for tx_out in self.nodes[0].gettransaction(txAB1)["details"] if tx_out["amount"] == Decimal("14.99998"))
|
2016-01-07 22:31:12 +01:00
|
|
|
|
|
|
|
#Create a child tx spending AB1 and C
|
|
|
|
inputs = []
|
2019-02-01 15:35:08 +01:00
|
|
|
inputs.append({"txid": txAB1, "vout": nAB})
|
|
|
|
inputs.append({"txid": txC, "vout": nC})
|
2016-01-07 22:31:12 +01:00
|
|
|
outputs = {}
|
|
|
|
outputs[self.nodes[0].getnewaddress()] = Decimal("24.9996")
|
2018-02-20 03:29:22 +01:00
|
|
|
signed2 = self.nodes[0].signrawtransactionwithwallet(self.nodes[0].createrawtransaction(inputs, outputs))
|
2016-01-07 22:31:12 +01:00
|
|
|
txABC2 = self.nodes[0].sendrawtransaction(signed2["hex"])
|
|
|
|
|
2018-07-16 14:52:16 +02:00
|
|
|
# Create a child tx spending ABC2
|
|
|
|
signed3_change = Decimal("24.999")
|
2019-02-01 15:35:08 +01:00
|
|
|
inputs = [{"txid": txABC2, "vout": 0}]
|
|
|
|
outputs = {self.nodes[0].getnewaddress(): signed3_change}
|
2020-12-11 03:25:55 +01:00
|
|
|
signed3 = self.nodes[0].signrawtransactionwithwallet(self.nodes[0].createrawtransaction(inputs, outputs))
|
2018-07-16 14:52:16 +02:00
|
|
|
# note tx is never directly referenced, only abandoned as a child of the above
|
|
|
|
self.nodes[0].sendrawtransaction(signed3["hex"])
|
|
|
|
|
2016-01-07 22:31:12 +01:00
|
|
|
# In mempool txs from self should increase balance from change
|
|
|
|
newbalance = self.nodes[0].getbalance()
|
2018-07-16 14:52:16 +02:00
|
|
|
assert_equal(newbalance, balance - Decimal("30") + signed3_change)
|
2016-01-07 22:31:12 +01:00
|
|
|
balance = newbalance
|
|
|
|
|
|
|
|
# Restart the node with a higher min relay fee so the parent tx is no longer in mempool
|
|
|
|
# TODO: redo with eviction
|
2017-06-02 12:08:48 +02:00
|
|
|
self.stop_node(0)
|
2017-09-01 18:47:13 +02:00
|
|
|
self.start_node(0, extra_args=["-minrelaytxfee=0.0001"])
|
2019-12-05 21:52:12 +01:00
|
|
|
wait_until(lambda: self.nodes[0].getmempoolinfo()['loaded'])
|
2016-01-07 22:31:12 +01:00
|
|
|
|
2017-05-06 12:00:01 +02:00
|
|
|
# Verify txs no longer in either node's mempool
|
2016-08-18 08:41:50 +02:00
|
|
|
assert_equal(len(self.nodes[0].getrawmempool()), 0)
|
2017-05-06 12:00:01 +02:00
|
|
|
assert_equal(len(self.nodes[1].getrawmempool()), 0)
|
2016-01-07 22:31:12 +01:00
|
|
|
|
|
|
|
# Not in mempool txs from self should only reduce balance
|
|
|
|
# inputs are still spent, but change not received
|
|
|
|
newbalance = self.nodes[0].getbalance()
|
2018-07-16 14:52:16 +02:00
|
|
|
assert_equal(newbalance, balance - signed3_change)
|
2016-03-17 17:48:05 +01:00
|
|
|
# Unconfirmed received funds that are not in mempool, also shouldn't show
|
|
|
|
# up in unconfirmed balance
|
|
|
|
unconfbalance = self.nodes[0].getunconfirmedbalance() + self.nodes[0].getbalance()
|
2016-08-18 08:41:50 +02:00
|
|
|
assert_equal(unconfbalance, newbalance)
|
2016-03-17 17:48:05 +01:00
|
|
|
# Also shouldn't show up in listunspent
|
2019-02-01 15:35:08 +01:00
|
|
|
assert not txABC2 in [utxo["txid"] for utxo in self.nodes[0].listunspent(0)]
|
2016-01-07 22:31:12 +01:00
|
|
|
balance = newbalance
|
|
|
|
|
|
|
|
# Abandon original transaction and verify inputs are available again
|
|
|
|
# including that the child tx was also abandoned
|
|
|
|
self.nodes[0].abandontransaction(txAB1)
|
|
|
|
newbalance = self.nodes[0].getbalance()
|
2016-08-18 08:41:50 +02:00
|
|
|
assert_equal(newbalance, balance + Decimal("30"))
|
2016-01-07 22:31:12 +01:00
|
|
|
balance = newbalance
|
|
|
|
|
|
|
|
# Verify that even with a low min relay fee, the tx is not reaccepted from wallet on startup once abandoned
|
2017-06-02 12:08:48 +02:00
|
|
|
self.stop_node(0)
|
2017-09-01 18:47:13 +02:00
|
|
|
self.start_node(0, extra_args=["-minrelaytxfee=0.00001"])
|
2019-12-05 21:52:12 +01:00
|
|
|
wait_until(lambda: self.nodes[0].getmempoolinfo()['loaded'])
|
|
|
|
|
2016-08-18 08:41:50 +02:00
|
|
|
assert_equal(len(self.nodes[0].getrawmempool()), 0)
|
|
|
|
assert_equal(self.nodes[0].getbalance(), balance)
|
2016-01-07 22:31:12 +01:00
|
|
|
|
2018-03-21 16:16:28 +01:00
|
|
|
# But if it is received again then it is unabandoned
|
2016-01-07 22:31:12 +01:00
|
|
|
# And since now in mempool, the change is available
|
|
|
|
# But its child tx remains abandoned
|
|
|
|
self.nodes[0].sendrawtransaction(signed["hex"])
|
|
|
|
newbalance = self.nodes[0].getbalance()
|
2016-08-18 08:41:50 +02:00
|
|
|
assert_equal(newbalance, balance - Decimal("20") + Decimal("14.99998"))
|
2016-01-07 22:31:12 +01:00
|
|
|
balance = newbalance
|
|
|
|
|
2018-03-21 16:16:28 +01:00
|
|
|
# Send child tx again so it is unabandoned
|
2016-01-07 22:31:12 +01:00
|
|
|
self.nodes[0].sendrawtransaction(signed2["hex"])
|
|
|
|
newbalance = self.nodes[0].getbalance()
|
2016-08-18 08:41:50 +02:00
|
|
|
assert_equal(newbalance, balance - Decimal("10") - Decimal("14.99998") + Decimal("24.9996"))
|
2016-01-07 22:31:12 +01:00
|
|
|
balance = newbalance
|
|
|
|
|
|
|
|
# Remove using high relay fee again
|
2017-06-02 12:08:48 +02:00
|
|
|
self.stop_node(0)
|
2017-09-01 18:47:13 +02:00
|
|
|
self.start_node(0, extra_args=["-minrelaytxfee=0.0001"])
|
2019-12-05 21:52:12 +01:00
|
|
|
wait_until(lambda: self.nodes[0].getmempoolinfo()['loaded'])
|
2016-08-18 08:41:50 +02:00
|
|
|
assert_equal(len(self.nodes[0].getrawmempool()), 0)
|
2016-01-07 22:31:12 +01:00
|
|
|
newbalance = self.nodes[0].getbalance()
|
2016-08-18 08:41:50 +02:00
|
|
|
assert_equal(newbalance, balance - Decimal("24.9996"))
|
2016-01-07 22:31:12 +01:00
|
|
|
balance = newbalance
|
|
|
|
|
2021-10-07 09:58:58 +02:00
|
|
|
self.log.info("Test transactions conflicted by a double spend")
|
2016-01-07 22:31:12 +01:00
|
|
|
# Create a double spend of AB1 by spending again from only A's 10 output
|
|
|
|
# Mine double spend from node 1
|
2019-02-01 15:35:08 +01:00
|
|
|
inputs = []
|
|
|
|
inputs.append({"txid": txA, "vout": nA})
|
2016-01-07 22:31:12 +01:00
|
|
|
outputs = {}
|
|
|
|
outputs[self.nodes[1].getnewaddress()] = Decimal("9.9999")
|
|
|
|
tx = self.nodes[0].createrawtransaction(inputs, outputs)
|
2018-02-20 03:29:22 +01:00
|
|
|
signed = self.nodes[0].signrawtransactionwithwallet(tx)
|
2016-01-07 22:31:12 +01:00
|
|
|
self.nodes[1].sendrawtransaction(signed["hex"])
|
|
|
|
self.nodes[1].generate(1)
|
|
|
|
|
|
|
|
connect_nodes(self.nodes[0], 1)
|
2020-04-14 12:00:16 +02:00
|
|
|
self.sync_blocks()
|
2016-01-07 22:31:12 +01:00
|
|
|
|
2021-10-07 09:58:58 +02:00
|
|
|
tx_list = self.nodes[0].listtransactions()
|
|
|
|
|
|
|
|
conflicted = [tx for tx in tx_list if tx["confirmations"] < 0]
|
|
|
|
assert_equal(4, len(conflicted))
|
|
|
|
|
|
|
|
wallet_conflicts = [tx for tx in conflicted if tx["walletconflicts"]]
|
|
|
|
assert_equal(2, len(wallet_conflicts))
|
|
|
|
|
|
|
|
double_spends = [tx for tx in tx_list if tx["walletconflicts"] and tx["confirmations"] > 0]
|
|
|
|
assert_equal(1, len(double_spends))
|
|
|
|
double_spend = double_spends[0]
|
|
|
|
|
|
|
|
# Test the properties of the conflicted transactions, i.e. with confirmations < 0.
|
|
|
|
for tx in conflicted:
|
|
|
|
assert_equal(tx["abandoned"], False)
|
|
|
|
assert_equal(tx["confirmations"], -1)
|
|
|
|
assert_equal(tx["trusted"], False)
|
|
|
|
|
|
|
|
# Test the properties of the double-spend transaction, i.e. having wallet conflicts and confirmations > 0.
|
|
|
|
assert_equal(double_spend["abandoned"], False)
|
|
|
|
assert_equal(double_spend["confirmations"], 1)
|
|
|
|
assert "trusted" not in double_spend.keys() # "trusted" only returned if tx has 0 or negative confirmations.
|
|
|
|
|
|
|
|
# Test the walletconflicts field of each.
|
|
|
|
for tx in wallet_conflicts:
|
|
|
|
assert_equal(double_spend["walletconflicts"], [tx["txid"]])
|
|
|
|
assert_equal(tx["walletconflicts"], [double_spend["txid"]])
|
|
|
|
|
2016-01-07 22:31:12 +01:00
|
|
|
# Verify that B and C's 10 BTC outputs are available for spending again because AB1 is now conflicted
|
|
|
|
newbalance = self.nodes[0].getbalance()
|
2016-08-18 08:41:50 +02:00
|
|
|
assert_equal(newbalance, balance + Decimal("20"))
|
2016-01-07 22:31:12 +01:00
|
|
|
balance = newbalance
|
|
|
|
|
|
|
|
# There is currently a minor bug around this and so this test doesn't work. See Issue #7315
|
|
|
|
# Invalidate the block with the double spend and B's 10 BTC output should no longer be available
|
|
|
|
# Don't think C's should either
|
|
|
|
self.nodes[0].invalidateblock(self.nodes[0].getbestblockhash())
|
|
|
|
newbalance = self.nodes[0].getbalance()
|
2016-08-18 08:41:50 +02:00
|
|
|
#assert_equal(newbalance, balance - Decimal("10"))
|
2017-03-09 21:16:20 +01:00
|
|
|
self.log.info("If balance has not declined after invalidateblock then out of mempool wallet tx which is no longer")
|
|
|
|
self.log.info("conflicted has not resumed causing its inputs to be seen as spent. See Issue #7315")
|
|
|
|
self.log.info(str(balance) + " -> " + str(newbalance) + " ?")
|
2016-01-07 22:31:12 +01:00
|
|
|
|
2019-02-01 15:35:08 +01:00
|
|
|
|
2016-01-07 22:31:12 +01:00
|
|
|
if __name__ == '__main__':
|
|
|
|
AbandonConflictTest().main()
|