2022-06-08 01:36:46 +02:00
|
|
|
// Copyright (c) 2014-2022 The Dash Core developers
|
2016-02-02 16:28:56 +01:00
|
|
|
// Distributed under the MIT software license, see the accompanying
|
|
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
2015-02-09 21:54:51 +01:00
|
|
|
|
2020-03-19 23:46:56 +01:00
|
|
|
#include <spork.h>
|
2018-03-02 14:15:04 +01:00
|
|
|
|
2020-03-19 23:46:56 +01:00
|
|
|
#include <chainparams.h>
|
2021-10-25 15:55:34 +02:00
|
|
|
#include <consensus/params.h>
|
Merge #11372: Address encoding cleanup
92f1f8b31 Split off key_io_tests from base58_tests (Pieter Wuille)
119b0f85e Split key_io (address/key encodings) off from base58 (Pieter Wuille)
ebfe217b1 Stop using CBase58Data for ext keys (Pieter Wuille)
32e69fa0d Replace CBitcoinSecret with {Encode,Decode}Secret (Pieter Wuille)
Pull request description:
This PR contains some of the changes left as TODO in #11167 (and built on top of that PR). They are not intended for backporting.
This removes the `CBase58`, `CBitcoinSecret`, `CBitcoinExtKey`, and `CBitcoinExtPubKey` classes, in favor of simple `Encode`/`Decode` functions. Furthermore, all Bitcoin-specific logic (addresses, WIF, BIP32) is moved to `key_io.{h,cpp}`, leaving `base58.{h,cpp}` as a pure utility that implements the base58 encoding/decoding logic.
Tree-SHA512: a5962c0ed27ad53cbe00f22af432cf11aa530e3efc9798e25c004bc9ed1b5673db5df3956e398ee2c085e3a136ac8da69fe7a7d97a05fb2eb3be0b60d0479655
Make linter happy
Dashify
2018-03-07 00:04:56 +01:00
|
|
|
#include <key_io.h>
|
2021-10-25 15:55:34 +02:00
|
|
|
#include <logging.h>
|
2020-03-19 23:46:56 +01:00
|
|
|
#include <messagesigner.h>
|
2021-10-25 15:55:34 +02:00
|
|
|
#include <net.h>
|
2020-03-19 23:46:56 +01:00
|
|
|
#include <net_processing.h>
|
|
|
|
#include <netmessagemaker.h>
|
2021-10-25 15:55:34 +02:00
|
|
|
#include <primitives/block.h>
|
|
|
|
#include <protocol.h>
|
|
|
|
#include <script/standard.h>
|
|
|
|
#include <timedata.h>
|
2022-09-18 22:49:22 +02:00
|
|
|
#include <util/message.h> // for MESSAGE_MAGIC
|
2021-12-21 13:05:29 +01:00
|
|
|
#include <util/ranges.h>
|
2022-12-15 20:17:05 +01:00
|
|
|
#include <util/string.h>
|
2022-04-17 12:52:51 +02:00
|
|
|
#include <validation.h>
|
2015-02-09 21:54:51 +01:00
|
|
|
|
2018-07-12 11:02:20 +02:00
|
|
|
#include <string>
|
2015-02-09 21:54:51 +01:00
|
|
|
|
2022-08-26 23:52:53 +02:00
|
|
|
std::unique_ptr<CSporkManager> sporkManager;
|
2019-05-29 20:18:31 +02:00
|
|
|
|
2023-02-20 00:04:57 +01:00
|
|
|
std::optional<SporkValue> CSporkManager::SporkValueIfActive(SporkId nSporkID) const
|
2018-09-30 19:01:33 +02:00
|
|
|
{
|
2021-09-28 23:23:34 +02:00
|
|
|
AssertLockHeld(cs);
|
2018-09-30 19:01:33 +02:00
|
|
|
|
2022-10-19 20:37:28 +02:00
|
|
|
if (!mapSporksActive.count(nSporkID)) return std::nullopt;
|
2018-09-30 19:01:33 +02:00
|
|
|
|
2022-04-11 17:22:05 +02:00
|
|
|
{
|
|
|
|
LOCK(cs_mapSporksCachedValues);
|
|
|
|
if (auto it = mapSporksCachedValues.find(nSporkID); it != mapSporksCachedValues.end()) {
|
2022-10-19 20:37:28 +02:00
|
|
|
return {it->second};
|
2022-04-11 17:22:05 +02:00
|
|
|
}
|
2021-01-21 03:04:14 +01:00
|
|
|
}
|
|
|
|
|
2018-09-30 19:01:33 +02:00
|
|
|
// calc how many values we have and how many signers vote for every value
|
2023-02-20 00:04:57 +01:00
|
|
|
std::unordered_map<SporkValue, int> mapValueCounts;
|
2021-12-17 18:22:11 +01:00
|
|
|
for (const auto& [_, spork] : mapSporksActive.at(nSporkID)) {
|
|
|
|
mapValueCounts[spork.nValue]++;
|
|
|
|
if (mapValueCounts.at(spork.nValue) >= nMinSporkKeys) {
|
2018-09-30 19:01:33 +02:00
|
|
|
// nMinSporkKeys is always more than the half of the max spork keys number,
|
|
|
|
// so there is only one such value and we can stop here
|
2022-10-19 20:37:28 +02:00
|
|
|
{
|
|
|
|
LOCK(cs_mapSporksCachedValues);
|
|
|
|
mapSporksCachedValues[nSporkID] = spork.nValue;
|
|
|
|
}
|
|
|
|
return {spork.nValue};
|
2018-09-30 19:01:33 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-10-19 20:37:28 +02:00
|
|
|
return std::nullopt;
|
2018-09-30 19:01:33 +02:00
|
|
|
}
|
|
|
|
|
2018-08-13 22:21:21 +02:00
|
|
|
void CSporkManager::Clear()
|
|
|
|
{
|
|
|
|
LOCK(cs);
|
|
|
|
mapSporksActive.clear();
|
|
|
|
mapSporksByHash.clear();
|
2018-09-26 16:15:58 +02:00
|
|
|
// sporkPubKeyID and sporkPrivKey should be set in init.cpp,
|
|
|
|
// we should not alter them here.
|
2018-08-13 22:21:21 +02:00
|
|
|
}
|
|
|
|
|
2018-09-26 16:15:02 +02:00
|
|
|
void CSporkManager::CheckAndRemove()
|
|
|
|
{
|
|
|
|
LOCK(cs);
|
2021-12-17 18:22:11 +01:00
|
|
|
assert(!setSporkPubKeyIDs.empty());
|
2018-09-26 16:15:02 +02:00
|
|
|
|
2021-12-17 18:22:11 +01:00
|
|
|
for (auto itActive = mapSporksActive.begin(); itActive != mapSporksActive.end();) {
|
2018-09-30 19:01:33 +02:00
|
|
|
auto itSignerPair = itActive->second.begin();
|
|
|
|
while (itSignerPair != itActive->second.end()) {
|
2021-01-20 23:27:41 +01:00
|
|
|
bool fHasValidSig = setSporkPubKeyIDs.find(itSignerPair->first) != setSporkPubKeyIDs.end() &&
|
|
|
|
itSignerPair->second.CheckSignature(itSignerPair->first);
|
|
|
|
if (!fHasValidSig) {
|
2020-08-30 16:22:21 +02:00
|
|
|
mapSporksByHash.erase(itSignerPair->second.GetHash());
|
|
|
|
itActive->second.erase(itSignerPair++);
|
|
|
|
continue;
|
2018-09-30 19:01:33 +02:00
|
|
|
}
|
|
|
|
++itSignerPair;
|
|
|
|
}
|
|
|
|
if (itActive->second.empty()) {
|
|
|
|
mapSporksActive.erase(itActive++);
|
|
|
|
continue;
|
2018-09-26 16:15:02 +02:00
|
|
|
}
|
|
|
|
++itActive;
|
|
|
|
}
|
2018-09-30 19:01:33 +02:00
|
|
|
|
2021-12-17 18:22:11 +01:00
|
|
|
for (auto itByHash = mapSporksByHash.begin(); itByHash != mapSporksByHash.end();) {
|
2018-09-30 19:01:33 +02:00
|
|
|
bool found = false;
|
2021-12-17 18:22:11 +01:00
|
|
|
for (const auto& signer : setSporkPubKeyIDs) {
|
2020-08-30 16:22:21 +02:00
|
|
|
if (itByHash->second.CheckSignature(signer)) {
|
2018-09-30 19:01:33 +02:00
|
|
|
found = true;
|
|
|
|
break;
|
2018-09-26 16:15:02 +02:00
|
|
|
}
|
|
|
|
}
|
2018-09-30 19:01:33 +02:00
|
|
|
if (!found) {
|
|
|
|
mapSporksByHash.erase(itByHash++);
|
|
|
|
continue;
|
|
|
|
}
|
2018-09-26 16:15:02 +02:00
|
|
|
++itByHash;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-01-19 18:49:21 +01:00
|
|
|
void CSporkManager::ProcessMessage(CNode& peer, CConnman& connman, std::string_view msg_type, CDataStream& vRecv)
|
2015-02-09 21:54:51 +01:00
|
|
|
{
|
2022-10-28 21:50:54 +02:00
|
|
|
if (msg_type == NetMsgType::SPORK) {
|
2023-01-19 18:49:21 +01:00
|
|
|
ProcessSpork(peer, connman, vRecv);
|
2022-10-28 21:50:54 +02:00
|
|
|
} else if (msg_type == NetMsgType::GETSPORKS) {
|
|
|
|
ProcessGetSporks(peer, connman);
|
|
|
|
}
|
2021-12-17 18:22:11 +01:00
|
|
|
}
|
2015-02-09 21:54:51 +01:00
|
|
|
|
2023-01-19 18:49:21 +01:00
|
|
|
void CSporkManager::ProcessSpork(const CNode& peer, CConnman& connman, CDataStream& vRecv)
|
2021-12-17 18:22:11 +01:00
|
|
|
{
|
|
|
|
CSporkMessage spork;
|
|
|
|
vRecv >> spork;
|
2015-02-09 21:54:51 +01:00
|
|
|
|
2021-12-17 18:22:11 +01:00
|
|
|
uint256 hash = spork.GetHash();
|
2016-09-15 08:50:16 +02:00
|
|
|
|
2021-12-17 18:22:11 +01:00
|
|
|
std::string strLogMsg;
|
|
|
|
{
|
|
|
|
LOCK(cs_main);
|
2022-10-28 21:50:54 +02:00
|
|
|
EraseObjectRequest(peer.GetId(), CInv(MSG_SPORK, hash));
|
2021-12-17 18:22:11 +01:00
|
|
|
if (!::ChainActive().Tip()) return;
|
2022-10-28 21:50:54 +02:00
|
|
|
strLogMsg = strprintf("SPORK -- hash: %s id: %d value: %10d bestHeight: %d peer=%d", hash.ToString(), spork.nSporkID, spork.nValue, ::ChainActive().Height(), peer.GetId());
|
2021-12-17 18:22:11 +01:00
|
|
|
}
|
2018-09-30 19:01:33 +02:00
|
|
|
|
2021-12-17 18:22:11 +01:00
|
|
|
if (spork.nTimeSigned > GetAdjustedTime() + 2 * 60 * 60) {
|
|
|
|
LogPrint(BCLog::SPORK, "CSporkManager::ProcessSpork -- ERROR: too far into the future\n");
|
2022-10-28 21:50:54 +02:00
|
|
|
Misbehaving(peer.GetId(), 100);
|
2021-12-17 18:22:11 +01:00
|
|
|
return;
|
|
|
|
}
|
2018-12-22 11:33:49 +01:00
|
|
|
|
2022-10-19 20:37:28 +02:00
|
|
|
auto opt_keyIDSigner = spork.GetSignerKeyID();
|
2020-08-30 16:22:21 +02:00
|
|
|
|
2022-10-19 20:37:28 +02:00
|
|
|
if (opt_keyIDSigner == std::nullopt || WITH_LOCK(cs, return !setSporkPubKeyIDs.count(*opt_keyIDSigner))) {
|
2021-12-17 18:22:11 +01:00
|
|
|
LogPrint(BCLog::SPORK, "CSporkManager::ProcessSpork -- ERROR: invalid signature\n");
|
2022-10-28 21:50:54 +02:00
|
|
|
Misbehaving(peer.GetId(), 100);
|
2021-12-17 18:22:11 +01:00
|
|
|
return;
|
|
|
|
}
|
2018-09-30 19:01:33 +02:00
|
|
|
|
2022-10-19 20:37:28 +02:00
|
|
|
auto keyIDSigner = *opt_keyIDSigner;
|
|
|
|
|
2021-12-17 18:22:11 +01:00
|
|
|
{
|
|
|
|
LOCK(cs); // make sure to not lock this together with cs_main
|
|
|
|
if (mapSporksActive.count(spork.nSporkID)) {
|
|
|
|
if (mapSporksActive[spork.nSporkID].count(keyIDSigner)) {
|
|
|
|
if (mapSporksActive[spork.nSporkID][keyIDSigner].nTimeSigned >= spork.nTimeSigned) {
|
|
|
|
LogPrint(BCLog::SPORK, "%s seen\n", strLogMsg);
|
|
|
|
return;
|
2018-08-11 00:34:28 +02:00
|
|
|
} else {
|
2021-12-17 18:22:11 +01:00
|
|
|
LogPrintf("%s updated\n", strLogMsg);
|
2018-08-11 00:34:28 +02:00
|
|
|
}
|
2015-02-09 21:54:51 +01:00
|
|
|
} else {
|
2021-12-17 18:22:11 +01:00
|
|
|
LogPrintf("%s new signer\n", strLogMsg);
|
2015-02-09 21:54:51 +01:00
|
|
|
}
|
2021-12-17 18:22:11 +01:00
|
|
|
} else {
|
|
|
|
LogPrintf("%s new\n", strLogMsg);
|
2015-02-09 21:54:51 +01:00
|
|
|
}
|
2021-12-17 18:22:11 +01:00
|
|
|
}
|
2015-02-09 21:54:51 +01:00
|
|
|
|
|
|
|
|
2021-12-17 18:22:11 +01:00
|
|
|
{
|
2018-08-11 00:34:28 +02:00
|
|
|
LOCK(cs); // make sure to not lock this together with cs_main
|
2021-12-17 18:22:11 +01:00
|
|
|
mapSporksByHash[hash] = spork;
|
|
|
|
mapSporksActive[spork.nSporkID][keyIDSigner] = spork;
|
|
|
|
// Clear cached values on new spork being processed
|
2022-04-11 17:22:05 +02:00
|
|
|
WITH_LOCK(cs_mapSporksCachedActive, mapSporksCachedActive.erase(spork.nSporkID));
|
|
|
|
WITH_LOCK(cs_mapSporksCachedValues, mapSporksCachedValues.erase(spork.nSporkID));
|
2015-02-09 21:54:51 +01:00
|
|
|
}
|
2021-12-17 18:22:11 +01:00
|
|
|
spork.Relay(connman);
|
|
|
|
}
|
|
|
|
|
2022-10-28 21:50:54 +02:00
|
|
|
void CSporkManager::ProcessGetSporks(CNode& peer, CConnman& connman)
|
2021-12-17 18:22:11 +01:00
|
|
|
{
|
|
|
|
LOCK(cs); // make sure to not lock this together with cs_main
|
|
|
|
for (const auto& pair : mapSporksActive) {
|
|
|
|
for (const auto& signerSporkPair : pair.second) {
|
2022-10-28 21:50:54 +02:00
|
|
|
connman.PushMessage(&peer, CNetMsgMaker(peer.GetSendVersion()).Make(NetMsgType::SPORK, signerSporkPair.second));
|
2021-12-17 18:22:11 +01:00
|
|
|
}
|
|
|
|
}
|
2015-02-09 21:54:51 +01:00
|
|
|
}
|
|
|
|
|
2021-12-17 18:22:11 +01:00
|
|
|
|
2023-02-20 00:04:57 +01:00
|
|
|
bool CSporkManager::UpdateSpork(SporkId nSporkID, SporkValue nValue, CConnman& connman)
|
2016-07-30 13:04:27 +02:00
|
|
|
{
|
2021-12-17 18:22:11 +01:00
|
|
|
CSporkMessage spork(nSporkID, nValue, GetAdjustedTime());
|
2016-07-30 13:04:27 +02:00
|
|
|
|
2021-09-28 23:23:34 +02:00
|
|
|
{
|
|
|
|
LOCK(cs);
|
2016-07-30 13:04:27 +02:00
|
|
|
|
2021-09-28 23:23:34 +02:00
|
|
|
if (!spork.Sign(sporkPrivKey)) {
|
|
|
|
LogPrintf("CSporkManager::%s -- ERROR: signing failed for spork %d\n", __func__, nSporkID);
|
|
|
|
return false;
|
|
|
|
}
|
2019-08-28 13:51:59 +02:00
|
|
|
|
2022-10-19 20:37:28 +02:00
|
|
|
auto opt_keyIDSigner = spork.GetSignerKeyID();
|
|
|
|
if (opt_keyIDSigner == std::nullopt || !setSporkPubKeyIDs.count(*opt_keyIDSigner)) {
|
2021-09-28 23:23:34 +02:00
|
|
|
LogPrintf("CSporkManager::UpdateSpork: failed to find keyid for private key\n");
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
LogPrintf("CSporkManager::%s -- signed %d %s\n", __func__, nSporkID, spork.GetHash().ToString());
|
2019-08-28 13:51:59 +02:00
|
|
|
|
2020-11-28 20:06:51 +01:00
|
|
|
mapSporksByHash[spork.GetHash()] = spork;
|
2022-10-19 20:37:28 +02:00
|
|
|
mapSporksActive[nSporkID][*opt_keyIDSigner] = spork;
|
2021-01-21 03:04:14 +01:00
|
|
|
// Clear cached values on new spork being processed
|
2022-04-11 17:22:05 +02:00
|
|
|
WITH_LOCK(cs_mapSporksCachedActive, mapSporksCachedActive.erase(spork.nSporkID));
|
|
|
|
WITH_LOCK(cs_mapSporksCachedValues, mapSporksCachedValues.erase(spork.nSporkID));
|
2020-11-28 20:06:51 +01:00
|
|
|
}
|
2019-08-28 13:51:59 +02:00
|
|
|
|
|
|
|
spork.Relay(connman);
|
|
|
|
return true;
|
2016-07-30 13:04:27 +02:00
|
|
|
}
|
|
|
|
|
2021-01-22 06:57:42 +01:00
|
|
|
bool CSporkManager::IsSporkActive(SporkId nSporkID) const
|
2015-02-09 21:54:51 +01:00
|
|
|
{
|
2021-01-21 03:04:14 +01:00
|
|
|
// If nSporkID is cached, and the cached value is true, then return early true
|
2022-04-11 17:22:05 +02:00
|
|
|
{
|
|
|
|
LOCK(cs_mapSporksCachedActive);
|
|
|
|
if (auto it = mapSporksCachedActive.find(nSporkID); it != mapSporksCachedActive.end() && it->second) {
|
|
|
|
return true;
|
|
|
|
}
|
2021-01-21 03:04:14 +01:00
|
|
|
}
|
|
|
|
|
2023-02-20 00:04:57 +01:00
|
|
|
SporkValue nSporkValue = GetSporkValue(nSporkID);
|
2021-01-21 03:04:14 +01:00
|
|
|
// Get time is somewhat costly it looks like
|
|
|
|
bool ret = nSporkValue < GetAdjustedTime();
|
|
|
|
// Only cache true values
|
|
|
|
if (ret) {
|
2022-04-11 17:22:05 +02:00
|
|
|
LOCK(cs_mapSporksCachedActive);
|
2021-01-21 03:04:14 +01:00
|
|
|
mapSporksCachedActive[nSporkID] = ret;
|
|
|
|
}
|
|
|
|
return ret;
|
2015-02-09 21:54:51 +01:00
|
|
|
}
|
|
|
|
|
2023-02-20 00:04:57 +01:00
|
|
|
SporkValue CSporkManager::GetSporkValue(SporkId nSporkID) const
|
2015-02-11 15:47:21 +01:00
|
|
|
{
|
2018-08-11 00:34:28 +02:00
|
|
|
LOCK(cs);
|
2018-09-30 19:01:33 +02:00
|
|
|
|
2022-10-19 20:37:28 +02:00
|
|
|
if (auto opt_sporkValue = SporkValueIfActive(nSporkID)) {
|
|
|
|
return *opt_sporkValue;
|
2018-09-30 19:01:33 +02:00
|
|
|
}
|
2016-08-29 21:16:02 +02:00
|
|
|
|
2015-02-11 15:47:21 +01:00
|
|
|
|
2021-12-21 13:05:29 +01:00
|
|
|
if (auto optSpork = ranges::find_if_opt(sporkDefs,
|
|
|
|
[&nSporkID](const auto& sporkDef){return sporkDef.sporkId == nSporkID;})) {
|
|
|
|
return optSpork->defaultValue;
|
|
|
|
} else {
|
|
|
|
LogPrint(BCLog::SPORK, "CSporkManager::GetSporkValue -- Unknown Spork ID %d\n", nSporkID);
|
|
|
|
return -1;
|
|
|
|
}
|
2015-02-11 15:47:21 +01:00
|
|
|
}
|
|
|
|
|
2021-12-17 18:22:11 +01:00
|
|
|
SporkId CSporkManager::GetSporkIDByName(std::string_view strName)
|
2015-02-12 05:05:09 +01:00
|
|
|
{
|
2021-12-21 13:05:29 +01:00
|
|
|
if (auto optSpork = ranges::find_if_opt(sporkDefs,
|
|
|
|
[&strName](const auto& sporkDef){return sporkDef.name == strName;})) {
|
|
|
|
return optSpork->sporkId;
|
2019-05-29 20:18:31 +02:00
|
|
|
}
|
2015-08-02 23:59:28 +02:00
|
|
|
|
2021-10-12 01:08:02 +02:00
|
|
|
LogPrint(BCLog::SPORK, "CSporkManager::GetSporkIDByName -- Unknown Spork name '%s'\n", strName);
|
|
|
|
return SPORK_INVALID;
|
2015-02-12 05:05:09 +01:00
|
|
|
}
|
|
|
|
|
2022-10-19 20:37:28 +02:00
|
|
|
std::optional<CSporkMessage> CSporkManager::GetSporkByHash(const uint256& hash) const
|
2018-08-13 22:21:21 +02:00
|
|
|
{
|
|
|
|
LOCK(cs);
|
|
|
|
|
2022-10-19 20:37:28 +02:00
|
|
|
if (const auto it = mapSporksByHash.find(hash); it != mapSporksByHash.end())
|
|
|
|
return {it->second};
|
2018-08-13 22:21:21 +02:00
|
|
|
|
2022-10-19 20:37:28 +02:00
|
|
|
return std::nullopt;
|
2018-08-13 22:21:21 +02:00
|
|
|
}
|
|
|
|
|
2021-12-17 18:22:11 +01:00
|
|
|
bool CSporkManager::SetSporkAddress(const std::string& strAddress)
|
|
|
|
{
|
2018-08-11 00:34:28 +02:00
|
|
|
LOCK(cs);
|
Merge #11117: Prepare for non-Base58 addresses (#3294)
* Merge #11117: Prepare for non-Base58 addresses
864cd2787 Move CBitcoinAddress to base58.cpp (Pieter Wuille)
5c8ff0d44 Introduce wrappers around CBitcoinAddress (Pieter Wuille)
Pull request description:
This patch removes the need for the intermediary Base58 type `CBitcoinAddress`, by providing {`Encode`,`Decode`,`IsValid`}`Destination` functions that directly operate on the conversion between `std::string`s and `CTxDestination`.
As a side, it also fixes a number of indentation issues, and removes probably several unnecessary implicit `CTxDestination`<->`CBitcoinAddress` conversions.
This change is far from complete. In follow-ups I'd like to:
* Split off the specific address and key encoding logic from base58.h, and move it to a address.h or so.
* Replace `CTxDestination` with a non-`boost::variant` version (which can be more efficient as `boost::variant` allocates everything on the heap, and remove the need for `boost::get<...>` and `IsValidDestination` calls everywhere).
* Do the same for `CBitcoinSecret`, `CBitcoinExtKey`, and `CBitcoinExtPubKey`.
However, I've tried to keep this patch to be minimally invasive, but still enough to support non-Base58 addresses. Perhaps a smaller patch is possible to hack Bech32 support into `CBitcoinAddress`, but I would consider that a move in the wrong direction.
Tree-SHA512: c2c77ffb57caeadf2429b1c2562ce60e8c7be8aa9f8e51b591f354b6b441162625b2efe14c023a1ae485cf2ed417263afa35c892891dfaa7844e7fbabccab85e
* CBitcoinAddress -> EncodeDestination in providertx.h
Signed-off-by: Pasta <pasta@dashboost.org>
* more CBitcoinAddress -> EncodeDestination in providertx.h
Signed-off-by: Pasta <pasta@dashboost.org>
* more CBitcoinAddress -> EncodeDestination in providertx.h
Signed-off-by: Pasta <pasta@dashboost.org>
* more CBitcoinAddress -> EncodeDestination in providertx.h
Signed-off-by: Pasta <pasta@dashboost.org>
* fix CBitcoinAddress GetKeyID check
Signed-off-by: Pasta <pasta@dashboost.org>
* fix providertx.cpp
Signed-off-by: Pasta <pasta@dashboost.org>
* hopefully fix governance-classes.cpp
Signed-off-by: Pasta <pasta@dashboost.org>
* partially fix governance-validators.cpp, unable to resolve "address.IsScript()"
Signed-off-by: Pasta <pasta@dashboost.org>
* partially fix governance-classes.cpp, unable to resolve "address.IsScript()"
Signed-off-by: Pasta <pasta@dashboost.org>
* fix governance-classes.h
Signed-off-by: Pasta <pasta@dashboost.org>
* DecodeTransaction -> DecodeDestination, fix governance-validators.cpp
Signed-off-by: Pasta <pasta@dashboost.org>
* More fixes for 3294
* Move GetIndexKey into rpc/misc.cpp near getAddressesFromParams
No need to have it in base58.cpp anymore as this is only used in getAddressesFromParams
Co-authored-by: Wladimir J. van der Laan <laanwj@gmail.com>
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
Co-authored-by: Alexander Block <ablock84@gmail.com>
2020-01-22 11:35:04 +01:00
|
|
|
CTxDestination dest = DecodeDestination(strAddress);
|
2019-05-09 18:04:52 +02:00
|
|
|
const PKHash* pkhash = std::get_if<PKHash>(&dest);
|
|
|
|
if (!pkhash) {
|
2018-03-02 14:15:04 +01:00
|
|
|
LogPrintf("CSporkManager::SetSporkAddress -- Failed to parse spork address\n");
|
|
|
|
return false;
|
|
|
|
}
|
2019-05-09 18:04:52 +02:00
|
|
|
setSporkPubKeyIDs.insert(CKeyID(*pkhash));
|
2018-09-30 19:01:33 +02:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool CSporkManager::SetMinSporkKeys(int minSporkKeys)
|
|
|
|
{
|
2021-09-28 23:23:34 +02:00
|
|
|
LOCK(cs);
|
2021-12-17 18:22:11 +01:00
|
|
|
if (int maxKeysNumber = setSporkPubKeyIDs.size(); (minSporkKeys <= maxKeysNumber / 2) || (minSporkKeys > maxKeysNumber)) {
|
2018-09-30 19:01:33 +02:00
|
|
|
LogPrintf("CSporkManager::SetMinSporkKeys -- Invalid min spork signers number: %d\n", minSporkKeys);
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
nMinSporkKeys = minSporkKeys;
|
2018-03-02 14:15:04 +01:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2018-02-12 13:49:00 +01:00
|
|
|
bool CSporkManager::SetPrivKey(const std::string& strPrivKey)
|
2015-02-09 21:54:51 +01:00
|
|
|
{
|
2018-03-02 14:15:04 +01:00
|
|
|
CKey key;
|
|
|
|
CPubKey pubKey;
|
2021-12-17 18:22:11 +01:00
|
|
|
if (!CMessageSigner::GetKeysFromSecret(strPrivKey, key, pubKey)) {
|
2018-03-02 14:15:04 +01:00
|
|
|
LogPrintf("CSporkManager::SetPrivKey -- Failed to parse private key\n");
|
|
|
|
return false;
|
|
|
|
}
|
2015-02-09 21:54:51 +01:00
|
|
|
|
2021-09-28 23:23:34 +02:00
|
|
|
LOCK(cs);
|
2018-09-30 19:01:33 +02:00
|
|
|
if (setSporkPubKeyIDs.find(pubKey.GetID()) == setSporkPubKeyIDs.end()) {
|
|
|
|
LogPrintf("CSporkManager::SetPrivKey -- New private key does not belong to spork addresses\n");
|
2018-03-02 14:15:04 +01:00
|
|
|
return false;
|
|
|
|
}
|
2016-07-30 13:04:27 +02:00
|
|
|
|
2021-12-17 18:22:11 +01:00
|
|
|
if (!CSporkMessage().Sign(key)) {
|
2018-03-02 14:15:04 +01:00
|
|
|
LogPrintf("CSporkManager::SetPrivKey -- Test signing failed\n");
|
2015-02-09 21:54:51 +01:00
|
|
|
return false;
|
|
|
|
}
|
2019-08-28 13:51:59 +02:00
|
|
|
|
|
|
|
// Test signing successful, proceed
|
|
|
|
LogPrintf("CSporkManager::SetPrivKey -- Successfully initialized as spork signer\n");
|
|
|
|
sporkPrivKey = key;
|
|
|
|
return true;
|
2015-02-09 21:54:51 +01:00
|
|
|
}
|
|
|
|
|
2018-08-13 22:21:21 +02:00
|
|
|
std::string CSporkManager::ToString() const
|
|
|
|
{
|
|
|
|
LOCK(cs);
|
|
|
|
return strprintf("Sporks: %llu", mapSporksActive.size());
|
|
|
|
}
|
|
|
|
|
2018-02-16 15:54:53 +01:00
|
|
|
uint256 CSporkMessage::GetHash() const
|
|
|
|
{
|
|
|
|
return SerializeHash(*this);
|
|
|
|
}
|
|
|
|
|
|
|
|
uint256 CSporkMessage::GetSignatureHash() const
|
|
|
|
{
|
2018-09-30 19:01:33 +02:00
|
|
|
CHashWriter s(SER_GETHASH, 0);
|
|
|
|
s << nSporkID;
|
|
|
|
s << nValue;
|
|
|
|
s << nTimeSigned;
|
|
|
|
return s.GetHash();
|
2018-02-16 15:54:53 +01:00
|
|
|
}
|
|
|
|
|
2020-08-30 16:22:21 +02:00
|
|
|
bool CSporkMessage::Sign(const CKey& key)
|
2015-02-09 21:54:51 +01:00
|
|
|
{
|
2018-06-19 01:40:55 +02:00
|
|
|
if (!key.IsValid()) {
|
|
|
|
LogPrintf("CSporkMessage::Sign -- signing key is not valid\n");
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2018-03-02 14:15:04 +01:00
|
|
|
CKeyID pubKeyId = key.GetPubKey().GetID();
|
2015-02-09 21:54:51 +01:00
|
|
|
|
2020-08-30 16:22:21 +02:00
|
|
|
// Harden Spork6 so that it is active on testnet and no other networks
|
2021-12-17 18:22:11 +01:00
|
|
|
if (std::string strError; Params().NetworkIDString() == CBaseChainParams::TESTNET) {
|
2018-02-16 15:54:53 +01:00
|
|
|
uint256 hash = GetSignatureHash();
|
2015-02-09 21:54:51 +01:00
|
|
|
|
2021-12-17 18:22:11 +01:00
|
|
|
if (!CHashSigner::SignHash(hash, key, vchSig)) {
|
2018-02-16 15:54:53 +01:00
|
|
|
LogPrintf("CSporkMessage::Sign -- SignHash() failed\n");
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2018-03-02 14:15:04 +01:00
|
|
|
if (!CHashSigner::VerifyHash(hash, pubKeyId, vchSig, strError)) {
|
2018-02-16 15:54:53 +01:00
|
|
|
LogPrintf("CSporkMessage::Sign -- VerifyHash() failed, error: %s\n", strError);
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
} else {
|
2022-12-15 20:17:05 +01:00
|
|
|
std::string strMessage = ToString(nSporkID) + ToString(nValue) + ToString(nTimeSigned);
|
2018-02-16 15:54:53 +01:00
|
|
|
|
2021-12-17 18:22:11 +01:00
|
|
|
if (!CMessageSigner::SignMessage(strMessage, vchSig, key)) {
|
2018-02-16 15:54:53 +01:00
|
|
|
LogPrintf("CSporkMessage::Sign -- SignMessage() failed\n");
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2021-12-17 18:22:11 +01:00
|
|
|
if (!CMessageSigner::VerifyMessage(pubKeyId, vchSig, strMessage, strError)) {
|
2018-02-16 15:54:53 +01:00
|
|
|
LogPrintf("CSporkMessage::Sign -- VerifyMessage() failed, error: %s\n", strError);
|
|
|
|
return false;
|
|
|
|
}
|
2015-02-09 21:54:51 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2020-08-30 16:22:21 +02:00
|
|
|
bool CSporkMessage::CheckSignature(const CKeyID& pubKeyId) const
|
2015-02-09 21:54:51 +01:00
|
|
|
{
|
2020-08-30 16:22:21 +02:00
|
|
|
// Harden Spork6 so that it is active on testnet and no other networks
|
2021-12-17 18:22:11 +01:00
|
|
|
if (std::string strError; Params().NetworkIDString() == CBaseChainParams::TESTNET) {
|
2018-02-16 15:54:53 +01:00
|
|
|
uint256 hash = GetSignatureHash();
|
|
|
|
|
2018-03-02 14:15:04 +01:00
|
|
|
if (!CHashSigner::VerifyHash(hash, pubKeyId, vchSig, strError)) {
|
2020-01-28 11:04:47 +01:00
|
|
|
LogPrint(BCLog::SPORK, "CSporkMessage::CheckSignature -- VerifyHash() failed, error: %s\n", strError);
|
2018-02-16 15:54:53 +01:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
} else {
|
2022-12-15 20:17:05 +01:00
|
|
|
std::string strMessage = ToString(nSporkID) + ToString(nValue) + ToString(nTimeSigned);
|
2018-02-16 15:54:53 +01:00
|
|
|
|
2021-12-17 18:22:11 +01:00
|
|
|
if (!CMessageSigner::VerifyMessage(pubKeyId, vchSig, strMessage, strError)) {
|
2020-08-30 16:22:21 +02:00
|
|
|
LogPrint(BCLog::SPORK, "CSporkMessage::CheckSignature -- VerifyMessage() failed, error: %s\n", strError);
|
|
|
|
return false;
|
2018-02-16 15:54:53 +01:00
|
|
|
}
|
2015-02-09 21:54:51 +01:00
|
|
|
}
|
|
|
|
|
2016-07-30 13:04:27 +02:00
|
|
|
return true;
|
2015-02-09 21:54:51 +01:00
|
|
|
}
|
|
|
|
|
2022-10-19 20:37:28 +02:00
|
|
|
std::optional<CKeyID> CSporkMessage::GetSignerKeyID() const
|
2018-09-30 19:01:33 +02:00
|
|
|
{
|
|
|
|
CPubKey pubkeyFromSig;
|
2020-08-30 16:22:21 +02:00
|
|
|
// Harden Spork6 so that it is active on testnet and no other networks
|
|
|
|
if (Params().NetworkIDString() == CBaseChainParams::TESTNET) {
|
2018-09-30 19:01:33 +02:00
|
|
|
if (!pubkeyFromSig.RecoverCompact(GetSignatureHash(), vchSig)) {
|
2022-10-19 20:37:28 +02:00
|
|
|
return std::nullopt;
|
2018-09-30 19:01:33 +02:00
|
|
|
}
|
|
|
|
} else {
|
2022-12-15 20:17:05 +01:00
|
|
|
std::string strMessage = ToString(nSporkID) + ToString(nValue) + ToString(nTimeSigned);
|
2018-09-30 19:01:33 +02:00
|
|
|
CHashWriter ss(SER_GETHASH, 0);
|
2022-09-18 22:49:22 +02:00
|
|
|
ss << MESSAGE_MAGIC;
|
2018-09-30 19:01:33 +02:00
|
|
|
ss << strMessage;
|
|
|
|
if (!pubkeyFromSig.RecoverCompact(ss.GetHash(), vchSig)) {
|
2022-10-19 20:37:28 +02:00
|
|
|
return std::nullopt;
|
2018-09-30 19:01:33 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-10-19 20:37:28 +02:00
|
|
|
return {pubkeyFromSig.GetID()};
|
2018-09-30 19:01:33 +02:00
|
|
|
}
|
|
|
|
|
2021-01-22 06:57:42 +01:00
|
|
|
void CSporkMessage::Relay(CConnman& connman) const
|
2015-02-09 21:54:51 +01:00
|
|
|
{
|
2016-07-30 13:04:27 +02:00
|
|
|
CInv inv(MSG_SPORK, GetHash());
|
2017-09-07 17:58:38 +02:00
|
|
|
connman.RelayInv(inv);
|
2015-04-03 00:51:08 +02:00
|
|
|
}
|