2020-09-09 09:06:16 +02:00
|
|
|
#!/usr/bin/env python3
|
|
|
|
# Copyright (c) 2020 The Bitcoin Core developers
|
|
|
|
# Distributed under the MIT software license, see the accompanying
|
|
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
"""A limited-functionality wallet, which may replace a real wallet in tests"""
|
|
|
|
|
|
|
|
from decimal import Decimal
|
2021-05-25 07:26:18 +02:00
|
|
|
from enum import Enum
|
2020-09-09 09:06:16 +02:00
|
|
|
from test_framework.address import ADDRESS_BCRT1_P2SH_OP_TRUE
|
2021-05-24 08:29:05 +02:00
|
|
|
from test_framework.key import ECKey
|
2021-06-07 07:05:05 +02:00
|
|
|
from typing import Optional
|
2020-09-09 09:06:16 +02:00
|
|
|
from test_framework.messages import (
|
|
|
|
COIN,
|
|
|
|
COutPoint,
|
|
|
|
CTransaction,
|
|
|
|
CTxIn,
|
|
|
|
CTxOut,
|
|
|
|
)
|
|
|
|
from test_framework.script import (
|
|
|
|
CScript,
|
2021-05-24 08:29:05 +02:00
|
|
|
SignatureHash,
|
|
|
|
OP_CHECKSIG,
|
2020-09-09 09:06:16 +02:00
|
|
|
OP_TRUE,
|
2024-07-23 19:39:49 +02:00
|
|
|
OP_NOP,
|
2021-05-24 08:29:05 +02:00
|
|
|
SIGHASH_ALL,
|
2020-09-09 09:06:16 +02:00
|
|
|
)
|
|
|
|
from test_framework.util import (
|
|
|
|
assert_equal,
|
|
|
|
satoshi_round,
|
|
|
|
)
|
|
|
|
|
|
|
|
|
2021-05-25 07:26:18 +02:00
|
|
|
class MiniWalletMode(Enum):
|
|
|
|
"""Determines the transaction type the MiniWallet is creating and spending.
|
|
|
|
|
|
|
|
For most purposes, the default mode ADDRESS_OP_TRUE should be sufficient;
|
|
|
|
it simply uses a fixed P2SH address whose coins are spent with a
|
|
|
|
witness stack of OP_TRUE, i.e. following an anyone-can-spend policy.
|
|
|
|
However, if the transactions need to be modified by the user (e.g. prepending
|
|
|
|
scriptSig for testing opcodes that are activated by a soft-fork), or the txs
|
|
|
|
should contain an actual signature, the raw modes RAW_OP_TRUE and RAW_P2PK
|
|
|
|
can be useful. Summary of modes:
|
|
|
|
|
|
|
|
| output | | tx is | can modify | needs
|
|
|
|
mode | description | address | standard | scriptSig | signing
|
|
|
|
----------------+-------------------+-----------+----------+------------+----------
|
|
|
|
ADDRESS_OP_TRUE | anyone-can-spend | bech32 | yes | no | no
|
|
|
|
RAW_OP_TRUE | anyone-can-spend | - (raw) | no | yes | no
|
|
|
|
RAW_P2PK | pay-to-public-key | - (raw) | yes | yes | yes
|
|
|
|
"""
|
|
|
|
ADDRESS_OP_TRUE = 1
|
|
|
|
RAW_OP_TRUE = 2
|
|
|
|
RAW_P2PK = 3
|
|
|
|
|
|
|
|
|
2020-09-09 09:06:16 +02:00
|
|
|
class MiniWallet:
|
2021-05-25 07:26:18 +02:00
|
|
|
def __init__(self, test_node, *, mode=MiniWalletMode.ADDRESS_OP_TRUE):
|
2020-09-09 09:06:16 +02:00
|
|
|
self._test_node = test_node
|
|
|
|
self._utxos = []
|
2021-05-24 08:29:05 +02:00
|
|
|
self._priv_key = None
|
|
|
|
self._address = None
|
|
|
|
|
2021-05-25 07:26:18 +02:00
|
|
|
assert isinstance(mode, MiniWalletMode)
|
|
|
|
if mode == MiniWalletMode.RAW_OP_TRUE:
|
2024-07-23 19:39:49 +02:00
|
|
|
self._scriptPubKey = bytes(CScript([OP_TRUE]))
|
2021-05-25 07:26:18 +02:00
|
|
|
elif mode == MiniWalletMode.RAW_P2PK:
|
2021-05-24 08:29:05 +02:00
|
|
|
# use simple deterministic private key (k=1)
|
|
|
|
self._priv_key = ECKey()
|
|
|
|
self._priv_key.set((1).to_bytes(32, 'big'), True)
|
|
|
|
pub_key = self._priv_key.get_pubkey()
|
|
|
|
self._scriptPubKey = bytes(CScript([pub_key.get_bytes(), OP_CHECKSIG]))
|
2021-05-25 07:26:18 +02:00
|
|
|
elif mode == MiniWalletMode.ADDRESS_OP_TRUE:
|
2024-07-23 19:39:49 +02:00
|
|
|
self._address = ADDRESS_BCRT1_P2SH_OP_TRUE
|
2021-07-31 21:23:16 +02:00
|
|
|
self._scriptPubKey = bytes.fromhex(self._test_node.validateaddress(self._address)['scriptPubKey'])
|
2020-09-09 09:06:16 +02:00
|
|
|
|
2021-02-25 09:48:28 +01:00
|
|
|
def scan_blocks(self, *, start=1, num):
|
|
|
|
"""Scan the blocks for self._address outputs and add them to self._utxos"""
|
|
|
|
for i in range(start, start + num):
|
|
|
|
block = self._test_node.getblock(blockhash=self._test_node.getblockhash(i), verbosity=2)
|
|
|
|
for tx in block['tx']:
|
2024-07-23 19:39:21 +02:00
|
|
|
self.scan_tx(tx)
|
|
|
|
|
|
|
|
def scan_tx(self, tx):
|
|
|
|
"""Scan the tx for self._scriptPubKey outputs and add them to self._utxos"""
|
|
|
|
for out in tx['vout']:
|
|
|
|
if out['scriptPubKey']['hex'] == self._scriptPubKey.hex():
|
|
|
|
self._utxos.append({'txid': tx['txid'], 'vout': out['n'], 'value': out['value']})
|
2021-02-25 09:48:28 +01:00
|
|
|
|
2021-05-24 08:29:05 +02:00
|
|
|
def sign_tx(self, tx):
|
|
|
|
"""Sign tx that has been created by MiniWallet in P2PK mode"""
|
|
|
|
assert self._priv_key is not None
|
|
|
|
(sighash, err) = SignatureHash(CScript(self._scriptPubKey), tx, 0, SIGHASH_ALL)
|
|
|
|
assert err is None
|
|
|
|
tx.vin[0].scriptSig = CScript([self._priv_key.sign_ecdsa(sighash) + bytes(bytearray([SIGHASH_ALL]))])
|
|
|
|
|
2020-09-09 09:06:16 +02:00
|
|
|
def generate(self, num_blocks):
|
|
|
|
"""Generate blocks with coinbase outputs to the internal address, and append the outputs to the internal list"""
|
2024-07-23 19:39:49 +02:00
|
|
|
blocks = self._test_node.generatetodescriptor(num_blocks, f'raw({self._scriptPubKey.hex()})')
|
2020-09-09 09:06:16 +02:00
|
|
|
for b in blocks:
|
|
|
|
cb_tx = self._test_node.getblock(blockhash=b, verbosity=2)['tx'][0]
|
|
|
|
self._utxos.append({'txid': cb_tx['txid'], 'vout': 0, 'value': cb_tx['vout'][0]['value']})
|
|
|
|
return blocks
|
|
|
|
|
2021-03-26 08:52:51 +01:00
|
|
|
def get_address(self):
|
|
|
|
return self._address
|
|
|
|
|
Merge bitcoin/bitcoin#21900: test: use MiniWallet for feature_csv_activation.py
bd7f27d16dacf6f7de3b4f6bd052def41d9601be refactor: feature_csv_activation.py: move tx helper functions to methods (Sebastian Falbesoner)
2eca46b0aa0ecf4738500b53523d7013985b387d test: use MiniWallet for feature_csv_activation.py (Sebastian Falbesoner)
Pull request description:
This PR enables one more of the non-wallet functional tests (feature_csv_activation.py) to be run even with the Bitcoin Core wallet disabled by using the new MiniWallet instead, as proposed in #20078.
Short reviewers guideline:
- Since we exclusively work with anyone-can-spend outputs here (raw scriptPubKey = OP_TRUE), signing is not needed anymore. The function `sign_transaction` and its calls are removed, after changing a tx (e.g. its scriptSig or nVersion) a simple `.rehash()` call is sufficient. Also, generating an address `self.nodeaddress` (and with that, passing it to the the various test tx creation/sending helper methods) is not needed anymore and removed.
- The test repeatedly uses the same input for creating different txs (e.g. with different txversions 1 and 2). To let `MiniWallet` create a tx with a specific input, we have to call `.get_utxo()` before which also marks the UTXO as spent. The method is changed to also support keeping the UTXO in its internal list (`mark_as_spent=False`). With the behaviour on master, the second call to `.get_utxo()` with the same input would fail.
- To keep the diff in the first commit short, the `miniwallet` is set as a global variable, to avoid passing it on every tx creation/spending helper. The global is eliminated in the second (refactoring) commit, where all the helpers are moved to the test class as methods. By that, we can use `self.nodes[0]` directly in the helpers and don't have to pass it again and again. I think there could still be a lot of improvements/refactoring done in the test, but that should hopefully serve as a good basis.
ACKs for top commit:
laanwj:
Code review ACK bd7f27d16dacf6f7de3b4f6bd052def41d9601be
MarcoFalke:
review ACK bd7f27d16dacf6f7de3b4f6bd052def41d9601be 🐕
Tree-SHA512: 24fb6a0f7702bae40d5271d197119827067d4b597e954d182e4c1aa5d0fa870368eb3ffed469b26713fa8ff8eb3ecc06abc80b2449cd68156d5559e7ae8a2b11
2021-05-10 17:50:15 +02:00
|
|
|
def get_utxo(self, *, txid: Optional[str]='', mark_as_spent=True):
|
2020-11-19 16:39:56 +01:00
|
|
|
"""
|
|
|
|
Returns a utxo and marks it as spent (pops it from the internal list)
|
|
|
|
|
|
|
|
Args:
|
2021-06-07 07:05:05 +02:00
|
|
|
txid: get the first utxo we find from a specific transaction
|
2020-11-19 16:39:56 +01:00
|
|
|
|
|
|
|
Note: Can be used to get the change output immediately after a send_self_transfer
|
|
|
|
"""
|
|
|
|
index = -1 # by default the last utxo
|
|
|
|
if txid:
|
|
|
|
utxo = next(filter(lambda utxo: txid == utxo['txid'], self._utxos))
|
|
|
|
index = self._utxos.index(utxo)
|
Merge bitcoin/bitcoin#21900: test: use MiniWallet for feature_csv_activation.py
bd7f27d16dacf6f7de3b4f6bd052def41d9601be refactor: feature_csv_activation.py: move tx helper functions to methods (Sebastian Falbesoner)
2eca46b0aa0ecf4738500b53523d7013985b387d test: use MiniWallet for feature_csv_activation.py (Sebastian Falbesoner)
Pull request description:
This PR enables one more of the non-wallet functional tests (feature_csv_activation.py) to be run even with the Bitcoin Core wallet disabled by using the new MiniWallet instead, as proposed in #20078.
Short reviewers guideline:
- Since we exclusively work with anyone-can-spend outputs here (raw scriptPubKey = OP_TRUE), signing is not needed anymore. The function `sign_transaction` and its calls are removed, after changing a tx (e.g. its scriptSig or nVersion) a simple `.rehash()` call is sufficient. Also, generating an address `self.nodeaddress` (and with that, passing it to the the various test tx creation/sending helper methods) is not needed anymore and removed.
- The test repeatedly uses the same input for creating different txs (e.g. with different txversions 1 and 2). To let `MiniWallet` create a tx with a specific input, we have to call `.get_utxo()` before which also marks the UTXO as spent. The method is changed to also support keeping the UTXO in its internal list (`mark_as_spent=False`). With the behaviour on master, the second call to `.get_utxo()` with the same input would fail.
- To keep the diff in the first commit short, the `miniwallet` is set as a global variable, to avoid passing it on every tx creation/spending helper. The global is eliminated in the second (refactoring) commit, where all the helpers are moved to the test class as methods. By that, we can use `self.nodes[0]` directly in the helpers and don't have to pass it again and again. I think there could still be a lot of improvements/refactoring done in the test, but that should hopefully serve as a good basis.
ACKs for top commit:
laanwj:
Code review ACK bd7f27d16dacf6f7de3b4f6bd052def41d9601be
MarcoFalke:
review ACK bd7f27d16dacf6f7de3b4f6bd052def41d9601be 🐕
Tree-SHA512: 24fb6a0f7702bae40d5271d197119827067d4b597e954d182e4c1aa5d0fa870368eb3ffed469b26713fa8ff8eb3ecc06abc80b2449cd68156d5559e7ae8a2b11
2021-05-10 17:50:15 +02:00
|
|
|
if mark_as_spent:
|
|
|
|
return self._utxos.pop(index)
|
|
|
|
else:
|
|
|
|
return self._utxos[index]
|
2020-09-11 16:16:10 +02:00
|
|
|
|
|
|
|
def send_self_transfer(self, *, fee_rate=Decimal("0.003"), from_node, utxo_to_spend=None):
|
2020-09-09 09:06:16 +02:00
|
|
|
"""Create and send a tx with the specified fee_rate. Fee may be exact or at most one satoshi higher than needed."""
|
2024-07-23 19:39:21 +02:00
|
|
|
tx = self.create_self_transfer(fee_rate=fee_rate, from_node=from_node, utxo_to_spend=utxo_to_spend)
|
|
|
|
self.sendrawtransaction(from_node=from_node, tx_hex=tx['hex'])
|
|
|
|
return tx
|
|
|
|
|
|
|
|
def create_self_transfer(self, *, fee_rate=Decimal("0.003"), from_node, utxo_to_spend=None, mempool_valid=True):
|
|
|
|
"""Create and return a tx with the specified fee_rate. Fee may be exact or at most one satoshi higher than needed."""
|
2020-09-11 16:16:10 +02:00
|
|
|
self._utxos = sorted(self._utxos, key=lambda k: k['value'])
|
|
|
|
utxo_to_spend = utxo_to_spend or self._utxos.pop() # Pick the largest utxo (if none provided) and hope it covers the fee
|
2020-09-09 09:06:16 +02:00
|
|
|
vsize = Decimal(85)
|
2020-09-11 16:16:10 +02:00
|
|
|
send_value = satoshi_round(utxo_to_spend['value'] - fee_rate * (vsize / 1000))
|
|
|
|
fee = utxo_to_spend['value'] - send_value
|
|
|
|
assert send_value > 0
|
2020-09-09 09:06:16 +02:00
|
|
|
|
|
|
|
tx = CTransaction()
|
2020-09-11 16:16:10 +02:00
|
|
|
tx.vin = [CTxIn(COutPoint(int(utxo_to_spend['txid'], 16), utxo_to_spend['vout']))]
|
2020-09-09 09:06:16 +02:00
|
|
|
tx.vout = [CTxOut(int(send_value * COIN), self._scriptPubKey)]
|
2024-07-23 19:39:49 +02:00
|
|
|
if not self._address:
|
|
|
|
# raw script
|
2021-05-24 08:29:05 +02:00
|
|
|
if self._priv_key is not None:
|
|
|
|
# P2PK, need to sign
|
|
|
|
self.sign_tx(tx)
|
|
|
|
else:
|
|
|
|
# anyone-can-spend
|
|
|
|
tx.vin[0].scriptSig = CScript([OP_NOP] * 24) # pad to identical size
|
2024-07-23 19:39:49 +02:00
|
|
|
else:
|
|
|
|
tx.vin[0].scriptSig = CScript([CScript([OP_TRUE])])
|
2020-09-09 09:06:16 +02:00
|
|
|
tx_hex = tx.serialize().hex()
|
|
|
|
|
2021-01-11 08:57:23 +01:00
|
|
|
tx_info = from_node.testmempoolaccept([tx_hex])[0]
|
2024-07-23 19:39:21 +02:00
|
|
|
assert_equal(mempool_valid, tx_info['allowed'])
|
|
|
|
if mempool_valid:
|
2021-05-24 08:29:05 +02:00
|
|
|
# TODO: for P2PK, vsize is not constant due to varying scriptSig length,
|
|
|
|
# so only check this for anyone-can-spend outputs right now
|
|
|
|
if self._priv_key is None:
|
|
|
|
assert_equal(len(tx_hex) // 2, vsize) # 1 byte = 2 character
|
2024-07-23 19:39:21 +02:00
|
|
|
assert_equal(tx_info['fees']['base'], fee)
|
2024-07-23 19:39:49 +02:00
|
|
|
return {'txid': tx_info['txid'], 'hex': tx_hex, 'tx': tx}
|
2024-07-23 19:39:21 +02:00
|
|
|
|
|
|
|
def sendrawtransaction(self, *, from_node, tx_hex):
|
|
|
|
from_node.sendrawtransaction(tx_hex)
|
|
|
|
self.scan_tx(from_node.decoderawtransaction(tx_hex))
|