2016-05-06 11:23:48 +02:00
#!/usr/bin/env python3
# Copyright (c) 2015-2016 The Bitcoin Core developers
# Distributed under the MIT software license, see the accompanying
2015-06-28 20:42:17 +02:00
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
2019-01-07 10:55:35 +01:00
""" Test BIP65 (CHECKLOCKTIMEVERIFY).
2019-09-08 18:07:07 +02:00
Test that the CHECKLOCKTIMEVERIFY soft - fork activates at ( regtest ) block height
1351.
2019-01-07 10:55:35 +01:00
"""
2015-06-28 20:42:17 +02:00
Merge #13669: Tests: Cleanup create_transaction implementations
44bbceeef1 [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput object (Conor Scott)
736f941424 [Tests] Cleanup extra instances of create_transaction (Conor Scott)
157651855f [Tests] Rename create_tx and move to blocktools.py (Conor Scott)
Pull request description:
There currently exist seven ([1](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_cltv.py#L52-L60), [2](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_csv_activation.py#L88-L95) [3](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_dersig.py#L40-L48), [4](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_nulldummy.py#L100-L108), [5](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/util.py#L529-L535), [6](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/blocktools.py#L120-L129), [7](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_block.py#L1218-L1220)) implementations of a function called something similar to `create_transaction` in the functional tests, some of which are exact copies of each other.
This PR aims to clean this up into [three different cases implemented in blocktools.py](https://github.com/conscott/bitcoin/blob/create_tx_cleanup/test/functional/test_framework/blocktools.py#L121-L149)
1. `create_tx_with_script`: Return transaction object spending generic tx output optionally specifying scriptSig and scriptPubKey
2. `create_transaction`: Return transaction object spending coinbase tx
2. `create_raw_transaction`: Return raw transaction (hex string) spending coinbase tx
I am not committed to any of these function names, so I'll gladly take suggestions on there.
Additionally there are some related cleanups to feature_block.py tests, specifically removing the [PreviousSpendableOutput](https://github.com/conscott/bitcoin/blob/master/test/functional/feature_block.py#L51-L54) object, which seems like an unnecessary layer given that every instance spends the 0 output.
Tree-SHA512: 63c6233b6f0942c81ba1ca67ea6770809b8c9409314c6d4cf8e5a3991cb9ee92b22bebe88c0dde45cd71e754eb351230c4c404b70ff118f5f43c034452ada65c
2018-08-09 18:09:27 +02:00
from test_framework . blocktools import create_coinbase , create_block , create_transaction
Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
68400d8b96 tests: Use explicit imports (practicalswift)
Pull request description:
Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools.
An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports.
Before this commit:
```
$ contrib/devtools/lint-python.sh | head -10
./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
$
```
After this commit:
```
$ contrib/devtools/lint-python.sh | head -10
$
```
Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
2018-08-13 14:24:43 +02:00
from test_framework . messages import CTransaction , msg_block , ToHex
2018-09-08 06:56:51 +02:00
from test_framework . mininode import P2PInterface
2019-09-08 18:07:07 +02:00
from test_framework . script import CScript , OP_1NEGATE , OP_CHECKLOCKTIMEVERIFY , OP_DROP , CScriptNum
Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
68400d8b96 tests: Use explicit imports (practicalswift)
Pull request description:
Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools.
An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports.
Before this commit:
```
$ contrib/devtools/lint-python.sh | head -10
./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
$
```
After this commit:
```
$ contrib/devtools/lint-python.sh | head -10
$
```
Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
2018-08-13 14:24:43 +02:00
from test_framework . test_framework import BitcoinTestFramework
2018-09-08 06:56:51 +02:00
from test_framework . util import (
assert_equal ,
assert_raises_rpc_error ,
hex_str_to_bytes ,
)
Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
68400d8b96 tests: Use explicit imports (practicalswift)
Pull request description:
Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools.
An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports.
Before this commit:
```
$ contrib/devtools/lint-python.sh | head -10
./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
$
```
After this commit:
```
$ contrib/devtools/lint-python.sh | head -10
$
```
Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
2018-08-13 14:24:43 +02:00
2016-03-19 21:36:32 +01:00
from io import BytesIO
2015-06-28 20:42:17 +02:00
2019-09-08 18:07:07 +02:00
CLTV_HEIGHT = 1351
2015-06-28 20:42:17 +02:00
def cltv_invalidate ( tx ) :
''' Modify the signature in vin 0 of the tx to fail CLTV
Prepends - 1 CLTV DROP in the scriptSig itself .
2019-09-08 18:07:07 +02:00
TODO : test more ways that transactions using CLTV could be invalid ( eg
locktime requirements fail , sequence time requirements fail , etc ) .
2015-06-28 20:42:17 +02:00
'''
2015-12-14 20:21:34 +01:00
tx . vin [ 0 ] . scriptSig = CScript ( [ OP_1NEGATE , OP_CHECKLOCKTIMEVERIFY , OP_DROP ] +
2015-06-28 20:42:17 +02:00
list ( CScript ( tx . vin [ 0 ] . scriptSig ) ) )
2019-09-08 18:07:07 +02:00
def cltv_validate ( node , tx , height ) :
''' Modify the signature in vin 0 of the tx to pass CLTV
Prepends < height > CLTV DROP in the scriptSig , and sets
the locktime to height '''
tx . vin [ 0 ] . nSequence = 0
tx . nLockTime = height
# Need to re-sign, since nSequence and nLockTime changed
2018-02-20 03:29:22 +01:00
signed_result = node . signrawtransactionwithwallet ( ToHex ( tx ) )
2019-09-08 18:07:07 +02:00
new_tx = CTransaction ( )
new_tx . deserialize ( BytesIO ( hex_str_to_bytes ( signed_result [ ' hex ' ] ) ) )
new_tx . vin [ 0 ] . scriptSig = CScript ( [ CScriptNum ( height ) , OP_CHECKLOCKTIMEVERIFY , OP_DROP ] +
list ( CScript ( new_tx . vin [ 0 ] . scriptSig ) ) )
return new_tx
2018-09-08 06:56:51 +02:00
2019-09-08 18:07:07 +02:00
class BIP65Test ( BitcoinTestFramework ) :
2017-09-01 18:47:13 +02:00
def set_test_params ( self ) :
2015-06-28 20:42:17 +02:00
self . num_nodes = 1
2019-07-16 22:07:14 +02:00
self . extra_args = [ [
2020-02-28 05:18:57 +01:00
' -whitelist=noban@127.0.0.1 ' ,
2019-07-16 22:07:14 +02:00
' -dip3params=9000:9000 ' ,
' -par=1 ' , # Use only one script thread to get the exact reject reason for testing
' -acceptnonstdtxn=1 ' , # cltv_invalidate is nonstandard
] ]
2019-09-08 18:07:07 +02:00
self . setup_clean_chain = True
2019-03-01 15:04:33 +01:00
self . rpc_timeout = 120
2015-06-28 20:42:17 +02:00
2019-07-03 18:11:39 +02:00
def test_cltv_info ( self , * , is_active ) :
assert_equal (
next ( s for s in self . nodes [ 0 ] . getblockchaininfo ( ) [ ' softforks ' ] if s [ ' id ' ] == ' bip65 ' ) ,
{
" id " : " bip65 " ,
" version " : 4 ,
" reject " : {
" status " : is_active
}
} ,
)
2018-09-13 12:33:15 +02:00
def skip_test_if_missing_module ( self ) :
self . skip_if_no_wallet ( )
2015-06-28 20:42:17 +02:00
def run_test ( self ) :
2017-11-30 23:58:58 +01:00
self . nodes [ 0 ] . add_p2p_connection ( P2PInterface ( ) )
2019-09-08 18:07:07 +02:00
2019-07-03 18:11:39 +02:00
self . test_cltv_info ( is_active = False )
2019-09-08 18:07:07 +02:00
self . log . info ( " Mining %d blocks " , CLTV_HEIGHT - 2 )
Merge #13669: Tests: Cleanup create_transaction implementations
44bbceeef1 [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput object (Conor Scott)
736f941424 [Tests] Cleanup extra instances of create_transaction (Conor Scott)
157651855f [Tests] Rename create_tx and move to blocktools.py (Conor Scott)
Pull request description:
There currently exist seven ([1](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_cltv.py#L52-L60), [2](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_csv_activation.py#L88-L95) [3](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_dersig.py#L40-L48), [4](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_nulldummy.py#L100-L108), [5](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/util.py#L529-L535), [6](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/blocktools.py#L120-L129), [7](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_block.py#L1218-L1220)) implementations of a function called something similar to `create_transaction` in the functional tests, some of which are exact copies of each other.
This PR aims to clean this up into [three different cases implemented in blocktools.py](https://github.com/conscott/bitcoin/blob/create_tx_cleanup/test/functional/test_framework/blocktools.py#L121-L149)
1. `create_tx_with_script`: Return transaction object spending generic tx output optionally specifying scriptSig and scriptPubKey
2. `create_transaction`: Return transaction object spending coinbase tx
2. `create_raw_transaction`: Return raw transaction (hex string) spending coinbase tx
I am not committed to any of these function names, so I'll gladly take suggestions on there.
Additionally there are some related cleanups to feature_block.py tests, specifically removing the [PreviousSpendableOutput](https://github.com/conscott/bitcoin/blob/master/test/functional/feature_block.py#L51-L54) object, which seems like an unnecessary layer given that every instance spends the 0 output.
Tree-SHA512: 63c6233b6f0942c81ba1ca67ea6770809b8c9409314c6d4cf8e5a3991cb9ee92b22bebe88c0dde45cd71e754eb351230c4c404b70ff118f5f43c034452ada65c
2018-08-09 18:09:27 +02:00
self . coinbase_txids = [ self . nodes [ 0 ] . getblock ( b ) [ ' tx ' ] [ 0 ] for b in self . nodes [ 0 ] . generate ( CLTV_HEIGHT - 2 ) ]
2015-06-28 20:42:17 +02:00
self . nodeaddress = self . nodes [ 0 ] . getnewaddress ( )
2019-09-08 18:07:07 +02:00
self . log . info ( " Test that an invalid-according-to-CLTV transaction can still appear in a block " )
Merge #13669: Tests: Cleanup create_transaction implementations
44bbceeef1 [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput object (Conor Scott)
736f941424 [Tests] Cleanup extra instances of create_transaction (Conor Scott)
157651855f [Tests] Rename create_tx and move to blocktools.py (Conor Scott)
Pull request description:
There currently exist seven ([1](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_cltv.py#L52-L60), [2](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_csv_activation.py#L88-L95) [3](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_dersig.py#L40-L48), [4](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_nulldummy.py#L100-L108), [5](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/util.py#L529-L535), [6](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/blocktools.py#L120-L129), [7](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_block.py#L1218-L1220)) implementations of a function called something similar to `create_transaction` in the functional tests, some of which are exact copies of each other.
This PR aims to clean this up into [three different cases implemented in blocktools.py](https://github.com/conscott/bitcoin/blob/create_tx_cleanup/test/functional/test_framework/blocktools.py#L121-L149)
1. `create_tx_with_script`: Return transaction object spending generic tx output optionally specifying scriptSig and scriptPubKey
2. `create_transaction`: Return transaction object spending coinbase tx
2. `create_raw_transaction`: Return raw transaction (hex string) spending coinbase tx
I am not committed to any of these function names, so I'll gladly take suggestions on there.
Additionally there are some related cleanups to feature_block.py tests, specifically removing the [PreviousSpendableOutput](https://github.com/conscott/bitcoin/blob/master/test/functional/feature_block.py#L51-L54) object, which seems like an unnecessary layer given that every instance spends the 0 output.
Tree-SHA512: 63c6233b6f0942c81ba1ca67ea6770809b8c9409314c6d4cf8e5a3991cb9ee92b22bebe88c0dde45cd71e754eb351230c4c404b70ff118f5f43c034452ada65c
2018-08-09 18:09:27 +02:00
spendtx = create_transaction ( self . nodes [ 0 ] , self . coinbase_txids [ 0 ] ,
2018-08-13 13:29:32 +02:00
self . nodeaddress , amount = 1.0 )
2015-06-28 20:42:17 +02:00
cltv_invalidate ( spendtx )
spendtx . rehash ( )
2019-09-08 18:07:07 +02:00
tip = self . nodes [ 0 ] . getbestblockhash ( )
block_time = self . nodes [ 0 ] . getblockheader ( tip ) [ ' mediantime ' ] + 1
block = create_block ( int ( tip , 16 ) , create_coinbase ( CLTV_HEIGHT - 1 ) , block_time )
block . nVersion = 3
2015-06-28 20:42:17 +02:00
block . vtx . append ( spendtx )
block . hashMerkleRoot = block . calc_merkle_root ( )
block . solve ( )
2019-07-03 18:11:39 +02:00
self . test_cltv_info ( is_active = False )
2017-11-08 19:10:43 +01:00
self . nodes [ 0 ] . p2p . send_and_ping ( msg_block ( block ) )
2019-07-03 18:11:39 +02:00
self . test_cltv_info ( is_active = False ) # Not active as of current tip, but next block must obey rules
2019-09-08 18:07:07 +02:00
assert_equal ( self . nodes [ 0 ] . getbestblockhash ( ) , block . hash )
self . log . info ( " Test that blocks must now be at least version 4 " )
tip = block . sha256
block_time + = 1
block = create_block ( tip , create_coinbase ( CLTV_HEIGHT ) , block_time )
2015-06-28 20:42:17 +02:00
block . nVersion = 3
block . solve ( )
2018-09-08 06:56:51 +02:00
with self . nodes [ 0 ] . assert_debug_log ( expected_msgs = [ ' {} , bad-version(0x00000003) ' . format ( block . hash ) ] ) :
self . nodes [ 0 ] . p2p . send_and_ping ( msg_block ( block ) )
assert_equal ( int ( self . nodes [ 0 ] . getbestblockhash ( ) , 16 ) , tip )
self . nodes [ 0 ] . p2p . sync_with_ping ( )
2019-09-08 18:07:07 +02:00
self . log . info ( " Test that invalid-according-to-cltv transactions cannot appear in a block " )
2015-06-28 20:42:17 +02:00
block . nVersion = 4
2019-09-08 18:07:07 +02:00
Merge #13669: Tests: Cleanup create_transaction implementations
44bbceeef1 [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput object (Conor Scott)
736f941424 [Tests] Cleanup extra instances of create_transaction (Conor Scott)
157651855f [Tests] Rename create_tx and move to blocktools.py (Conor Scott)
Pull request description:
There currently exist seven ([1](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_cltv.py#L52-L60), [2](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_csv_activation.py#L88-L95) [3](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_dersig.py#L40-L48), [4](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_nulldummy.py#L100-L108), [5](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/util.py#L529-L535), [6](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/blocktools.py#L120-L129), [7](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_block.py#L1218-L1220)) implementations of a function called something similar to `create_transaction` in the functional tests, some of which are exact copies of each other.
This PR aims to clean this up into [three different cases implemented in blocktools.py](https://github.com/conscott/bitcoin/blob/create_tx_cleanup/test/functional/test_framework/blocktools.py#L121-L149)
1. `create_tx_with_script`: Return transaction object spending generic tx output optionally specifying scriptSig and scriptPubKey
2. `create_transaction`: Return transaction object spending coinbase tx
2. `create_raw_transaction`: Return raw transaction (hex string) spending coinbase tx
I am not committed to any of these function names, so I'll gladly take suggestions on there.
Additionally there are some related cleanups to feature_block.py tests, specifically removing the [PreviousSpendableOutput](https://github.com/conscott/bitcoin/blob/master/test/functional/feature_block.py#L51-L54) object, which seems like an unnecessary layer given that every instance spends the 0 output.
Tree-SHA512: 63c6233b6f0942c81ba1ca67ea6770809b8c9409314c6d4cf8e5a3991cb9ee92b22bebe88c0dde45cd71e754eb351230c4c404b70ff118f5f43c034452ada65c
2018-08-09 18:09:27 +02:00
spendtx = create_transaction ( self . nodes [ 0 ] , self . coinbase_txids [ 1 ] ,
2018-08-13 13:29:32 +02:00
self . nodeaddress , amount = 1.0 )
2016-08-04 11:55:25 +02:00
cltv_invalidate ( spendtx )
spendtx . rehash ( )
2019-09-08 18:07:07 +02:00
# First we show that this tx is valid except for CLTV by getting it
2018-08-07 15:33:02 +02:00
# rejected from the mempool for exactly that reason.
2021-12-12 07:27:44 +01:00
assert_raises_rpc_error ( - 26 , ' non-mandatory-script-verify-flag (Negative locktime) (code 64) ' , self . nodes [ 0 ] . sendrawtransaction , spendtx . serialize ( ) . hex ( ) , 0 )
2019-09-08 18:07:07 +02:00
2018-08-07 15:33:02 +02:00
# Now we verify that a block with this transaction is also invalid.
2016-08-04 11:55:25 +02:00
block . vtx . append ( spendtx )
block . hashMerkleRoot = block . calc_merkle_root ( )
block . solve ( )
2018-09-08 06:56:51 +02:00
with self . nodes [ 0 ] . assert_debug_log ( expected_msgs = [ ' CheckInputs on {} failed with non-mandatory-script-verify-flag (Negative locktime) ' . format ( block . vtx [ - 1 ] . hash ) ] ) :
self . nodes [ 0 ] . p2p . send_and_ping ( msg_block ( block ) )
assert_equal ( int ( self . nodes [ 0 ] . getbestblockhash ( ) , 16 ) , tip )
self . nodes [ 0 ] . p2p . sync_with_ping ( )
2019-09-08 18:07:07 +02:00
self . log . info ( " Test that a version 4 block with a valid-according-to-CLTV transaction is accepted " )
spendtx = cltv_validate ( self . nodes [ 0 ] , spendtx , CLTV_HEIGHT - 1 )
spendtx . rehash ( )
block . vtx . pop ( 1 )
block . vtx . append ( spendtx )
block . hashMerkleRoot = block . calc_merkle_root ( )
2015-06-28 20:42:17 +02:00
block . solve ( )
2019-09-08 18:07:07 +02:00
2019-07-03 18:11:39 +02:00
self . test_cltv_info ( is_active = False ) # Not active as of current tip, but next block must obey rules
2017-11-08 19:10:43 +01:00
self . nodes [ 0 ] . p2p . send_and_ping ( msg_block ( block ) )
2019-07-03 18:11:39 +02:00
self . test_cltv_info ( is_active = True ) # Active as of current tip
2019-09-08 18:07:07 +02:00
assert_equal ( int ( self . nodes [ 0 ] . getbestblockhash ( ) , 16 ) , block . sha256 )
2015-06-28 20:42:17 +02:00
if __name__ == ' __main__ ' :
BIP65Test ( ) . main ( )