2016-05-06 11:23:48 +02:00
|
|
|
#!/usr/bin/env python3
|
2020-12-31 18:50:11 +01:00
|
|
|
# Copyright (c) 2014-2020 The Bitcoin Core developers
|
2014-12-02 17:44:50 +01:00
|
|
|
# Distributed under the MIT software license, see the accompanying
|
|
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
2019-01-07 10:55:35 +01:00
|
|
|
"""Test spending coinbase transactions.
|
2014-12-02 17:44:50 +01:00
|
|
|
|
2019-01-07 10:55:35 +01:00
|
|
|
The coinbase transaction in block N can appear in block
|
|
|
|
N+100... so is valid in the mempool when the best block
|
|
|
|
height is N+99.
|
|
|
|
This test makes sure coinbase spends that will be mature
|
|
|
|
in the next block are accepted into the memory pool,
|
|
|
|
but less mature coinbase spends are NOT.
|
|
|
|
"""
|
2014-12-02 17:44:50 +01:00
|
|
|
|
2015-05-02 12:53:35 +02:00
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
68400d8b96 tests: Use explicit imports (practicalswift)
Pull request description:
Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools.
An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports.
Before this commit:
```
$ contrib/devtools/lint-python.sh | head -10
./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
$
```
After this commit:
```
$ contrib/devtools/lint-python.sh | head -10
$
```
Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
2018-08-13 14:24:43 +02:00
|
|
|
from test_framework.util import assert_equal, assert_raises_rpc_error
|
2020-11-19 16:39:56 +01:00
|
|
|
from test_framework.wallet import MiniWallet
|
2014-12-02 17:44:50 +01:00
|
|
|
|
2018-08-11 12:45:29 +02:00
|
|
|
|
2014-12-02 17:44:50 +01:00
|
|
|
class MempoolSpendCoinbaseTest(BitcoinTestFramework):
|
2017-09-01 18:47:13 +02:00
|
|
|
def set_test_params(self):
|
2016-05-20 15:16:51 +02:00
|
|
|
self.num_nodes = 1
|
2018-09-13 12:33:15 +02:00
|
|
|
|
2014-12-02 17:44:50 +01:00
|
|
|
def run_test(self):
|
2020-11-19 16:39:56 +01:00
|
|
|
wallet = MiniWallet(self.nodes[0])
|
|
|
|
|
2024-07-23 19:39:21 +02:00
|
|
|
# Invalidate two blocks, so that miniwallet has access to a coin that will mature in the next block
|
|
|
|
chain_height = 198
|
|
|
|
self.nodes[0].invalidateblock(self.nodes[0].getblockhash(chain_height + 1))
|
|
|
|
assert_equal(chain_height, self.nodes[0].getblockcount())
|
2014-12-02 17:44:50 +01:00
|
|
|
|
|
|
|
# Coinbase at height chain_height-100+1 ok in mempool, should
|
|
|
|
# get mined. Coinbase at height chain_height-100+2 is
|
2020-11-19 16:39:56 +01:00
|
|
|
# too immature to spend.
|
2024-07-23 19:39:21 +02:00
|
|
|
wallet.scan_blocks(start=chain_height - 100 + 1, num=1)
|
|
|
|
utxo_mature = wallet.get_utxo()
|
|
|
|
wallet.scan_blocks(start=chain_height - 100 + 2, num=1)
|
|
|
|
utxo_immature = wallet.get_utxo()
|
2014-12-02 17:44:50 +01:00
|
|
|
|
2024-07-23 19:39:21 +02:00
|
|
|
spend_mature_id = wallet.send_self_transfer(from_node=self.nodes[0], utxo_to_spend=utxo_mature)["txid"]
|
2014-12-02 17:44:50 +01:00
|
|
|
|
2024-07-23 19:39:21 +02:00
|
|
|
# other coinbase should be too immature to spend
|
|
|
|
immature_tx = wallet.create_self_transfer(from_node=self.nodes[0], utxo_to_spend=utxo_immature, mempool_valid=False)
|
2020-11-19 16:39:56 +01:00
|
|
|
assert_raises_rpc_error(-26,
|
|
|
|
"bad-txns-premature-spend-of-coinbase",
|
2024-07-23 19:39:21 +02:00
|
|
|
lambda: self.nodes[0].sendrawtransaction(immature_tx['hex']))
|
2014-12-02 17:44:50 +01:00
|
|
|
|
2024-07-23 19:39:21 +02:00
|
|
|
# mempool should have just the mature one
|
|
|
|
assert_equal(self.nodes[0].getrawmempool(), [spend_mature_id])
|
2014-12-02 17:44:50 +01:00
|
|
|
|
2024-07-23 19:39:21 +02:00
|
|
|
# mine a block, mature one should get confirmed
|
2015-04-01 05:28:28 +02:00
|
|
|
self.nodes[0].generate(1)
|
2014-12-02 17:44:50 +01:00
|
|
|
assert_equal(set(self.nodes[0].getrawmempool()), set())
|
|
|
|
|
2024-07-23 19:39:21 +02:00
|
|
|
# ... and now previously immature can be spent:
|
|
|
|
spend_new_id = self.nodes[0].sendrawtransaction(immature_tx['hex'])
|
|
|
|
assert_equal(self.nodes[0].getrawmempool(), [spend_new_id])
|
2020-11-19 16:39:56 +01:00
|
|
|
|
2014-12-02 17:44:50 +01:00
|
|
|
|
|
|
|
if __name__ == '__main__':
|
|
|
|
MempoolSpendCoinbaseTest().main()
|