2016-05-06 11:23:48 +02:00
#!/usr/bin/env python3
# Copyright (c) 2015-2016 The Bitcoin Core developers
2015-11-19 02:55:52 +01:00
# Distributed under the MIT software license, see the accompanying
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
2019-01-07 10:55:35 +01:00
""" Test the prioritisetransaction mining RPC. """
2015-11-19 02:55:52 +01:00
Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
68400d8b96 tests: Use explicit imports (practicalswift)
Pull request description:
Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools.
An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports.
Before this commit:
```
$ contrib/devtools/lint-python.sh | head -10
./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
$
```
After this commit:
```
$ contrib/devtools/lint-python.sh | head -10
$
```
Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
2018-08-13 14:24:43 +02:00
from test_framework . messages import COIN , MAX_BLOCK_SIZE
2015-11-19 02:55:52 +01:00
from test_framework . test_framework import BitcoinTestFramework
Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
68400d8b96 tests: Use explicit imports (practicalswift)
Pull request description:
Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools.
An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports.
Before this commit:
```
$ contrib/devtools/lint-python.sh | head -10
./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
$
```
After this commit:
```
$ contrib/devtools/lint-python.sh | head -10
$
```
Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
2018-08-13 14:24:43 +02:00
from test_framework . util import assert_equal , assert_raises_rpc_error , create_confirmed_utxos , create_lots_of_big_transactions , gen_return_txouts
2015-11-19 02:55:52 +01:00
class PrioritiseTransactionTest ( BitcoinTestFramework ) :
2017-09-01 18:47:13 +02:00
def set_test_params ( self ) :
2016-05-20 15:16:51 +02:00
self . setup_clean_chain = True
2017-05-17 22:17:28 +02:00
self . num_nodes = 2
2019-07-16 22:07:14 +02:00
self . extra_args = [ [
" -printpriority=1 " ,
" -acceptnonstdtxn=1 " ,
] ] * self . num_nodes
2019-12-09 19:52:38 +01:00
self . supports_cli = False
2015-11-19 02:55:52 +01:00
2018-09-13 12:33:15 +02:00
def skip_test_if_missing_module ( self ) :
self . skip_if_no_wallet ( )
2017-05-02 20:02:55 +02:00
def run_test ( self ) :
2018-01-06 13:28:20 +01:00
# Test `prioritisetransaction` required parameters
assert_raises_rpc_error ( - 1 , " prioritisetransaction " , self . nodes [ 0 ] . prioritisetransaction )
assert_raises_rpc_error ( - 1 , " prioritisetransaction " , self . nodes [ 0 ] . prioritisetransaction , ' ' )
# Test `prioritisetransaction` invalid extra parameters
2020-02-29 20:46:55 +01:00
assert_raises_rpc_error ( - 1 , " prioritisetransaction " , self . nodes [ 0 ] . prioritisetransaction , ' ' , 0 , 0 )
2018-01-06 13:28:20 +01:00
# Test `prioritisetransaction` invalid `txid`
2018-09-24 20:54:10 +02:00
assert_raises_rpc_error ( - 8 , " txid must be of length 64 (not 3, for ' foo ' ) " , self . nodes [ 0 ] . prioritisetransaction , txid = ' foo ' , fee_delta = 0 )
2018-09-27 17:26:17 +02:00
assert_raises_rpc_error ( - 8 , " txid must be hexadecimal string (not ' Zd1d4e24ed99057e84c3f80fd8fbec79ed9e1acee37da269356ecea000000000 ' ) " , self . nodes [ 0 ] . prioritisetransaction , txid = ' Zd1d4e24ed99057e84c3f80fd8fbec79ed9e1acee37da269356ecea000000000 ' , fee_delta = 0 )
2018-01-06 13:28:20 +01:00
txid = ' 1d1d4e24ed99057e84c3f80fd8fbec79ed9e1acee37da269356ecea000000000 '
# Test `prioritisetransaction` invalid `fee_delta`
assert_raises_rpc_error ( - 1 , " JSON value is not an integer as expected " , self . nodes [ 0 ] . prioritisetransaction , txid = txid , fee_delta = ' foo ' )
2016-05-20 15:16:51 +02:00
self . txouts = gen_return_txouts ( )
2015-11-19 02:55:52 +01:00
self . relayfee = self . nodes [ 0 ] . getnetworkinfo ( ) [ ' relayfee ' ]
2016-03-01 15:28:16 +01:00
utxo_count = 90
2024-09-26 21:13:22 +02:00
utxos = create_confirmed_utxos ( self , self . relayfee , self . nodes [ 0 ] , utxo_count )
2015-11-19 02:55:52 +01:00
base_fee = self . relayfee * 100 # our transactions are smaller than 100kb
txids = [ ]
# Create 3 batches of transactions at 3 different fee rate levels
2016-03-01 15:28:16 +01:00
range_size = utxo_count / / 3
2016-05-06 11:23:48 +02:00
for i in range ( 3 ) :
2015-11-19 02:55:52 +01:00
txids . append ( [ ] )
2016-03-01 15:28:16 +01:00
start_range = i * range_size
end_range = start_range + range_size
2016-12-06 12:05:31 +01:00
txids [ i ] = create_lots_of_big_transactions ( self . nodes [ 0 ] , self . txouts , utxos [ start_range : end_range ] , end_range - start_range , ( i + 1 ) * base_fee )
2016-03-01 15:28:16 +01:00
# Make sure that the size of each group of transactions exceeds
# MAX_BLOCK_SIZE -- otherwise the test needs to be revised to create
# more transactions.
mempool = self . nodes [ 0 ] . getrawmempool ( True )
sizes = [ 0 , 0 , 0 ]
2016-05-06 11:23:48 +02:00
for i in range ( 3 ) :
2016-03-01 15:28:16 +01:00
for j in txids [ i ] :
2021-08-27 21:03:02 +02:00
assert j in mempool
2019-03-26 17:56:08 +01:00
sizes [ i ] + = mempool [ j ] [ ' vsize ' ]
2021-08-27 21:03:02 +02:00
assert sizes [ i ] > MAX_BLOCK_SIZE # Fail => raise utxo_count
2015-11-19 02:55:52 +01:00
# add a fee delta to something in the cheapest bucket and make sure it gets mined
2019-03-14 15:44:42 +01:00
# also check that a different entry in the cheapest bucket is NOT mined
self . nodes [ 0 ] . prioritisetransaction ( txids [ 0 ] [ 0 ] , int ( 3 * base_fee * COIN ) )
2015-11-19 02:55:52 +01:00
2024-10-01 21:25:52 +02:00
self . generate ( self . nodes [ 0 ] , 1 )
2015-11-19 02:55:52 +01:00
mempool = self . nodes [ 0 ] . getrawmempool ( )
2017-03-09 21:16:20 +01:00
self . log . info ( " Assert that prioritised transaction was mined " )
2021-08-27 21:03:02 +02:00
assert txids [ 0 ] [ 0 ] not in mempool
assert txids [ 0 ] [ 1 ] in mempool
2015-11-19 02:55:52 +01:00
high_fee_tx = None
for x in txids [ 2 ] :
if x not in mempool :
high_fee_tx = x
# Something high-fee should have been mined!
2018-12-13 12:57:41 +01:00
assert high_fee_tx is not None
2015-11-19 02:55:52 +01:00
# Add a prioritisation before a tx is in the mempool (de-prioritising a
2016-03-01 15:28:16 +01:00
# high-fee transaction so that it's now low fee).
2019-03-14 15:44:42 +01:00
self . nodes [ 0 ] . prioritisetransaction ( high_fee_tx , - int ( 2 * base_fee * COIN ) )
2015-11-19 02:55:52 +01:00
# Add everything back to mempool
self . nodes [ 0 ] . invalidateblock ( self . nodes [ 0 ] . getbestblockhash ( ) )
# Check to make sure our high fee rate tx is back in the mempool
mempool = self . nodes [ 0 ] . getrawmempool ( )
2021-08-27 21:03:02 +02:00
assert high_fee_tx in mempool
2015-11-19 02:55:52 +01:00
2016-03-01 15:28:16 +01:00
# Now verify the modified-high feerate transaction isn't mined before
# the other high fee transactions. Keep mining until our mempool has
# decreased by all the high fee size that we calculated above.
while ( self . nodes [ 0 ] . getmempoolinfo ( ) [ ' bytes ' ] > sizes [ 0 ] + sizes [ 1 ] ) :
2024-09-26 21:17:04 +02:00
self . generate ( self . nodes [ 0 ] , 1 , sync_fun = self . no_op )
2015-11-19 02:55:52 +01:00
# High fee transaction should not have been mined, but other high fee rate
# transactions should have been.
mempool = self . nodes [ 0 ] . getrawmempool ( )
2017-03-09 21:16:20 +01:00
self . log . info ( " Assert that de-prioritised transaction is still in mempool " )
2021-08-27 21:03:02 +02:00
assert high_fee_tx in mempool
2015-11-19 02:55:52 +01:00
for x in txids [ 2 ] :
if ( x != high_fee_tx ) :
2021-08-27 21:03:02 +02:00
assert x not in mempool
2015-11-19 02:55:52 +01:00
2019-03-14 15:44:42 +01:00
# Create a free transaction. Should be rejected.
2015-11-19 17:18:28 +01:00
utxo_list = self . nodes [ 0 ] . listunspent ( )
2021-08-27 21:03:02 +02:00
assert len ( utxo_list ) > 0
2015-11-19 17:18:28 +01:00
utxo = utxo_list [ 0 ]
inputs = [ ]
outputs = { }
inputs . append ( { " txid " : utxo [ " txid " ] , " vout " : utxo [ " vout " ] } )
2019-03-14 15:44:42 +01:00
outputs [ self . nodes [ 0 ] . getnewaddress ( ) ] = utxo [ " amount " ]
2015-11-19 17:18:28 +01:00
raw_tx = self . nodes [ 0 ] . createrawtransaction ( inputs , outputs )
2018-02-20 03:29:22 +01:00
tx_hex = self . nodes [ 0 ] . signrawtransactionwithwallet ( raw_tx ) [ " hex " ]
2019-03-14 15:44:42 +01:00
tx_id = self . nodes [ 0 ] . decoderawtransaction ( tx_hex ) [ " txid " ]
2015-11-19 17:18:28 +01:00
2017-03-16 11:57:09 +01:00
# This will raise an exception due to min relay fee not being met
2018-04-26 03:39:29 +02:00
assert_raises_rpc_error ( - 26 , " min relay fee not met " , self . nodes [ 0 ] . sendrawtransaction , tx_hex )
2021-08-27 21:03:02 +02:00
assert tx_id not in self . nodes [ 0 ] . getrawmempool ( )
2015-11-19 17:18:28 +01:00
# This is a less than 1000-byte transaction, so just set the fee
2018-03-21 16:16:28 +01:00
# to be the minimum for a 1000-byte transaction and check that it is
2015-11-19 17:18:28 +01:00
# accepted.
2019-03-14 15:44:42 +01:00
self . nodes [ 0 ] . prioritisetransaction ( tx_id , int ( self . relayfee * COIN ) )
2015-11-19 17:18:28 +01:00
2017-03-09 21:16:20 +01:00
self . log . info ( " Assert that prioritised free transaction is accepted to mempool " )
2019-03-14 15:44:42 +01:00
assert_equal ( self . nodes [ 0 ] . sendrawtransaction ( tx_hex ) , tx_id )
2021-08-27 21:03:02 +02:00
assert tx_id in self . nodes [ 0 ] . getrawmempool ( )
2015-11-19 17:18:28 +01:00
2017-05-17 22:17:28 +02:00
# Test that calling prioritisetransaction is sufficient to trigger
# getblocktemplate to (eventually) return a new block.
2019-08-09 01:14:11 +02:00
self . nodes [ 0 ] . setmocktime ( self . mocktime )
2017-05-17 22:17:28 +02:00
template = self . nodes [ 0 ] . getblocktemplate ( )
2019-03-15 07:18:16 +01:00
self . nodes [ 0 ] . prioritisetransaction ( tx_id , - int ( self . relayfee * COIN ) )
2019-08-09 01:14:11 +02:00
self . nodes [ 0 ] . setmocktime ( self . mocktime + 10 )
2017-05-17 22:17:28 +02:00
new_template = self . nodes [ 0 ] . getblocktemplate ( )
2021-08-27 21:03:02 +02:00
assert template != new_template
2017-05-17 22:17:28 +02:00
2015-11-19 02:55:52 +01:00
if __name__ == ' __main__ ' :
PrioritiseTransactionTest ( ) . main ( )