2016-05-06 11:23:48 +02:00
|
|
|
#!/usr/bin/env python3
|
|
|
|
# Copyright (c) 2015-2016 The Bitcoin Core developers
|
|
|
|
# Distributed under the MIT software license, see the accompanying
|
2015-04-28 18:39:47 +02:00
|
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
2019-01-07 10:55:35 +01:00
|
|
|
"""Test node responses to invalid blocks.
|
2015-04-28 18:39:47 +02:00
|
|
|
|
|
|
|
In this test we connect to one node over p2p, and test block requests:
|
|
|
|
1) Valid blocks should be requested and become chain tip.
|
|
|
|
2) Invalid block with duplicated transaction should be re-requested.
|
|
|
|
3) Invalid block with bad coinbase value should be rejected and not
|
|
|
|
re-requested.
|
2019-01-07 10:55:35 +01:00
|
|
|
"""
|
|
|
|
import copy
|
2015-04-28 18:39:47 +02:00
|
|
|
|
Merge #13669: Tests: Cleanup create_transaction implementations
44bbceeef1 [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput object (Conor Scott)
736f941424 [Tests] Cleanup extra instances of create_transaction (Conor Scott)
157651855f [Tests] Rename create_tx and move to blocktools.py (Conor Scott)
Pull request description:
There currently exist seven ([1](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_cltv.py#L52-L60), [2](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_csv_activation.py#L88-L95) [3](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_dersig.py#L40-L48), [4](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_nulldummy.py#L100-L108), [5](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/util.py#L529-L535), [6](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/blocktools.py#L120-L129), [7](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_block.py#L1218-L1220)) implementations of a function called something similar to `create_transaction` in the functional tests, some of which are exact copies of each other.
This PR aims to clean this up into [three different cases implemented in blocktools.py](https://github.com/conscott/bitcoin/blob/create_tx_cleanup/test/functional/test_framework/blocktools.py#L121-L149)
1. `create_tx_with_script`: Return transaction object spending generic tx output optionally specifying scriptSig and scriptPubKey
2. `create_transaction`: Return transaction object spending coinbase tx
2. `create_raw_transaction`: Return raw transaction (hex string) spending coinbase tx
I am not committed to any of these function names, so I'll gladly take suggestions on there.
Additionally there are some related cleanups to feature_block.py tests, specifically removing the [PreviousSpendableOutput](https://github.com/conscott/bitcoin/blob/master/test/functional/feature_block.py#L51-L54) object, which seems like an unnecessary layer given that every instance spends the 0 output.
Tree-SHA512: 63c6233b6f0942c81ba1ca67ea6770809b8c9409314c6d4cf8e5a3991cb9ee92b22bebe88c0dde45cd71e754eb351230c4c404b70ff118f5f43c034452ada65c
2018-08-09 18:09:27 +02:00
|
|
|
from test_framework.blocktools import create_block, create_coinbase, create_tx_with_script
|
Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
68400d8b96 tests: Use explicit imports (practicalswift)
Pull request description:
Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools.
An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports.
Before this commit:
```
$ contrib/devtools/lint-python.sh | head -10
./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
$
```
After this commit:
```
$ contrib/devtools/lint-python.sh | head -10
$
```
Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
2018-08-13 14:24:43 +02:00
|
|
|
from test_framework.messages import COIN
|
|
|
|
from test_framework.mininode import P2PDataStore
|
2018-03-13 22:09:43 +01:00
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
2019-10-09 18:48:12 +02:00
|
|
|
from test_framework.util import assert_equal
|
2018-03-13 22:09:43 +01:00
|
|
|
|
2015-04-28 18:39:47 +02:00
|
|
|
|
2018-03-13 22:09:43 +01:00
|
|
|
class InvalidBlockRequestTest(BitcoinTestFramework):
|
2017-09-01 18:47:13 +02:00
|
|
|
def set_test_params(self):
|
2015-04-28 18:39:47 +02:00
|
|
|
self.num_nodes = 1
|
2017-09-01 18:47:13 +02:00
|
|
|
self.setup_clean_chain = True
|
2018-03-13 22:09:43 +01:00
|
|
|
self.extra_args = [["-whitelist=127.0.0.1"]]
|
2015-04-28 18:39:47 +02:00
|
|
|
|
|
|
|
def run_test(self):
|
2018-03-13 22:09:43 +01:00
|
|
|
# Add p2p connection to node0
|
|
|
|
node = self.nodes[0] # convenience reference to the node
|
|
|
|
node.add_p2p_connection(P2PDataStore())
|
2015-04-28 18:39:47 +02:00
|
|
|
|
2018-03-13 22:09:43 +01:00
|
|
|
best_block = node.getblock(node.getbestblockhash())
|
|
|
|
tip = int(node.getbestblockhash(), 16)
|
|
|
|
height = best_block["height"] + 1
|
|
|
|
block_time = best_block["time"] + 1
|
|
|
|
|
|
|
|
self.log.info("Create a new block with an anyone-can-spend coinbase")
|
2015-04-28 18:39:47 +02:00
|
|
|
|
2015-08-05 23:47:34 +02:00
|
|
|
height = 1
|
2018-03-13 22:09:43 +01:00
|
|
|
block = create_block(tip, create_coinbase(height), block_time)
|
2015-04-28 18:39:47 +02:00
|
|
|
block.solve()
|
|
|
|
# Save the coinbase for later
|
2018-03-13 22:09:43 +01:00
|
|
|
block1 = block
|
|
|
|
tip = block.sha256
|
2018-08-31 13:07:59 +02:00
|
|
|
node.p2p.send_blocks_and_test([block1], node, success=True)
|
2018-03-13 22:09:43 +01:00
|
|
|
|
|
|
|
self.log.info("Mature the block.")
|
2018-09-17 20:00:41 +02:00
|
|
|
node.generatetoaddress(100, node.get_deterministic_priv_key().address)
|
2018-03-13 22:09:43 +01:00
|
|
|
|
|
|
|
best_block = node.getblock(node.getbestblockhash())
|
|
|
|
tip = int(node.getbestblockhash(), 16)
|
|
|
|
height = best_block["height"] + 1
|
|
|
|
block_time = best_block["time"] + 1
|
|
|
|
|
|
|
|
# Use merkle-root malleability to generate an invalid block with
|
2019-09-18 15:53:36 +02:00
|
|
|
# same blockheader (CVE-2012-2459).
|
2018-03-13 22:09:43 +01:00
|
|
|
# Manufacture a block with 3 transactions (coinbase, spend of prior
|
|
|
|
# coinbase, spend of that spend). Duplicate the 3rd transaction to
|
|
|
|
# leave merkle root and blockheader unchanged but invalidate the block.
|
2019-09-18 15:53:36 +02:00
|
|
|
# For more information on merkle-root malleability see src/consensus/merkle.cpp.
|
2018-03-13 22:09:43 +01:00
|
|
|
self.log.info("Test merkle root malleability.")
|
|
|
|
|
|
|
|
block2 = create_block(tip, create_coinbase(height), block_time)
|
|
|
|
block_time += 1
|
2015-04-28 18:39:47 +02:00
|
|
|
|
2016-04-10 16:54:28 +02:00
|
|
|
# b'0x51' is OP_TRUE
|
Merge #13669: Tests: Cleanup create_transaction implementations
44bbceeef1 [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput object (Conor Scott)
736f941424 [Tests] Cleanup extra instances of create_transaction (Conor Scott)
157651855f [Tests] Rename create_tx and move to blocktools.py (Conor Scott)
Pull request description:
There currently exist seven ([1](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_cltv.py#L52-L60), [2](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_csv_activation.py#L88-L95) [3](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_dersig.py#L40-L48), [4](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_nulldummy.py#L100-L108), [5](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/util.py#L529-L535), [6](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/blocktools.py#L120-L129), [7](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_block.py#L1218-L1220)) implementations of a function called something similar to `create_transaction` in the functional tests, some of which are exact copies of each other.
This PR aims to clean this up into [three different cases implemented in blocktools.py](https://github.com/conscott/bitcoin/blob/create_tx_cleanup/test/functional/test_framework/blocktools.py#L121-L149)
1. `create_tx_with_script`: Return transaction object spending generic tx output optionally specifying scriptSig and scriptPubKey
2. `create_transaction`: Return transaction object spending coinbase tx
2. `create_raw_transaction`: Return raw transaction (hex string) spending coinbase tx
I am not committed to any of these function names, so I'll gladly take suggestions on there.
Additionally there are some related cleanups to feature_block.py tests, specifically removing the [PreviousSpendableOutput](https://github.com/conscott/bitcoin/blob/master/test/functional/feature_block.py#L51-L54) object, which seems like an unnecessary layer given that every instance spends the 0 output.
Tree-SHA512: 63c6233b6f0942c81ba1ca67ea6770809b8c9409314c6d4cf8e5a3991cb9ee92b22bebe88c0dde45cd71e754eb351230c4c404b70ff118f5f43c034452ada65c
2018-08-09 18:09:27 +02:00
|
|
|
tx1 = create_tx_with_script(block1.vtx[0], 0, script_sig=b'\x51', amount=50 * COIN)
|
|
|
|
tx2 = create_tx_with_script(tx1, 0, script_sig=b'\x51', amount=50 * COIN)
|
2015-04-28 18:39:47 +02:00
|
|
|
|
|
|
|
block2.vtx.extend([tx1, tx2])
|
|
|
|
block2.hashMerkleRoot = block2.calc_merkle_root()
|
|
|
|
block2.rehash()
|
|
|
|
block2.solve()
|
|
|
|
orig_hash = block2.sha256
|
|
|
|
block2_orig = copy.deepcopy(block2)
|
|
|
|
|
|
|
|
# Mutate block 2
|
|
|
|
block2.vtx.append(tx2)
|
|
|
|
assert_equal(block2.hashMerkleRoot, block2.calc_merkle_root())
|
|
|
|
assert_equal(orig_hash, block2.rehash())
|
2018-11-13 16:24:49 +01:00
|
|
|
assert block2_orig.vtx != block2.vtx
|
2015-04-28 18:39:47 +02:00
|
|
|
|
2018-09-08 06:56:51 +02:00
|
|
|
node.p2p.send_blocks_and_test([block2], node, success=False, request_block=False, reject_reason='bad-txns-duplicate')
|
2019-09-18 15:53:36 +02:00
|
|
|
# Check transactions for duplicate inputs (CVE-2018-17144)
|
2018-09-18 01:19:45 +02:00
|
|
|
self.log.info("Test duplicate input block.")
|
|
|
|
|
2019-09-18 15:53:36 +02:00
|
|
|
block2_dup = copy.deepcopy(block2_orig)
|
|
|
|
block2_dup.vtx[2].vin.append(block2_dup.vtx[2].vin[0])
|
|
|
|
block2_dup.vtx[2].rehash()
|
|
|
|
block2_dup.hashMerkleRoot = block2_dup.calc_merkle_root()
|
|
|
|
block2_dup.rehash()
|
|
|
|
block2_dup.solve()
|
|
|
|
node.p2p.send_blocks_and_test([block2_dup], node, success=False, reject_reason='bad-txns-inputs-duplicate')
|
2018-09-18 01:19:45 +02:00
|
|
|
|
2018-03-13 22:09:43 +01:00
|
|
|
self.log.info("Test very broken block.")
|
|
|
|
|
|
|
|
block3 = create_block(tip, create_coinbase(height), block_time)
|
|
|
|
block_time += 1
|
|
|
|
block3.vtx[0].vout[0].nValue = 1000 * COIN # Too high!
|
|
|
|
block3.vtx[0].sha256 = None
|
2015-04-28 18:39:47 +02:00
|
|
|
block3.vtx[0].calc_sha256()
|
|
|
|
block3.hashMerkleRoot = block3.calc_merkle_root()
|
|
|
|
block3.rehash()
|
|
|
|
block3.solve()
|
|
|
|
|
2018-09-08 06:56:51 +02:00
|
|
|
node.p2p.send_blocks_and_test([block3], node, success=False, request_block=False, reject_reason='bad-cb-amount')
|
2015-04-28 18:39:47 +02:00
|
|
|
|
2019-09-18 15:53:36 +02:00
|
|
|
# Complete testing of CVE-2012-2459 by sending the original block.
|
|
|
|
# It should be accepted even though it has the same hash as the mutated one.
|
|
|
|
|
|
|
|
self.log.info("Test accepting original block after rejecting its mutated version.")
|
|
|
|
node.p2p.send_blocks_and_test([block2_orig], node, success=True, timeout=5)
|
|
|
|
|
|
|
|
# Update tip info
|
|
|
|
height += 1
|
|
|
|
block_time += 1
|
|
|
|
tip = int(block2_orig.hash, 16)
|
|
|
|
|
|
|
|
# Complete testing of CVE-2018-17144, by checking for the inflation bug.
|
|
|
|
# Create a block that spends the output of a tx in a previous block.
|
|
|
|
block4 = create_block(tip, create_coinbase(height), block_time)
|
|
|
|
tx3 = create_tx_with_script(tx2, 0, script_sig=b'\x51', amount=50 * COIN)
|
|
|
|
|
|
|
|
# Duplicates input
|
|
|
|
tx3.vin.append(tx3.vin[0])
|
|
|
|
tx3.rehash()
|
|
|
|
block4.vtx.append(tx3)
|
|
|
|
block4.hashMerkleRoot = block4.calc_merkle_root()
|
|
|
|
block4.rehash()
|
|
|
|
block4.solve()
|
|
|
|
self.log.info("Test inflation by duplicating input")
|
|
|
|
node.p2p.send_blocks_and_test([block4], node, success=False, reject_reason='bad-txns-inputs-duplicate')
|
|
|
|
|
2015-04-28 18:39:47 +02:00
|
|
|
if __name__ == '__main__':
|
|
|
|
InvalidBlockRequestTest().main()
|