sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-26 12:32:48 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
a2687d4594
dash/.github/PULL_REQUEST_TEMPLATE.md

25 lines
1.0 KiB
Markdown
Raw Normal View History

Merge #16962: doc: Put PR template in comments 203a67d21f566634165531a7a75c3f8c9f9c9d6a doc: Put PR template in comments (Wladimir J. van der Laan) Pull request description: This prevents the common annoyance of the text being included into PRs accidentally. ACKs for top commit: sdaftuar: utACK 203a67d21f566634165531a7a75c3f8c9f9c9d6a fanquake: ACK 203a67d21f566634165531a7a75c3f8c9f9c9d6a - I make an effort to remove it whenever I see it in a PR. Tree-SHA512: 3514d285488b7930d7f3d7f8823198d7325d8b7de57a6d8f13e559c0c23b30d58916b15782cbbdc347a375b418e9d0f7a5b99b34d26f3b957d7d5a03a3d83dfd
2019-09-30 09:48:10 +02:00
<!--
*** Please remove the following help text before submitting: ***
Merge #14217: doc: Add GitHub pr template fae9e84cbb doc: Add GitHub pr template (MarcoFalke) Pull request description: Bitcoin Core has a very thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. Authors should provide clear motivation for patches and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly. Tree-SHA512: 83b379d75934089f13ba173e6ec847845f954f10f83e406ef9722836aa093170c612b4214f22cd5939d59f66a50f5d0e52aa0059423e8e7261bb176f1c546a08
2018-09-28 13:53:47 +02:00
Pull requests without a rationale and clear improvement may be closed
immediately.
Merge #16962: doc: Put PR template in comments 203a67d21f566634165531a7a75c3f8c9f9c9d6a doc: Put PR template in comments (Wladimir J. van der Laan) Pull request description: This prevents the common annoyance of the text being included into PRs accidentally. ACKs for top commit: sdaftuar: utACK 203a67d21f566634165531a7a75c3f8c9f9c9d6a fanquake: ACK 203a67d21f566634165531a7a75c3f8c9f9c9d6a - I make an effort to remove it whenever I see it in a PR. Tree-SHA512: 3514d285488b7930d7f3d7f8823198d7325d8b7de57a6d8f13e559c0c23b30d58916b15782cbbdc347a375b418e9d0f7a5b99b34d26f3b957d7d5a03a3d83dfd
2019-09-30 09:48:10 +02:00
-->
Merge #14217: doc: Add GitHub pr template fae9e84cbb doc: Add GitHub pr template (MarcoFalke) Pull request description: Bitcoin Core has a very thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. Authors should provide clear motivation for patches and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly. Tree-SHA512: 83b379d75934089f13ba173e6ec847845f954f10f83e406ef9722836aa093170c612b4214f22cd5939d59f66a50f5d0e52aa0059423e8e7261bb176f1c546a08
2018-09-28 13:53:47 +02:00
Merge #16962: doc: Put PR template in comments 203a67d21f566634165531a7a75c3f8c9f9c9d6a doc: Put PR template in comments (Wladimir J. van der Laan) Pull request description: This prevents the common annoyance of the text being included into PRs accidentally. ACKs for top commit: sdaftuar: utACK 203a67d21f566634165531a7a75c3f8c9f9c9d6a fanquake: ACK 203a67d21f566634165531a7a75c3f8c9f9c9d6a - I make an effort to remove it whenever I see it in a PR. Tree-SHA512: 3514d285488b7930d7f3d7f8823198d7325d8b7de57a6d8f13e559c0c23b30d58916b15782cbbdc347a375b418e9d0f7a5b99b34d26f3b957d7d5a03a3d83dfd
2019-09-30 09:48:10 +02:00
<!--
Merge #14217: doc: Add GitHub pr template fae9e84cbb doc: Add GitHub pr template (MarcoFalke) Pull request description: Bitcoin Core has a very thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. Authors should provide clear motivation for patches and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly. Tree-SHA512: 83b379d75934089f13ba173e6ec847845f954f10f83e406ef9722836aa093170c612b4214f22cd5939d59f66a50f5d0e52aa0059423e8e7261bb176f1c546a08
2018-09-28 13:53:47 +02:00
Please provide clear motivation for your patch and explain how it improves
Dash Core user experience or Dash Core developer experience
Merge #16962: doc: Put PR template in comments 203a67d21f566634165531a7a75c3f8c9f9c9d6a doc: Put PR template in comments (Wladimir J. van der Laan) Pull request description: This prevents the common annoyance of the text being included into PRs accidentally. ACKs for top commit: sdaftuar: utACK 203a67d21f566634165531a7a75c3f8c9f9c9d6a fanquake: ACK 203a67d21f566634165531a7a75c3f8c9f9c9d6a - I make an effort to remove it whenever I see it in a PR. Tree-SHA512: 3514d285488b7930d7f3d7f8823198d7325d8b7de57a6d8f13e559c0c23b30d58916b15782cbbdc347a375b418e9d0f7a5b99b34d26f3b957d7d5a03a3d83dfd
2019-09-30 09:48:10 +02:00
significantly:
Merge #14217: doc: Add GitHub pr template fae9e84cbb doc: Add GitHub pr template (MarcoFalke) Pull request description: Bitcoin Core has a very thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. Authors should provide clear motivation for patches and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly. Tree-SHA512: 83b379d75934089f13ba173e6ec847845f954f10f83e406ef9722836aa093170c612b4214f22cd5939d59f66a50f5d0e52aa0059423e8e7261bb176f1c546a08
2018-09-28 13:53:47 +02:00
* Any test improvements or new tests that improve coverage are always welcome.
* All other changes should have accompanying unit tests (see `src/test/`) or
functional tests (see `test/`). Contributors should note which tests cover
modified code. If no tests exist for a region of modified code, new tests
should accompany the change.
* Bug fixes are most welcome when they come with steps to reproduce or an
explanation of the potential issue as well as reasoning for the way the bug
was fixed.
* Features are welcome, but might be rejected due to design or scope issues.
If a feature is based on a lot of dependencies, contributors should first
consider building the system outside of Dash Core, if possible.
Merge #16962: doc: Put PR template in comments 203a67d21f566634165531a7a75c3f8c9f9c9d6a doc: Put PR template in comments (Wladimir J. van der Laan) Pull request description: This prevents the common annoyance of the text being included into PRs accidentally. ACKs for top commit: sdaftuar: utACK 203a67d21f566634165531a7a75c3f8c9f9c9d6a fanquake: ACK 203a67d21f566634165531a7a75c3f8c9f9c9d6a - I make an effort to remove it whenever I see it in a PR. Tree-SHA512: 3514d285488b7930d7f3d7f8823198d7325d8b7de57a6d8f13e559c0c23b30d58916b15782cbbdc347a375b418e9d0f7a5b99b34d26f3b957d7d5a03a3d83dfd
2019-09-30 09:48:10 +02:00
-->
Reference in New Issue Copy Permalink