2016-05-06 11:23:48 +02:00
|
|
|
#!/usr/bin/env python3
|
|
|
|
# Copyright (c) 2014-2016 The Bitcoin Core developers
|
2015-03-24 04:56:53 +01:00
|
|
|
# Distributed under the MIT software license, see the accompanying
|
|
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
2019-01-07 10:55:35 +01:00
|
|
|
"""Test the wallet accounts properly when there are cloned transactions with malleated scriptsigs."""
|
2015-03-24 04:56:53 +01:00
|
|
|
|
2019-02-18 15:16:33 +01:00
|
|
|
import io
|
2015-07-02 20:39:44 +02:00
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
2021-04-12 16:58:49 +02:00
|
|
|
from test_framework.util import (
|
|
|
|
assert_equal,
|
|
|
|
connect_nodes,
|
|
|
|
disconnect_nodes,
|
|
|
|
)
|
2019-02-18 15:16:33 +01:00
|
|
|
from test_framework.messages import CTransaction, COIN
|
2015-03-24 04:56:53 +01:00
|
|
|
|
|
|
|
class TxnMallTest(BitcoinTestFramework):
|
2017-09-01 18:47:13 +02:00
|
|
|
def set_test_params(self):
|
2016-05-20 15:16:51 +02:00
|
|
|
self.num_nodes = 4
|
2019-12-09 19:52:38 +01:00
|
|
|
self.supports_cli = False
|
2016-05-20 15:16:51 +02:00
|
|
|
|
2018-09-13 12:33:15 +02:00
|
|
|
def skip_test_if_missing_module(self):
|
|
|
|
self.skip_if_no_wallet()
|
|
|
|
|
2015-03-24 04:56:53 +01:00
|
|
|
def add_options(self, parser):
|
2021-07-04 00:41:23 +02:00
|
|
|
parser.add_argument("--mineblock", dest="mine_block", default=False, action="store_true",
|
|
|
|
help="Test double-spend of 1-confirmed transaction")
|
2015-03-24 04:56:53 +01:00
|
|
|
|
|
|
|
def setup_network(self):
|
|
|
|
# Start with split network:
|
2017-05-02 20:02:55 +02:00
|
|
|
super(TxnMallTest, self).setup_network()
|
|
|
|
disconnect_nodes(self.nodes[1], 2)
|
2015-03-24 04:56:53 +01:00
|
|
|
|
|
|
|
def run_test(self):
|
2016-03-06 16:14:39 +01:00
|
|
|
# All nodes should start with 12,500 DASH:
|
|
|
|
starting_balance = 12500
|
2015-03-24 04:56:53 +01:00
|
|
|
for i in range(4):
|
|
|
|
assert_equal(self.nodes[i].getbalance(), starting_balance)
|
2018-05-11 00:08:57 +02:00
|
|
|
self.nodes[i].getnewaddress() # bug workaround, coins generated assigned to first getnewaddress!
|
2015-03-24 04:56:53 +01:00
|
|
|
|
|
|
|
self.nodes[0].settxfee(.001)
|
|
|
|
|
2018-05-11 00:08:57 +02:00
|
|
|
node0_address1 = self.nodes[0].getnewaddress()
|
|
|
|
node0_txid1 = self.nodes[0].sendtoaddress(node0_address1, 12190)
|
|
|
|
node0_tx1 = self.nodes[0].gettransaction(node0_txid1)
|
2015-03-24 04:56:53 +01:00
|
|
|
|
2018-05-11 00:08:57 +02:00
|
|
|
node0_address2 = self.nodes[0].getnewaddress()
|
|
|
|
node0_txid2 = self.nodes[0].sendtoaddress(node0_address2, 290)
|
|
|
|
node0_tx2 = self.nodes[0].gettransaction(node0_txid2)
|
2015-03-24 04:56:53 +01:00
|
|
|
|
2018-05-11 00:08:57 +02:00
|
|
|
assert_equal(self.nodes[0].getbalance(),
|
|
|
|
starting_balance + node0_tx1["fee"] + node0_tx2["fee"])
|
2015-03-24 04:56:53 +01:00
|
|
|
|
|
|
|
# Coins are sent to node1_address
|
2018-05-11 00:08:57 +02:00
|
|
|
node1_address = self.nodes[1].getnewaddress()
|
2015-03-24 04:56:53 +01:00
|
|
|
|
2020-07-29 03:23:12 +02:00
|
|
|
# Send tx1, and another transaction tx2 that won't be cloned
|
2018-05-11 00:08:57 +02:00
|
|
|
txid1 = self.nodes[0].sendtoaddress(node1_address, 400)
|
|
|
|
txid2 = self.nodes[0].sendtoaddress(node1_address, 200)
|
2015-03-24 04:56:53 +01:00
|
|
|
|
2020-07-29 03:23:12 +02:00
|
|
|
# Construct a clone of tx1, to be malleated
|
2021-04-12 16:58:49 +02:00
|
|
|
rawtx1 = self.nodes[0].getrawtransaction(txid1, 1)
|
2021-11-01 16:30:13 +01:00
|
|
|
clone_inputs = [{"txid": rawtx1["vin"][0]["txid"], "vout": rawtx1["vin"][0]["vout"], "sequence": rawtx1["vin"][0]["sequence"]}]
|
2021-04-12 16:58:49 +02:00
|
|
|
clone_outputs = {rawtx1["vout"][0]["scriptPubKey"]["addresses"][0]: rawtx1["vout"][0]["value"],
|
|
|
|
rawtx1["vout"][1]["scriptPubKey"]["addresses"][0]: rawtx1["vout"][1]["value"]}
|
2016-01-22 16:56:50 +01:00
|
|
|
clone_locktime = rawtx1["locktime"]
|
|
|
|
clone_raw = self.nodes[0].createrawtransaction(clone_inputs, clone_outputs, clone_locktime)
|
2015-03-24 04:56:53 +01:00
|
|
|
|
2016-01-22 16:56:50 +01:00
|
|
|
# createrawtransaction randomizes the order of its outputs, so swap them if necessary.
|
2019-02-18 15:16:33 +01:00
|
|
|
clone_tx = CTransaction()
|
|
|
|
clone_tx.deserialize(io.BytesIO(bytes.fromhex(clone_raw)))
|
|
|
|
if (rawtx1["vout"][0]["value"] == 400 and clone_tx.vout[0].nValue != 400*COIN or rawtx1["vout"][0]["value"] != 400 and clone_tx.vout[0].nValue == 400*COIN):
|
|
|
|
(clone_tx.vout[0], clone_tx.vout[1]) = (clone_tx.vout[1], clone_tx.vout[0])
|
2015-03-24 04:56:53 +01:00
|
|
|
|
|
|
|
# Use a different signature hash type to sign. This creates an equivalent but malleated clone.
|
|
|
|
# Don't send the clone anywhere yet
|
2019-02-18 15:16:33 +01:00
|
|
|
tx1_clone = self.nodes[0].signrawtransactionwithwallet(clone_tx.serialize().hex(), None, "ALL|ANYONECANPAY")
|
2015-03-24 04:56:53 +01:00
|
|
|
assert_equal(tx1_clone["complete"], True)
|
|
|
|
|
|
|
|
# Have node0 mine a block, if requested:
|
|
|
|
if (self.options.mine_block):
|
|
|
|
self.nodes[0].generate(1)
|
2020-04-14 12:00:16 +02:00
|
|
|
self.sync_blocks(self.nodes[0:2])
|
2015-03-24 04:56:53 +01:00
|
|
|
|
|
|
|
tx1 = self.nodes[0].gettransaction(txid1)
|
|
|
|
tx2 = self.nodes[0].gettransaction(txid2)
|
|
|
|
|
2016-03-06 16:14:39 +01:00
|
|
|
# Node0's balance should be starting balance, plus 500DASH for another
|
2015-03-24 04:56:53 +01:00
|
|
|
# matured block, minus tx1 and tx2 amounts, and minus transaction fees:
|
2018-05-11 00:08:57 +02:00
|
|
|
expected = starting_balance + node0_tx1["fee"] + node0_tx2["fee"]
|
Merge #12987: tests/tools: Enable additional Python flake8 rules for automatic linting via Travis
643aad17fa Enable additional flake8 rules (practicalswift)
f020aca297 Minor Python cleanups to make flake8 pass with the new rules enabled (practicalswift)
Pull request description:
Enabled rules:
```
* E242: tab after ','
* E266: too many leading '#' for block comment
* E401: multiple imports on one line
* E402: module level import not at top of file
* E701: multiple statements on one line (colon)
* E901: SyntaxError: invalid syntax
* E902: TokenError: EOF in multi-line string
* F821: undefined name 'Foo'
* W293: blank line contains whitespace
* W606: 'async' and 'await' are reserved keywords starting with Python 3.7
```
Note to reviewers:
* In general we don't allow whitespace cleanups to existing code, but in order to allow for enabling Travis checking for these rules a few smaller whitespace cleanups had to made as part of this PR.
* Use [this `?w=1` link](https://github.com/bitcoin/bitcoin/pull/12987/files?w=1) to show a diff without whitespace changes.
Before this commit:
```
$ flake8 -qq --statistics --ignore=B,C,E,F,I,N,W --select=E112,E113,E115,E116,E125,E131,E133,E223,E224,E242,E266,E271,E272,E273,E274,E275,E304,E306,E401,E402,E502,E701,E702,E703,E714,E721,E741,E742,E743,F401,E901,E902,F402,F404,F406,F407,F601,F602,F621,F622,F631,F701,F702,F703,F704,F705,F706,F707,F811,F812,F821,F822,F823,F831,F841,W292,W293,W504,W601,W602,W603,W604,W605,W606 .
5 E266 too many leading '#' for block comment
4 E401 multiple imports on one line
6 E402 module level import not at top of file
5 E701 multiple statements on one line (colon)
1 F812 list comprehension redefines 'n' from line 159
4 F821 undefined name 'ConnectionRefusedError'
28 W293 blank line contains whitespace
```
After this commit:
```
$ flake8 -qq --statistics --ignore=B,C,E,F,I,N,W --select=E112,E113,E115,E116,E125,E131,E133,E223,E224,E242,E266,E271,E272,E273,E274,E275,E304,E306,E401,E402,E502,E701,E702,E703,E714,E721,E741,E742,E743,F401,E901,E902,F402,F404,F406,F407,F601,F602,F621,F622,F631,F701,F702,F703,F704,F705,F706,F707,F811,F812,F821,F822,F823,F831,F841,W292,W293,W504,W601,W602,W603,W604,W605,W606 .
$
```
Tree-SHA512: fc7d5e752298a50d4248afc620ee2c173135b4ca008e48e02913ac968e5a24a5fd5396926047ec62f1d580d537434ccae01f249bb2f3338fa59dc630bf97ca7a
Signed-off-by: pasta <pasta@dashboost.org>
2018-04-16 17:49:49 +02:00
|
|
|
if self.options.mine_block:
|
|
|
|
expected += 500
|
2015-03-24 04:56:53 +01:00
|
|
|
expected += tx1["amount"] + tx1["fee"]
|
|
|
|
expected += tx2["amount"] + tx2["fee"]
|
|
|
|
assert_equal(self.nodes[0].getbalance(), expected)
|
|
|
|
|
|
|
|
if self.options.mine_block:
|
|
|
|
assert_equal(tx1["confirmations"], 1)
|
|
|
|
assert_equal(tx2["confirmations"], 1)
|
|
|
|
else:
|
|
|
|
assert_equal(tx1["confirmations"], 0)
|
|
|
|
assert_equal(tx2["confirmations"], 0)
|
|
|
|
|
|
|
|
# Send clone and its parent to miner
|
2018-05-11 00:08:57 +02:00
|
|
|
self.nodes[2].sendrawtransaction(node0_tx1["hex"])
|
2015-03-24 04:56:53 +01:00
|
|
|
txid1_clone = self.nodes[2].sendrawtransaction(tx1_clone["hex"])
|
|
|
|
# ... mine a block...
|
|
|
|
self.nodes[2].generate(1)
|
|
|
|
|
|
|
|
# Reconnect the split network, and sync chain:
|
|
|
|
connect_nodes(self.nodes[1], 2)
|
2018-05-11 00:08:57 +02:00
|
|
|
self.nodes[2].sendrawtransaction(node0_tx2["hex"])
|
2015-07-10 03:10:57 +02:00
|
|
|
self.nodes[2].sendrawtransaction(tx2["hex"])
|
2015-03-24 04:56:53 +01:00
|
|
|
self.nodes[2].generate(1) # Mine another block to make sure we sync
|
2020-04-14 12:00:16 +02:00
|
|
|
self.sync_blocks()
|
2015-03-24 04:56:53 +01:00
|
|
|
|
|
|
|
# Re-fetch transaction info:
|
|
|
|
tx1 = self.nodes[0].gettransaction(txid1)
|
|
|
|
tx1_clone = self.nodes[0].gettransaction(txid1_clone)
|
|
|
|
tx2 = self.nodes[0].gettransaction(txid2)
|
Merge #12987: tests/tools: Enable additional Python flake8 rules for automatic linting via Travis
643aad17fa Enable additional flake8 rules (practicalswift)
f020aca297 Minor Python cleanups to make flake8 pass with the new rules enabled (practicalswift)
Pull request description:
Enabled rules:
```
* E242: tab after ','
* E266: too many leading '#' for block comment
* E401: multiple imports on one line
* E402: module level import not at top of file
* E701: multiple statements on one line (colon)
* E901: SyntaxError: invalid syntax
* E902: TokenError: EOF in multi-line string
* F821: undefined name 'Foo'
* W293: blank line contains whitespace
* W606: 'async' and 'await' are reserved keywords starting with Python 3.7
```
Note to reviewers:
* In general we don't allow whitespace cleanups to existing code, but in order to allow for enabling Travis checking for these rules a few smaller whitespace cleanups had to made as part of this PR.
* Use [this `?w=1` link](https://github.com/bitcoin/bitcoin/pull/12987/files?w=1) to show a diff without whitespace changes.
Before this commit:
```
$ flake8 -qq --statistics --ignore=B,C,E,F,I,N,W --select=E112,E113,E115,E116,E125,E131,E133,E223,E224,E242,E266,E271,E272,E273,E274,E275,E304,E306,E401,E402,E502,E701,E702,E703,E714,E721,E741,E742,E743,F401,E901,E902,F402,F404,F406,F407,F601,F602,F621,F622,F631,F701,F702,F703,F704,F705,F706,F707,F811,F812,F821,F822,F823,F831,F841,W292,W293,W504,W601,W602,W603,W604,W605,W606 .
5 E266 too many leading '#' for block comment
4 E401 multiple imports on one line
6 E402 module level import not at top of file
5 E701 multiple statements on one line (colon)
1 F812 list comprehension redefines 'n' from line 159
4 F821 undefined name 'ConnectionRefusedError'
28 W293 blank line contains whitespace
```
After this commit:
```
$ flake8 -qq --statistics --ignore=B,C,E,F,I,N,W --select=E112,E113,E115,E116,E125,E131,E133,E223,E224,E242,E266,E271,E272,E273,E274,E275,E304,E306,E401,E402,E502,E701,E702,E703,E714,E721,E741,E742,E743,F401,E901,E902,F402,F404,F406,F407,F601,F602,F621,F622,F631,F701,F702,F703,F704,F705,F706,F707,F811,F812,F821,F822,F823,F831,F841,W292,W293,W504,W601,W602,W603,W604,W605,W606 .
$
```
Tree-SHA512: fc7d5e752298a50d4248afc620ee2c173135b4ca008e48e02913ac968e5a24a5fd5396926047ec62f1d580d537434ccae01f249bb2f3338fa59dc630bf97ca7a
Signed-off-by: pasta <pasta@dashboost.org>
2018-04-16 17:49:49 +02:00
|
|
|
|
2015-03-24 04:56:53 +01:00
|
|
|
# Verify expected confirmations
|
2015-11-26 18:42:07 +01:00
|
|
|
assert_equal(tx1["confirmations"], -2)
|
2015-03-24 04:56:53 +01:00
|
|
|
assert_equal(tx1_clone["confirmations"], 2)
|
2015-07-10 03:10:57 +02:00
|
|
|
assert_equal(tx2["confirmations"], 1)
|
2015-03-24 04:56:53 +01:00
|
|
|
|
2016-03-06 16:14:39 +01:00
|
|
|
# Check node0's total balance; should be same as before the clone, + 1000 DASH for 2 matured,
|
2015-03-24 04:56:53 +01:00
|
|
|
# less possible orphaned matured subsidy
|
2016-03-06 16:14:39 +01:00
|
|
|
expected += 1000
|
2020-07-29 03:23:12 +02:00
|
|
|
if (self.options.mine_block):
|
2016-03-06 16:14:39 +01:00
|
|
|
expected -= 500
|
2015-03-24 04:56:53 +01:00
|
|
|
assert_equal(self.nodes[0].getbalance(), expected)
|
|
|
|
|
|
|
|
if __name__ == '__main__':
|
|
|
|
TxnMallTest().main()
|