2016-05-06 11:23:48 +02:00
|
|
|
#!/usr/bin/env python3
|
|
|
|
# Copyright (c) 2015-2016 The Bitcoin Core developers
|
2015-03-23 18:16:07 +01:00
|
|
|
# Distributed under the MIT software license, see the accompanying
|
|
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
2018-02-20 03:29:22 +01:00
|
|
|
"""Test transaction signing using the signrawtransaction* RPCs."""
|
2015-03-23 18:16:07 +01:00
|
|
|
|
2015-05-02 13:58:10 +02:00
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
68400d8b96 tests: Use explicit imports (practicalswift)
Pull request description:
Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools.
An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports.
Before this commit:
```
$ contrib/devtools/lint-python.sh | head -10
./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
$
```
After this commit:
```
$ contrib/devtools/lint-python.sh | head -10
$
```
Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
2018-08-13 14:24:43 +02:00
|
|
|
from test_framework.util import assert_equal, assert_raises_rpc_error
|
2015-03-23 18:16:07 +01:00
|
|
|
|
|
|
|
|
|
|
|
class SignRawTransactionsTest(BitcoinTestFramework):
|
2017-09-01 18:47:13 +02:00
|
|
|
def set_test_params(self):
|
2016-05-20 15:16:51 +02:00
|
|
|
self.setup_clean_chain = True
|
|
|
|
self.num_nodes = 1
|
2018-02-20 03:29:22 +01:00
|
|
|
self.extra_args = [["-deprecatedrpc=signrawtransaction"]]
|
2015-03-23 18:16:07 +01:00
|
|
|
|
|
|
|
def successful_signing_test(self):
|
2019-01-07 10:55:35 +01:00
|
|
|
"""Create and sign a valid raw transaction with one input.
|
2015-03-23 18:16:07 +01:00
|
|
|
|
|
|
|
Expected results:
|
|
|
|
|
|
|
|
1) The transaction has a complete set of signatures
|
|
|
|
2) No script verification error occurred"""
|
2017-02-06 14:35:44 +01:00
|
|
|
privKeys = ['cUeKHd5orzT3mz8P9pxyREHfsWtVfgsfDjiZZBcjUBAaGk1BTj7N', 'cVKpPfVKSJxKqVpE9awvXNWuLHCa5j5tiE7K6zbUSptFpTEtiFrA']
|
2015-03-23 18:16:07 +01:00
|
|
|
|
|
|
|
inputs = [
|
2017-02-06 14:35:44 +01:00
|
|
|
# Valid pay-to-pubkey scripts
|
2015-03-23 18:16:07 +01:00
|
|
|
{'txid': '9b907ef1e3c26fc71fe4a4b3580bc75264112f95050014157059c736f0202e71', 'vout': 0,
|
2017-02-06 14:35:44 +01:00
|
|
|
'scriptPubKey': '76a91460baa0f494b38ce3c940dea67f3804dc52d1fb9488ac'},
|
|
|
|
{'txid': '83a4f6a6b73660e13ee6cb3c6063fa3759c50c9b7521d0536022961898f4fb02', 'vout': 0,
|
|
|
|
'scriptPubKey': '76a914669b857c03a5ed269d5d85a1ffac9ed5d663072788ac'},
|
2015-03-23 18:16:07 +01:00
|
|
|
]
|
|
|
|
|
2016-05-10 14:00:07 +02:00
|
|
|
outputs = {'ycwedq2f3sz2Yf9JqZsBCQPxp18WU3Hp4J': 0.1}
|
2015-03-23 18:16:07 +01:00
|
|
|
|
|
|
|
rawTx = self.nodes[0].createrawtransaction(inputs, outputs)
|
2018-02-20 03:29:22 +01:00
|
|
|
rawTxSigned = self.nodes[0].signrawtransactionwithkey(rawTx, privKeys, inputs)
|
2015-03-23 18:16:07 +01:00
|
|
|
|
|
|
|
# 1) The transaction has a complete set of signatures
|
2018-02-20 03:29:22 +01:00
|
|
|
assert rawTxSigned['complete']
|
2015-03-23 18:16:07 +01:00
|
|
|
|
|
|
|
# 2) No script verification error occurred
|
|
|
|
assert 'errors' not in rawTxSigned
|
|
|
|
|
2018-02-20 03:29:22 +01:00
|
|
|
# Perform the same test on signrawtransaction
|
|
|
|
rawTxSigned2 = self.nodes[0].signrawtransaction(rawTx, inputs, privKeys)
|
|
|
|
assert_equal(rawTxSigned, rawTxSigned2)
|
|
|
|
|
2015-03-23 18:16:07 +01:00
|
|
|
def script_verification_error_test(self):
|
2019-01-07 10:55:35 +01:00
|
|
|
"""Create and sign a raw transaction with valid (vin 0), invalid (vin 1) and one missing (vin 2) input script.
|
2015-03-23 18:16:07 +01:00
|
|
|
|
|
|
|
Expected results:
|
|
|
|
|
|
|
|
3) The transaction has no complete set of signatures
|
|
|
|
4) Two script verification errors occurred
|
|
|
|
5) Script verification errors have certain properties ("txid", "vout", "scriptSig", "sequence", "error")
|
|
|
|
6) The verification errors refer to the invalid (vin 1) and missing input (vin 2)"""
|
|
|
|
privKeys = ['cUeKHd5orzT3mz8P9pxyREHfsWtVfgsfDjiZZBcjUBAaGk1BTj7N']
|
|
|
|
|
|
|
|
inputs = [
|
|
|
|
# Valid pay-to-pubkey script
|
|
|
|
{'txid': '9b907ef1e3c26fc71fe4a4b3580bc75264112f95050014157059c736f0202e71', 'vout': 0},
|
|
|
|
# Invalid script
|
|
|
|
{'txid': '5b8673686910442c644b1f4993d8f7753c7c8fcb5c87ee40d56eaeef25204547', 'vout': 7},
|
|
|
|
# Missing scriptPubKey
|
|
|
|
{'txid': '9b907ef1e3c26fc71fe4a4b3580bc75264112f95050014157059c736f0202e71', 'vout': 1},
|
|
|
|
]
|
|
|
|
|
|
|
|
scripts = [
|
|
|
|
# Valid pay-to-pubkey script
|
|
|
|
{'txid': '9b907ef1e3c26fc71fe4a4b3580bc75264112f95050014157059c736f0202e71', 'vout': 0,
|
|
|
|
'scriptPubKey': '76a91460baa0f494b38ce3c940dea67f3804dc52d1fb9488ac'},
|
|
|
|
# Invalid script
|
|
|
|
{'txid': '5b8673686910442c644b1f4993d8f7753c7c8fcb5c87ee40d56eaeef25204547', 'vout': 7,
|
|
|
|
'scriptPubKey': 'badbadbadbad'}
|
|
|
|
]
|
|
|
|
|
2016-05-10 14:00:07 +02:00
|
|
|
outputs = {'ycwedq2f3sz2Yf9JqZsBCQPxp18WU3Hp4J': 0.1}
|
2015-03-23 18:16:07 +01:00
|
|
|
|
|
|
|
rawTx = self.nodes[0].createrawtransaction(inputs, outputs)
|
2017-02-06 14:35:44 +01:00
|
|
|
|
|
|
|
# Make sure decoderawtransaction is at least marginally sane
|
|
|
|
decodedRawTx = self.nodes[0].decoderawtransaction(rawTx)
|
|
|
|
for i, inp in enumerate(inputs):
|
|
|
|
assert_equal(decodedRawTx["vin"][i]["txid"], inp["txid"])
|
|
|
|
assert_equal(decodedRawTx["vin"][i]["vout"], inp["vout"])
|
|
|
|
|
|
|
|
# Make sure decoderawtransaction throws if there is extra data
|
2019-09-25 11:34:51 +02:00
|
|
|
assert_raises_rpc_error(-22, "TX decode failed", self.nodes[0].decoderawtransaction, rawTx + "00")
|
2017-02-06 14:35:44 +01:00
|
|
|
|
2018-02-20 03:29:22 +01:00
|
|
|
rawTxSigned = self.nodes[0].signrawtransactionwithkey(rawTx, privKeys, scripts)
|
2015-03-23 18:16:07 +01:00
|
|
|
|
|
|
|
# 3) The transaction has no complete set of signatures
|
2018-02-20 03:29:22 +01:00
|
|
|
assert not rawTxSigned['complete']
|
2015-03-23 18:16:07 +01:00
|
|
|
|
|
|
|
# 4) Two script verification errors occurred
|
|
|
|
assert 'errors' in rawTxSigned
|
|
|
|
assert_equal(len(rawTxSigned['errors']), 2)
|
|
|
|
|
|
|
|
# 5) Script verification errors have certain properties
|
|
|
|
assert 'txid' in rawTxSigned['errors'][0]
|
|
|
|
assert 'vout' in rawTxSigned['errors'][0]
|
|
|
|
assert 'scriptSig' in rawTxSigned['errors'][0]
|
|
|
|
assert 'sequence' in rawTxSigned['errors'][0]
|
|
|
|
assert 'error' in rawTxSigned['errors'][0]
|
|
|
|
|
|
|
|
# 6) The verification errors refer to the invalid (vin 1) and missing input (vin 2)
|
|
|
|
assert_equal(rawTxSigned['errors'][0]['txid'], inputs[1]['txid'])
|
|
|
|
assert_equal(rawTxSigned['errors'][0]['vout'], inputs[1]['vout'])
|
|
|
|
assert_equal(rawTxSigned['errors'][1]['txid'], inputs[2]['txid'])
|
|
|
|
assert_equal(rawTxSigned['errors'][1]['vout'], inputs[2]['vout'])
|
|
|
|
|
2018-02-20 03:29:22 +01:00
|
|
|
# Perform same test with signrawtransaction
|
2020-12-11 03:25:55 +01:00
|
|
|
rawTxSigned2 = self.nodes[0].signrawtransaction(rawTx, scripts, privKeys)
|
2018-02-20 03:29:22 +01:00
|
|
|
assert_equal(rawTxSigned, rawTxSigned2)
|
|
|
|
|
2015-03-23 18:16:07 +01:00
|
|
|
def run_test(self):
|
|
|
|
self.successful_signing_test()
|
|
|
|
self.script_verification_error_test()
|
|
|
|
|
|
|
|
|
|
|
|
if __name__ == '__main__':
|
|
|
|
SignRawTransactionsTest().main()
|