2016-08-24 12:10:36 +02:00
|
|
|
#!/usr/bin/env python3
|
|
|
|
# Copyright (c) 2016 The Bitcoin Core developers
|
|
|
|
# Distributed under the MIT software license, see the accompanying
|
|
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
2019-01-07 10:55:35 +01:00
|
|
|
"""Test account RPCs.
|
|
|
|
|
|
|
|
RPCs tested are:
|
|
|
|
- getaccountaddress
|
|
|
|
- getaddressesbyaccount
|
2017-05-02 20:18:30 +02:00
|
|
|
- listaddressgroupings
|
2019-01-07 10:55:35 +01:00
|
|
|
- setaccount
|
|
|
|
- sendfrom (with account arguments)
|
|
|
|
- move (with account arguments)
|
|
|
|
"""
|
2016-08-24 12:10:36 +02:00
|
|
|
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
2017-06-02 12:08:48 +02:00
|
|
|
from test_framework.util import assert_equal
|
2016-08-24 12:10:36 +02:00
|
|
|
|
|
|
|
class WalletAccountsTest(BitcoinTestFramework):
|
2017-09-01 18:47:13 +02:00
|
|
|
def set_test_params(self):
|
2016-08-24 12:10:36 +02:00
|
|
|
self.setup_clean_chain = True
|
|
|
|
self.num_nodes = 1
|
2019-06-20 18:37:09 +02:00
|
|
|
self.extra_args = [["-paytxfee=0.0001"]]
|
2016-08-24 12:10:36 +02:00
|
|
|
|
2017-05-02 20:18:30 +02:00
|
|
|
def run_test(self):
|
2016-08-24 12:10:36 +02:00
|
|
|
node = self.nodes[0]
|
|
|
|
# Check that there's no UTXO on any of the nodes
|
|
|
|
assert_equal(len(node.listunspent()), 0)
|
2017-05-02 20:18:30 +02:00
|
|
|
|
|
|
|
# Note each time we call generate, all generated coins go into
|
2019-06-20 18:37:09 +02:00
|
|
|
# the same address, so we call twice to get two addresses w/500 each
|
2017-05-02 20:18:30 +02:00
|
|
|
node.generate(1)
|
2016-08-24 12:10:36 +02:00
|
|
|
node.generate(101)
|
2017-05-02 20:18:30 +02:00
|
|
|
assert_equal(node.getbalance(), 1000)
|
|
|
|
|
|
|
|
# there should be 2 address groups
|
|
|
|
# each with 1 address with a balance of 500 Dash
|
|
|
|
address_groups = node.listaddressgroupings()
|
|
|
|
assert_equal(len(address_groups), 2)
|
|
|
|
# the addresses aren't linked now, but will be after we send to the
|
|
|
|
# common address
|
|
|
|
linked_addresses = set()
|
|
|
|
for address_group in address_groups:
|
|
|
|
assert_equal(len(address_group), 1)
|
|
|
|
assert_equal(len(address_group[0]), 2)
|
|
|
|
assert_equal(address_group[0][1], 500)
|
|
|
|
linked_addresses.add(address_group[0][0])
|
|
|
|
|
|
|
|
# send 500 from each address to a third address not in this wallet
|
|
|
|
# There's some fee that will come back to us when the miner reward
|
|
|
|
# matures.
|
2019-06-19 20:01:39 +02:00
|
|
|
common_address = "yd5KMREs3GLMe6mTJYr3YrH1juwNwrFCfB"
|
2017-05-02 20:18:30 +02:00
|
|
|
txid = node.sendmany(
|
|
|
|
fromaccount="",
|
2019-06-20 18:37:09 +02:00
|
|
|
amounts={common_address: 1000},
|
2017-05-02 20:18:30 +02:00
|
|
|
minconf=1,
|
2019-06-20 18:37:09 +02:00
|
|
|
addlocked=False,
|
|
|
|
comment="",
|
|
|
|
subtractfeefrom=[common_address],
|
2017-05-02 20:18:30 +02:00
|
|
|
)
|
|
|
|
tx_details = node.gettransaction(txid)
|
|
|
|
fee = -tx_details['details'][0]['fee']
|
|
|
|
# there should be 1 address group, with the previously
|
|
|
|
# unlinked addresses now linked (they both have 0 balance)
|
|
|
|
address_groups = node.listaddressgroupings()
|
|
|
|
assert_equal(len(address_groups), 1)
|
|
|
|
assert_equal(len(address_groups[0]), 2)
|
|
|
|
assert_equal(set([a[0] for a in address_groups[0]]), linked_addresses)
|
|
|
|
assert_equal([a[1] for a in address_groups[0]], [0, 0])
|
|
|
|
|
|
|
|
node.generate(1)
|
|
|
|
|
|
|
|
# we want to reset so that the "" account has what's expected.
|
|
|
|
# otherwise we're off by exactly the fee amount as that's mined
|
|
|
|
# and matures in the next 100 blocks
|
|
|
|
node.sendfrom("", common_address, fee)
|
2016-08-24 12:10:36 +02:00
|
|
|
amount_to_send = 1.0
|
2017-11-09 13:07:40 +01:00
|
|
|
|
|
|
|
# Create accounts and make sure subsequent account API calls
|
|
|
|
# recognize the account/address associations.
|
|
|
|
accounts = [Account(name) for name in ("a", "b", "c", "d", "e")]
|
2016-08-24 12:10:36 +02:00
|
|
|
for account in accounts:
|
2017-11-09 13:07:40 +01:00
|
|
|
account.add_receive_address(node.getaccountaddress(account.name))
|
|
|
|
account.verify(node)
|
|
|
|
|
|
|
|
# Send a transaction to each account, and make sure this forces
|
|
|
|
# getaccountaddress to generate a new receiving address.
|
|
|
|
for account in accounts:
|
|
|
|
node.sendtoaddress(account.receive_address, amount_to_send)
|
|
|
|
account.add_receive_address(node.getaccountaddress(account.name))
|
|
|
|
account.verify(node)
|
|
|
|
|
|
|
|
# Check the amounts received.
|
2016-08-24 12:10:36 +02:00
|
|
|
node.generate(1)
|
2017-11-09 13:07:40 +01:00
|
|
|
for account in accounts:
|
|
|
|
assert_equal(
|
|
|
|
node.getreceivedbyaddress(account.addresses[0]), amount_to_send)
|
|
|
|
assert_equal(node.getreceivedbyaccount(account.name), amount_to_send)
|
|
|
|
|
|
|
|
# Check that sendfrom account reduces listaccounts balances.
|
|
|
|
for i, account in enumerate(accounts):
|
2017-05-02 20:18:30 +02:00
|
|
|
to_account = accounts[(i+1) % len(accounts)]
|
2017-11-09 13:07:40 +01:00
|
|
|
node.sendfrom(account.name, to_account.receive_address, amount_to_send)
|
2016-08-24 12:10:36 +02:00
|
|
|
node.generate(1)
|
|
|
|
for account in accounts:
|
2017-11-09 13:07:40 +01:00
|
|
|
account.add_receive_address(node.getaccountaddress(account.name))
|
|
|
|
account.verify(node)
|
|
|
|
assert_equal(node.getreceivedbyaccount(account.name), 2)
|
|
|
|
node.move(account.name, "", node.getbalance(account.name))
|
|
|
|
account.verify(node)
|
2016-08-24 12:10:36 +02:00
|
|
|
node.generate(101)
|
2018-01-09 17:45:28 +01:00
|
|
|
expected_account_balances = {"": 52000}
|
2016-08-24 12:10:36 +02:00
|
|
|
for account in accounts:
|
2017-11-09 13:07:40 +01:00
|
|
|
expected_account_balances[account.name] = 0
|
2016-08-24 12:10:36 +02:00
|
|
|
assert_equal(node.listaccounts(), expected_account_balances)
|
2018-01-09 17:45:28 +01:00
|
|
|
assert_equal(node.getbalance(""), 52000)
|
Merge #12987: tests/tools: Enable additional Python flake8 rules for automatic linting via Travis
643aad17fa Enable additional flake8 rules (practicalswift)
f020aca297 Minor Python cleanups to make flake8 pass with the new rules enabled (practicalswift)
Pull request description:
Enabled rules:
```
* E242: tab after ','
* E266: too many leading '#' for block comment
* E401: multiple imports on one line
* E402: module level import not at top of file
* E701: multiple statements on one line (colon)
* E901: SyntaxError: invalid syntax
* E902: TokenError: EOF in multi-line string
* F821: undefined name 'Foo'
* W293: blank line contains whitespace
* W606: 'async' and 'await' are reserved keywords starting with Python 3.7
```
Note to reviewers:
* In general we don't allow whitespace cleanups to existing code, but in order to allow for enabling Travis checking for these rules a few smaller whitespace cleanups had to made as part of this PR.
* Use [this `?w=1` link](https://github.com/bitcoin/bitcoin/pull/12987/files?w=1) to show a diff without whitespace changes.
Before this commit:
```
$ flake8 -qq --statistics --ignore=B,C,E,F,I,N,W --select=E112,E113,E115,E116,E125,E131,E133,E223,E224,E242,E266,E271,E272,E273,E274,E275,E304,E306,E401,E402,E502,E701,E702,E703,E714,E721,E741,E742,E743,F401,E901,E902,F402,F404,F406,F407,F601,F602,F621,F622,F631,F701,F702,F703,F704,F705,F706,F707,F811,F812,F821,F822,F823,F831,F841,W292,W293,W504,W601,W602,W603,W604,W605,W606 .
5 E266 too many leading '#' for block comment
4 E401 multiple imports on one line
6 E402 module level import not at top of file
5 E701 multiple statements on one line (colon)
1 F812 list comprehension redefines 'n' from line 159
4 F821 undefined name 'ConnectionRefusedError'
28 W293 blank line contains whitespace
```
After this commit:
```
$ flake8 -qq --statistics --ignore=B,C,E,F,I,N,W --select=E112,E113,E115,E116,E125,E131,E133,E223,E224,E242,E266,E271,E272,E273,E274,E275,E304,E306,E401,E402,E502,E701,E702,E703,E714,E721,E741,E742,E743,F401,E901,E902,F402,F404,F406,F407,F601,F602,F621,F622,F631,F701,F702,F703,F704,F705,F706,F707,F811,F812,F821,F822,F823,F831,F841,W292,W293,W504,W601,W602,W603,W604,W605,W606 .
$
```
Tree-SHA512: fc7d5e752298a50d4248afc620ee2c173135b4ca008e48e02913ac968e5a24a5fd5396926047ec62f1d580d537434ccae01f249bb2f3338fa59dc630bf97ca7a
Signed-off-by: pasta <pasta@dashboost.org>
2018-04-16 17:49:49 +02:00
|
|
|
|
2017-11-09 13:07:40 +01:00
|
|
|
# Check that setaccount can assign an account to a new unused address.
|
2016-08-24 12:10:36 +02:00
|
|
|
for account in accounts:
|
|
|
|
address = node.getaccountaddress("")
|
2017-11-09 13:07:40 +01:00
|
|
|
node.setaccount(address, account.name)
|
|
|
|
account.add_address(address)
|
|
|
|
account.verify(node)
|
2016-08-24 12:10:36 +02:00
|
|
|
assert(address not in node.getaddressesbyaccount(""))
|
Merge #12987: tests/tools: Enable additional Python flake8 rules for automatic linting via Travis
643aad17fa Enable additional flake8 rules (practicalswift)
f020aca297 Minor Python cleanups to make flake8 pass with the new rules enabled (practicalswift)
Pull request description:
Enabled rules:
```
* E242: tab after ','
* E266: too many leading '#' for block comment
* E401: multiple imports on one line
* E402: module level import not at top of file
* E701: multiple statements on one line (colon)
* E901: SyntaxError: invalid syntax
* E902: TokenError: EOF in multi-line string
* F821: undefined name 'Foo'
* W293: blank line contains whitespace
* W606: 'async' and 'await' are reserved keywords starting with Python 3.7
```
Note to reviewers:
* In general we don't allow whitespace cleanups to existing code, but in order to allow for enabling Travis checking for these rules a few smaller whitespace cleanups had to made as part of this PR.
* Use [this `?w=1` link](https://github.com/bitcoin/bitcoin/pull/12987/files?w=1) to show a diff without whitespace changes.
Before this commit:
```
$ flake8 -qq --statistics --ignore=B,C,E,F,I,N,W --select=E112,E113,E115,E116,E125,E131,E133,E223,E224,E242,E266,E271,E272,E273,E274,E275,E304,E306,E401,E402,E502,E701,E702,E703,E714,E721,E741,E742,E743,F401,E901,E902,F402,F404,F406,F407,F601,F602,F621,F622,F631,F701,F702,F703,F704,F705,F706,F707,F811,F812,F821,F822,F823,F831,F841,W292,W293,W504,W601,W602,W603,W604,W605,W606 .
5 E266 too many leading '#' for block comment
4 E401 multiple imports on one line
6 E402 module level import not at top of file
5 E701 multiple statements on one line (colon)
1 F812 list comprehension redefines 'n' from line 159
4 F821 undefined name 'ConnectionRefusedError'
28 W293 blank line contains whitespace
```
After this commit:
```
$ flake8 -qq --statistics --ignore=B,C,E,F,I,N,W --select=E112,E113,E115,E116,E125,E131,E133,E223,E224,E242,E266,E271,E272,E273,E274,E275,E304,E306,E401,E402,E502,E701,E702,E703,E714,E721,E741,E742,E743,F401,E901,E902,F402,F404,F406,F407,F601,F602,F621,F622,F631,F701,F702,F703,F704,F705,F706,F707,F811,F812,F821,F822,F823,F831,F841,W292,W293,W504,W601,W602,W603,W604,W605,W606 .
$
```
Tree-SHA512: fc7d5e752298a50d4248afc620ee2c173135b4ca008e48e02913ac968e5a24a5fd5396926047ec62f1d580d537434ccae01f249bb2f3338fa59dc630bf97ca7a
Signed-off-by: pasta <pasta@dashboost.org>
2018-04-16 17:49:49 +02:00
|
|
|
|
2017-11-09 13:07:40 +01:00
|
|
|
# Check that addmultisigaddress can assign accounts.
|
2016-08-24 12:10:36 +02:00
|
|
|
for account in accounts:
|
|
|
|
addresses = []
|
|
|
|
for x in range(10):
|
|
|
|
addresses.append(node.getnewaddress())
|
2020-05-15 11:34:41 +02:00
|
|
|
multisig_address = node.addmultisigaddress(5, addresses, account.name)['address']
|
2017-11-09 13:07:40 +01:00
|
|
|
account.add_address(multisig_address)
|
|
|
|
account.verify(node)
|
2016-08-24 12:10:36 +02:00
|
|
|
node.sendfrom("", multisig_address, 50)
|
|
|
|
node.generate(101)
|
|
|
|
for account in accounts:
|
2017-11-09 13:07:40 +01:00
|
|
|
assert_equal(node.getbalance(account.name), 50)
|
|
|
|
|
|
|
|
# Check that setaccount can change the account of an address from a
|
|
|
|
# different account.
|
|
|
|
change_account(node, accounts[0].addresses[0], accounts[0], accounts[1])
|
|
|
|
|
|
|
|
# Check that setaccount can change the account of an address which
|
|
|
|
# is the receiving address of a different account.
|
|
|
|
change_account(node, accounts[0].receive_address, accounts[0], accounts[1])
|
|
|
|
|
|
|
|
# Check that setaccount can set the account of an address already
|
|
|
|
# in the account. This is a no-op.
|
|
|
|
change_account(node, accounts[2].addresses[0], accounts[2], accounts[2])
|
|
|
|
|
|
|
|
# Check that setaccount can set the account of an address which is
|
|
|
|
# already the receiving address of the account. It would probably make
|
|
|
|
# sense for this to be a no-op, but right now it resets the receiving
|
|
|
|
# address, causing getaccountaddress to return a brand new address.
|
|
|
|
change_account(node, accounts[2].receive_address, accounts[2], accounts[2])
|
|
|
|
|
|
|
|
class Account:
|
|
|
|
def __init__(self, name):
|
|
|
|
# Account name
|
|
|
|
self.name = name
|
|
|
|
# Current receiving address associated with this account.
|
|
|
|
self.receive_address = None
|
|
|
|
# List of all addresses assigned with this account
|
|
|
|
self.addresses = []
|
|
|
|
|
|
|
|
def add_address(self, address):
|
|
|
|
assert_equal(address not in self.addresses, True)
|
|
|
|
self.addresses.append(address)
|
|
|
|
|
|
|
|
def add_receive_address(self, address):
|
|
|
|
self.add_address(address)
|
|
|
|
self.receive_address = address
|
|
|
|
|
|
|
|
def verify(self, node):
|
|
|
|
if self.receive_address is not None:
|
|
|
|
assert self.receive_address in self.addresses
|
|
|
|
assert_equal(node.getaccountaddress(self.name), self.receive_address)
|
|
|
|
|
|
|
|
for address in self.addresses:
|
|
|
|
assert_equal(node.getaccount(address), self.name)
|
|
|
|
|
|
|
|
assert_equal(
|
|
|
|
set(node.getaddressesbyaccount(self.name)), set(self.addresses))
|
|
|
|
|
|
|
|
|
|
|
|
def change_account(node, address, old_account, new_account):
|
|
|
|
assert_equal(address in old_account.addresses, True)
|
|
|
|
node.setaccount(address, new_account.name)
|
|
|
|
|
|
|
|
old_account.addresses.remove(address)
|
|
|
|
new_account.add_address(address)
|
|
|
|
|
|
|
|
# Calling setaccount on an address which was previously the receiving
|
|
|
|
# address of a different account should reset the receiving address of
|
|
|
|
# the old account, causing getaccountaddress to return a brand new
|
|
|
|
# address.
|
|
|
|
if address == old_account.receive_address:
|
|
|
|
new_address = node.getaccountaddress(old_account.name)
|
|
|
|
assert_equal(new_address not in old_account.addresses, True)
|
|
|
|
assert_equal(new_address not in new_account.addresses, True)
|
|
|
|
old_account.add_receive_address(new_address)
|
|
|
|
|
|
|
|
old_account.verify(node)
|
|
|
|
new_account.verify(node)
|
|
|
|
|
2016-08-24 12:10:36 +02:00
|
|
|
|
|
|
|
if __name__ == '__main__':
|
2017-05-02 20:18:30 +02:00
|
|
|
WalletAccountsTest().main()
|