sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-25 20:12:57 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge bitcoin/bitcoin#24191: refactor: Make MessageBoxFlags enum underlying type unsigned

Browse Source 
1111d33532516c16fb2e22660ac2745ce56ad6cd refactor: Make MessageBoxFlags enum underlying type unsigned (MarcoFalke)

Pull request description:

  All values in the enum are unsigned. Also, flags shouldn't be treated as signed types. So clarify the underlying type and remove a sanitizer suppression.

ACKs for top commit:
  hebasto:
    ACK 1111d33532516c16fb2e22660ac2745ce56ad6cd, I have reviewed the code and it looks OK, I agree it can be merged.

Tree-SHA512: 48b16c4a0ace1a1e4d351d6eadadbb1bc42aef7fd82e24e3ea50c62f2c04a552ed21027158d09aa97e630c8c7d732cb150c38065333d7c2accbae46593b7ed9f
This commit is contained in:
MarcoFalke 2022-01-31 16:27:39 +01:00 committed by pasta
parent 93027376bf
commit 002db515dc
No known key found for this signature in database
GPG Key ID: 52527BEDABE87984
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/node/ui_interface.h
View File

@ -27,8 +27,7 @@ class CClientUIInterface
{ {
public: public:
/** Flags for CClientUIInterface::ThreadSafeMessageBox */ /** Flags for CClientUIInterface::ThreadSafeMessageBox */
enum MessageBoxFlags enum MessageBoxFlags : uint32_t {
{
ICON_INFORMATION = 0, ICON_INFORMATION = 0,
ICON_WARNING = (1U << 0), ICON_WARNING = (1U << 0),
ICON_ERROR = (1U << 1), ICON_ERROR = (1U << 1),

1
test/sanitizer_suppressions/ubsan
View File

@ -60,7 +60,6 @@ implicit-integer-sign-change:crypto/
# implicit-integer-sign-change in FuzzedDataProvider's ConsumeIntegralInRange # implicit-integer-sign-change in FuzzedDataProvider's ConsumeIntegralInRange
implicit-integer-sign-change:FuzzedDataProvider.h implicit-integer-sign-change:FuzzedDataProvider.h
implicit-integer-sign-change:key.cpp implicit-integer-sign-change:key.cpp
implicit-integer-sign-change:noui.cpp
implicit-integer-sign-change:policy/fees.cpp implicit-integer-sign-change:policy/fees.cpp
implicit-integer-sign-change:prevector.h implicit-integer-sign-change:prevector.h
implicit-integer-sign-change:script/bitcoinconsensus.cpp implicit-integer-sign-change:script/bitcoinconsensus.cpp