mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 20:12:57 +01:00
Merge #17650: util: remove unwanted fields from bitcoin-cli -getinfo
01c87015597021bf1c0856f7f6be175bdde844b2 util: remove unwanted fields from bitcoin-cli -getinfo (malevolent) Pull request description: Removed the following fields from -getinfo: protocolversion, walletversion and keypoololdest. This change closes #17314 . ACKs for top commit: laanwj: ACK 01c87015597021bf1c0856f7f6be175bdde844b2 achow101: ACK 01c87015597021bf1c0856f7f6be175bdde844b2 practicalswift: ACK 01c87015597021bf1c0856f7f6be175bdde844b2 -- diff looks correct Tree-SHA512: c98f2e8a3fee04d46766f70cb88f4e49e892a4424eff8940a7d48e9e808597b702427225788f984f5c3641591fd8d86acee56774afde1d57a4259c31d971ea08
This commit is contained in:
parent
c5c5b520cb
commit
00fbb89b10
@ -273,7 +273,6 @@ public:
|
|||||||
return batch[ID_BLOCKCHAININFO];
|
return batch[ID_BLOCKCHAININFO];
|
||||||
}
|
}
|
||||||
result.pushKV("version", batch[ID_NETWORKINFO]["result"]["version"]);
|
result.pushKV("version", batch[ID_NETWORKINFO]["result"]["version"]);
|
||||||
result.pushKV("protocolversion", batch[ID_NETWORKINFO]["result"]["protocolversion"]);
|
|
||||||
result.pushKV("blocks", batch[ID_BLOCKCHAININFO]["result"]["blocks"]);
|
result.pushKV("blocks", batch[ID_BLOCKCHAININFO]["result"]["blocks"]);
|
||||||
result.pushKV("headers", batch[ID_BLOCKCHAININFO]["result"]["headers"]);
|
result.pushKV("headers", batch[ID_BLOCKCHAININFO]["result"]["headers"]);
|
||||||
result.pushKV("verificationprogress", batch[ID_BLOCKCHAININFO]["result"]["verificationprogress"]);
|
result.pushKV("verificationprogress", batch[ID_BLOCKCHAININFO]["result"]["verificationprogress"]);
|
||||||
@ -283,10 +282,8 @@ public:
|
|||||||
result.pushKV("difficulty", batch[ID_BLOCKCHAININFO]["result"]["difficulty"]);
|
result.pushKV("difficulty", batch[ID_BLOCKCHAININFO]["result"]["difficulty"]);
|
||||||
result.pushKV("chain", UniValue(batch[ID_BLOCKCHAININFO]["result"]["chain"]));
|
result.pushKV("chain", UniValue(batch[ID_BLOCKCHAININFO]["result"]["chain"]));
|
||||||
if (!batch[ID_WALLETINFO]["result"].isNull()) {
|
if (!batch[ID_WALLETINFO]["result"].isNull()) {
|
||||||
result.pushKV("walletversion", batch[ID_WALLETINFO]["result"]["walletversion"]);
|
|
||||||
result.pushKV("balance", batch[ID_WALLETINFO]["result"]["balance"]);
|
result.pushKV("balance", batch[ID_WALLETINFO]["result"]["balance"]);
|
||||||
result.pushKV("coinjoin_balance", batch[ID_WALLETINFO]["result"]["coinjoin_balance"]);
|
result.pushKV("coinjoin_balance", batch[ID_WALLETINFO]["result"]["coinjoin_balance"]);
|
||||||
result.pushKV("keypoololdest", batch[ID_WALLETINFO]["result"]["keypoololdest"]);
|
|
||||||
result.pushKV("keypoolsize", batch[ID_WALLETINFO]["result"]["keypoolsize"]);
|
result.pushKV("keypoolsize", batch[ID_WALLETINFO]["result"]["keypoolsize"]);
|
||||||
if (!batch[ID_WALLETINFO]["result"]["unlocked_until"].isNull()) {
|
if (!batch[ID_WALLETINFO]["result"]["unlocked_until"].isNull()) {
|
||||||
result.pushKV("unlocked_until", batch[ID_WALLETINFO]["result"]["unlocked_until"]);
|
result.pushKV("unlocked_until", batch[ID_WALLETINFO]["result"]["unlocked_until"]);
|
||||||
|
@ -59,7 +59,6 @@ class TestBitcoinCli(BitcoinTestFramework):
|
|||||||
blockchain_info = self.nodes[0].getblockchaininfo()
|
blockchain_info = self.nodes[0].getblockchaininfo()
|
||||||
|
|
||||||
assert_equal(cli_get_info['version'], network_info['version'])
|
assert_equal(cli_get_info['version'], network_info['version'])
|
||||||
assert_equal(cli_get_info['protocolversion'], network_info['protocolversion'])
|
|
||||||
assert_equal(cli_get_info['blocks'], blockchain_info['blocks'])
|
assert_equal(cli_get_info['blocks'], blockchain_info['blocks'])
|
||||||
assert_equal(cli_get_info['timeoffset'], network_info['timeoffset'])
|
assert_equal(cli_get_info['timeoffset'], network_info['timeoffset'])
|
||||||
assert_equal(cli_get_info['connections'], network_info['connections'])
|
assert_equal(cli_get_info['connections'], network_info['connections'])
|
||||||
@ -67,10 +66,8 @@ class TestBitcoinCli(BitcoinTestFramework):
|
|||||||
assert_equal(cli_get_info['difficulty'], blockchain_info['difficulty'])
|
assert_equal(cli_get_info['difficulty'], blockchain_info['difficulty'])
|
||||||
assert_equal(cli_get_info['chain'], blockchain_info['chain'])
|
assert_equal(cli_get_info['chain'], blockchain_info['chain'])
|
||||||
if self.is_wallet_compiled():
|
if self.is_wallet_compiled():
|
||||||
assert_equal(cli_get_info['walletversion'], wallet_info['walletversion'])
|
|
||||||
assert_equal(cli_get_info['balance'], wallet_info['balance'])
|
assert_equal(cli_get_info['balance'], wallet_info['balance'])
|
||||||
assert_equal(cli_get_info['coinjoin_balance'], wallet_info['coinjoin_balance'])
|
assert_equal(cli_get_info['coinjoin_balance'], wallet_info['coinjoin_balance'])
|
||||||
assert_equal(cli_get_info['keypoololdest'], wallet_info['keypoololdest'])
|
|
||||||
assert_equal(cli_get_info['keypoolsize'], wallet_info['keypoolsize'])
|
assert_equal(cli_get_info['keypoolsize'], wallet_info['keypoolsize'])
|
||||||
assert_equal(cli_get_info['paytxfee'], wallet_info['paytxfee'])
|
assert_equal(cli_get_info['paytxfee'], wallet_info['paytxfee'])
|
||||||
assert_equal(cli_get_info['relayfee'], network_info['relayfee'])
|
assert_equal(cli_get_info['relayfee'], network_info['relayfee'])
|
||||||
|
Loading…
Reference in New Issue
Block a user