From 1017bbb84e1e61760ee93ab19f963301e001a266 Mon Sep 17 00:00:00 2001 From: Jonas Schnelli Date: Tue, 3 Oct 2017 20:14:58 -0700 Subject: [PATCH] Merge #11419: Utils: Fix launchctl not being able to stop bitcoind MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ab5bba778 Fix launchctl not being able to stop bitcoind (Alejandro Avilés) Pull request description: `bitcoind` should not be launched as daemon from the Launch Agent. Otherwise, the process cannot be stopped from `launchctl stop`/`launchctl unload`. To reproduce the issue: ```console $ launchctl load ~/Library/LaunchAgents/org.bitcoin.bitcoind.plist $ pgrep -fla bitcoin 60225 /usr/local/opt/bitcoin/bin/bitcoind $ launchctl unload ~/Library/LaunchAgents/org.bitcoin.bitcoind.plist ``` Wait a few seconds and then run `pgrep` again: ```console $ pgrep -fla bitcoin 60225 /usr/local/opt/bitcoin/bin/bitcoind ``` The node is still running. This happens because Launch Agent is not supposed to run programs as daemons, since the agent makes sure they run in the background. Running them as daemons makes the Launch Agent lose control of the process and, so, it cannot be stopped. Tree-SHA512: 5342e1a858e478a226a1db292f1b8f8666bb252ee951753b131902c325ea3d47592cf245298decb423ac658a3175761b54dc2e7df6feea5343d65ba255613f67 --- contrib/init/org.dash.dashd.plist | 1 - 1 file changed, 1 deletion(-) diff --git a/contrib/init/org.dash.dashd.plist b/contrib/init/org.dash.dashd.plist index 9873f1a3f1..11ef333ee5 100644 --- a/contrib/init/org.dash.dashd.plist +++ b/contrib/init/org.dash.dashd.plist @@ -7,7 +7,6 @@ ProgramArguments /usr/local/bin/dashd - -daemon RunAtLoad