Merge #19722: test: Add test for getblockheader verboseness

5067c5acc30c5cf87496c1bf8eb03712cc66b206 [test] Add test for getblockheader verboseness (Torhte Butler)

Pull request description:

  Improve test coverage by adding a test for getblockheader with verbose argument set to false.

ACKs for top commit:
  theStack:
    ACK 5067c5acc3

Tree-SHA512: e55593f1026a89dc7b796fa985b4cbcdb596e91d80d42dfb0660bda1692aaa35749ec29f9cd7032803f6225afb323f085df1ef6a9982de87be8e098f7253cdd5
This commit is contained in:
MarcoFalke 2020-08-21 14:33:41 +02:00 committed by pasta
parent 3c79f6120f
commit 1382c881df

View File

@ -37,6 +37,8 @@ from test_framework.blocktools import (
create_coinbase, create_coinbase,
) )
from test_framework.messages import ( from test_framework.messages import (
CBlockHeader,
FromHex,
msg_block, msg_block,
) )
from test_framework.mininode import ( from test_framework.mininode import (
@ -234,6 +236,14 @@ class BlockchainTest(BitcoinTestFramework):
assert isinstance(int(header['versionHex'], 16), int) assert isinstance(int(header['versionHex'], 16), int)
assert isinstance(header['difficulty'], Decimal) assert isinstance(header['difficulty'], Decimal)
# Test with verbose=False, which should return the header as hex.
header_hex = node.getblockheader(blockhash=besthash, verbose=False)
assert_is_hex_string(header_hex)
header = FromHex(CBlockHeader(), header_hex)
header.calc_sha256()
assert_equal(header.hash, besthash)
def _test_getdifficulty(self): def _test_getdifficulty(self):
difficulty = self.nodes[0].getdifficulty() difficulty = self.nodes[0].getdifficulty()
# 1 hash in 2 should be valid, so difficulty should be 1/2**31 # 1 hash in 2 should be valid, so difficulty should be 1/2**31