From 1904ed51d1a9b7a9a40edd70e666dcd823f41705 Mon Sep 17 00:00:00 2001 From: fanquake Date: Mon, 7 Dec 2020 10:02:45 +0800 Subject: [PATCH] Merge #20577: doc: libconsensus: add missing error code description, fix NBitcoin link cb0b7125c14bf97394bd8b43bf2abfb943bb1cf9 doc: libbitcoinconsensus: add missing error code description, fix NBitcoin link (Sebastian Falbesoner) Pull request description: This PR improves the libbitcoinconsensus description in `shared-libraries.md` in two ways: * adds the missing error code description for `bitcoinconsensus_ERR_INVALID_FLAGS` (introduced by commit 5ca8ef299a08aae91d5061750533694b58d810b2, PR #8976) * updates and fixes the link to the NBitcoin implementation (introduced by commit 3361edd01046aab137928d1e6e2468dbfc4b946e, PR #6430) * the owner of the `NBitcoin` github repository changed from `NicolasDorier` to `MetacoSA` (redirection still worked though) * instead of dynamically referring to a file in master with a fixed line number (which is obviously always quickly outdated), use a permalink with a file numbers area ACKs for top commit: MarcoFalke: cr ACK cb0b7125c14bf97394bd8b43bf2abfb943bb1cf9 harding: Code (documentation) review ACK cb0b7125c14bf97394bd8b43bf2abfb943bb1cf9. Text is clear and seems accurate, and the link checks out. Tree-SHA512: 9840458db6fb40e71c9852104aefcec5abbaf5054c6123701181dd477cea8c81d3647f376b67692159adf577c9b6305b05b784728bf9f14a753fab5898075a4e --- doc/shared-libraries.md | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/shared-libraries.md b/doc/shared-libraries.md index 0447e44623..0e8e40e9b6 100644 --- a/doc/shared-libraries.md +++ b/doc/shared-libraries.md @@ -39,3 +39,4 @@ The interface is defined in the C header `bitcoinconsensus.h` located in `src/s - `dashconsensus_ERR_TX_INDEX` - An invalid index for `txTo` - `dashconsensus_ERR_TX_SIZE_MISMATCH` - `txToLen` did not match with the size of `txTo` - `dashconsensus_ERR_DESERIALIZE` - An error deserializing `txTo` +- `dashconsensus_ERR_INVALID_FLAGS` - Script verification `flags` are invalid (i.e. not part of the libconsensus interface)